128182 2014-02-04 07:12:49 -0800 Remove SVG_DOM_OBJC_BINDINGS after r161638. 2014-02-04 09:45:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tgergely.u-szeged webkit-unassigned commit-queue dbates ddkilzer ossy oldest_to_newest 976334 0 tgergely.u-szeged 2014-02-04 07:12:49 -0800 ENABLE(SVG_DOM_OBJC_BINDINGS) was removed in r147878 (bug 114112), but r161638 added two occurrences (bug 126698). 976336 1 223112 tgergely.u-szeged 2014-02-04 07:23:51 -0800 Created attachment 223112 patch 976357 2 ossy 2014-02-04 08:05:40 -0800 LGTM, it seems like an upstream failure, but it would be better if the owners of bug126698 can confirm it. Daniel or David? 976380 3 223112 kling 2014-02-04 09:17:48 -0800 Comment on attachment 223112 patch Thanks! 976397 4 223112 commit-queue 2014-02-04 09:45:20 -0800 Comment on attachment 223112 patch Clearing flags on attachment: 223112 Committed r163383: <http://trac.webkit.org/changeset/163383> 976398 5 commit-queue 2014-02-04 09:45:22 -0800 All reviewed patches have been landed. Closing bug. 223112 2014-02-04 07:23:51 -0800 2014-02-04 09:45:20 -0800 patch code_cleanup_svg_dom_objc_bindings.patch text/plain 2236 tgergely.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhYzVlMDkxLi45NzQxOWVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTQtMDItMDQgIFRhbWFzIEdlcmdlbHkgIDx0Z2VyZ2VseS51LXN6ZWdlZEBwYXJ0bmVy LnNhbXN1bmcuY29tPgorCisgICAgICAgIFJlbW92ZSBTVkdfRE9NX09CSkNfQklORElOR1MgYWZ0 ZXIgcjE2MTYzOC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyODE4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlbW92ZWQgRU5BQkxFKFNWR19ET01fT0JKQ19CSU5ESU5HUykuCisKKyAgICAgICAgTm8g dGVzdHMgcmVxdWlyZWQuCisKKyAgICAgICAgKiBiaW5kaW5ncy9vYmpjL0RPTVVJS2l0RXh0ZW5z aW9ucy5tbToKKyAgICAgICAgKC1bRE9NTm9kZSBib3VuZGluZ0JveGVzXSk6CisgICAgICAgICgt W0RPTU5vZGUgYWJzb2x1dGVRdWFkc10pOgorCiAyMDE0LTAyLTA0ICBNaWhhaSBNYWVyZWFuICA8 bW1hZXJlYW5AYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1MgUmVnaW9uc10gRml4IEFzc2VydCBT SE9VTEQgTkVWRVIgQkUgUkVBQ0hFRCBpbiBSZW5kZXJMYXllcjo6ZW5jbG9zaW5nRWxlbWVudCgp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9vYmpjL0RPTVVJS2l0RXh0ZW5z aW9ucy5tbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL29iamMvRE9NVUlLaXRFeHRlbnNpb25z Lm1tCmluZGV4IGJmMzc1MmIuLjA3MTBlODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL29iamMvRE9NVUlLaXRFeHRlbnNpb25zLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL29iamMvRE9NVUlLaXRFeHRlbnNpb25zLm1tCkBAIC0xNTcsMTEgKzE1Nyw3IEBAIHVz aW5nIFdlYkNvcmU6OlZpc2libGVQb3NpdGlvbjsKICAgICAgICAgICAgIERPTUNTU1N0eWxlRGVj bGFyYXRpb24gKnN0eWxlID0gW2RvY3VtZW50IGdldENvbXB1dGVkU3R5bGU6KERPTUVsZW1lbnQg KilzZWxmIHBzZXVkb0VsZW1lbnQ6QCIiXTsKICAgICAgICAgICAgIGlmIChbW3N0eWxlIGdldFBy b3BlcnR5VmFsdWU6QCJkaXNwbGF5Il0gaXNFcXVhbFRvU3RyaW5nOkAiaW5saW5lIl0pCiAgICAg ICAgICAgICAgICAgcmVjdHMgPSBbc2VsZiBsaW5lQm94UmVjdHNdOwotICAgICAgICB9IGVsc2Ug aWYgKFtzZWxmIGlzS2luZE9mQ2xhc3M6W0RPTVRleHQgY2xhc3NdXQotI2lmIEVOQUJMRShTVkdf RE9NX09CSkNfQklORElOR1MpCi0gICAgICAgICAgICAgICAgICAgJiYgIVtbc2VsZiBwYXJlbnRO b2RlXSBpc0tpbmRPZkNsYXNzOk5TQ2xhc3NGcm9tU3RyaW5nKEAiRE9NU1ZHRWxlbWVudCIpXQot I2VuZGlmCi0gICAgICAgICAgICAgICAgICApCisgICAgICAgIH0gZWxzZSBpZiAoW3NlbGYgaXNL aW5kT2ZDbGFzczpbRE9NVGV4dCBjbGFzc11dKQogICAgICAgICAgICAgcmVjdHMgPSBbc2VsZiBs aW5lQm94UmVjdHNdOwogICAgIH0KIApAQCAtMTgxLDExICsxNzcsNyBAQCB1c2luZyBXZWJDb3Jl OjpWaXNpYmxlUG9zaXRpb247CiAgICAgICAgICAgICBET01DU1NTdHlsZURlY2xhcmF0aW9uICpz dHlsZSA9IFtkb2N1bWVudCBnZXRDb21wdXRlZFN0eWxlOihET01FbGVtZW50ICopc2VsZiBwc2V1 ZG9FbGVtZW50OkAiIl07CiAgICAgICAgICAgICBpZiAoW1tzdHlsZSBnZXRQcm9wZXJ0eVZhbHVl OkAiZGlzcGxheSJdIGlzRXF1YWxUb1N0cmluZzpAImlubGluZSJdKQogICAgICAgICAgICAgICAg IHF1YWRzID0gW3NlbGYgbGluZUJveFF1YWRzXTsKLSAgICAgICAgfSBlbHNlIGlmIChbc2VsZiBp c0tpbmRPZkNsYXNzOltET01UZXh0IGNsYXNzXV0KLSNpZiBFTkFCTEUoU1ZHX0RPTV9PQkpDX0JJ TkRJTkdTKQotICAgICAgICAgICAgICAgICAgICYmICFbW3NlbGYgcGFyZW50Tm9kZV0gaXNLaW5k T2ZDbGFzczpOU0NsYXNzRnJvbVN0cmluZyhAIkRPTVNWR0VsZW1lbnQiKV0KLSNlbmRpZgotICAg ICAgICAgICAgICAgICAgICkKKyAgICAgICAgfSBlbHNlIGlmIChbc2VsZiBpc0tpbmRPZkNsYXNz OltET01UZXh0IGNsYXNzXV0pCiAgICAgICAgICAgICBxdWFkcyA9IFtzZWxmIGxpbmVCb3hRdWFk c107CiAgICAgfQogCg==