128170 2014-02-04 02:42:33 -0800 [GTK] Add $(feature_defines) when generating InjectedBundle code from IDLs 2014-02-04 06:45:48 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98931 1 carlosg webkit-unassigned cgarcia commit-queue zan oldest_to_newest 976258 0 carlosg 2014-02-04 02:42:33 -0800 Patch in bug #98931 relies on the ENABLE_TOUCH_EVENTS define being available at the time of generating the code from the EventSenderProxy IDL, but the --defines switch is empty, so those functions are invariably opted out. I'm attaching a patch that adds $(feature_defines) so config defines are available when generating the code. 976260 1 223090 carlosg 2014-02-04 02:50:47 -0800 Created attachment 223090 patch, adds $(feature_defines) 976308 2 223090 cgarcia 2014-02-04 06:17:03 -0800 Comment on attachment 223090 patch, adds $(feature_defines) Good catch! thanks 976309 3 223090 cgarcia 2014-02-04 06:21:59 -0800 Comment on attachment 223090 patch, adds $(feature_defines) hope it's not too late this might be causing issues when generating the api docs 976310 4 cgarcia 2014-02-04 06:22:26 -0800 See http://webkit-queues.appspot.com/results/4927924343930880 976311 5 cgarcia 2014-02-04 06:24:06 -0800 (In reply to comment #4) > See http://webkit-queues.appspot.com/results/4927924343930880 hmm, wait, this is probably the other patch that depends on this one 976312 6 cgarcia 2014-02-04 06:25:51 -0800 This one seems to be failing as well https://webkit-queues.appspot.com/results/5611648777715712 976316 7 223090 cgarcia 2014-02-04 06:42:44 -0800 Comment on attachment 223090 patch, adds $(feature_defines) I think EWS mixed both patches or something, let's try to land this, it shouldn't affect the GObject DOM bindings 976318 8 223090 commit-queue 2014-02-04 06:45:46 -0800 Comment on attachment 223090 patch, adds $(feature_defines) Clearing flags on attachment: 223090 Committed r163375: <http://trac.webkit.org/changeset/163375> 976319 9 commit-queue 2014-02-04 06:45:48 -0800 All reviewed patches have been landed. Closing bug. 223090 2014-02-04 02:50:47 -0800 2014-02-04 06:45:46 -0800 patch, adds $(feature_defines) patch-feature-defines.diff text/plain 1416 carlosg ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzZDRj MjE5Li4wNzMwODQxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMDEtMzAgIENhcmxvcyBHYXJuYWNobyAgPGNh cmxvc2dAZ25vbWUub3JnPgorCisgICAgICAgIFtBdXRvbWFrZV0gQWRkIG1pc3NpbmcgJChmZWF0 dXJlX2RlZmluZXMpIHdoZW4gZ2VuZXJhdGluZyBJbmplY3RlZEJ1bmRsZSBiaW5kaW5ncworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MTcwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0 UnVubmVyL0dOVW1ha2VmaWxlLmFtOiBBZGQgbWlzc2luZyAkKGZlYXR1cmVfZGVmaW5lcykgd2hl bgorICAgICAgICBnZW5lcmF0aW5nIHRoZSBJbmplY3RlZEJ1bmRsZSBiaW5kaW5ncy4gU28gdGhl IHZhcmlvdXMgRU5BQkxFXyogZGVmaW5lcworICAgICAgICBhcmUgYXZhaWxhYmxlIHRoZXJlLgor CiAyMDE0LTAyLTAzICBLcnp5c3p0b2YgQ3plY2ggIDxrLmN6ZWNoQHNhbXN1bmcuY29tPgogCiAg ICAgICAgIFtBVEtdIEV4cG9zZSBhcmlhLWNvbnRyb2xzIHRocm91Z2ggQVRLX1JFTEFUSU9OX0NP TlRST0xMRVJfRk9SCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0dOVW1ha2Vm aWxlLmFtIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9HTlVtYWtlZmlsZS5hbQppbmRleCAwZTE3 ODM1Li4yOGEyZDU3IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0dOVW1ha2Vm aWxlLmFtCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvR05VbWFrZWZpbGUuYW0KQEAgLTE2 MSw3ICsxNjEsNyBAQCBEZXJpdmVkU291cmNlcy9JbmplY3RlZEJ1bmRsZS9KUyUuY3BwOiBUb29s cy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0JpbgogCQktSSAkKHNyY2RpcikvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cyBcCiAJCS1JICQoc3JjZGlyKS9Ub29scy9XZWJL aXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0JpbmRpbmdzIFwKIAkJJChzcmNkaXIpL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvZ2VuZXJhdGUtYmluZGluZ3MucGwgXAotCQktLWRl ZmluZXMgXCJcIiAtLWdlbmVyYXRvciBUZXN0UnVubmVyIFwKKwkJLS1kZWZpbmVzICIkKGZlYXR1 cmVfZGVmaW5lcykiIC0tZ2VuZXJhdG9yIFRlc3RSdW5uZXIgXAogCQktLWluY2x1ZGUgJChzcmNk aXIpL1Rvb2xzL0luamVjdGVkQnVuZGxlL0JpbmRpbmdzIFwKIAkJLS1vdXRwdXREaXIgJCh0b3Bf YnVpbGRkaXIpL0Rlcml2ZWRTb3VyY2VzL0luamVjdGVkQnVuZGxlIFwKIAkJJDwK