<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>128168</bug_id>
          
          <creation_ts>2014-02-04 01:59:41 -0800</creation_ts>
          <short_desc>Fine tuning the ARM EFL bots</short_desc>
          <delta_ts>2014-02-05 10:00:53 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Gabor Rapcsanyi">rgabor</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>lforschler</cc>
    
    <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>976249</commentid>
    <comment_count>0</comment_count>
    <who name="Gabor Rapcsanyi">rgabor</who>
    <bug_when>2014-02-04 01:59:41 -0800</bug_when>
    <thetext>Fine tuning the ARM EFL bots</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>976259</commentid>
    <comment_count>1</comment_count>
      <attachid>223089</attachid>
    <who name="Gabor Rapcsanyi">rgabor</who>
    <bug_when>2014-02-04 02:47:46 -0800</bug_when>
    <thetext>Created attachment 223089
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>976271</commentid>
    <comment_count>2</comment_count>
      <attachid>223089</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-02-04 03:47:13 -0800</bug_when>
    <thetext>Comment on attachment 223089
proposed patch

r=me. 

Lucas, could you possibly restart the master after the landing?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>976272</commentid>
    <comment_count>3</comment_count>
      <attachid>223089</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-02-04 03:49:29 -0800</bug_when>
    <thetext>Comment on attachment 223089
proposed patch

Clearing flags on attachment: 223089

Committed r163372: &lt;http://trac.webkit.org/changeset/163372&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>976273</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-02-04 03:49:31 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>976393</commentid>
    <comment_count>5</comment_count>
    <who name="Lucas Forschler">lforschler</who>
    <bug_when>2014-02-04 09:37:06 -0800</bug_when>
    <thetext>master restarted.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>976476</commentid>
    <comment_count>6</comment_count>
      <attachid>223089</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-02-04 12:49:51 -0800</bug_when>
    <thetext>Comment on attachment 223089
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223089&amp;action=review

&gt; Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:139
&gt; +    def evaluateCommand(self, cmd):
&gt; +        if cmd.rc != 0:
&gt; +            return WARNINGS

I think I got what caused the exception. You 
should return with SUCCESS after it, similar 
to other evaluateCommands in master.cfg</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>976709</commentid>
    <comment_count>7</comment_count>
    <who name="Gabor Rapcsanyi">rgabor</who>
    <bug_when>2014-02-05 04:30:27 -0800</bug_when>
    <thetext>(In reply to comment #6)
&gt; (From update of attachment 223089 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=223089&amp;action=review
&gt; 
&gt; &gt; Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:139
&gt; &gt; +    def evaluateCommand(self, cmd):
&gt; &gt; +        if cmd.rc != 0:
&gt; &gt; +            return WARNINGS
&gt; 
&gt; I think I got what caused the exception. You 
&gt; should return with SUCCESS after it, similar 
&gt; to other evaluateCommands in master.cfg

Yes sure, the fix landed at:
https://trac.webkit.org/r163441</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>976785</commentid>
    <comment_count>8</comment_count>
    <who name="Lucas Forschler">lforschler</who>
    <bug_when>2014-02-05 10:00:53 -0800</bug_when>
    <thetext>I&apos;ve restarted the webkit build master for you.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>223089</attachid>
            <date>2014-02-04 02:47:46 -0800</date>
            <delta_ts>2014-02-04 12:49:51 -0800</delta_ts>
            <desc>proposed patch</desc>
            <filename>master.patch</filename>
            <type>text/plain</type>
            <size>3439</size>
            <attacher name="Gabor Rapcsanyi">rgabor</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDE2MzM2OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE3IEBACisyMDE0LTAyLTA0ICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9y
Zz4KKworICAgICAgICBGaW5lIHR1bmluZyB0aGUgQVJNIEVGTCBib3RzCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgxNjgKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1
aWxkLndlYmtpdC5vcmctY29uZmlnL2NvbmZpZy5qc29uOiBBZGQgY3VzdG9tIFNWTiBtaXJyb3Iu
CisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz
dGVyLmNmZzoKKyAgICAgICAgKFdhaXRGb3JTVk5TZXJ2ZXIpOiBNYWtlIGl0IG5vdCB0byBoYWx0
IGJlZm9yZSB0aGUgZmlyc3QgcmVwb3NpdG9yeSBjaGVja291dC4KKyAgICAgICAgKFdhaXRGb3JT
Vk5TZXJ2ZXIuZXZhbHVhdGVDb21tYW5kKToKKyAgICAgICAgKEZhY3RvcnkuX19pbml0X18pOiBE
aXNhYmxlIGtpbGwtb2xkLXByb2Nlc3NlcyBzdGVwIG9uIEVGTCBBUk0gYm90cywgYmVjYXVzZSB0
aGVzZQorICAgICAgICBib3RzIHJ1biBvbiB0aGUgc2FtZSBtYWNoaW5lIGFuZCB0aGV5IGtpbGwg
dGhlIHByb2Nlc3NlcyBvZiBlYWNoIG90aGVyLgorCiAyMDE0LTAyLTAzICBSeW9zdWtlIE5pd2Eg
IDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIGtpbGwtb2xkLXByb2Nlc3NlcyBkb2Vzbid0
IGtpbGwgcGx1Z2luIHByb2Nlc3NlcwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVp
bGQud2Via2l0Lm9yZy1jb25maWcvY29uZmlnLmpzb24KPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVp
bGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvY29uZmlnLmpzb24JKHJldmlz
aW9uIDE2MzM2NykKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmct
Y29uZmlnL2NvbmZpZy5qc29uCSh3b3JraW5nIGNvcHkpCkBAIC0xODksMTEgKzE4OSwxMyBAQAog
ICAgICAgICAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgICAgICAgIm5hbWUiOiAiRUZM
IExpbnV4IEFSTXY3IFRodW1iMiBSZWxlYXNlIChCdWlsZCkiLCAidHlwZSI6ICJCdWlsZCIsICJi
dWlsZGRpciI6ICJlZmwtbGludXgtYXJtdjctdGh1bWIyLXJlbGVhc2UiLAogICAgICAgICAgICAg
ICAgICAgICAgICJwbGF0Zm9ybSI6ICJlZmwiLCAiY29uZmlndXJhdGlvbiI6ICJyZWxlYXNlIiwg
ImFyY2hpdGVjdHVyZXMiOiBbImFybXY3Il0sCisgICAgICAgICAgICAgICAgICAgICAgIlNWTk1p
cnJvciI6ICJzdm46Ly93ZWJraXQuaW5mLnUtc3plZ2VkLmh1L3dlYmtpdC8iLAogICAgICAgICAg
ICAgICAgICAgICAgICJzbGF2ZW5hbWVzIjogWyJlZmwtbGludXgtc3plZ2VkLXNsYXZlLTEiXQog
ICAgICAgICAgICAgICAgICAgICB9LAogICAgICAgICAgICAgICAgICAgICB7CiAgICAgICAgICAg
ICAgICAgICAgICAgIm5hbWUiOiAiRUZMIExpbnV4IEFSTXY3IFRyYWRpdGlvbmFsIFJlbGVhc2Ug
KEJ1aWxkKSIsICJ0eXBlIjogIkJ1aWxkIiwgImJ1aWxkZGlyIjogImVmbC1saW51eC1hcm12Ny10
cmFkaXRpb25hbC1yZWxlYXNlIiwKICAgICAgICAgICAgICAgICAgICAgICAicGxhdGZvcm0iOiAi
ZWZsIiwgImNvbmZpZ3VyYXRpb24iOiAicmVsZWFzZSIsICJhcmNoaXRlY3R1cmVzIjogWyJhcm12
NyJdLAorICAgICAgICAgICAgICAgICAgICAgICJTVk5NaXJyb3IiOiAic3ZuOi8vd2Via2l0Lmlu
Zi51LXN6ZWdlZC5odS93ZWJraXQvIiwKICAgICAgICAgICAgICAgICAgICAgICAic2xhdmVuYW1l
cyI6IFsiZWZsLWxpbnV4LXN6ZWdlZC1zbGF2ZS0yIl0KICAgICAgICAgICAgICAgICAgICAgfQog
ICAgICAgICAgICAgICAgICAgXSwKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxk
LndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRT
bGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZwkocmV2aXNpb24g
MTYzMzY3KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m
aWcvbWFzdGVyLmNmZwkod29ya2luZyBjb3B5KQpAQCAtMTMyLDcgKzEzMiwxMSBAQCBjbGFzcyBX
YWl0Rm9yU1ZOU2VydmVyKHNoZWxsLlNoZWxsQ29tbWFuCiAgICAgY29tbWFuZCA9IFsicHl0aG9u
IiwgIi4vVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvd2FpdC1mb3ItU1ZOLXNlcnZlci5weSIsICIt
ciIsIFdpdGhQcm9wZXJ0aWVzKCIlKHJldmlzaW9uKXMiKSwgIi1zIiwgV2l0aFByb3BlcnRpZXMo
IiUoU1ZOTWlycm9yKXMiKV0KICAgICBkZXNjcmlwdGlvbiA9IFsid2FpdGluZyBmb3IgU1ZOIHNl
cnZlciJdCiAgICAgZGVzY3JpcHRpb25Eb25lID0gWyJTVk4gc2VydmVyIGlzIHJlYWR5Il0KLSAg
ICBoYWx0T25GYWlsdXJlID0gVHJ1ZQorICAgIHdhcm5PbkZhaWx1cmUgPSBUcnVlCisKKyAgICBk
ZWYgZXZhbHVhdGVDb21tYW5kKHNlbGYsIGNtZCk6CisgICAgICAgIGlmIGNtZC5yYyAhPSAwOgor
ICAgICAgICAgICAgcmV0dXJuIFdBUk5JTkdTCiAKIGNsYXNzIEluc3RhbGxXaW4zMkRlcGVuZGVu
Y2llcyhzaGVsbC5Db21waWxlKToKICAgICBkZXNjcmlwdGlvbiA9IFsiaW5zdGFsbGluZyBkZXBl
bmRlbmNpZXMiXQpAQCAtNzM5LDcgKzc0Myw4IEBAIGNsYXNzIEZhY3RvcnkoZmFjdG9yeS5CdWls
ZEZhY3RvcnkpOgogICAgICAgICBpZiBTVk5NaXJyb3I6CiAgICAgICAgICAgICBzZWxmLmFkZFN0
ZXAoV2FpdEZvclNWTlNlcnZlcigpKQogICAgICAgICBzZWxmLmFkZFN0ZXAoQ2hlY2tPdXRTb3Vy
Y2UoU1ZOTWlycm9yPVNWTk1pcnJvcikpCi0gICAgICAgIHNlbGYuYWRkU3RlcChLaWxsT2xkUHJv
Y2Vzc2VzKCkpCisgICAgICAgIGlmIG5vdCAocGxhdGZvcm0gPT0gImVmbCIgYW5kICdhcm12Nycg
aW4gYXJjaGl0ZWN0dXJlcyk6CisgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoS2lsbE9sZFByb2Nl
c3NlcygpKQogICAgICAgICBzZWxmLmFkZFN0ZXAoQ2xlYW5CdWlsZElmU2NoZWR1bGVkKCkpCiAg
ICAgICAgIHNlbGYuYWRkU3RlcChEZWxldGVTdGFsZUJ1aWxkRmlsZXMoKSkKICAgICAgICAgaWYg
cGxhdGZvcm0gPT0gIndpbiI6Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>