128163 2014-02-03 23:08:22 -0800 [GTK] [Stable] Build unittests only when requested 2017-03-11 11:05:57 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 pachoramos1 webkit-unassigned berto bugs-noreply cgarcia gnome gustavo zan oldest_to_newest 976217 0 223074 pachoramos1 2014-02-03 23:08:22 -0800 Created attachment 223074 webkit-gtk-2.2.4-unittests-build.patch We are applying this patch on Gentoo to build unittests only when going to run tests Thanks for applying it 976718 1 berto 2014-02-05 05:41:13 -0800 Hey, thanks for the patch. The problem is that we're switching to cmake soon so this will be obsolete in a few weeks. We run the tests all the time and changing the workflow of the developers (even if it's such a small change) shortly before the switch is probably not a good idea. This would also need changes in the build-webkit script else the build bots will probably break. 976720 2 cgarcia 2014-02-05 05:49:43 -0800 We are not going to switch to cmake in the stable branches. 977056 3 pachoramos1 2014-02-05 13:19:02 -0800 Maybe would be interesting to apply it to 2.2.x branch only then (if there will be more releases) 977287 4 berto 2014-02-06 01:25:34 -0800 I wouldn't change that at this point for the reasons I already said, but I don't have strong arguments against fixing it in the stable branches either. 979362 5 gustavo 2014-02-11 03:42:49 -0800 Not opposed, but this is only useful for the 2.2.x stable branch right? In 2.4 we have developer mode. 223074 2014-02-03 23:08:22 -0800 2014-02-03 23:08:22 -0800 webkit-gtk-2.2.4-unittests-build.patch webkit-gtk-2.2.4-unittests-build.patch text/plain 2866 pachoramos1 RnJvbTogR2lsbGVzIERhcnRpZ3VlbG9uZ3VlIDxldmFAZ2VudG9vLm9yZz4KRGF0ZTogV2VkLCAw MyBGZWIgMjAxNCAyMzo0NzozOSArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEJ1aWxkIHVuaXR0ZXN0 cyBvbiBkZW1hbmQKCi0tLSBhL0dOVW1ha2VmaWxlLmFtCTIwMTMtMTEtMjcgMjM6NTI6NTYuMTQ4 NzM1NDMzICswMTAwCisrKyBiL0dOVW1ha2VmaWxlLmFtCTIwMTMtMTEtMjcgMjM6NTE6MjUuNTUx NTkwODA2ICswMTAwCkBAIC01MSw2ICs1MSw5IEBACiAjIExpYnJhcmllcyBhbmQgc3VwcG9ydCBj b21wb25lbnRzCiBiaW5fUFJPR1JBTVMgOj0KIG5vaW5zdF9QUk9HUkFNUyA6PQorY2hlY2tfUFJP R1JBTVMgOj0KK2NoZWNrX0xUTElCUkFSSUVTIDo9CitjaGVja19EQVRBIDo9CiBsaWJleGVjX1BS T0dSQU1TIDo9CiBub2luc3RfREFUQSA6PQogbm9pbnN0X0hFQURFUlMgOj0KLS0tIGEvVG9vbHMv VGVzdFdlYktpdEFQSS9HTlVtYWtlZmlsZS5hbQkyMDE0LTAyLTAzIDIzOjQ0OjUyLjUzNDI3MjU3 MiArMDEwMAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL0dOVW1ha2VmaWxlLmFtCTIwMTQtMDIt MDMgMjM6NDU6NDEuNzExNzgzMjk5ICswMTAwCkBAIC0xLDggKzEsOCBAQAotbm9pbnN0X0xUTElC UkFSSUVTICs9IFwKK2NoZWNrX0xUTElCUkFSSUVTICs9IFwKIAlMaWJyYXJpZXMvbGliVGVzdFdl YktpdEFQSU1haW4ubGEKIAogaWYgRU5BQkxFX1dFQktJVDIKLW5vaW5zdF9MVExJQlJBUklFUyAr PSBcCitjaGVja19MVExJQlJBUklFUyArPSBcCiAJTGlicmFyaWVzL2xpYlRlc3RXZWJLaXQyR3Rr QVBJLmxhCiBlbmRpZgogCkBAIC0xMTEsMTQgKzExMSwxNCBAQAogTGlicmFyaWVzX2xpYlRlc3RX ZWJLaXQyR3RrQVBJX2xhX0NQUEZMQUdTID0gJCh3ZWJraXQyZ3RrX3Rlc3RzX2NwcGZsYWdzKQog CiAKLW5vaW5zdF9QUk9HUkFNUyArPSBcCitjaGVja19QUk9HUkFNUyArPSBcCiAJUHJvZ3JhbXMv VGVzdFdlYktpdEFQSS9XVEYvVGVzdFdURiBcCiAJUHJvZ3JhbXMvVGVzdFdlYktpdEFQSS9KYXZh U2NyaXB0Q29yZS9UZXN0SmF2YVNjcmlwdENvcmUgXAogCVByb2dyYW1zL1Rlc3RXZWJLaXRBUEkv V2ViQ29yZS9UZXN0V2ViQ29yZSBcCiAJUHJvZ3JhbXMvVGVzdFdlYktpdEFQSS9XZWJDb3JlR3Rr L1Rlc3RXZWJDb3JlR3RrCiAKIGlmIEVOQUJMRV9XRUJLSVQxCi1ub2luc3RfUFJPR1JBTVMgKz0g XAorY2hlY2tfUFJPR1JBTVMgKz0gXAogCVByb2dyYW1zL1Rlc3RXZWJLaXRBUEkvV2ViS2l0R3Rr L3Rlc3RhcHBsaWNhdGlvbmNhY2hlIFwKIAlQcm9ncmFtcy9UZXN0V2ViS2l0QVBJL1dlYktpdEd0 ay90ZXN0Y29udGV4dG1lbnUgXAogCVByb2dyYW1zL1Rlc3RXZWJLaXRBUEkvV2ViS2l0R3RrL3Rl c3Rkb21kb2N1bWVudCBcCkBAIC0xNTAsNyArMTUwLDcgQEAKIGVuZGlmCiAKIGlmIEVOQUJMRV9X RUJLSVQyCi1ub2luc3RfUFJPR1JBTVMgKz0gXAorY2hlY2tfUFJPR1JBTVMgKz0gXAogCVByb2dy YW1zL1Rlc3RXZWJLaXRBUEkvV2ViS2l0Mi9UZXN0V2ViS2l0MiBcCiAJUHJvZ3JhbXMvVGVzdFdl YktpdEFQSS9XZWJLaXQyR3RrL0luc3BlY3RvclRlc3RTZXJ2ZXIgXAogCVByb2dyYW1zL1Rlc3RX ZWJLaXRBUEkvV2ViS2l0Mkd0ay9UZXN0QXV0aGVudGljYXRpb24gXApAQCAtMTc5LDcgKzE3OSw3 IEBACiAJUHJvZ3JhbXMvVGVzdFdlYktpdEFQSS9XZWJLaXQyR3RrL1Rlc3RXZWJWaWV3RWRpdG9y CiAKIGlmIEhBVkVfQVRTUEkyCi1ub2luc3RfUFJPR1JBTVMgKz0gXAorY2hlY2tfUFJPR1JBTVMg Kz0gXAogCVByb2dyYW1zL1Rlc3RXZWJLaXRBUEkvV2ViS2l0Mkd0ay9BY2Nlc3NpYmlsaXR5VGVz dFNlcnZlciBcCiAJUHJvZ3JhbXMvVGVzdFdlYktpdEFQSS9XZWJLaXQyR3RrL1Rlc3RXZWJLaXRB Y2Nlc3NpYmlsaXR5CiBlbmRpZgpAQCAtNjI3LDcgKzYyNyw3IEBACiAJVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXQyL1dLVVJMLmNwcAogCiBpZiBFTkFCTEVfV0VCS0lUMgotbm9pbnN0 X0xUTElCUkFSSUVTICs9IFwKK2NoZWNrX0xUTElCUkFSSUVTICs9IFwKIAlMaWJyYXJpZXMvbGli VGVzdFdlYktpdEFQSUluamVjdGVkQnVuZGxlLmxhCiBlbmRpZiAjIEVOQUJMRV9XRUJLSVQyCiAK QEAgLTY4NCw3ICs2ODQsNyBAQAogCiAKIGlmIEVOQUJMRV9XRUJLSVQyCi1ub2luc3RfTFRMSUJS QVJJRVMgKz0gTGlicmFyaWVzL1dlYkV4dGVuc2lvbnMvbGliV2ViRXh0ZW5zaW9uVGVzdC5sYQor Y2hlY2tfTFRMSUJSQVJJRVMgKz0gTGlicmFyaWVzL1dlYkV4dGVuc2lvbnMvbGliV2ViRXh0ZW5z aW9uVGVzdC5sYQogZW5kaWYKIAogTGlicmFyaWVzX1dlYkV4dGVuc2lvbnNfbGliV2ViRXh0ZW5z aW9uVGVzdF9sYV9TT1VSQ0VTID0gXApAQCAtNzExLDcgKzcxMSw3IEBACiAKIAogaWYgRU5BQkxF X1dFQktJVDIKLW5vaW5zdF9MVExJQlJBUklFUyArPSBMaWJyYXJpZXMvV2ViRXh0ZW5zaW9ucy9s aWJXZWJQcm9jZXNzVGVzdC5sYQorY2hlY2tfTFRMSUJSQVJJRVMgKz0gTGlicmFyaWVzL1dlYkV4 dGVuc2lvbnMvbGliV2ViUHJvY2Vzc1Rlc3QubGEKIGVuZGlmCiAKIExpYnJhcmllc19XZWJFeHRl bnNpb25zX2xpYldlYlByb2Nlc3NUZXN0X2xhX1NPVVJDRVMgPSBcCkBAIC03NDcsNyArNzQ3LDcg QEAKIERJU1RDTEVBTkZJTEVTICs9IFwKIAlQcm9ncmFtcy9UZXN0V2ViS2l0QVBJL1dlYktpdDJH dGsvcmVzb3VyY2VzL3dlYmtpdDJndGstdGVzdHMtcmVzb3VyY2VzLmdyZXNvdXJjZQogCi1ub2lu c3RfREFUQSArPSBcCitjaGVja19EQVRBICs9IFwKIAlQcm9ncmFtcy9UZXN0V2ViS2l0QVBJL1dl YktpdDJHdGsvcmVzb3VyY2VzL3dlYmtpdDJndGstdGVzdHMtcmVzb3VyY2VzLmdyZXNvdXJjZQog CiAKLS0gCjEuOC4zLjIKCg==