128157 2014-02-03 21:06:02 -0800 IDB: HTML5 Rocks Indexed Database demo fails 2014-02-13 04:13:12 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All Unspecified ASSIGNED InRadar P2 Normal --- 1 beidson beidson jonlee oldest_to_newest 976191 0 beidson 2014-02-03 21:06:02 -0800 IDB: HTML5 Rocks Indexed Database demo fails The demo can be found here - http://www.html5rocks.com/en/tutorials/indexeddb/todo/ TODOs that you save are stored to the database, but they are never retrieved. This is because the value cursor they create never returns any values. And that is because we're choosing the wrong SQL statement for the cursor. In radar as <rdar://problem/15966095> 976192 1 223068 beidson 2014-02-03 21:08:39 -0800 Created attachment 223068 Patch v1 976193 2 beidson 2014-02-03 21:08:58 -0800 Of the large number of layout test failures, this fixes a handful! \o/ 976197 3 223068 jonlee 2014-02-03 21:27:09 -0800 Comment on attachment 223068 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=223068&action=review > Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:112 > + This is all fine except the statements are not in consistent order. Line 77-78 is open upper key, not closed upper key like in 85-86 and 92-93. > Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:164 > + This looks good here. It might be slightly better to name the variables "hasLowerKey", "isLowerOpen", "hasUpperKey", "isUpperOpen", even though the current var names are more consistent with the IDB API. 976198 4 jonlee 2014-02-03 21:27:45 -0800 provisional r-! 976201 5 223071 beidson 2014-02-03 21:32:32 -0800 Created attachment 223071 Patch v2 976202 6 beidson 2014-02-03 21:33:09 -0800 Nice find, and good suggestion. New patch uploaded. 976203 7 223071 jonlee 2014-02-03 21:34:03 -0800 Comment on attachment 223071 Patch v2 Provisional r=me! 976204 8 beidson 2014-02-03 21:34:33 -0800 Thanks for the eyes! 976205 9 beidson 2014-02-03 21:39:44 -0800 http://trac.webkit.org/changeset/163364 and http://trac.webkit.org/changeset/163365 as a build fix followup 980251 10 223068 ossy 2014-02-13 04:13:12 -0800 Comment on attachment 223068 Patch v1 Cleared Anders Carlsson's review+ from obsolete attachment 223068 so that this bug does not appear in http://webkit.org/pending-commit. 223068 2014-02-03 21:08:39 -0800 2014-02-13 04:13:12 -0800 Patch v1 patch text/plain 1970 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4MjE0OGNhLi5mNzlhMmFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTQtMDItMDMgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIElEQjogSFRNTDUgUm9ja3MgSW5kZXhlZCBEYXRhYmFzZSBkZW1vIGZhaWxzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgxNTcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIERhdGFiYXNlUHJvY2Vz cy9JbmRleGVkREIvc3FsaXRlL1NRTGl0ZUlEQkN1cnNvci5jcHA6CisgICAgICAgIChXZWJLaXQ6 OmdldEluZGV4U3RhdGVtZW50KTogT25seSBpbmNyZW1lbnQgdGhlIG9wZW4vY2xvc2VkIGNvdW50 ZXJzIGlmIHRob3NlIGtleXMgZXhpc3QuCisgICAgICAgIChXZWJLaXQ6OmdldE9iamVjdFN0b3Jl U3RhdGVtZW50KTogRGl0dG8uCisKIDIwMTQtMDItMDIgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25A YXBwbGUuY29tPgogCiAgICAgICAgIElEQjogQ2Fubm90IG9wZW4gbmV3IGRhdGFiYXNlcyB3aXRo IHRoZSBkZWZhdWx0IHZlcnNpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0RhdGFiYXNl UHJvY2Vzcy9JbmRleGVkREIvc3FsaXRlL1NRTGl0ZUlEQkN1cnNvci5jcHAgYi9Tb3VyY2UvV2Vi S2l0Mi9EYXRhYmFzZVByb2Nlc3MvSW5kZXhlZERCL3NxbGl0ZS9TUUxpdGVJREJDdXJzb3IuY3Bw CmluZGV4IDdlODlhNWUuLmU5MDZmNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0RhdGFi YXNlUHJvY2Vzcy9JbmRleGVkREIvc3FsaXRlL1NRTGl0ZUlEQkN1cnNvci5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvRGF0YWJhc2VQcm9jZXNzL0luZGV4ZWREQi9zcWxpdGUvU1FMaXRlSURCQ3Vy c29yLmNwcApAQCAtOTcsMTQgKzk3LDE5IEBAIHN0YXRpYyBjb25zdCBTdHJpbmcmIGdldEluZGV4 U3RhdGVtZW50KGJvb2wgbG93ZXJLZXksIGJvb2wgbG93ZXJPcGVuLCBib29sIHVwcGVyCiAgICAg fQogCiAgICAgc2l6ZV90IGkgPSAwOwotICAgIGlmIChsb3dlcktleSkKLSAgICAgICAgaSArPSA2 OwotICAgIGlmIChsb3dlck9wZW4pCisKKyAgICBpZiAobG93ZXJLZXkpIHsKICAgICAgICAgaSAr PSA2OwotICAgIGlmICh1cHBlcktleSkKLSAgICAgICAgaSArPSAyOwotICAgIGlmICh1cHBlck9w ZW4pCisgICAgICAgIGlmIChsb3dlck9wZW4pCisgICAgICAgICAgICBpICs9IDY7CisgICAgfQor CisgICAgaWYgKHVwcGVyS2V5KSB7CiAgICAgICAgIGkgKz0gMjsKKyAgICAgICAgaWYgKHVwcGVy T3BlbikKKyAgICAgICAgICAgIGkgKz0gMjsKKyAgICB9CisKICAgICBpZiAoZGVzY2VuZGluZykK ICAgICAgICAgaSArPSAxOwogCkBAIC0xNDQsMTQgKzE0OSwxOSBAQCBzdGF0aWMgY29uc3QgU3Ry aW5nJiBnZXRPYmplY3RTdG9yZVN0YXRlbWVudChib29sIGxvd2VyS2V5LCBib29sIGxvd2VyT3Bl biwgYm9vbAogICAgIH0KIAogICAgIHNpemVfdCBpID0gMDsKLSAgICBpZiAobG93ZXJLZXkpCi0g ICAgICAgIGkgKz0gNjsKLSAgICBpZiAobG93ZXJPcGVuKQorCisgICAgaWYgKGxvd2VyS2V5KSB7 CiAgICAgICAgIGkgKz0gNjsKLSAgICBpZiAodXBwZXJLZXkpCi0gICAgICAgIGkgKz0gMjsKLSAg ICBpZiAodXBwZXJPcGVuKQorICAgICAgICBpZiAobG93ZXJPcGVuKQorICAgICAgICAgICAgaSAr PSA2OworICAgIH0KKworICAgIGlmICh1cHBlcktleSkgewogICAgICAgICBpICs9IDI7CisgICAg ICAgIGlmICh1cHBlck9wZW4pCisgICAgICAgICAgICBpICs9IDI7CisgICAgfQorCiAgICAgaWYg KGRlc2NlbmRpbmcpCiAgICAgICAgIGkgKz0gMTsKIAo= 223071 2014-02-03 21:32:32 -0800 2014-02-03 21:34:18 -0800 Patch v2 patch text/plain 4001 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4MjE0OGNhLi45YWU5OTM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTQtMDItMDMgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIElEQjogSFRNTDUgUm9ja3MgSW5kZXhlZCBEYXRhYmFzZSBkZW1vIGZhaWxzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgxNTcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIERhdGFiYXNlUHJvY2Vz cy9JbmRleGVkREIvc3FsaXRlL1NRTGl0ZUlEQkN1cnNvci5jcHA6CisgICAgICAgIChXZWJLaXQ6 OmdldEluZGV4U3RhdGVtZW50KTogT25seSBpbmNyZW1lbnQgdGhlIG9wZW4vY2xvc2VkIGNvdW50 ZXJzIGlmIHRob3NlIGtleXMgZXhpc3QuCisgICAgICAgICAgRml4IG9yZGVyIG9mIHN0YXRlbWVu dHMgZm9yIG5vIGxvd2VyIGtleS4KKyAgICAgICAgKFdlYktpdDo6Z2V0T2JqZWN0U3RvcmVTdGF0 ZW1lbnQpOiBPbmx5IGluY3JlbWVudCB0aGUgb3Blbi9jbG9zZWQgY291bnRlcnMgaWYgdGhvc2Ug a2V5cyBleGlzdC4KKwogMjAxNC0wMi0wMiAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5j b20+CiAKICAgICAgICAgSURCOiBDYW5ub3Qgb3BlbiBuZXcgZGF0YWJhc2VzIHdpdGggdGhlIGRl ZmF1bHQgdmVyc2lvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvRGF0YWJhc2VQcm9jZXNz L0luZGV4ZWREQi9zcWxpdGUvU1FMaXRlSURCQ3Vyc29yLmNwcCBiL1NvdXJjZS9XZWJLaXQyL0Rh dGFiYXNlUHJvY2Vzcy9JbmRleGVkREIvc3FsaXRlL1NRTGl0ZUlEQkN1cnNvci5jcHAKaW5kZXgg N2U4OWE1ZS4uZGNmNTM5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvRGF0YWJhc2VQcm9j ZXNzL0luZGV4ZWREQi9zcWxpdGUvU1FMaXRlSURCQ3Vyc29yLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9EYXRhYmFzZVByb2Nlc3MvSW5kZXhlZERCL3NxbGl0ZS9TUUxpdGVJREJDdXJzb3IuY3Bw CkBAIC02NCw3ICs2NCw3IEBAIFNRTGl0ZUlEQkN1cnNvcjo6U1FMaXRlSURCQ3Vyc29yKFNRTGl0 ZUlEQlRyYW5zYWN0aW9uKiB0cmFuc2FjdGlvbiwgY29uc3QgSURCSWRlCiAgICAgQVNTRVJUKG1f b2JqZWN0U3RvcmVJRCk7CiB9CiAKLXN0YXRpYyBjb25zdCBTdHJpbmcmIGdldEluZGV4U3RhdGVt ZW50KGJvb2wgbG93ZXJLZXksIGJvb2wgbG93ZXJPcGVuLCBib29sIHVwcGVyS2V5LCBib29sIHVw cGVyT3BlbiwgYm9vbCBkZXNjZW5kaW5nKQorc3RhdGljIGNvbnN0IFN0cmluZyYgZ2V0SW5kZXhT dGF0ZW1lbnQoYm9vbCBoYXNMb3dlcktleSwgYm9vbCBpc0xvd2VyT3BlbiwgYm9vbCBoYXNVcHBl cktleSwgYm9vbCBpc1VwcGVyT3BlbiwgYm9vbCBkZXNjZW5kaW5nKQogewogICAgIERFRklORV9T VEFUSUNfTE9DQUwoVmVjdG9yPFN0cmluZz4sIGluZGV4U3RhdGVtZW50cywgKCkpOwogCkBAIC03 NCwxMCArNzQsMTAgQEAgc3RhdGljIGNvbnN0IFN0cmluZyYgZ2V0SW5kZXhTdGF0ZW1lbnQoYm9v bCBsb3dlcktleSwgYm9vbCBsb3dlck9wZW4sIGJvb2wgdXBwZXIKICAgICAgICAgLy8gTm8gbG93 ZXIga2V5IHN0YXRlbWVudHMgKDYpCiAgICAgICAgIGluZGV4U3RhdGVtZW50cy5hcHBlbmQoQVND SUlMaXRlcmFsKCJTRUxFQ1Qga2V5LCB2YWx1ZSBGUk9NIEluZGV4UmVjb3JkcyBXSEVSRSBpbmRl eElEID0gPyBPUkRFUiBCWSBrZXk7IikpOwogICAgICAgICBpbmRleFN0YXRlbWVudHMuYXBwZW5k KEFTQ0lJTGl0ZXJhbCgiU0VMRUNUIGtleSwgdmFsdWUgRlJPTSBJbmRleFJlY29yZHMgV0hFUkUg aW5kZXhJRCA9ID8gT1JERVIgQlkga2V5IERFU0M7IikpOwotICAgICAgICBpbmRleFN0YXRlbWVu dHMuYXBwZW5kKEFTQ0lJTGl0ZXJhbCgiU0VMRUNUIGtleSwgdmFsdWUgRlJPTSBJbmRleFJlY29y ZHMgV0hFUkUgaW5kZXhJRCA9ID8gQU5EIGtleSA8IENBU1QoPyBBUyBURVhUKSBPUkRFUiBCWSBr ZXk7IikpOwotICAgICAgICBpbmRleFN0YXRlbWVudHMuYXBwZW5kKEFTQ0lJTGl0ZXJhbCgiU0VM RUNUIGtleSwgdmFsdWUgRlJPTSBJbmRleFJlY29yZHMgV0hFUkUgaW5kZXhJRCA9ID8gQU5EIGtl eSA8IENBU1QoPyBBUyBURVhUKSBPUkRFUiBCWSBrZXkgREVTQzsiKSk7CiAgICAgICAgIGluZGV4 U3RhdGVtZW50cy5hcHBlbmQoQVNDSUlMaXRlcmFsKCJTRUxFQ1Qga2V5LCB2YWx1ZSBGUk9NIElu ZGV4UmVjb3JkcyBXSEVSRSBpbmRleElEID0gPyBBTkQga2V5IDw9IENBU1QoPyBBUyBURVhUKSBP UkRFUiBCWSBrZXk7IikpOwogICAgICAgICBpbmRleFN0YXRlbWVudHMuYXBwZW5kKEFTQ0lJTGl0 ZXJhbCgiU0VMRUNUIGtleSwgdmFsdWUgRlJPTSBJbmRleFJlY29yZHMgV0hFUkUgaW5kZXhJRCA9 ID8gQU5EIGtleSA8PSBDQVNUKD8gQVMgVEVYVCkgT1JERVIgQlkga2V5IERFU0M7IikpOworICAg ICAgICBpbmRleFN0YXRlbWVudHMuYXBwZW5kKEFTQ0lJTGl0ZXJhbCgiU0VMRUNUIGtleSwgdmFs dWUgRlJPTSBJbmRleFJlY29yZHMgV0hFUkUgaW5kZXhJRCA9ID8gQU5EIGtleSA8IENBU1QoPyBB UyBURVhUKSBPUkRFUiBCWSBrZXk7IikpOworICAgICAgICBpbmRleFN0YXRlbWVudHMuYXBwZW5k KEFTQ0lJTGl0ZXJhbCgiU0VMRUNUIGtleSwgdmFsdWUgRlJPTSBJbmRleFJlY29yZHMgV0hFUkUg aW5kZXhJRCA9ID8gQU5EIGtleSA8IENBU1QoPyBBUyBURVhUKSBPUkRFUiBCWSBrZXkgREVTQzsi KSk7CiAKICAgICAgICAgLy8gQ2xvc2VkIGxvd2VyIGtleSBzdGF0ZW1lbnRzICg2KQogICAgICAg ICBpbmRleFN0YXRlbWVudHMuYXBwZW5kKEFTQ0lJTGl0ZXJhbCgiU0VMRUNUIGtleSwgdmFsdWUg RlJPTSBJbmRleFJlY29yZHMgV0hFUkUgaW5kZXhJRCA9ID8gQU5EIGtleSA+PSBDQVNUKD8gQVMg VEVYVCkgT1JERVIgQlkga2V5OyIpKTsKQEAgLTk3LDE0ICs5NywxOSBAQCBzdGF0aWMgY29uc3Qg U3RyaW5nJiBnZXRJbmRleFN0YXRlbWVudChib29sIGxvd2VyS2V5LCBib29sIGxvd2VyT3Blbiwg Ym9vbCB1cHBlcgogICAgIH0KIAogICAgIHNpemVfdCBpID0gMDsKLSAgICBpZiAobG93ZXJLZXkp Ci0gICAgICAgIGkgKz0gNjsKLSAgICBpZiAobG93ZXJPcGVuKQorCisgICAgaWYgKGhhc0xvd2Vy S2V5KSB7CiAgICAgICAgIGkgKz0gNjsKLSAgICBpZiAodXBwZXJLZXkpCi0gICAgICAgIGkgKz0g MjsKLSAgICBpZiAodXBwZXJPcGVuKQorICAgICAgICBpZiAoaXNMb3dlck9wZW4pCisgICAgICAg ICAgICBpICs9IDY7CisgICAgfQorCisgICAgaWYgKGhhc1VwcGVyS2V5KSB7CiAgICAgICAgIGkg Kz0gMjsKKyAgICAgICAgaWYgKGlzVXBwZXJPcGVuKQorICAgICAgICAgICAgaSArPSAyOworICAg IH0KKwogICAgIGlmIChkZXNjZW5kaW5nKQogICAgICAgICBpICs9IDE7CiAKQEAgLTE0NCwxNCAr MTQ5LDE5IEBAIHN0YXRpYyBjb25zdCBTdHJpbmcmIGdldE9iamVjdFN0b3JlU3RhdGVtZW50KGJv b2wgbG93ZXJLZXksIGJvb2wgbG93ZXJPcGVuLCBib29sCiAgICAgfQogCiAgICAgc2l6ZV90IGkg PSAwOwotICAgIGlmIChsb3dlcktleSkKLSAgICAgICAgaSArPSA2OwotICAgIGlmIChsb3dlck9w ZW4pCisKKyAgICBpZiAoaGFzTG93ZXJLZXkpIHsKICAgICAgICAgaSArPSA2OwotICAgIGlmICh1 cHBlcktleSkKLSAgICAgICAgaSArPSAyOwotICAgIGlmICh1cHBlck9wZW4pCisgICAgICAgIGlm IChpc0xvd2VyT3BlbikKKyAgICAgICAgICAgIGkgKz0gNjsKKyAgICB9CisKKyAgICBpZiAoaGFz VXBwZXJLZXkpIHsKICAgICAgICAgaSArPSAyOworICAgICAgICBpZiAoaXNVcHBlck9wZW4pCisg ICAgICAgICAgICBpICs9IDI7CisgICAgfQorCiAgICAgaWYgKGRlc2NlbmRpbmcpCiAgICAgICAg IGkgKz0gMTsKIAo=