128142 2014-02-03 16:40:57 -0800 WK2: Selection callout bar does not scroll with the selection 2014-02-04 10:36:35 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica oldest_to_newest 976106 0 enrica 2014-02-03 16:40:57 -0800 Open a page in Safari on iOS. Select some text. The callout bar appears. Now scroll to a different position on the screen. Expected The callout disappears while scrolling and reappears when done. Actual The callout bar stays in the original position. <rdar://problem/15970812> 976129 1 223050 enrica 2014-02-03 17:30:10 -0800 Created attachment 223050 Patch 976138 2 223050 benjamin 2014-02-03 17:59:39 -0800 Comment on attachment 223050 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223050&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:272 > + [_contentView willStartZoomOrScroll]; > +} > + > +- (void)scrollViewWillBeginDragging:(UIScrollView *)scrollView > +{ > + [_contentView willStartZoomOrScroll]; I may have to split those at some point, we'll see. 976432 3 enrica 2014-02-04 10:36:35 -0800 Committed revision 163388 223050 2014-02-03 17:30:10 -0800 2014-02-03 17:59:38 -0800 Patch hide-show-callout-webkit.txt text/plain 5948 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MzM0OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBACisyMDE0LTAyLTAzICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgV0syOiBTZWxlY3Rpb24gY2Fs bG91dCBiYXIgZG9lcyBub3Qgc2Nyb2xsIHdpdGggdGhlIHNlbGVjdGlvbi4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODE0MgorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMTU5NzA4MTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkaW5nIG5vdGlmaWNhdGlvbnMgdG8gV0tDb250ZW50VmlldyB0byBh bGwgdGhlIGRlbGVnYXRlcworICAgICAgICBmb3Igc2Nyb2xsaW5nIGFuZCB6b29taW5nIHRvIGxl dCBXS0ludGVyYWN0aW9uVmlldyBhYm91dCBpdC4KKyAgICAgICAgVGhpcyBhbGxvd3MgdGhlIGlu dGVyYWN0aW9uIGFzc2lzdGFudHMgdG8gaGlkZSB0aGUgY2FsbG91dAorICAgICAgICB3aGlsZSBz Y3JvbGxpbmcgb3Igem9vbWluZyBhbmQgdG8gZmFkZSBpdCBpbiBhZ2FpbiBhdCB0aGUgZW5kLgor CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW06CisgICAgICAgICgt W1dLV2ViVmlldyBzY3JvbGxWaWV3V2lsbEJlZ2luWm9vbWluZzp3aXRoVmlldzpdKToKKyAgICAg ICAgKC1bV0tXZWJWaWV3IHNjcm9sbFZpZXdXaWxsQmVnaW5EcmFnZ2luZzpdKToKKyAgICAgICAg KiBVSVByb2Nlc3MvQVBJL2lvcy9XS0NvbnRlbnRWaWV3Lmg6CisgICAgICAgICogVUlQcm9jZXNz L0FQSS9pb3MvV0tDb250ZW50Vmlldy5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBkaWRG aW5pc2hTY3JvbGxUbzpdKToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyB3aWxsU3RhcnRab29t T3JTY3JvbGxdKToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBkaWRab29tVG9TY2FsZTpdKToK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2lvcy9XS0ludGVyYWN0aW9uVmlldy5oOgorICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvaW9zL1dLSW50ZXJhY3Rpb25WaWV3Lm1tOgorICAgICAgICAoLVtX S0ludGVyYWN0aW9uVmlldyBfd2lsbFN0YXJ0U2Nyb2xsaW5nT3Jab29taW5nXSk6CisgICAgICAg ICgtW1dLSW50ZXJhY3Rpb25WaWV3IF9kaWRFbmRTY3JvbGxpbmdPclpvb21pbmddKToKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL2lvcy9XS1ZpZXdJT1MubW06CisgICAgICAgICgtW1dLVmlldyBz Y3JvbGxWaWV3V2lsbEJlZ2luWm9vbWluZzp3aXRoVmlldzpdKToKKyAgICAgICAgKC1bV0tWaWV3 IHNjcm9sbFZpZXdXaWxsQmVnaW5EcmFnZ2luZzpdKToKKwogMjAxNC0wMi0wMyAgU2ltb24gRnJh c2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBBbGxvdyBXSzIgdG8gcmVh ZCBmcm9tIE5TVXNlckRlZmF1bHRzIHdoZW4gaXQgaGFzIG5vIHByZWZzIGlkZW50aWZpZXIKSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1t CShyZXZpc2lvbiAxNjMzMjIpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29h L1dLV2ViVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjY0LDYgKzI2NCwxMiBAQCAtICh2b2lk KXNjcm9sbFZpZXdXaWxsQmVnaW5ab29taW5nOihVSVNjCiB7CiAgICAgaWYgKHNjcm9sbFZpZXcu cGluY2hHZXN0dXJlUmVjb2duaXplci5zdGF0ZSA9PSBVSUdlc3R1cmVSZWNvZ25pemVyU3RhdGVC ZWdhbikKICAgICAgICAgX3VzZXJIYXNDaGFuZ2VkUGFnZVNjYWxlID0gWUVTOworICAgIFtfY29u dGVudFZpZXcgd2lsbFN0YXJ0Wm9vbU9yU2Nyb2xsXTsKK30KKworLSAodm9pZClzY3JvbGxWaWV3 V2lsbEJlZ2luRHJhZ2dpbmc6KFVJU2Nyb2xsVmlldyAqKXNjcm9sbFZpZXcKK3sKKyAgICBbX2Nv bnRlbnRWaWV3IHdpbGxTdGFydFpvb21PclNjcm9sbF07CiB9CiAKIC0gKHZvaWQpX2RpZEZpbmlz aFNjcm9sbApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9pb3MvV0tDb250ZW50 Vmlldy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvaW9zL1dL Q29udGVudFZpZXcuaAkocmV2aXNpb24gMTYzMzIyKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9pb3MvV0tDb250ZW50Vmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC03MCw1ICs3MCw2 IEBAIFdLX0FQSV9DTEFTUwogLSAodm9pZClkaWRGaW5pc2hTY3JvbGxUbzooQ0dQb2ludCljb250 ZW50T2Zmc2V0OwogLSAodm9pZClkaWRTY3JvbGxUbzooQ0dQb2ludCljb250ZW50T2Zmc2V0Owog LSAodm9pZClkaWRab29tVG9TY2FsZTooQ0dGbG9hdClzY2FsZTsKKy0gKHZvaWQpd2lsbFN0YXJ0 Wm9vbU9yU2Nyb2xsOwogCiBAZW5kCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2lvcy9XS0NvbnRlbnRWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvaW9zL1dLQ29udGVudFZpZXcubW0JKHJldmlzaW9uIDE2MzMyMikKKysrIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvaW9zL1dLQ29udGVudFZpZXcubW0JKHdvcmtpbmcgY29w eSkKQEAgLTIxNSw2ICsyMTUsNyBAQCAtICh2b2lkKWRpZEZpbmlzaFNjcm9sbFRvOihDR1BvaW50 KWNvbnRlCiAgICAgX3BhZ2UtPmRpZEZpbmlzaFNjcm9sbGluZyhjb250ZW50T2Zmc2V0KTsKICAg ICBbc2VsZiBfdXBkYXRlVmlld0V4cG9zZWRSZWN0XTsKICAgICBbc2VsZiBfdXBkYXRlRml4ZWRQ b3NpdGlvblJlY3RdOworICAgIFtfaW50ZXJhY3Rpb25WaWV3IF9kaWRFbmRTY3JvbGxpbmdPclpv b21pbmddOwogfQogCiAtICh2b2lkKWRpZFNjcm9sbFRvOihDR1BvaW50KWNvbnRlbnRPZmZzZXQK QEAgLTIyNSwxMSArMjI2LDE3IEBAIC0gKHZvaWQpZGlkU2Nyb2xsVG86KENHUG9pbnQpY29udGVu dE9mZnMKICAgICBfcGFnZS0+c2Nyb2xsaW5nQ29vcmRpbmF0b3JQcm94eSgpLT5zY3JvbGxQb3Np dGlvbkNoYW5nZWRWaWFEZWxlZ2F0ZWRTY3JvbGxpbmcoX3BhZ2UtPnNjcm9sbGluZ0Nvb3JkaW5h dG9yUHJveHkoKS0+cm9vdFNjcm9sbGluZ05vZGVJRCgpLCByb3VuZGVkSW50UG9pbnQoY29udGVu dE9mZnNldCkpOwogfQogCistICh2b2lkKXdpbGxTdGFydFpvb21PclNjcm9sbAoreworICAgIFtf aW50ZXJhY3Rpb25WaWV3IF93aWxsU3RhcnRTY3JvbGxpbmdPclpvb21pbmddOworfQorCiAtICh2 b2lkKWRpZFpvb21Ub1NjYWxlOihDR0Zsb2F0KXNjYWxlCiB7CiAgICAgX3BhZ2UtPmRpZEZpbmlz aFpvb21pbmcoc2NhbGUpOwogICAgIFtzZWxmIF91cGRhdGVWaWV3RXhwb3NlZFJlY3RdOwogICAg IFtzZWxmIF91cGRhdGVGaXhlZFBvc2l0aW9uUmVjdF07CisgICAgW19pbnRlcmFjdGlvblZpZXcg X2RpZEVuZFNjcm9sbGluZ09yWm9vbWluZ107CiB9CiAKICNwcmFnbWEgbWFyayBJbnRlcm5hbApJ bmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9pb3MvV0tJbnRlcmFjdGlvblZpZXcu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2lvcy9XS0ludGVy YWN0aW9uVmlldy5oCShyZXZpc2lvbiAxNjMzMjIpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2lvcy9XS0ludGVyYWN0aW9uVmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC02Myw2ICs2 Myw3IEBAIHN0cnVjdCBJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbjsKIC0gKHZvaWQp X2F0dGVtcHRDbGlja0F0TG9jYXRpb246KENHUG9pbnQpbG9jYXRpb247CiAtICh2b2lkKV91cGRh dGVQb3NpdGlvbkluZm9ybWF0aW9uOwogLSAodm9pZClfcGVyZm9ybUFjdGlvbjooV2ViS2l0OjpX S1NoZWV0QWN0aW9ucylhY3Rpb247Ci0KKy0gKHZvaWQpX3dpbGxTdGFydFNjcm9sbGluZ09yWm9v bWluZzsKKy0gKHZvaWQpX2RpZEVuZFNjcm9sbGluZ09yWm9vbWluZzsKIEBwcm9wZXJ0eSAocmVh ZG9ubHksIG5vbmF0b21pYykgV2ViS2l0OjpJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlv biBwb3NpdGlvbkluZm9ybWF0aW9uOwogQGVuZApJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9pb3MvV0tJbnRlcmFjdGlvblZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9pb3MvV0tJbnRlcmFjdGlvblZpZXcubW0JKHJldmlzaW9uIDE2 MzMyMikKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvaW9zL1dLSW50ZXJhY3Rpb25W aWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC02NzksNiArNjc5LDE4IEBAIC0gKHZvaWQpX3Bvc2l0 aW9uSW5mb3JtYXRpb25EaWRDaGFuZ2U6KGMKICAgICAgICAgW19hY3Rpb25TaGVldEFzc2lzdGFu dCB1cGRhdGVTaGVldFBvc2l0aW9uXTsKIH0KIAorLSAodm9pZClfd2lsbFN0YXJ0U2Nyb2xsaW5n T3Jab29taW5nCit7CisgICAgW193ZWJTZWxlY3Rpb25Bc3Npc3RhbnQgd2lsbFN0YXJ0U2Nyb2xs aW5nT3Jab29taW5nUGFnZV07CisgICAgW190ZXh0U2VsZWN0aW9uQXNzaXN0YW50IHdpbGxTdGFy dFNjcm9sbGluZ092ZXJmbG93XTsKK30KKworLSAodm9pZClfZGlkRW5kU2Nyb2xsaW5nT3Jab29t aW5nCit7CisgICAgW193ZWJTZWxlY3Rpb25Bc3Npc3RhbnQgZGlkRW5kU2Nyb2xsaW5nT3Jab29t aW5nUGFnZV07CisgICAgW190ZXh0U2VsZWN0aW9uQXNzaXN0YW50IGRpZEVuZFNjcm9sbGluZ092 ZXJmbG93XTsKK30KKwogLSAoVUlWaWV3ICopaW5wdXRBY2Nlc3NvcnlWaWV3CiB7CiAgICAgaWYg KCFfaXNFZGl0YWJsZSkKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvaW9zL1dL Vmlld0lPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2lv cy9XS1ZpZXdJT1MubW0JKHJldmlzaW9uIDE2MzMyMikKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvaW9zL1dLVmlld0lPUy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTkxLDYgKzE5MSwx MiBAQCAtICh2b2lkKXNjcm9sbFZpZXdXaWxsQmVnaW5ab29taW5nOihVSVNjCiB7CiAgICAgaWYg KHNjcm9sbFZpZXcucGluY2hHZXN0dXJlUmVjb2duaXplci5zdGF0ZSA9PSBVSUdlc3R1cmVSZWNv Z25pemVyU3RhdGVCZWdhbikKICAgICAgICAgX3VzZXJIYXNDaGFuZ2VkUGFnZVNjYWxlID0gWUVT OworICAgIFtfY29udGVudFZpZXcgd2lsbFN0YXJ0Wm9vbU9yU2Nyb2xsXTsKK30KKworLSAodm9p ZClzY3JvbGxWaWV3V2lsbEJlZ2luRHJhZ2dpbmc6KFVJU2Nyb2xsVmlldyAqKXNjcm9sbFZpZXcK K3sKKyAgICBbX2NvbnRlbnRWaWV3IHdpbGxTdGFydFpvb21PclNjcm9sbF07CiB9CiAKIC0gKHZv aWQpX2RpZEZpbmlzaFNjcm9sbAo=