128122 2014-02-03 13:56:58 -0800 Consolidate StringImpl tail handling into two functions 2014-02-03 14:00:10 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cmarcelo commit-queue oldest_to_newest 976004 0 andersca 2014-02-03 13:56:58 -0800 Consolidate StringImpl tail handling into two functions 976005 1 223016 andersca 2014-02-03 13:57:15 -0800 Created attachment 223016 Patch 976009 2 andersca 2014-02-03 14:00:10 -0800 Committed r163326: <http://trac.webkit.org/changeset/163326> 223016 2014-02-03 13:57:15 -0800 2014-02-03 13:58:58 -0800 Patch bug-128122-20140203135715.patch text/plain 3862 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDFkMzYzYzcyMzgzYTkxMzYzNGJlMmE3 YTYxYmRmYTQ3NzA5YjkwMjUuLjNlM2Q2YTU3MDJiMzNhODE2YTllZGNjNmFkODQ4YjUwM2RjOGYx MjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTQtMDItMDMgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBDb25zb2xpZGF0ZSBTdHJpbmdJbXBsIHRhaWwg aGFuZGxpbmcgaW50byB0d28gZnVuY3Rpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgxMjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHd0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwOgorICAgICAgICAo V1RGOjpTdHJpbmdJbXBsOjpjcmVhdGVVbmluaXRpYWxpemVkSW50ZXJuYWxOb25FbXB0eSk6Cisg ICAgICAgIChXVEY6OlN0cmluZ0ltcGw6OnJlYWxsb2NhdGVJbnRlcm5hbCk6CisgICAgICAgICog d3RmL3RleHQvU3RyaW5nSW1wbC5oOgorICAgICAgICAoV1RGOjpTdHJpbmdJbXBsOjp0cnlDcmVh dGVVbmluaXRpYWxpemVkKToKKyAgICAgICAgKFdURjo6U3RyaW5nSW1wbDo6YWxsb2NhdGlvblNp emUpOgorICAgICAgICAoV1RGOjpTdHJpbmdJbXBsOjp0YWlsUG9pbnRlcik6CisKIDIwMTQtMDIt MDMgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSBVbmlj b2RlLmgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5jcHAgYi9T b3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwCmluZGV4IDM0Nzk0MjU4YzMwNzc1ZjJm MDkzOWJjMTljNTViNDYwODQ1NWZiNzkuLjE2YjdmMDQ5ZGU2MWIzZTA5MTU2YmIxNzUxMDQ0MWRl MjY2ZWJiM2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nSW1wbC5jcHAK KysrIGIvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcApAQCAtMTk1LDggKzE5NSw3 IEBAIGlubGluZSBQYXNzUmVmPFN0cmluZ0ltcGw+IFN0cmluZ0ltcGw6OmNyZWF0ZVVuaW5pdGlh bGl6ZWRJbnRlcm5hbE5vbkVtcHR5KHVuc2lnCiAgICAgLy8gaGVhcCBhbGxvY2F0aW9uIGZyb20g dGhpcyBjYWxsLgogICAgIGlmIChsZW5ndGggPiAoKHN0ZDo6bnVtZXJpY19saW1pdHM8dW5zaWdu ZWQ+OjptYXgoKSAtIHNpemVvZihTdHJpbmdJbXBsKSkgLyBzaXplb2YoQ2hhclR5cGUpKSkKICAg ICAgICAgQ1JBU0goKTsKLSAgICBzaXplX3Qgc2l6ZSA9IHNpemVvZihTdHJpbmdJbXBsKSArIGxl bmd0aCAqIHNpemVvZihDaGFyVHlwZSk7Ci0gICAgU3RyaW5nSW1wbCogc3RyaW5nID0gc3RhdGlj X2Nhc3Q8U3RyaW5nSW1wbCo+KGZhc3RNYWxsb2Moc2l6ZSkpOworICAgIFN0cmluZ0ltcGwqIHN0 cmluZyA9IHN0YXRpY19jYXN0PFN0cmluZ0ltcGwqPihmYXN0TWFsbG9jKGFsbG9jYXRpb25TaXpl PENoYXJUeXBlPihsZW5ndGgpKSk7CiAKICAgICBkYXRhID0gcmVpbnRlcnByZXRfY2FzdDxDaGFy VHlwZSo+KHN0cmluZyArIDEpOwogICAgIHJldHVybiBjb25zdHJ1Y3RJbnRlcm5hbDxDaGFyVHlw ZT4oc3RyaW5nLCBsZW5ndGgpOwpAQCAtMjI2LDExICsyMjUsMTEgQEAgaW5saW5lIFBhc3NSZWY8 U3RyaW5nSW1wbD4gU3RyaW5nSW1wbDo6cmVhbGxvY2F0ZUludGVybmFsKFBhc3NSZWZQdHI8U3Ry aW5nSW1wbD4KICAgICAvLyBTYW1lIGFzIGNyZWF0ZVVuaW5pdGlhbGl6ZWQoKSBleGNlcHQgaGVy ZSB3ZSB1c2UgZmFzdFJlYWxsb2MuCiAgICAgaWYgKGxlbmd0aCA+ICgoc3RkOjpudW1lcmljX2xp bWl0czx1bnNpZ25lZD46Om1heCgpIC0gc2l6ZW9mKFN0cmluZ0ltcGwpKSAvIHNpemVvZihDaGFy VHlwZSkpKQogICAgICAgICBDUkFTSCgpOwotICAgIHNpemVfdCBzaXplID0gc2l6ZW9mKFN0cmlu Z0ltcGwpICsgbGVuZ3RoICogc2l6ZW9mKENoYXJUeXBlKTsKKwogICAgIG9yaWdpbmFsU3RyaW5n LT5+U3RyaW5nSW1wbCgpOwotICAgIFN0cmluZ0ltcGwqIHN0cmluZyA9IHN0YXRpY19jYXN0PFN0 cmluZ0ltcGwqPihmYXN0UmVhbGxvYyhvcmlnaW5hbFN0cmluZy5sZWFrUmVmKCksIHNpemUpKTsK KyAgICBTdHJpbmdJbXBsKiBzdHJpbmcgPSBzdGF0aWNfY2FzdDxTdHJpbmdJbXBsKj4oZmFzdFJl YWxsb2Mob3JpZ2luYWxTdHJpbmcubGVha1JlZigpLCBhbGxvY2F0aW9uU2l6ZTxDaGFyVHlwZT4o bGVuZ3RoKSkpOwogCi0gICAgZGF0YSA9IHJlaW50ZXJwcmV0X2Nhc3Q8Q2hhclR5cGUqPihzdHJp bmcgKyAxKTsKKyAgICBkYXRhID0gc3RyaW5nLT50YWlsUG9pbnRlcjxDaGFyVHlwZT4oKTsKICAg ICByZXR1cm4gY29uc3RydWN0SW50ZXJuYWw8Q2hhclR5cGU+KHN0cmluZywgbGVuZ3RoKTsKIH0K IApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmggYi9Tb3VyY2Uv V1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaAppbmRleCBiMGIyNzI4MzU3OGI5ODdkMzIxMTI5ZGZm MDFkZTJhZDMxNGJiZWQyLi4wNjg1OTQ5YmQ2ZTVhYzQyN2E0MTg3MTljZDZhZTgwMWZmYmFkZDY4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaAorKysgYi9Tb3Vy Y2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaApAQCAtNDA4LDExICs0MDgsMTEgQEAgcHVibGlj OgogICAgICAgICAgICAgcmV0dXJuIDA7CiAgICAgICAgIH0KICAgICAgICAgU3RyaW5nSW1wbCog cmVzdWx0SW1wbDsKLSAgICAgICAgaWYgKCF0cnlGYXN0TWFsbG9jKHNpemVvZihUKSAqIGxlbmd0 aCArIHNpemVvZihTdHJpbmdJbXBsKSkuZ2V0VmFsdWUocmVzdWx0SW1wbCkpIHsKKyAgICAgICAg aWYgKCF0cnlGYXN0TWFsbG9jKGFsbG9jYXRpb25TaXplPFQ+KGxlbmd0aCkpLmdldFZhbHVlKHJl c3VsdEltcGwpKSB7CiAgICAgICAgICAgICBvdXRwdXQgPSAwOwogICAgICAgICAgICAgcmV0dXJu IDA7CiAgICAgICAgIH0KLSAgICAgICAgb3V0cHV0ID0gcmVpbnRlcnByZXRfY2FzdDxUKj4ocmVz dWx0SW1wbCArIDEpOworICAgICAgICBvdXRwdXQgPSByZXN1bHRJbXBsLT50YWlsUG9pbnRlcjxU PigpOwogCiAgICAgICAgIHJldHVybiBjb25zdHJ1Y3RJbnRlcm5hbDxUPihyZXN1bHRJbXBsLCBs ZW5ndGgpOwogICAgIH0KQEAgLTc2OSw2ICs3NjksMTggQEAgcHJpdmF0ZToKICAgICAgICAgcmV0 dXJuIHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3Qgdm9pZCo+KG1fZGF0YTE2KSA9PSByZWludGVycHJl dF9jYXN0PGNvbnN0IHZvaWQqPih0aGlzICsgMSk7CiAgICAgfQogCisgICAgdGVtcGxhdGU8dHlw ZW5hbWUgVD4KKyAgICBzdGF0aWMgc2l6ZV90IGFsbG9jYXRpb25TaXplKHVuc2lnbmVkIHRhaWxF bGVtZW50Q291bnQpCisgICAgeworICAgICAgICByZXR1cm4gc2l6ZW9mKFN0cmluZ0ltcGwpICsg dGFpbEVsZW1lbnRDb3VudCAqIHNpemVvZihUKTsKKyAgICB9CisKKyAgICB0ZW1wbGF0ZTx0eXBl bmFtZSBUPgorICAgIFQqIHRhaWxQb2ludGVyKCkKKyAgICB7CisgICAgICAgIHJldHVybiByZWlu dGVycHJldF9jYXN0PFQqPih0aGlzICsgMSk7CisgICAgfQorCiAgICAgLy8gVGhpcyBudW1iZXIg bXVzdCBiZSBhdCBsZWFzdCAyIHRvIGF2b2lkIHNoYXJpbmcgZW1wdHksIG51bGwgYXMgd2VsbCBh cyAxIGNoYXJhY3RlciBzdHJpbmdzIGZyb20gU21hbGxTdHJpbmdzLgogICAgIHN0YXRpYyBjb25z dCB1bnNpZ25lZCBzX2NvcHlDaGFyc0lubGluZUN1dE9mZiA9IDIwOwogCg==