128120 2014-02-03 13:14:19 -0800 Need regression test for the debugger modifying locals in a DFG frame 2014-02-03 21:05:19 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 128112 1 mark.lam mark.lam commit-queue oldest_to_newest 975985 0 mark.lam 2014-02-03 13:14:19 -0800 A regression test is needed for the issue fixed in https://bugs.webkit.org/show_bug.cgi?id=128112. 976177 1 223065 mark.lam 2014-02-03 20:16:06 -0800 Created attachment 223065 new regression test. 976182 2 223065 ggaren 2014-02-03 20:35:40 -0800 Comment on attachment 223065 new regression test. r=me 976189 3 223065 commit-queue 2014-02-03 21:05:16 -0800 Comment on attachment 223065 new regression test. Clearing flags on attachment: 223065 Committed r163363: <http://trac.webkit.org/changeset/163363> 976190 4 commit-queue 2014-02-03 21:05:19 -0800 All reviewed patches have been landed. Closing bug. 223065 2014-02-03 20:16:06 -0800 2014-02-03 21:05:16 -0800 new regression test. bug-128120.patch text/plain 6954 mark.lam SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE2MzM2MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDM3IEBACisyMDE0LTAyLTAzICBNYXJrIExhbSAgPG1hcmsu bGFtQGFwcGxlLmNvbT4KKworICAgICAgICBOZWVkIHJlZ3Jlc3Npb24gdGVzdCBmb3IgdGhlIGRl YnVnZ2VyIG1vZGlmeWluZyBsb2NhbHMgaW4gYSBERkcgZnJhbWUuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgxMjAuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVncmVzc2lvbiB0ZXN0IGZvciBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MTEyLgorCisgICAgICAgIFRo aXMgdGVzdCBkb2VzIHRoZSBmb2xsb3dpbmc6CisgICAgICAgIDEuIFdhcm0gdXAgYSBERkcgZnVu Y3Rpb24uCisgICAgICAgIDIuIFNldHMgYSBicmVha3BvaW50IGluIGEgZnVuY3Rpb24gYnJlYWtw b2ludEJhc2ljKCkgdGhhdCB3aWxsIGJlIGNhbGxlZAorICAgICAgICAgICBieSB0aGUgREZHIGZ1 bmN0aW9uLCBidXQgaGFzIG5ldmVyIGJlZW4gY2FsbGVkIHlldC4KKyAgICAgICAgMy4gQ2FsbCBh IGRyaXZlciBmdW5jdGlvbiB3aGljaCBpbiB0dXJuIGNhbGxzIHRoZSBERkcgZnVuY3Rpb24sIGFu ZCBleHBlY3QKKyAgICAgICAgICAgdGhlIGRlYnVnZ2VyIHRvIGJyZWFrLgorICAgICAgICA0LiBB dCB0aGUgYnJlYWtwb2ludCBpbiBicmVha3BvaW50QmFzaWMoKSwgZXZhbHVhdGUgYW4gZXhwcmVz c2lvbiBvbiBpdHMKKyAgICAgICAgICAgY2FsbGVyIGkuZS4gdGhlIERGRyBmdW5jdGlvbiwgYW5k IGNoYW5nZSBhIGxvY2FsIHZhcmlhYmxlIGluIGl0LgorICAgICAgICA1LiBSZXN1bWUgZnJvbSB0 aGUgZGVidWdnZXIsIGFuZCBsZXQgdGhlIERGRyBmdW5jdGlvbiBhbmQgaXRzIGRyaXZlcgorICAg ICAgICAgICBmdW5jdGlvbiBydW4gdG8gY29tcGxldGlvbi4gVGhlIERGRyBmdW5jdGlvbiB3aWxs IHJldHVybiBhIHZhbHVlCisgICAgICAgICAgIGNvbXB1dGVkIHVzaW5nIHRoZSBtb2RpZmllZCBs b2NhbC4KKyAgICAgICAgNi4gQXQgdGhlIGVuZCBvZiB0aGUgZHJpdmVyIGZ1bmN0aW9uLCB2ZXJp ZnkgdGhhdCB0aGUgcmV0dXJuZWQgY29tcHV0ZWQKKyAgICAgICAgICAgdmFsdWUgcmVmbGVjdHMg dGhlIG1vZGlmaWVkIHZhbHVlLgorCisgICAgICAgIFRoaXMgdGVzdCBoYXMgYmVlbiB2ZXJpZmll ZCB3aXRoIHRyYWNpbmcgZW5hYmxlZCB0byBlbnN1cmUgdGhhdCB0aGUgdGVzdAorICAgICAgICBE RkcgZnVuY3Rpb24gd2FzIGluZGVlZCBERkcgY29tcGlsZWQsIGFuZCB0aGF0IHRoZSB0ZXN0IHBh c3NlZCB3aXRoIHRoZQorICAgICAgICBleHBlY3RlZCByZXN1bHRzLgorCisgICAgICAgICogaW5z cGVjdG9yLXByb3RvY29sL2RlYnVnZ2VyL3Jlc291cmNlcy9icmVha3BvaW50LmpzOgorICAgICAg ICAobm90SW5saW5lYWJsZTIpOgorICAgICAgICAoZGZnV2l0aG91dElubGluZTIpOgorICAgICAg ICAoY2FsbE5vdElubGluZWFibGUyKToKKyAgICAgICAgKiBpbnNwZWN0b3ItcHJvdG9jb2wvZGVi dWdnZXIvc2V0QnJlYWtwb2ludC1kZmctYW5kLW1vZGlmeS1sb2NhbC1leHBlY3RlZC50eHQ6IEFk ZGVkLgorICAgICAgICAqIGluc3BlY3Rvci1wcm90b2NvbC9kZWJ1Z2dlci9zZXRCcmVha3BvaW50 LWRmZy1hbmQtbW9kaWZ5LWxvY2FsLmh0bWw6IEFkZGVkLgorCiAyMDE0LTAyLTAzICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBOZWVkIHJlZ3Jlc3Npb24gdGVzdCB0 byBlbnN1cmUgdGhhdCB0aGUgZGVidWdnZXIgZG9lcyBub3QgYXR0ZW1wdCB0byBleGVjdXRlIGEg YmFkIHNjcmlwdCBmcm9tIGl0cyBjb25zb2xlLgpJbmRleDogTGF5b3V0VGVzdHMvaW5zcGVjdG9y LXByb3RvY29sL2RlYnVnZ2VyL3NldEJyZWFrcG9pbnQtZGZnLWFuZC1tb2RpZnktbG9jYWwtZXhw ZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2luc3BlY3Rvci1wcm90b2NvbC9k ZWJ1Z2dlci9zZXRCcmVha3BvaW50LWRmZy1hbmQtbW9kaWZ5LWxvY2FsLWV4cGVjdGVkLnR4dAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2luc3BlY3Rvci1wcm90b2NvbC9kZWJ1Z2dlci9z ZXRCcmVha3BvaW50LWRmZy1hbmQtbW9kaWZ5LWxvY2FsLWV4cGVjdGVkLnR4dAkod29ya2luZyBj b3B5KQpAQCAtMCwwICsxLDE0IEBACitEZWJ1Z2dlci5ldmFsdWF0ZU9uQ2FsbEZyYW1lIGluIGEg REZHIGNvbXBpbGVkIGZ1bmN0aW9ucy4KKworRm91bmQgYnJlYWtwb2ludC5qcworcmVzdWx0OiA1 MDI1MDAKK2RmZyBmdW5jdGlvbiB3YXJtZWQgdXAKKworQnJlYWtwb2ludCBzZXQgaW4gYnJlYWtw b2ludEJhc2ljKCkKK0hpdCBCcmVha3BvaW50IQorRXZhbHVhdGluZyBpbiBERkcgZnJhbWUgYXQg ZnJhbWVbMV06ICd4ID0gMjAwMDA7JworUmVzdW1lZCBmcm9tIGJyZWFrcG9pbnQKK2luc2lkZSBi cmVha3BvaW50QmFzaWMKK1BBU1M6IHJlc3VsdCBpcyAyMDAwMworVGVzdCBjb21wbGV0ZQorCklu ZGV4OiBMYXlvdXRUZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvZGVidWdnZXIvc2V0QnJlYWtwb2lu dC1kZmctYW5kLW1vZGlmeS1sb2NhbC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2lu c3BlY3Rvci1wcm90b2NvbC9kZWJ1Z2dlci9zZXRCcmVha3BvaW50LWRmZy1hbmQtbW9kaWZ5LWxv Y2FsLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wv ZGVidWdnZXIvc2V0QnJlYWtwb2ludC1kZmctYW5kLW1vZGlmeS1sb2NhbC5odG1sCSh3b3JraW5n IGNvcHkpCkBAIC0wLDAgKzEsNzIgQEAKKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4v Li4vaHR0cC90ZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvcmVzb3VyY2VzL3Byb3RvY29sLXRlc3Qu anMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9InJlc291cmNlcy9icmVha3BvaW50LmpzIj48L3Nj cmlwdD4KKworPHNjcmlwdD4KKy8vIFB1dCB0aGlzIGhlcmUgaW5zdGVhZCBvZiBvbiA8Ym9keSBv bmxvYWQ+IHRvIHByZXZlbnQgYW4gZXh0cmEgRGVidWdnZXIuc2NyaXB0UGFyc2VkIGV2ZW50Lgor d2luZG93Lm9ubG9hZCA9IHJ1blRlc3Q7CisKK2Z1bmN0aW9uIHRlc3QoKQoreworICAgIC8vIFRo aXMgdGVzdCBzZXR0aW5nIDIgYnJlYWtwb2ludHMgaW4gREZHIGNvbXBpbGVkIGZ1bmN0aW9uczog b25lIGlubGluZWQsCisgICAgLy8gYW5kIG9uZSBub3QgaW5saW5lZC4KKworICAgIEluc3BlY3Rv clRlc3Quc2VuZENvbW1hbmQoIkRlYnVnZ2VyLmVuYWJsZSIsIHt9KTsKKworICAgIHZhciBicmVh a3BvaW50SWQgPSBudWxsOworICAgIHZhciBzY3JpcHRJZCA9IDA7CisgICAgdmFyIHN0YXJ0TGlu ZSA9IDA7CisKKyAgICBJbnNwZWN0b3JUZXN0LmV2ZW50SGFuZGxlclsiRGVidWdnZXIuc2NyaXB0 UGFyc2VkIl0gPSBmdW5jdGlvbihtZXNzYWdlT2JqZWN0KQorICAgIHsKKyAgICAgICAgaWYgKC9y ZXNvdXJjZXNcL2JyZWFrcG9pbnRcLmpzJC8udGVzdChtZXNzYWdlT2JqZWN0LnBhcmFtcy51cmwp KSB7CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmxvZygiRm91bmQgYnJlYWtwb2ludC5qcyIp OworICAgICAgICAgICAgc2NyaXB0SWQgPSBtZXNzYWdlT2JqZWN0LnBhcmFtcy5zY3JpcHRJZDsK KyAgICAgICAgICAgIHN0YXJ0TGluZSA9IG1lc3NhZ2VPYmplY3QucGFyYW1zLnN0YXJ0TGluZTsK KworICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5zZW5kQ29tbWFuZCgiUnVudGltZS5ldmFsdWF0 ZSIsIHsKKyAgICAgICAgICAgICAgICBleHByZXNzaW9uOiAiZGZnV2l0aG91dElubGluZTIoKTsi CisgICAgICAgICAgICB9LCBmdW5jdGlvbihyZXNwb25zZU9iamVjdCkgeworICAgICAgICAgICAg ICAgIEluc3BlY3RvclRlc3QubG9nKCJkZmcgZnVuY3Rpb24gd2FybWVkIHVwXG4iKTsKKworICAg ICAgICAgICAgICAgIHZhciBsb2NhdGlvbjEgPSB7c2NyaXB0SWQ6IHNjcmlwdElkLCBsaW5lTnVt YmVyOiAyLCBjb2x1bW5OdW1iZXI6IDB9OworCisgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVz dC5zZW5kQ29tbWFuZCgiRGVidWdnZXIuc2V0QnJlYWtwb2ludCIsIHtsb2NhdGlvbjogbG9jYXRp b24xfSwgZnVuY3Rpb24ocmVzcG9uc2VPYmplY3QpIHsKKyAgICAgICAgICAgICAgICAgICAgSW5z cGVjdG9yVGVzdC5jaGVja0ZvckVycm9yKHJlc3BvbnNlT2JqZWN0KTsKKyAgICAgICAgICAgICAg ICAgICAgSW5zcGVjdG9yVGVzdC5sb2coIkJyZWFrcG9pbnQgc2V0IGluIGJyZWFrcG9pbnRCYXNp YygpIik7CisKKyAgICAgICAgICAgICAgICAgICAgYnJlYWtwb2ludElkID0gcmVzcG9uc2VPYmpl Y3QucmVzdWx0LmJyZWFrcG9pbnRJZDsKKyAgICAgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVz dC5zZW5kQ29tbWFuZCgiUnVudGltZS5ldmFsdWF0ZSIsIHsKKyAgICAgICAgICAgICAgICAgICAg ICAgIGV4cHJlc3Npb246ICJjYWxsTm90SW5saW5lYWJsZTIoKTsiCisgICAgICAgICAgICAgICAg ICAgIH0sIGZ1bmN0aW9uKHJlc3BvbnNlT2JqZWN0KSB7CisgICAgICAgICAgICAgICAgICAgICAg ICBJbnNwZWN0b3JUZXN0LmxvZygiVGVzdCBjb21wbGV0ZSIpOworICAgICAgICAgICAgICAgICAg ICAgICAgSW5zcGVjdG9yVGVzdC5jb21wbGV0ZVRlc3QoKTsKKyAgICAgICAgICAgICAgICAgICAg fSk7CisgICAgICAgICAgICAgICAgfSk7CisgICAgICAgICAgICB9KTsKKyAgICAgICAgfQorICAg IH0KKworICAgIEluc3BlY3RvclRlc3QuZXZlbnRIYW5kbGVyWyJEZWJ1Z2dlci5wYXVzZWQiXSA9 IGZ1bmN0aW9uKG1lc3NhZ2VPYmplY3QpCisgICAgeworICAgICAgICBJbnNwZWN0b3JUZXN0Lmxv ZygiSGl0IEJyZWFrcG9pbnQhIik7CisgICAgICAgIHZhciBjYWxsRnJhbWVzID0gbWVzc2FnZU9i amVjdC5wYXJhbXMuY2FsbEZyYW1lczsKKyAgICAgICAgaWYgKGNhbGxGcmFtZXMubGVuZ3RoIDwg MykKKyAgICAgICAgICAgIEluc3BlY3RvclRlc3QubG9nKCJGQUlMOiB0b28gZmV3IGZyYW1lcyBp biBzdGFjayB0cmFjZSIpOworCisgICAgICAgIHZhciBjYWxsRnJhbWVJZCA9IGNhbGxGcmFtZXNb MV0uY2FsbEZyYW1lSWQ7CisgICAgICAgIEluc3BlY3RvclRlc3QubG9nKCJFdmFsdWF0aW5nIGlu IERGRyBmcmFtZSBhdCBmcmFtZVsxXTogJ3ggPSAyMDAwMDsnIik7CisgICAgICAgIEluc3BlY3Rv clRlc3Quc2VuZENvbW1hbmQoIkRlYnVnZ2VyLmV2YWx1YXRlT25DYWxsRnJhbWUiLCB7IGNhbGxG cmFtZUlkOiBjYWxsRnJhbWVJZCwgZXhwcmVzc2lvbjogInggPSAyMDAwMDsiIH0sIGZ1bmN0aW9u KHJlc3BvbnNlT2JqZWN0KSB7CisgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LnNlbmRDb21tYW5k KCJEZWJ1Z2dlci5yZXN1bWUiLCB7fSwgZnVuY3Rpb24ocmVzcG9uc2VPYmplY3QpIHsKKyAgICAg ICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmxvZygiUmVzdW1lZCBmcm9tIGJyZWFrcG9pbnQiKTsK KyAgICAgICAgICAgIH0pOworICAgICAgICB9KTsKKyAgICB9Cit9Cis8L3NjcmlwdD4KKzwvaGVh ZD4KKzxib2R5PgorPHA+RGVidWdnZXIuZXZhbHVhdGVPbkNhbGxGcmFtZSBpbiBhIERGRyBjb21w aWxlZCBmdW5jdGlvbnMuPC9wPgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMv aW5zcGVjdG9yLXByb3RvY29sL2RlYnVnZ2VyL3Jlc291cmNlcy9icmVha3BvaW50LmpzCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL2luc3BlY3Rvci1wcm90b2NvbC9kZWJ1Z2dlci9yZXNvdXJj ZXMvYnJlYWtwb2ludC5qcwkocmV2aXNpb24gMTYzMzYxKQorKysgTGF5b3V0VGVzdHMvaW5zcGVj dG9yLXByb3RvY29sL2RlYnVnZ2VyL3Jlc291cmNlcy9icmVha3BvaW50LmpzCSh3b3JraW5nIGNv cHkpCkBAIC01NiwzICs1NiwyOSBAQCBmdW5jdGlvbiBkZmdXaXRoSW5saW5lKCkKICAgICAgICAg cmVzdWx0ICs9IGlubGluaW5nRm9vKGkpOwogICAgIGxvZygiZGZnV2l0aElubGluZSByZXN1bHQ6 ICIgKyByZXN1bHQpOyAgICAKIH0KKworZnVuY3Rpb24gbm90SW5saW5lYWJsZTIoeCwgY2FsbEZ1 bmN0aW9uV2l0aEJyZWFrcG9pbnQpCit7CisgICAgdmFyIGZ1bmMgPSBuZXcgRnVuY3Rpb24oInJl dHVybiB4ICsgMTAwOyIpOworICAgIGlmIChjYWxsRnVuY3Rpb25XaXRoQnJlYWtwb2ludCkKKyAg ICAgICAgYnJlYWtwb2ludEJhc2ljKCk7CisgICAgcmV0dXJuIHggKyAzOworfQorCitmdW5jdGlv biBkZmdXaXRob3V0SW5saW5lMigpCit7CisgICAgdmFyIGk7CisgICAgdmFyIHJlc3VsdCA9IDA7 CisgICAgZm9yIChpID0gMDsgaSA8IDEwMDA7IGkrKykKKyAgICAgICAgcmVzdWx0ICs9IG5vdElu bGluZWFibGUyKGksIGZhbHNlKTsKKyAgICBsb2coInJlc3VsdDogIiArIHJlc3VsdCk7Cit9CisK K2Z1bmN0aW9uIGNhbGxOb3RJbmxpbmVhYmxlMigpCit7CisgICAgdmFyIHJlc3VsdCA9IG5vdElu bGluZWFibGUyKDEwMDAwLCB0cnVlKTsKKyAgICBpZiAocmVzdWx0ID09IDIwMDAzKQorICAgICAg ICBsb2coIlBBU1M6IHJlc3VsdCBpcyAiICsgcmVzdWx0KTsKKyAgICBlbHNlCisgICAgICAgIGxv ZygiRkFJTDogcmVzdWx0IGlzICIgKyByZXN1bHQgKyAiLCBleHBlY3RpbmcgMjAwMDMiKTsKK30K