128114 2014-02-03 11:11:09 -0800 AX: WebKit should support @headers/@id for complex accessible web tables 2014-02-03 12:30:04 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro commit-queue dmazzoni jcraig jdiggs mario samuel_white webkit-bug-importer oldest_to_newest 975937 0 cfleizach 2014-02-03 11:11:09 -0800 AX: WebKit should support @headers/@id for complex accessible web tables * STEPS TO REPRODUCE 1. Using VO, navigate the tables on http://webaim.org/articles/voiceover/tables * RESULTS headers/id attributes are ignored. This radar represents the WebKit portion of the bug. <rdar://problem/9199163> 975939 1 223001 cfleizach 2014-02-03 11:13:42 -0800 Created attachment 223001 patch 975950 2 223001 darin 2014-02-03 11:51:18 -0800 Comment on attachment 223001 patch View in context: https://bugs.webkit.org/attachment.cgi?id=223001&action=review > Source/WebCore/accessibility/AccessibilityTableCell.cpp:158 > + AccessibilityObject* object = cache->getOrCreate(element); > + if (object) > + headers.append(object); I suggest putting this inside the if statement. if (AccessibilityObject* object = cache->getOrCreate(element)) headers.append(object); > Source/WebCore/accessibility/AccessibilityTableCell.cpp:162 > + if (headers.size()) Maybe !headers.isEmpty() would be better? 975951 3 cfleizach 2014-02-03 11:52:43 -0800 (In reply to comment #2) > (From update of attachment 223001 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=223001&action=review > > > Source/WebCore/accessibility/AccessibilityTableCell.cpp:158 > > + AccessibilityObject* object = cache->getOrCreate(element); > > + if (object) > > + headers.append(object); > > I suggest putting this inside the if statement. > > if (AccessibilityObject* object = cache->getOrCreate(element)) > headers.append(object); > > > Source/WebCore/accessibility/AccessibilityTableCell.cpp:162 > > + if (headers.size()) > > Maybe !headers.isEmpty() would be better? Done. Thanks! 975963 4 cfleizach 2014-02-03 12:30:04 -0800 http://trac.webkit.org/changeset/163320 223001 2014-02-03 11:13:42 -0800 2014-02-03 11:51:18 -0800 patch patch text/plain 5957 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MzMxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAyLTAzICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFdlYktpdCBzaG91 bGQgc3VwcG9ydCBAaGVhZGVycy9AaWQgZm9yIGNvbXBsZXggYWNjZXNzaWJsZSB3ZWIgdGFibGVz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgxMTQK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeHBvc2Ug dGhlIGhlYWRlcnMgYXR0cmlidXRlIGZvciB0YWJsZSBjZWxscyB0byBhY2Nlc3NpYmlsaXR5Lgor CisgICAgICAgIFRlc3Q6IHBsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3RhYmxlLWhlYWRlcnMt YXR0cmlidXRlLmh0bWwKKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVRh YmxlQ2VsbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5VGFibGVDZWxsOjpj b2x1bW5IZWFkZXJzKToKKwogMjAxNC0wMi0wMyAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGln YWxpYS5jb20+CiAKICAgICAgICAgTW92ZSB0aGUgd2ViZGF0YWJhc2UgbW9kdWxlIHNvdXJjZSBj b2RlIHRvIHN0ZDo6dW5pcXVlX3B0cgpJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BY2Nlc3NpYmlsaXR5VGFibGVDZWxsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlUYWJsZUNlbGwuY3BwCShyZXZpc2lvbiAxNjI5 ODYpCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlUYWJsZUNl bGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDgsNiArMTQ4LDIwIEBACiAgICAgaWYgKCFwYXJl bnQpCiAgICAgICAgIHJldHVybjsKIAorICAgIC8vIENob29zZSBjb2x1bW5IZWFkZXJzIGFzIHRo ZSBwbGFjZSB3aGVyZSB0aGUgImhlYWRlcnMiIGF0dHJpYnV0ZSBpcyByZXBvcnRlZC4KKyAgICBB WE9iamVjdENhY2hlKiBjYWNoZSA9IGF4T2JqZWN0Q2FjaGUoKTsKKyAgICBWZWN0b3I8RWxlbWVu dCo+IGVsZW1lbnRzOworICAgIGVsZW1lbnRzRnJvbUF0dHJpYnV0ZShlbGVtZW50cywgaGVhZGVy c0F0dHIpOworICAgIGZvciAoYXV0byYgZWxlbWVudCA6IGVsZW1lbnRzKSB7CisgICAgICAgIEFj Y2Vzc2liaWxpdHlPYmplY3QqIG9iamVjdCA9IGNhY2hlLT5nZXRPckNyZWF0ZShlbGVtZW50KTsK KyAgICAgICAgaWYgKG9iamVjdCkKKyAgICAgICAgICAgIGhlYWRlcnMuYXBwZW5kKG9iamVjdCk7 CisgICAgfQorICAgIAorICAgIC8vIElmIHRoZSBoZWFkZXJzIGF0dHJpYnV0ZSByZXR1cm5lZCB2 YWxpZCB2YWx1ZXMsIHRoZW4gZG8gbm90IGZ1cnRoZXIgc2VhcmNoIGZvciBjb2x1bW4gaGVhZGVy cy4KKyAgICBpZiAoaGVhZGVycy5zaXplKCkpCisgICAgICAgIHJldHVybjsKKyAgICAKICAgICBz dGQ6OnBhaXI8dW5zaWduZWQsIHVuc2lnbmVkPiByb3dSYW5nZTsKICAgICByb3dJbmRleFJhbmdl KHJvd1JhbmdlKTsKICAgICAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MzMxNykKKysrIExheW91dFRl c3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAyLTAz ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFdl YktpdCBzaG91bGQgc3VwcG9ydCBAaGVhZGVycy9AaWQgZm9yIGNvbXBsZXggYWNjZXNzaWJsZSB3 ZWIgdGFibGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMjgxMTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3RhYmxlLWhlYWRlcnMtYXR0cmlidXRlLWV4 cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkv dGFibGUtaGVhZGVycy1hdHRyaWJ1dGUuaHRtbDogQWRkZWQuCisKIDIwMTQtMDItMDMgIEplc3Np ZSBCZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZlcnQgcjE2MzI5OSBz aW5jZSBpdCBicm9rZSB0aGUgTUwgMzItYml0IFJlbGVhc2UgYnVpbGQKSW5kZXg6IExheW91dFRl c3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3RhYmxlLWhlYWRlcnMtYXR0cmlidXRlLWV4 cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNz aWJpbGl0eS90YWJsZS1oZWFkZXJzLWF0dHJpYnV0ZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS90YWJsZS1oZWFkZXJz LWF0dHJpYnV0ZS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxOCBAQAor Q291cnNlIE5hbWUJQ291cnNlIFR1dG9yCVN1bW1hcnkJQ29kZQlGZWUKK0FmdGVyIHRoZSBDaXZp bCBXYXIJRHIuIEpvaG4gV3JvdWdodG9uCU9jdG9iZXIJSDI3CcOCwqMzMgnDgsKjMzIKK1RoaXMg dGVzdHMgdGhhdCB0aGUgaGVhZGVycyBhdHRyaWJ1dGUgcmV0dXJucyB0aGUgY29ycmVjdCBoZWFk ZXJzIGZvciBhIHRhYmxlIGNlbGwuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmll cyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQ QVNTIGNvbEhlYWRlcnMubGVuZ3RoIGlzIDMKK1BBU1MgY29sSGVhZGVyc1swXS5pc0VxdWFsKHRh YmxlLmNlbGxGb3JDb2x1bW5BbmRSb3coMCwgMCkpIGlzIHRydWUKK1BBU1MgY29sSGVhZGVyc1sx XS5pc0VxdWFsKHRhYmxlLmNlbGxGb3JDb2x1bW5BbmRSb3coMiwgMCkpIGlzIHRydWUKK1BBU1Mg Y29sSGVhZGVyc1syXS5pc0VxdWFsKHRhYmxlLmNlbGxGb3JDb2x1bW5BbmRSb3coNCwgMCkpIGlz IHRydWUKK1BBU1MgY29sSGVhZGVycy5sZW5ndGggaXMgMgorUEFTUyBjb2xIZWFkZXJzWzBdLmlz RXF1YWwodGFibGUuY2VsbEZvckNvbHVtbkFuZFJvdygzLCAwKSkgaXMgdHJ1ZQorUEFTUyBjb2xI ZWFkZXJzWzFdLmlzRXF1YWwodGFibGUuY2VsbEZvckNvbHVtbkFuZFJvdygyLCAwKSkgaXMgdHJ1 ZQorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5k ZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3RhYmxlLWhlYWRlcnMt YXR0cmlidXRlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Fj Y2Vzc2liaWxpdHkvdGFibGUtaGVhZGVycy1hdHRyaWJ1dGUuaHRtbAkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3RhYmxlLWhlYWRlcnMtYXR0 cmlidXRlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw1OSBAQAorPCFET0NUWVBFIEhU TUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxzY3Jp cHQgc3JjPSIuLi8uLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9o ZWFkPgorPGJvZHkgaWQ9ImJvZHkiPgorCis8dGFibGUgYm9yZGVyPSIxIiBjZWxscGFkZGluZz0i NSIgY2VsbHNwYWNpbmc9IjIiIGlkPSJ0YWJsZSI+CisgIDx0Ym9keT4KKyAgPHRyPgorICAgIDx0 aCBpZD0iaGVhZGVyMSIgc2NvcGU9ImNvbCIgYWJicj0iTmFtZSI+Q291cnNlIE5hbWU8L3RoPgor ICAgIDx0aCBpZD0iaGVhZGVyMiIgc2NvcGU9ImNvbCIgYWJicj0iVHV0b3IiPkNvdXJzZSBUdXRv cjwvdGg+CisgICAgPHRoIGlkPSJoZWFkZXIzIiBzY29wZT0iY29sIj5TdW1tYXJ5PC90aD4KKyAg ICA8dGggaWQ9ImhlYWRlcjQiIHNjb3BlPSJjb2wiPkNvZGU8L3RoPgorICAgIDx0aCBpZD0iaGVh ZGVyNSIgc2NvcGU9ImNvbCIgY29sc3Bhbj0iMiI+RmVlPC90aD4KKyAgPC90cj4KKyAgPHRyPgor ICAgIDx0ZCBpZD0iY2VsbDEiIGhlYWRlcnM9ImhlYWRlcjEgaGVhZGVyMyBoZWFkZXI1Ij5BZnRl ciB0aGUgQ2l2aWwgV2FyPC90ZD4KKyAgICA8dGQgaWQ9ImNlbGwyIiBoZWFkZXJzPSJoZWFkZXI0 IGhlYWRlcjMgaGVhZGVyNiI+RHIuIEpvaG4gV3JvdWdodG9uPC90ZD4KKyAgICA8dGQ+T2N0b2Jl cjwvdGQ+CisgICAgPHRkPkgyNzwvdGQ+CisgICAgPHRkPsKjMzI8L3RkPgorICAgIDx0ZD7CozMy PC90ZD4KKyAgPC90cj4KKzwvdGJvZHk+PC90YWJsZT4KKworCis8cCBpZD0iZGVzY3JpcHRpb24i PjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorCis8c2NyaXB0PgorCisgICAgZGVzY3Jp cHRpb24oIlRoaXMgdGVzdHMgdGhhdCB0aGUgaGVhZGVycyBhdHRyaWJ1dGUgcmV0dXJucyB0aGUg Y29ycmVjdCBoZWFkZXJzIGZvciBhIHRhYmxlIGNlbGwuIik7CisKKyAgICBpZiAod2luZG93LmFj Y2Vzc2liaWxpdHlDb250cm9sbGVyKSB7CisKKyAgICAgICAgdmFyIHRhYmxlID0gYWNjZXNzaWJp bGl0eUNvbnRyb2xsZXIuYWNjZXNzaWJsZUVsZW1lbnRCeUlkKCJ0YWJsZSIpOworCisgICAgICAg IC8vIFRoZSBmaXJzdCBjZWxsIHJlZmVyZW5jZXMgaGVhZGVyMSBoZWFkZXIzIGhlYWRlcjUuCisg ICAgICAgIHZhciBjZWxsMSA9IHRhYmxlLmNlbGxGb3JDb2x1bW5BbmRSb3coMCwgMSk7CisgICAg ICAgIHZhciBjb2xIZWFkZXJzID0gY2VsbDEuY29sdW1uSGVhZGVycygpOworICAgICAgICBzaG91 bGRCZSgiY29sSGVhZGVycy5sZW5ndGgiLCAiMyIpOworICAgICAgICBzaG91bGRCZVRydWUoImNv bEhlYWRlcnNbMF0uaXNFcXVhbCh0YWJsZS5jZWxsRm9yQ29sdW1uQW5kUm93KDAsIDApKSIpOwor ICAgICAgICBzaG91bGRCZVRydWUoImNvbEhlYWRlcnNbMV0uaXNFcXVhbCh0YWJsZS5jZWxsRm9y Q29sdW1uQW5kUm93KDIsIDApKSIpOworICAgICAgICBzaG91bGRCZVRydWUoImNvbEhlYWRlcnNb Ml0uaXNFcXVhbCh0YWJsZS5jZWxsRm9yQ29sdW1uQW5kUm93KDQsIDApKSIpOworCisgICAgICAg IC8vIFRoZSBzZWNvbmQgY2VsbCByZWZlcmVuY2VzIGhlYWRlcjQgaGVhZGVyMyBhbmQgYSBub24t ZXhpc3RlbnQgaGVhZGVyNi4KKyAgICAgICAgdmFyIGNlbGwyID0gdGFibGUuY2VsbEZvckNvbHVt bkFuZFJvdygxLCAxKTsKKyAgICAgICAgdmFyIGNvbEhlYWRlcnMgPSBjZWxsMi5jb2x1bW5IZWFk ZXJzKCk7CisgICAgICAgIHNob3VsZEJlKCJjb2xIZWFkZXJzLmxlbmd0aCIsICIyIik7CisgICAg ICAgIHNob3VsZEJlVHJ1ZSgiY29sSGVhZGVyc1swXS5pc0VxdWFsKHRhYmxlLmNlbGxGb3JDb2x1 bW5BbmRSb3coMywgMCkpIik7CisgICAgICAgIHNob3VsZEJlVHJ1ZSgiY29sSGVhZGVyc1sxXS5p c0VxdWFsKHRhYmxlLmNlbGxGb3JDb2x1bW5BbmRSb3coMiwgMCkpIik7CisgICAgfQorCis8L3Nj cmlwdD4KKworPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMi Pjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=