128112 2014-02-03 10:53:31 -0800 Debugger created JSActivations should account for CodeBlock::framePointerOffsetToGetActivationRegisters() 2014-02-03 13:22:00 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 128120 1 mark.lam mark.lam commit-queue fpizlo ggaren mhahnenberg msaboff oliver oldest_to_newest 975931 0 mark.lam 2014-02-03 10:53:31 -0800 They currently do not. Fix coming. 975942 1 223002 mark.lam 2014-02-03 11:26:14 -0800 Created attachment 223002 fixed in JSActivation::create(). 975962 2 223002 ggaren 2014-02-03 12:25:19 -0800 Comment on attachment 223002 fixed in JSActivation::create(). This needs a regression test. 975976 3 223002 commit-queue 2014-02-03 12:54:55 -0800 Comment on attachment 223002 fixed in JSActivation::create(). Clearing flags on attachment: 223002 Committed r163322: <http://trac.webkit.org/changeset/163322> 975977 4 commit-queue 2014-02-03 12:54:57 -0800 All reviewed patches have been landed. Closing bug. 975990 5 mark.lam 2014-02-03 13:22:00 -0800 (In reply to comment #2) > This needs a regression test. Will work on regression test at https://bugs.webkit.org/show_bug.cgi?id=128120. 223002 2014-02-03 11:26:14 -0800 2014-02-03 12:54:55 -0800 fixed in JSActivation::create(). bug-128112.patch text/plain 2131 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYzMzE1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBA CisyMDE0LTAyLTAzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBE ZWJ1Z2dlciBjcmVhdGVkIEpTQWN0aXZhdGlvbnMgc2hvdWxkIGFjY291bnQgZm9yIENvZGVCbG9j azo6ZnJhbWVQb2ludGVyT2Zmc2V0VG9HZXRBY3RpdmF0aW9uUmVnaXN0ZXJzKCkuCisgICAgICAg IDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjgxMTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudGx5LCB3aGVuIHRoZSBEZWJ1Z2dlckNhbGxG cmFtZSBjcmVhdGVzIHRoZSBKU0FjdGl2YXRpb24gb2JqZWN0CisgICAgICAgIGZvciBhIGZyYW1l LCBpdCBkb2VzIG5vdCBhY2NvdW50IGZvciB0aGUgZnJhbWVQb2ludGVyT2Zmc2V0VG9HZXRBY3Rp dmF0aW9uUmVnaXN0ZXJzKCkKKyAgICAgICAgb2Zmc2V0IHRoYXQgbmVlZHMgdG8gYmUgYWRkZWQg Zm9yIERGRyBmcmFtZXMuCisKKyAgICAgICAgSW5zdGVhZCBvZiBzcGVjaWFsIGNhc2luZyB0aGUg Zml4IGluIERlYnVnZ2VyQ2FsbEZyYW1lOjpzY29wZSgpLCB3ZSBmaXgKKyAgICAgICAgdGhpcyBi eSBhZGRpbmcgQ29kZUJsb2NrOjpmcmFtZVBvaW50ZXJPZmZzZXRUb0dldEFjdGl2YXRpb25SZWdp c3RlcnMoKSB0bworICAgICAgICBjYWxsRnJhbWUtPnJlZ2lzdGVycygpIGluIHRoZSBKU0FjdGl2 YXRpb246OmNyZWF0ZSgpIG1ldGhvZCB0aGF0IGRvZXMgbm90CisgICAgICAgIGV4cGxpY2l0bHkg dGFrZSBhIFJlZ2lzdGVyKi4gVGhpcyBlbnN1cmVzIHRoYXQgSlNBY3RpdmF0aW9uOjpjcmVhdGUo KSB3aWxsCisgICAgICAgIGFsd2F5cyBkbyB0aGUgcmlnaHQgdGhpbmcgaW5zdGVhZCBvZiBvbmx5 IGJlaW5nIGEgc3BlY2lhbCBjYXNlIGZvciB0aGUKKyAgICAgICAgTExJTlQgYW5kIGJhc2VsaW5l SklULgorCisgICAgICAgIEFwYXJ0IGZyb20gdGhlIERlYnVnZ2VyQ2FsbEZyYW1lLCB0aGlzIGNy ZWF0ZSgpIGZ1bmN0aW9uIGlzIG9ubHkgY2FsbGVkIGJ5CisgICAgICAgIHNsb3cgcGF0aHMgaW4g dGhlIExMSU5UIGFuZCBiYXNlbGluZUpJVC4gSGVuY2UsIGl0IGlzIG5vdCBwZXJmb3JtYW5jZQor ICAgICAgICBjcml0aWNhbC4KKworICAgICAgICAqIHJ1bnRpbWUvSlNBY3RpdmF0aW9uLmg6Cisg ICAgICAgIChKU0M6OkpTQWN0aXZhdGlvbjo6Y3JlYXRlKToKKwogMjAxNC0wMS0yNSAgRGFyaW4g QWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgU3RvcCB1c2luZyBVbmljb2RlLmgK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQWN0aXZhdGlvbi5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQWN0aXZhdGlvbi5oCShy ZXZpc2lvbiAxNjMzMTQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FjdGl2 YXRpb24uaAkod29ya2luZyBjb3B5KQpAQCAtNjMsNyArNjMsNyBAQCBwdWJsaWM6CiAgICAgICAg IAogICAgIHN0YXRpYyBKU0FjdGl2YXRpb24qIGNyZWF0ZShWTSYgdm0sIENhbGxGcmFtZSogY2Fs bEZyYW1lLCBDb2RlQmxvY2sqIGNvZGVCbG9jaykKICAgICB7Ci0gICAgICAgIHJldHVybiBjcmVh dGUodm0sIGNhbGxGcmFtZSwgY2FsbEZyYW1lLT5yZWdpc3RlcnMoKSwgY29kZUJsb2NrKTsKKyAg ICAgICAgcmV0dXJuIGNyZWF0ZSh2bSwgY2FsbEZyYW1lLCBjYWxsRnJhbWUtPnJlZ2lzdGVycygp ICsgY29kZUJsb2NrLT5mcmFtZVBvaW50ZXJPZmZzZXRUb0dldEFjdGl2YXRpb25SZWdpc3RlcnMo KSwgY29kZUJsb2NrKTsKICAgICB9CiAKICAgICBzdGF0aWMgdm9pZCB2aXNpdENoaWxkcmVuKEpT Q2VsbCosIFNsb3RWaXNpdG9yJik7Cg==