128107 2014-02-03 10:28:07 -0800 CTTE: RenderSVGGradientStop always has a SVGStopElement. 2014-02-03 12:21:20 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue d-r esprehn+autocc fmalita glenn gyuyoung.kim kling kondapallykalyan pdr schenney oldest_to_newest 975915 0 kling 2014-02-03 10:28:07 -0800 CTTE: RenderSVGGradientStop always has a SVGStopElement. 975916 1 222997 kling 2014-02-03 10:28:40 -0800 Created attachment 222997 Patch 975948 2 222997 darin 2014-02-03 11:49:11 -0800 Comment on attachment 222997 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222997&action=review > Source/WebCore/rendering/svg/RenderSVGGradientStop.h:39 > + SVGStopElement& element() const { return static_cast<SVGStopElement&>(RenderObject::nodeForNonAnonymous()); } Why can’t this use toSVGStopElement? 975960 3 kling 2014-02-03 12:21:20 -0800 Committed r163319: <http://trac.webkit.org/changeset/163319> 222997 2014-02-03 10:28:40 -0800 2014-02-03 11:49:11 -0800 Patch bug-128107.diff text/plain 6416 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhYWZjMWFlLi43NDE1NmM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjUg QEAKIDIwMTQtMDItMDMgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIENUVEU6IFJlbmRlclNWR0dyYWRpZW50U3RvcCBhbHdheXMgaGFzIGEgU1ZHU3RvcEVsZW1l bnQuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjgxMDc+CisKKyAgICAgICAgUmVu ZGVyU1ZHR3JhZGllbnRTdG9wIGlzIG5ldmVyIGFub255bW91cyBhbmQgYWx3YXlzIGhhcyBhCisg ICAgICAgIGNvcnJlc3BvbmRpbmcgU1ZHU3RvcEVsZW1lbnQuIENvZGlmeSB0aGlzIGJ5IGFkZGlu ZyBhbiBlbGVtZW50KCkKKyAgICAgICAgb3ZlcmxvYWQgdGhhdCByZXR1cm5zIGFuIFNWR1N0b3BF bGVtZW50Ji4KKworICAgICAgICBBbHNvIGFkZGVkIG1pc3Npbmcgb3ZlcnJpZGVzIGFuZCBtYWRl IG1vc3QgZnVuY3Rpb25zIHByaXZhdGUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvc3ZnL1JlbmRlclNWR0dyYWRpZW50U3RvcC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJTVkdHcmFkaWVudFN0b3A6OnN0eWxlRGlkQ2hh bmdlKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclNWR0dyYWRpZW50U3RvcDo6Z3JhZGllbnRF bGVtZW50KToKKyAgICAgICAgKiByZW5kZXJpbmcvc3ZnL1JlbmRlclNWR0dyYWRpZW50U3RvcC5o OgorICAgICAgICAqIHJlbmRlcmluZy9zdmcvU1ZHUmVuZGVyVHJlZUFzVGV4dC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjp3cml0ZVNWR0dyYWRpZW50U3RvcCk6CisKKzIwMTQtMDItMDMgIEFuZHJl YXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCiAgICAgICAgIENUVEU6IEdyYWIgYmFnIG9m IFNWR1JlbmRlclRyZWVBc1RleHQgY2xlYW51cHMuCiAgICAgICAgIDxodHRwczovL3dlYmtpdC5v cmcvYi8xMjgwOTk+CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcv UmVuZGVyU1ZHR3JhZGllbnRTdG9wLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcv UmVuZGVyU1ZHR3JhZGllbnRTdG9wLmNwcAppbmRleCBiYzg1MmNiLi45MDcwNzU0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR0dyYWRpZW50U3RvcC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdHcmFkaWVudFN0 b3AuY3BwCkBAIC01MCw3ICs1MCw3IEBAIHZvaWQgUmVuZGVyU1ZHR3JhZGllbnRTdG9wOjpzdHls ZURpZENoYW5nZShTdHlsZURpZmZlcmVuY2UgZGlmZiwgY29uc3QgUmVuZGVyU3R5CiAKICAgICAv LyA8c3RvcD4gZWxlbWVudHMgc2hvdWxkIG9ubHkgYmUgYWxsb3dlZCB0byBtYWtlIHJlbmRlcmVy cyB1bmRlciBncmFkaWVudCBlbGVtZW50cwogICAgIC8vIGJ1dCBJIGNhbiBpbWFnaW5lIGEgZmV3 IGNhc2VzIHdlIG1pZ2h0IG5vdCBiZSBjYXRjaGluZywgc28gbGV0J3Mgbm90IGNyYXNoIGlmIG91 ciBwYXJlbnQgaXNuJ3QgYSBncmFkaWVudC4KLSAgICBTVkdHcmFkaWVudEVsZW1lbnQqIGdyYWRp ZW50ID0gZ3JhZGllbnRFbGVtZW50KCk7CisgICAgY29uc3QgYXV0byogZ3JhZGllbnQgPSBncmFk aWVudEVsZW1lbnQoKTsKICAgICBpZiAoIWdyYWRpZW50KQogICAgICAgICByZXR1cm47CiAKQEAg LTY3LDEyICs2NywxMSBAQCB2b2lkIFJlbmRlclNWR0dyYWRpZW50U3RvcDo6bGF5b3V0KCkKICAg ICBjbGVhck5lZWRzTGF5b3V0KCk7CiB9CiAKLVNWR0dyYWRpZW50RWxlbWVudCogUmVuZGVyU1ZH R3JhZGllbnRTdG9wOjpncmFkaWVudEVsZW1lbnQoKSBjb25zdAorU1ZHR3JhZGllbnRFbGVtZW50 KiBSZW5kZXJTVkdHcmFkaWVudFN0b3A6OmdyYWRpZW50RWxlbWVudCgpCiB7Ci0gICAgQ29udGFp bmVyTm9kZSogcGFyZW50Tm9kZSA9IGVsZW1lbnQoKS0+cGFyZW50Tm9kZSgpOwotICAgIGlmIChw YXJlbnROb2RlLT5oYXNUYWdOYW1lKGxpbmVhckdyYWRpZW50VGFnKSB8fCBwYXJlbnROb2RlLT5o YXNUYWdOYW1lKHJhZGlhbEdyYWRpZW50VGFnKSkKLSAgICAgICAgcmV0dXJuIHRvU1ZHR3JhZGll bnRFbGVtZW50KHBhcmVudE5vZGUpOwotICAgIHJldHVybiAwOworICAgIGlmIChlbGVtZW50KCku cGFyZW50RWxlbWVudCgpICYmIGlzU1ZHR3JhZGllbnRFbGVtZW50KCplbGVtZW50KCkucGFyZW50 RWxlbWVudCgpKSkKKyAgICAgICAgcmV0dXJuICZ0b1NWR0dyYWRpZW50RWxlbWVudCgqZWxlbWVu dCgpLnBhcmVudEVsZW1lbnQoKSk7CisgICAgcmV0dXJuIG51bGxwdHI7CiB9CiAKIH0KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHR3JhZGllbnRTdG9w LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR0dyYWRpZW50U3RvcC5o CmluZGV4IDk0MjhiYjguLjYxYjNlNmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9zdmcvUmVuZGVyU1ZHR3JhZGllbnRTdG9wLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3N2Zy9SZW5kZXJTVkdHcmFkaWVudFN0b3AuaApAQCAtMSw2ICsxLDcgQEAKIC8qCiAg KiBDb3B5cmlnaHQgKEMpIDIwMDcgRXJpYyBTZWlkZWwgPGVyaWNAd2Via2l0Lm9yZz4KICAqIENv cHlyaWdodCAoQykgMjAwOSBHb29nbGUsIEluYy4KKyAqIENvcHlyaWdodCAoQykgMjAxNCBBcHBs ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogVGhpcyBsaWJyYXJ5IGlzIGZyZWUg c29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgogICogbW9kaWZ5IGl0IHVu ZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMKQEAgLTIzLDEx ICsyNCwxMSBAQAogCiAjaWYgRU5BQkxFKFNWRykKICNpbmNsdWRlICJSZW5kZXJFbGVtZW50Lmgi CisjaW5jbHVkZSAiU1ZHU3RvcEVsZW1lbnQuaCIKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogICAg IAogY2xhc3MgU1ZHR3JhZGllbnRFbGVtZW50OwotY2xhc3MgU1ZHU3RvcEVsZW1lbnQ7CiAKIC8v IFRoaXMgY2xhc3MgZXhpc3RzIG1vc3RseSBzbyB3ZSBjYW4gaGVhciBhYm91dCBncmFkaWVudCBz dG9wIHN0eWxlIGNoYW5nZXMKIGNsYXNzIFJlbmRlclNWR0dyYWRpZW50U3RvcCBmaW5hbCA6IHB1 YmxpYyBSZW5kZXJFbGVtZW50IHsKQEAgLTM1LDI4ICszNiwyOSBAQCBwdWJsaWM6CiAgICAgUmVu ZGVyU1ZHR3JhZGllbnRTdG9wKFNWR1N0b3BFbGVtZW50JiwgUGFzc1JlZjxSZW5kZXJTdHlsZT4p OwogICAgIHZpcnR1YWwgflJlbmRlclNWR0dyYWRpZW50U3RvcCgpOwogCi0gICAgdmlydHVhbCBi b29sIGlzU1ZHR3JhZGllbnRTdG9wKCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQotICAgIHZpcnR1 YWwgY29uc3QgY2hhciogcmVuZGVyTmFtZSgpIGNvbnN0IHsgcmV0dXJuICJSZW5kZXJTVkdHcmFk aWVudFN0b3AiOyB9CisgICAgU1ZHU3RvcEVsZW1lbnQmIGVsZW1lbnQoKSBjb25zdCB7IHJldHVy biBzdGF0aWNfY2FzdDxTVkdTdG9wRWxlbWVudCY+KFJlbmRlck9iamVjdDo6bm9kZUZvck5vbkFu b255bW91cygpKTsgfQogCi0gICAgdmlydHVhbCB2b2lkIGxheW91dCgpOworcHJpdmF0ZToKKyAg ICB2aXJ0dWFsIHZvaWQgc3R5bGVEaWRDaGFuZ2UoU3R5bGVEaWZmZXJlbmNlLCBjb25zdCBSZW5k ZXJTdHlsZSogb2xkU3R5bGUpIG92ZXJyaWRlOworCisgICAgdmlydHVhbCB2b2lkIGxheW91dCgp IG92ZXJyaWRlOwogCi0gICAgLy8gVGhpcyBvdmVycmlkZXMgYXJlIG5lZWRlZCB0byBwcmV2ZW50 IEFTU0VSVHMgb24gPHN2Zz48c3RvcCAvPjwvc3ZnPgorICAgIC8vIFRoZXNlIG92ZXJyaWRlcyBh cmUgbmVlZGVkIHRvIHByZXZlbnQgQVNTRVJUcyBvbiA8c3ZnPjxzdG9wIC8+PC9zdmc+CiAgICAg Ly8gUmVuZGVyT2JqZWN0J3MgZGVmYXVsdCBpbXBsZW1lbnRhdGlvbnMgQVNTRVJUX05PVF9SRUFD SEVEKCkKICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA0 MDAKICAgICB2aXJ0dWFsIExheW91dFJlY3QgY2xpcHBlZE92ZXJmbG93UmVjdEZvclJlcGFpbnQo Y29uc3QgUmVuZGVyTGF5ZXJNb2RlbE9iamVjdCopIGNvbnN0IG92ZXJyaWRlIHsgcmV0dXJuIExh eW91dFJlY3QoKTsgfQotICAgIHZpcnR1YWwgRmxvYXRSZWN0IG9iamVjdEJvdW5kaW5nQm94KCkg Y29uc3QgeyByZXR1cm4gRmxvYXRSZWN0KCk7IH0KLSAgICB2aXJ0dWFsIEZsb2F0UmVjdCBzdHJv a2VCb3VuZGluZ0JveCgpIGNvbnN0IHsgcmV0dXJuIEZsb2F0UmVjdCgpOyB9Ci0gICAgdmlydHVh bCBGbG9hdFJlY3QgcmVwYWludFJlY3RJbkxvY2FsQ29vcmRpbmF0ZXMoKSBjb25zdCB7IHJldHVy biBGbG9hdFJlY3QoKTsgfQorICAgIHZpcnR1YWwgRmxvYXRSZWN0IG9iamVjdEJvdW5kaW5nQm94 KCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gRmxvYXRSZWN0KCk7IH0KKyAgICB2aXJ0dWFsIEZs b2F0UmVjdCBzdHJva2VCb3VuZGluZ0JveCgpIGNvbnN0IG92ZXJyaWRlIHsgcmV0dXJuIEZsb2F0 UmVjdCgpOyB9CisgICAgdmlydHVhbCBGbG9hdFJlY3QgcmVwYWludFJlY3RJbkxvY2FsQ29vcmRp bmF0ZXMoKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiBGbG9hdFJlY3QoKTsgfQogICAgIHZpcnR1 YWwgYm9vbCBub2RlQXRGbG9hdFBvaW50KGNvbnN0IEhpdFRlc3RSZXF1ZXN0JiwgSGl0VGVzdFJl c3VsdCYsIGNvbnN0IEZsb2F0UG9pbnQmLCBIaXRUZXN0QWN0aW9uKSBvdmVycmlkZSB7IHJldHVy biBmYWxzZTsgfQogCi1wcm90ZWN0ZWQ6Ci0gICAgdmlydHVhbCB2b2lkIHN0eWxlRGlkQ2hhbmdl KFN0eWxlRGlmZmVyZW5jZSwgY29uc3QgUmVuZGVyU3R5bGUqIG9sZFN0eWxlKTsKKyAgICB2aXJ0 dWFsIGJvb2wgaXNTVkdHcmFkaWVudFN0b3AoKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiB0cnVl OyB9CisgICAgdmlydHVhbCBjb25zdCBjaGFyKiByZW5kZXJOYW1lKCkgY29uc3Qgb3ZlcnJpZGUg eyByZXR1cm4gIlJlbmRlclNWR0dyYWRpZW50U3RvcCI7IH0KIAotcHJpdmF0ZToKICAgICB2aXJ0 dWFsIGJvb2wgY2FuSGF2ZUNoaWxkcmVuKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gZmFsc2U7 IH0KLSAgICB2aXJ0dWFsIHZvaWQgcGFpbnQoUGFpbnRJbmZvJiwgY29uc3QgTGF5b3V0UG9pbnQm KSBvdmVycmlkZSBmaW5hbCB7IH0KKyAgICB2aXJ0dWFsIHZvaWQgcGFpbnQoUGFpbnRJbmZvJiwg Y29uc3QgTGF5b3V0UG9pbnQmKSBvdmVycmlkZSB7IH0KIAotICAgIFNWR0dyYWRpZW50RWxlbWVu dCogZ3JhZGllbnRFbGVtZW50KCkgY29uc3Q7CisgICAgU1ZHR3JhZGllbnRFbGVtZW50KiBncmFk aWVudEVsZW1lbnQoKTsKIH07CiAKIFJFTkRFUl9PQkpFQ1RfVFlQRV9DQVNUUyhSZW5kZXJTVkdH cmFkaWVudFN0b3AsIGlzU1ZHR3JhZGllbnRTdG9wKCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvc3ZnL1NWR1JlbmRlclRyZWVBc1RleHQuY3BwIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL3N2Zy9TVkdSZW5kZXJUcmVlQXNUZXh0LmNwcAppbmRleCA3Yzg2ZDc5Li45 M2E5ODBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR1JlbmRl clRyZWVBc1RleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHUmVu ZGVyVHJlZUFzVGV4dC5jcHAKQEAgLTYwOCwxMCArNjA4LDcgQEAgdm9pZCB3cml0ZVNWR0dyYWRp ZW50U3RvcChUZXh0U3RyZWFtJiB0cywgY29uc3QgUmVuZGVyU1ZHR3JhZGllbnRTdG9wJiBzdG9w LCBpbnQKIHsKICAgICB3cml0ZVN0YW5kYXJkUHJlZml4KHRzLCBzdG9wLCBpbmRlbnQpOwogCi0g ICAgU1ZHU3RvcEVsZW1lbnQqIHN0b3BFbGVtZW50ID0gdG9TVkdTdG9wRWxlbWVudCh0b1NWR0Vs ZW1lbnQoc3RvcC5lbGVtZW50KCkpKTsKLSAgICBBU1NFUlQoc3RvcEVsZW1lbnQpOwotCi0gICAg dHMgPDwgIiBbb2Zmc2V0PSIgPDwgc3RvcEVsZW1lbnQtPm9mZnNldCgpIDw8ICJdIFtjb2xvcj0i IDw8IHN0b3BFbGVtZW50LT5zdG9wQ29sb3JJbmNsdWRpbmdPcGFjaXR5KCkgPDwgIl1cbiI7Cisg ICAgdHMgPDwgIiBbb2Zmc2V0PSIgPDwgc3RvcC5lbGVtZW50KCkub2Zmc2V0KCkgPDwgIl0gW2Nv bG9yPSIgPDwgc3RvcC5lbGVtZW50KCkuc3RvcENvbG9ySW5jbHVkaW5nT3BhY2l0eSgpIDw8ICJd XG4iOwogfQogCiB2b2lkIHdyaXRlUmVzb3VyY2VzKFRleHRTdHJlYW0mIHRzLCBjb25zdCBSZW5k ZXJPYmplY3QmIHJlbmRlcmVyLCBpbnQgaW5kZW50KQo=