128102 2014-02-03 04:47:42 -0800 [Cairo] GraphicsContext::m_pixelSnappingFactor is uninitialized 2014-02-03 17:02:22 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hs85.jeong webkit-unassigned commit-queue d-r gyuyoung.kim lucas.de.marchi ossy zalan zan oldest_to_newest 975835 0 hs85.jeong 2014-02-03 04:47:42 -0800 GraphicsContext::m_pixelSnappingFactor is uninitialized. 975839 1 222976 hs85.jeong 2014-02-03 05:08:13 -0800 Created attachment 222976 Patch 975859 2 222976 ryuan.choi 2014-02-03 07:31:42 -0800 Comment on attachment 222976 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222976&action=review > Source/WebCore/ChangeLog:3 > + [EFL/Cairo] GraphicsContext::m_pixelSnappingFactor is uninitialized It is introduced since r163265 but it looks ommitted GraphicsContextCairo.cpp Nit, [Cairo] Looks enough because it is used by cairo based ports including GTK, EFL. 975873 3 zan 2014-02-03 08:38:37 -0800 *** Bug 128105 has been marked as a duplicate of this bug. *** 975874 4 zalan 2014-02-03 08:50:14 -0800 Looks correct to me. Sorry for the trouble, I didn't see cairo's extra ctor. 975875 5 222976 ossy 2014-02-03 08:52:42 -0800 Comment on attachment 222976 Patch r=me with comment fix mentioned by Ryuan. Please fix it before landing. 976041 6 223026 hs85.jeong 2014-02-03 15:00:48 -0800 Created attachment 223026 Patch for landing 976045 7 223026 jinwoo7.song 2014-02-03 15:05:40 -0800 Comment on attachment 223026 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=223026&action=review > Source/WebCore/ChangeLog:11 > + (WebCore::GraphicsContext::GraphicsContext): Initalized pixelSnappingFactor to 1 and Typo: s/Initalized/Initialized. 'Formatted to match the WebKit coding style' should be 'fixed the coding style violation'. 976054 8 223029 hs85.jeong 2014-02-03 15:23:37 -0800 Created attachment 223029 Patch 976118 9 223029 commit-queue 2014-02-03 17:02:15 -0800 Comment on attachment 223029 Patch Clearing flags on attachment: 223029 Committed r163348: <http://trac.webkit.org/changeset/163348> 976119 10 commit-queue 2014-02-03 17:02:22 -0800 All reviewed patches have been landed. Closing bug. 222976 2014-02-03 05:08:13 -0800 2014-02-03 15:00:38 -0800 Patch bug-128102-20140203220813.patch text/plain 1682 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMjk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzk4YWFkYWE1M2U0YTY0 MjFlZWU4NmE0ZTkxOWUzNTNhOTNmMzQzMi4uNGIzNTRjZWVlNjJjZTRkNTFjYWQwMWVmOGYyODI1 YzRjZjExNGE0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAyLTAzICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZML0NhaXJv XSBHcmFwaGljc0NvbnRleHQ6Om1fcGl4ZWxTbmFwcGluZ0ZhY3RvciBpcyB1bmluaXRpYWxpemVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjgxMDIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbml0YWxp emUgbV9waXhlbFNuYXBwaW5nRmFjdG9yIHRvIDEKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okdy YXBoaWNzQ29udGV4dDo6R3JhcGhpY3NDb250ZXh0KTogSW5pdGFsaXplZCBwaXhlbFNuYXBwaW5n RmFjdG9yIHRvIDEgYW5kIAorICAgICAgICBGb3JtYXR0ZWQgdG8gbWF0Y2ggdGhlIFdlYktpdCBj b2Rpbmcgc3R5bGUKKwogMjAxNC0wMi0wMiAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUu Y29tPgogCiAgICAgICAgIEFkb3B0IFVSTFV0aWxzIGludGVyZmFjZSBhbmQgdGVtcGxhdGUgaW4g SFRNTEFuY2hvckVsZW1lbnQgYW5kIEhUTUxBcmVhRWxlbWVudApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0 Q2Fpcm8uY3BwCmluZGV4IGI0YTliYWI0NGZlMWIyZDJhYTJlZDdmMDg5Mjg4M2RiNDY5NjRmN2Eu LmI1MTFkYjUzNGIwZjcxYjE5NDdhOTY1ZTE1Zjc4ODQyMGU0NDAyOWIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJv LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGlj c0NvbnRleHRDYWlyby5jcHAKQEAgLTE3NSw4ICsxNzUsOSBAQCBzdGF0aWMgaW5saW5lIHZvaWQg c2hhZG93QW5kU3Ryb2tlQ3VycmVudENhaXJvUGF0aChHcmFwaGljc0NvbnRleHQqIGNvbnRleHQp CiB9CiAKIEdyYXBoaWNzQ29udGV4dDo6R3JhcGhpY3NDb250ZXh0KGNhaXJvX3QqIGNyKQotICAg IDogbV91cGRhdGluZ0NvbnRyb2xUaW50cyhmYWxzZSksCi0gICAgICBtX3RyYW5zcGFyZW5jeUNv dW50KDApCisgICAgOiBtX3VwZGF0aW5nQ29udHJvbFRpbnRzKGZhbHNlKQorICAgICwgbV90cmFu c3BhcmVuY3lDb3VudCgwKQorICAgICwgbV9waXhlbFNuYXBwaW5nRmFjdG9yKDEpCiB7CiAgICAg bV9kYXRhID0gbmV3IEdyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZVRvcGxldmVsKG5ldyBQ bGF0Zm9ybUNvbnRleHRDYWlybyhjcikpOwogfQo= 223026 2014-02-03 15:00:48 -0800 2014-02-03 15:23:25 -0800 Patch for landing bug-128102-20140204080048.patch text/plain 1682 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMjk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzk4YWFkYWE1M2U0YTY0 MjFlZWU4NmE0ZTkxOWUzNTNhOTNmMzQzMi4uYzczZDFjYTAwMWIyM2MyNjk5NDJkYjJiZjhkZmMy NjZjNzE0NDhiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAyLTAzICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbQ2Fpcm9dIEdy YXBoaWNzQ29udGV4dDo6bV9waXhlbFNuYXBwaW5nRmFjdG9yIGlzIHVuaW5pdGlhbGl6ZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODEwMgorCisg ICAgICAgIFJldmlld2VkIGJ5IENzYWJhIE9zenRyb2dvbsOhYy4KKworICAgICAgICBJbml0YWxp emUgbV9waXhlbFNuYXBwaW5nRmFjdG9yIHRvIDEKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okdy YXBoaWNzQ29udGV4dDo6R3JhcGhpY3NDb250ZXh0KTogSW5pdGFsaXplZCBwaXhlbFNuYXBwaW5n RmFjdG9yIHRvIDEgYW5kIAorICAgICAgICBGb3JtYXR0ZWQgdG8gbWF0Y2ggdGhlIFdlYktpdCBj b2Rpbmcgc3R5bGUKKwogMjAxNC0wMi0wMiAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUu Y29tPgogCiAgICAgICAgIEFkb3B0IFVSTFV0aWxzIGludGVyZmFjZSBhbmQgdGVtcGxhdGUgaW4g SFRNTEFuY2hvckVsZW1lbnQgYW5kIEhUTUxBcmVhRWxlbWVudApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0 Q2Fpcm8uY3BwCmluZGV4IGI0YTliYWI0NGZlMWIyZDJhYTJlZDdmMDg5Mjg4M2RiNDY5NjRmN2Eu LmI1MTFkYjUzNGIwZjcxYjE5NDdhOTY1ZTE1Zjc4ODQyMGU0NDAyOWIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJv LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGlj c0NvbnRleHRDYWlyby5jcHAKQEAgLTE3NSw4ICsxNzUsOSBAQCBzdGF0aWMgaW5saW5lIHZvaWQg c2hhZG93QW5kU3Ryb2tlQ3VycmVudENhaXJvUGF0aChHcmFwaGljc0NvbnRleHQqIGNvbnRleHQp CiB9CiAKIEdyYXBoaWNzQ29udGV4dDo6R3JhcGhpY3NDb250ZXh0KGNhaXJvX3QqIGNyKQotICAg IDogbV91cGRhdGluZ0NvbnRyb2xUaW50cyhmYWxzZSksCi0gICAgICBtX3RyYW5zcGFyZW5jeUNv dW50KDApCisgICAgOiBtX3VwZGF0aW5nQ29udHJvbFRpbnRzKGZhbHNlKQorICAgICwgbV90cmFu c3BhcmVuY3lDb3VudCgwKQorICAgICwgbV9waXhlbFNuYXBwaW5nRmFjdG9yKDEpCiB7CiAgICAg bV9kYXRhID0gbmV3IEdyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZVRvcGxldmVsKG5ldyBQ bGF0Zm9ybUNvbnRleHRDYWlybyhjcikpOwogfQo= 223029 2014-02-03 15:23:37 -0800 2014-02-03 17:02:14 -0800 Patch bug-128102-20140204082337.patch text/plain 1649 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMzMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjFlMDYwZTE0NTE1MTg1 ZWE2ZjkxODdkOTM5YWVlOTdlYjE2NGViYy4uMTAxYTJhMGRjNDFjZDhmZjAwZDAxNDg3MDA0NjBh NWY4MmRhYTFhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAyLTAzICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbQ2Fpcm9dIEdy YXBoaWNzQ29udGV4dDo6bV9waXhlbFNuYXBwaW5nRmFjdG9yIGlzIHVuaW5pdGlhbGl6ZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODEwMgorCisg ICAgICAgIFJldmlld2VkIGJ5IENzYWJhIE9zenRyb2dvbsOhYy4KKworICAgICAgICBJbml0YWxp emUgbV9waXhlbFNuYXBwaW5nRmFjdG9yIHRvIDEKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okdy YXBoaWNzQ29udGV4dDo6R3JhcGhpY3NDb250ZXh0KTogSW5pdGlhbGl6ZWQgcGl4ZWxTbmFwcGlu Z0ZhY3RvciB0byAxIGFuZCAKKyAgICAgICAgZml4ZWQgdGhlIGNvZGluZyBzdHlsZSB2aW9sYXRp b24uCisKIDIwMTQtMDItMDMgIFJhZHUgU3RhdmlsYSAgPHN0YXZpbGFAYWRvYmUuY29tPgogCiAg ICAgICAgIFJFR1JFU1NJT04gKHIxNjMwMTgpOiBDYW7igJl0IHNjcm9sbCBpbiA8c2VsZWN0PiBs aXN0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8v R3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3BwCmluZGV4IGI0YTliYWI0NGZlMWIyZDJh YTJlZDdmMDg5Mjg4M2RiNDY5NjRmN2EuLmI1MTFkYjUzNGIwZjcxYjE5NDdhOTY1ZTE1Zjc4ODQy MGU0NDAyOWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nh aXJvL0dyYXBoaWNzQ29udGV4dENhaXJvLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHAKQEAgLTE3NSw4ICsxNzUs OSBAQCBzdGF0aWMgaW5saW5lIHZvaWQgc2hhZG93QW5kU3Ryb2tlQ3VycmVudENhaXJvUGF0aChH cmFwaGljc0NvbnRleHQqIGNvbnRleHQpCiB9CiAKIEdyYXBoaWNzQ29udGV4dDo6R3JhcGhpY3ND b250ZXh0KGNhaXJvX3QqIGNyKQotICAgIDogbV91cGRhdGluZ0NvbnRyb2xUaW50cyhmYWxzZSks Ci0gICAgICBtX3RyYW5zcGFyZW5jeUNvdW50KDApCisgICAgOiBtX3VwZGF0aW5nQ29udHJvbFRp bnRzKGZhbHNlKQorICAgICwgbV90cmFuc3BhcmVuY3lDb3VudCgwKQorICAgICwgbV9waXhlbFNu YXBwaW5nRmFjdG9yKDEpCiB7CiAgICAgbV9kYXRhID0gbmV3IEdyYXBoaWNzQ29udGV4dFBsYXRm b3JtUHJpdmF0ZVRvcGxldmVsKG5ldyBQbGF0Zm9ybUNvbnRleHRDYWlybyhjcikpOwogfQo=