128095 2014-02-02 20:51:42 -0800 Fix context save/restore mistake spotted in SVGInlineTextBox::paintTextWithShadows 2014-02-02 22:13:28 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin commit-queue d-r esprehn+autocc fmalita glenn gyuyoung.kim kondapallykalyan pdr schenney zimmermann oldest_to_newest 974905 0 darin 2014-02-02 20:51:42 -0800 Fix context save/restore mistake spotted in SVGInlineTextBox::paintTextWithShadows 974906 1 222956 darin 2014-02-02 20:52:35 -0800 Created attachment 222956 Patch 974907 2 darin 2014-02-02 20:53:41 -0800 I spotted this obvious minor logic mistake while making some other changes to this function. This is the minimal change to fix it. I have no idea if the error causes actual symptoms, but it seems worth fixing. 974919 3 222956 kling 2014-02-02 21:45:54 -0800 Comment on attachment 222956 Patch Sure, r=me. Maybe someday we can RAII our way out of things like this. 974925 4 222956 commit-queue 2014-02-02 22:13:25 -0800 Comment on attachment 222956 Patch Clearing flags on attachment: 222956 Committed r163286: <http://trac.webkit.org/changeset/163286> 974926 5 commit-queue 2014-02-02 22:13:28 -0800 All reviewed patches have been landed. Closing bug. 222956 2014-02-02 20:52:35 -0800 2014-02-02 22:13:25 -0800 Patch bug-128095-20140202205235.patch text/plain 1801 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMjY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWQzMmVlMzk3ZTBjMmIz NWQ5YWIzOWNhZDk0NjczYjNkMjRmYmY4Ni4uODViMjUyNDM4MzJhYTc5ZTcyNTU5OTAwMDY4NWQz MzM1YWI0MjBhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAyLTAyICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggY29udGV4dCBzYXZlL3Jl c3RvcmUgbWlzdGFrZSBzcG90dGVkIGluIFNWR0lubGluZVRleHRCb3g6OnBhaW50VGV4dFdpdGhT aGFkb3dzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjgwOTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHJlbmRlcmluZy9zdmcvU1ZHSW5saW5lVGV4dEJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpT VkdJbmxpbmVUZXh0Qm94OjpwYWludFRleHRXaXRoU2hhZG93cyk6IE1vdmUgY2FsbHMgdG8gR3Jh cGhpY3NDb250ZXh0OjpyZXN0b3JlCisgICAgICAgIGFuZCBHcmFwaGljc0NvbnRleHQ6OmNsZWFy U2hhZG93IGJlZm9yZSByZXN0b3JlR3JhcGhpY3NDb250ZXh0QWZ0ZXJUZXh0UGFpbnRpbmcsIHNp bmNlIHRoYXQKKyAgICAgICAgZnVuY3Rpb24gY2FuIHN3YXAgY29udGV4dHMuCisKIDIwMTQtMDIt MDIgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIElEQjogU3Vw cG9ydCBJREJGYWN0b3J5LmRlbGV0ZURhdGFiYXNlKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9zdmcvU1ZHSW5saW5lVGV4dEJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvc3ZnL1NWR0lubGluZVRleHRCb3guY3BwCmluZGV4IGZiN2YyNjk4YWE5MzAzMmFm ZmFhZGYxM2FkYWViZjc5YjgyN2JiNGEuLjJiNjNlMmQyZjExOWNlMTc1YjA1NWYwMGZlYmUyZjE3 OTM1NzVkOTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHSW5s aW5lVGV4dEJveC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdJbmxp bmVUZXh0Qm94LmNwcApAQCAtNTgxLDE2ICs1ODEsMTggQEAgdm9pZCBTVkdJbmxpbmVUZXh0Qm94 OjpwYWludFRleHRXaXRoU2hhZG93cyhHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIFJlbmRlclN0 eWwKIAogICAgICAgICBjb250ZXh0LT5yZXN0b3JlKCk7CiAKKyAgICAgICAgaWYgKHNoYWRvdykg eworICAgICAgICAgICAgaWYgKHNoYWRvdy0+bmV4dCgpKQorICAgICAgICAgICAgICAgIGNvbnRl eHQtPnJlc3RvcmUoKTsKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBjb250ZXh0 LT5jbGVhclNoYWRvdygpOworICAgICAgICB9CisKICAgICAgICAgcmVzdG9yZUdyYXBoaWNzQ29u dGV4dEFmdGVyVGV4dFBhaW50aW5nKGNvbnRleHQsIHRleHRSdW4pOwogCiAgICAgICAgIGlmICgh c2hhZG93KQogICAgICAgICAgICAgYnJlYWs7CiAKLSAgICAgICAgaWYgKHNoYWRvdy0+bmV4dCgp KQotICAgICAgICAgICAgY29udGV4dC0+cmVzdG9yZSgpOwotICAgICAgICBlbHNlCi0gICAgICAg ICAgICBjb250ZXh0LT5jbGVhclNoYWRvdygpOwotCiAgICAgICAgIHNoYWRvdyA9IHNoYWRvdy0+ bmV4dCgpOwogICAgIH0gd2hpbGUgKHNoYWRvdyk7CiB9Cg==