128087 2014-02-02 16:27:47 -0800 SVGDocumentExtensions::resourcesCache() should return a reference. 2014-02-02 17:00:21 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue d-r esprehn+autocc fmalita glenn gyuyoung.kim kondapallykalyan pdr schenney oldest_to_newest 974857 0 kling 2014-02-02 16:27:47 -0800 SVGDocumentExtensions::resourcesCache() should return a reference. 974858 1 222946 kling 2014-02-02 16:28:06 -0800 Created attachment 222946 Patch 974859 2 222946 sam 2014-02-02 16:31:41 -0800 Comment on attachment 222946 Patch r=me 974866 3 222946 commit-queue 2014-02-02 17:00:18 -0800 Comment on attachment 222946 Patch Clearing flags on attachment: 222946 Committed r163277: <http://trac.webkit.org/changeset/163277> 974867 4 commit-queue 2014-02-02 17:00:21 -0800 All reviewed patches have been landed. Closing bug. 222946 2014-02-02 16:28:06 -0800 2014-02-02 17:00:18 -0800 Patch bug-128087.diff text/plain 6713 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmYWY0ODkxLi5iNTFhMTU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMzAg QEAKIDIwMTQtMDItMDIgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIFNWR0RvY3VtZW50RXh0ZW5zaW9uczo6cmVzb3VyY2VzQ2FjaGUoKSBzaG91bGQgcmV0dXJu IGEgcmVmZXJlbmNlLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTI4MDg3PgorCisg ICAgICAgIFRoZSBTVkdSZXNvdXJjZXNDYWNoZSBpcyBhbHdheXMgcHJlc2VudCB3aGVuIHRoZSBE b2N1bWVudCBpcyB1c2luZworICAgICAgICBTVkcgZXh0ZW5zaW9ucywgc28gbWFrZSB0aGlzIHJl dHVybiBhIHJlZmVyZW5jZSBhbmQgcHJvcGFnYXRlIHRoYXQKKyAgICAgICAga25vd2xlZGdlIHRv IHRoZSBjYWxsIHNpdGUuCisKKyAgICAgICAgVGhpcyBnZXRzIHJpZCBvZiBhbiBhc3NlcnRpb24g YW5kIHNvbWUgcmlja2V0eSBsb29raW5nIC0+J3MuCisgICAgICAgIEFsc28gY29udmVydGVkIGEg bG9vcCB0byB1c2UgQysrMTEgcmFuZ2UgZm9yIHN5bnRheC4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJlbmRlcmluZy9zdmcvU1ZHUmVzb3VyY2Vz Q2FjaGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cmVzb3VyY2VzQ2FjaGVGcm9tUmVuZGVyZXIp OgorICAgICAgICAoV2ViQ29yZTo6U1ZHUmVzb3VyY2VzQ2FjaGU6OmNhY2hlZFJlc291cmNlc0Zv clJlbmRlck9iamVjdCk6CisgICAgICAgIChXZWJDb3JlOjpTVkdSZXNvdXJjZXNDYWNoZTo6Y2xp ZW50U3R5bGVDaGFuZ2VkKToKKyAgICAgICAgKFdlYkNvcmU6OlNWR1Jlc291cmNlc0NhY2hlOjpj bGllbnRXYXNBZGRlZFRvVHJlZSk6CisgICAgICAgIChXZWJDb3JlOjpTVkdSZXNvdXJjZXNDYWNo ZTo6Y2xpZW50V2lsbEJlUmVtb3ZlZEZyb21UcmVlKToKKyAgICAgICAgKFdlYkNvcmU6OlNWR1Jl c291cmNlc0NhY2hlOjpjbGllbnREZXN0cm95ZWQpOgorICAgICAgICAoV2ViQ29yZTo6U1ZHUmVz b3VyY2VzQ2FjaGU6OnJlc291cmNlRGVzdHJveWVkKToKKyAgICAgICAgKiBzdmcvU1ZHRG9jdW1l bnRFeHRlbnNpb25zLmg6CisgICAgICAgIChXZWJDb3JlOjpTVkdEb2N1bWVudEV4dGVuc2lvbnM6 OnJlc291cmNlc0NhY2hlKToKKworMjAxNC0wMi0wMiAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0Bh cHBsZS5jb20+CisKICAgICAgICAgUmVuZGVyU1ZHSW5saW5lVGV4dDo6Y29tcHV0ZU5ld1NjYWxl ZEZvbnRGb3JTdHlsZSgpIHNob3VsZCB0YWtlIHJlZmVyZW5jZXMuCiAgICAgICAgIDxodHRwczov L3dlYmtpdC5vcmcvYi8xMjgwODY+CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9zdmcvU1ZHUmVzb3VyY2VzQ2FjaGUuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L3N2Zy9TVkdSZXNvdXJjZXNDYWNoZS5jcHAKaW5kZXggZmFkNTE4YS4uZmE0MGVlYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdSZXNvdXJjZXNDYWNoZS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdSZXNvdXJjZXNDYWNoZS5jcHAK QEAgLTc2LDIwICs3NiwxNiBAQCB2b2lkIFNWR1Jlc291cmNlc0NhY2hlOjpyZW1vdmVSZXNvdXJj ZXNGcm9tUmVuZGVyZXIoUmVuZGVyRWxlbWVudCYgcmVuZGVyZXIpCiAgICAgICAgICgqaXQpLT5y ZW1vdmVDbGllbnQoJnJlbmRlcmVyKTsKIH0KIAotc3RhdGljIGlubGluZSBTVkdSZXNvdXJjZXND YWNoZSogcmVzb3VyY2VzQ2FjaGVGcm9tUmVuZGVyT2JqZWN0KGNvbnN0IFJlbmRlck9iamVjdCYg cmVuZGVyZXIpCitzdGF0aWMgaW5saW5lIFNWR1Jlc291cmNlc0NhY2hlJiByZXNvdXJjZXNDYWNo ZUZyb21SZW5kZXJlcihjb25zdCBSZW5kZXJPYmplY3QmIHJlbmRlcmVyKQogewogICAgIFNWR0Rv Y3VtZW50RXh0ZW5zaW9ucyogZXh0ZW5zaW9ucyA9IHJlbmRlcmVyLmRvY3VtZW50KCkuYWNjZXNz U1ZHRXh0ZW5zaW9ucygpOwogICAgIEFTU0VSVChleHRlbnNpb25zKTsKLQotICAgIFNWR1Jlc291 cmNlc0NhY2hlKiBjYWNoZSA9IGV4dGVuc2lvbnMtPnJlc291cmNlc0NhY2hlKCk7Ci0gICAgQVNT RVJUKGNhY2hlKTsKLQotICAgIHJldHVybiBjYWNoZTsKKyAgICByZXR1cm4gZXh0ZW5zaW9ucy0+ cmVzb3VyY2VzQ2FjaGUoKTsKIH0KIAogU1ZHUmVzb3VyY2VzKiBTVkdSZXNvdXJjZXNDYWNoZTo6 Y2FjaGVkUmVzb3VyY2VzRm9yUmVuZGVyT2JqZWN0KGNvbnN0IFJlbmRlck9iamVjdCYgcmVuZGVy ZXIpCiB7Ci0gICAgcmV0dXJuIHJlc291cmNlc0NhY2hlRnJvbVJlbmRlck9iamVjdChyZW5kZXJl ciktPm1fY2FjaGUuZ2V0KCZyZW5kZXJlcik7CisgICAgcmV0dXJuIHJlc291cmNlc0NhY2hlRnJv bVJlbmRlcmVyKHJlbmRlcmVyKS5tX2NhY2hlLmdldCgmcmVuZGVyZXIpOwogfQogCiB2b2lkIFNW R1Jlc291cmNlc0NhY2hlOjpjbGllbnRMYXlvdXRDaGFuZ2VkKFJlbmRlckVsZW1lbnQmIHJlbmRl cmVyKQpAQCAtMTIyLDkgKzExOCw5IEBAIHZvaWQgU1ZHUmVzb3VyY2VzQ2FjaGU6OmNsaWVudFN0 eWxlQ2hhbmdlZChSZW5kZXJFbGVtZW50JiByZW5kZXJlciwgU3R5bGVEaWZmZXJlCiAgICAgLy8g RklYTUU6IEF2b2lkIHBhc3NpbmcgaW4gYSB1c2VsZXNzIFN0eWxlRGlmZmVyZW5jZSwgYnV0IGlu c3RlYWQgY29tcGFyZSBvbGRTdHlsZS9uZXdTdHlsZSB0byBzZWUgd2hpY2ggcmVzb3VyY2VzIGNo YW5nZWQKICAgICAvLyB0byBiZSBhYmxlIHRvIHNlbGVjdGl2ZWx5IHJlYnVpbGQgaW5kaXZpZHVh bCByZXNvdXJjZXMsIGluc3RlYWQgb2YgYWxsIG9mIHRoZW0uCiAgICAgaWYgKHJlbmRlcmVyQ2Fu SGF2ZVJlc291cmNlcyhyZW5kZXJlcikpIHsKLSAgICAgICAgU1ZHUmVzb3VyY2VzQ2FjaGUqIGNh Y2hlID0gcmVzb3VyY2VzQ2FjaGVGcm9tUmVuZGVyT2JqZWN0KHJlbmRlcmVyKTsKLSAgICAgICAg Y2FjaGUtPnJlbW92ZVJlc291cmNlc0Zyb21SZW5kZXJlcihyZW5kZXJlcik7Ci0gICAgICAgIGNh Y2hlLT5hZGRSZXNvdXJjZXNGcm9tUmVuZGVyZXIocmVuZGVyZXIsIG5ld1N0eWxlKTsKKyAgICAg ICAgYXV0byYgY2FjaGUgPSByZXNvdXJjZXNDYWNoZUZyb21SZW5kZXJlcihyZW5kZXJlcik7Cisg ICAgICAgIGNhY2hlLnJlbW92ZVJlc291cmNlc0Zyb21SZW5kZXJlcihyZW5kZXJlcik7CisgICAg ICAgIGNhY2hlLmFkZFJlc291cmNlc0Zyb21SZW5kZXJlcihyZW5kZXJlciwgbmV3U3R5bGUpOwog ICAgIH0KIAogICAgIFJlbmRlclNWR1Jlc291cmNlOjptYXJrRm9yTGF5b3V0QW5kUGFyZW50UmVz b3VyY2VJbnZhbGlkYXRpb24ocmVuZGVyZXIsIGZhbHNlKTsKQEAgLTE0Myw4ICsxMzksNyBAQCB2 b2lkIFNWR1Jlc291cmNlc0NhY2hlOjpjbGllbnRXYXNBZGRlZFRvVHJlZShSZW5kZXJPYmplY3Qm IHJlbmRlcmVyKQogICAgIGlmICghcmVuZGVyZXJDYW5IYXZlUmVzb3VyY2VzKHJlbmRlcmVyKSkK ICAgICAgICAgcmV0dXJuOwogICAgIFJlbmRlckVsZW1lbnQmIGVsZW1lbnRSZW5kZXJlciA9IHRv UmVuZGVyRWxlbWVudChyZW5kZXJlcik7Ci0gICAgU1ZHUmVzb3VyY2VzQ2FjaGUqIGNhY2hlID0g cmVzb3VyY2VzQ2FjaGVGcm9tUmVuZGVyT2JqZWN0KGVsZW1lbnRSZW5kZXJlcik7Ci0gICAgY2Fj aGUtPmFkZFJlc291cmNlc0Zyb21SZW5kZXJlcihlbGVtZW50UmVuZGVyZXIsIGVsZW1lbnRSZW5k ZXJlci5zdHlsZSgpKTsKKyAgICByZXNvdXJjZXNDYWNoZUZyb21SZW5kZXJlcihlbGVtZW50UmVu ZGVyZXIpLmFkZFJlc291cmNlc0Zyb21SZW5kZXJlcihlbGVtZW50UmVuZGVyZXIsIGVsZW1lbnRS ZW5kZXJlci5zdHlsZSgpKTsKIH0KIAogdm9pZCBTVkdSZXNvdXJjZXNDYWNoZTo6Y2xpZW50V2ls bEJlUmVtb3ZlZEZyb21UcmVlKFJlbmRlck9iamVjdCYgcmVuZGVyZXIpCkBAIC0xNTcsOCArMTUy LDcgQEAgdm9pZCBTVkdSZXNvdXJjZXNDYWNoZTo6Y2xpZW50V2lsbEJlUmVtb3ZlZEZyb21UcmVl KFJlbmRlck9iamVjdCYgcmVuZGVyZXIpCiAgICAgaWYgKCFyZW5kZXJlckNhbkhhdmVSZXNvdXJj ZXMocmVuZGVyZXIpKQogICAgICAgICByZXR1cm47CiAgICAgUmVuZGVyRWxlbWVudCYgZWxlbWVu dFJlbmRlcmVyID0gdG9SZW5kZXJFbGVtZW50KHJlbmRlcmVyKTsKLSAgICBTVkdSZXNvdXJjZXND YWNoZSogY2FjaGUgPSByZXNvdXJjZXNDYWNoZUZyb21SZW5kZXJPYmplY3QoZWxlbWVudFJlbmRl cmVyKTsKLSAgICBjYWNoZS0+cmVtb3ZlUmVzb3VyY2VzRnJvbVJlbmRlcmVyKGVsZW1lbnRSZW5k ZXJlcik7CisgICAgcmVzb3VyY2VzQ2FjaGVGcm9tUmVuZGVyZXIoZWxlbWVudFJlbmRlcmVyKS5y ZW1vdmVSZXNvdXJjZXNGcm9tUmVuZGVyZXIoZWxlbWVudFJlbmRlcmVyKTsKIH0KIAogdm9pZCBT VkdSZXNvdXJjZXNDYWNoZTo6Y2xpZW50RGVzdHJveWVkKFJlbmRlckVsZW1lbnQmIHJlbmRlcmVy KQpAQCAtMTY3LDIzICsxNjEsMjIgQEAgdm9pZCBTVkdSZXNvdXJjZXNDYWNoZTo6Y2xpZW50RGVz dHJveWVkKFJlbmRlckVsZW1lbnQmIHJlbmRlcmVyKQogICAgIGlmIChyZXNvdXJjZXMpCiAgICAg ICAgIHJlc291cmNlcy0+cmVtb3ZlQ2xpZW50RnJvbUNhY2hlKHJlbmRlcmVyKTsKIAotICAgIFNW R1Jlc291cmNlc0NhY2hlKiBjYWNoZSA9IHJlc291cmNlc0NhY2hlRnJvbVJlbmRlck9iamVjdChy ZW5kZXJlcik7Ci0gICAgY2FjaGUtPnJlbW92ZVJlc291cmNlc0Zyb21SZW5kZXJlcihyZW5kZXJl cik7CisgICAgcmVzb3VyY2VzQ2FjaGVGcm9tUmVuZGVyZXIocmVuZGVyZXIpLnJlbW92ZVJlc291 cmNlc0Zyb21SZW5kZXJlcihyZW5kZXJlcik7CiB9CiAKIHZvaWQgU1ZHUmVzb3VyY2VzQ2FjaGU6 OnJlc291cmNlRGVzdHJveWVkKFJlbmRlclNWR1Jlc291cmNlQ29udGFpbmVyJiByZXNvdXJjZSkK IHsKLSAgICBTVkdSZXNvdXJjZXNDYWNoZSogY2FjaGUgPSByZXNvdXJjZXNDYWNoZUZyb21SZW5k ZXJPYmplY3QocmVzb3VyY2UpOworICAgIGF1dG8mIGNhY2hlID0gcmVzb3VyY2VzQ2FjaGVGcm9t UmVuZGVyZXIocmVzb3VyY2UpOwogCiAgICAgLy8gVGhlIHJlc291cmNlIGl0c2VsZiBtYXkgaGF2 ZSBjbGllbnRzLCB0aGF0IG5lZWQgdG8gYmUgbm90aWZpZWQuCi0gICAgY2FjaGUtPnJlbW92ZVJl c291cmNlc0Zyb21SZW5kZXJlcihyZXNvdXJjZSk7CisgICAgY2FjaGUucmVtb3ZlUmVzb3VyY2Vz RnJvbVJlbmRlcmVyKHJlc291cmNlKTsKIAotICAgIGZvciAoYXV0byBpdCA9IGNhY2hlLT5tX2Nh Y2hlLmJlZ2luKCksIGVuZCA9IGNhY2hlLT5tX2NhY2hlLmVuZCgpOyBpdCAhPSBlbmQ7ICsraXQp IHsKLSAgICAgICAgaXQtPnZhbHVlLT5yZXNvdXJjZURlc3Ryb3llZChyZXNvdXJjZSk7CisgICAg Zm9yIChhdXRvJiBpdCA6IGNhY2hlLm1fY2FjaGUpIHsKKyAgICAgICAgaXQudmFsdWUtPnJlc291 cmNlRGVzdHJveWVkKHJlc291cmNlKTsKIAogICAgICAgICAvLyBNYXJrIHVzZXJzIG9mIGRlc3Ry b3llZCByZXNvdXJjZXMgYXMgcGVuZGluZyByZXNvbHV0aW9uIGJhc2VkIG9uIHRoZSBpZCBvZiB0 aGUgb2xkIHJlc291cmNlLgogICAgICAgICBFbGVtZW50JiByZXNvdXJjZUVsZW1lbnQgPSByZXNv dXJjZS5lbGVtZW50KCk7Ci0gICAgICAgIEVsZW1lbnQqIGNsaWVudEVsZW1lbnQgPSB0b0VsZW1l bnQoaXQtPmtleS0+bm9kZSgpKTsKKyAgICAgICAgRWxlbWVudCogY2xpZW50RWxlbWVudCA9IHRv RWxlbWVudChpdC5rZXktPm5vZGUoKSk7CiAgICAgICAgIFNWR0RvY3VtZW50RXh0ZW5zaW9ucyog ZXh0ZW5zaW9ucyA9IGNsaWVudEVsZW1lbnQtPmRvY3VtZW50KCkuYWNjZXNzU1ZHRXh0ZW5zaW9u cygpOwogCiAgICAgICAgIGV4dGVuc2lvbnMtPmFkZFBlbmRpbmdSZXNvdXJjZShyZXNvdXJjZUVs ZW1lbnQuZ2V0SWRBdHRyaWJ1dGUoKSwgY2xpZW50RWxlbWVudCk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9zdmcvU1ZHRG9jdW1lbnRFeHRlbnNpb25zLmggYi9Tb3VyY2UvV2ViQ29yZS9z dmcvU1ZHRG9jdW1lbnRFeHRlbnNpb25zLmgKaW5kZXggNDYwYjE0NS4uMDUyYWE0NSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0RvY3VtZW50RXh0ZW5zaW9ucy5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3N2Zy9TVkdEb2N1bWVudEV4dGVuc2lvbnMuaApAQCAtNjIsNyArNjIsNyBA QCBwdWJsaWM6CiAgICAgdm9pZCByZXBvcnRXYXJuaW5nKGNvbnN0IFN0cmluZyYpOwogICAgIHZv aWQgcmVwb3J0RXJyb3IoY29uc3QgU3RyaW5nJik7CiAKLSAgICBTVkdSZXNvdXJjZXNDYWNoZSog cmVzb3VyY2VzQ2FjaGUoKSBjb25zdCB7IHJldHVybiBtX3Jlc291cmNlc0NhY2hlLmdldCgpOyB9 CisgICAgU1ZHUmVzb3VyY2VzQ2FjaGUmIHJlc291cmNlc0NhY2hlKCkgeyByZXR1cm4gKm1fcmVz b3VyY2VzQ2FjaGU7IH0KIAogICAgIEhhc2hTZXQ8U1ZHRWxlbWVudCo+KiBzZXRPZkVsZW1lbnRz UmVmZXJlbmNpbmdUYXJnZXQoU1ZHRWxlbWVudCogcmVmZXJlbmNlZEVsZW1lbnQpIGNvbnN0Owog ICAgIHZvaWQgYWRkRWxlbWVudFJlZmVyZW5jaW5nVGFyZ2V0KFNWR0VsZW1lbnQqIHJlZmVyZW5j aW5nRWxlbWVudCwgU1ZHRWxlbWVudCogcmVmZXJlbmNlZEVsZW1lbnQpOwo=