128084 2014-02-02 15:07:44 -0800 WK2: Selection in non editable content is not cleared when navigating to a different page 2014-02-02 15:41:31 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica mitz oldest_to_newest 974835 0 enrica 2014-02-02 15:07:44 -0800 We need to make sure the selection code knows that we are resigning first responder. <rdar://problem/15966166> 974838 1 222941 enrica 2014-02-02 15:11:31 -0800 Created attachment 222941 Patch 974839 2 222941 mitz 2014-02-02 15:24:05 -0800 Comment on attachment 222941 Patch Conceptually it seems wrong to do any work in our override of resignFirstResponder if the superclass implementation is going to return NO. Should we call super first and bail out if it returned NO? This is not new to this patch, however, so r=me. 974840 3 enrica 2014-02-02 15:35:44 -0800 (In reply to comment #2) > (From update of attachment 222941 [details]) > Conceptually it seems wrong to do any work in our override of resignFirstResponder if the superclass implementation is going to return NO. Should we call super first and bail out if it returned NO? > > This is not new to this patch, however, so r=me. Thanks for the review! You are probably correct about calling the super class first. I checked the implementation in UIWebDocumentview and there are tasks performed before and other performed after calling [super resignFirstResponder] but no checks are performed on the return value. I will leave it like this for now, but I'll add a comment before landing to remind me to do further investigation. 974841 4 enrica 2014-02-02 15:41:31 -0800 Committed revision 163273. 222941 2014-02-02 15:11:31 -0800 2014-02-02 15:24:05 -0800 Patch cleanupselection.txt text/plain 1306 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MzI3MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAyLTAyICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgV0syOiBTZWxlY3Rpb24gaXMg bm9uIGVkaXRhYmxlIGNvbnRlbnQgaXMgbm90IGNsZWFyZWQgd2hlbiBuYXZpZ2F0aW5nIHRvIGEg ZGlmZmVyZW50IHBhZ2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMjgwODQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE1OTY2MTY2PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gcmVzaWduaW5n IGZpcnN0IHJlc3BvbmRlciB3ZSBuZWVkIHRvIGNsZWFudXAgdGhlIHNlbGVjdGlvbi4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvaW9zL1dLSW50ZXJhY3Rpb25WaWV3Lm1tOgorICAgICAgICAo LVtXS0ludGVyYWN0aW9uVmlldyByZXNpZ25GaXJzdFJlc3BvbmRlcl0pOgorCiAyMDE0LTAyLTAy ICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CiAKICAgICAgICAgV0syOiBDYW5u b3QgZm9jdXMgYSBzZWNvbmQgZmllbGQgaW4gYSBwYWdlIGFmdGVyIHRoZSBmaXJzdCBoYXMgYmVl biBmb2N1c2VkLgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9pb3MvV0tJbnRl cmFjdGlvblZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9pb3MvV0tJbnRlcmFjdGlvblZpZXcubW0JKHJldmlzaW9uIDE2MzI2OSkKKysrIFNvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvaW9zL1dLSW50ZXJhY3Rpb25WaWV3Lm1tCSh3b3JraW5nIGNv cHkpCkBAIC0yNjgsNiArMjY4LDggQEAgLSAoQk9PTClyZXNpZ25GaXJzdFJlc3BvbmRlcgogewog ICAgIF9wYWdlLT5ibHVyQXNzaXN0ZWROb2RlKCk7CiAgICAgW3NlbGYgX2NhbmNlbEludGVyYWN0 aW9uXTsKKyAgICBbX3dlYlNlbGVjdGlvbkFzc2lzdGFudCByZXNpZ25lZEZpcnN0UmVzcG9uZGVy XTsKKwogICAgIHJldHVybiBbc3VwZXIgcmVzaWduRmlyc3RSZXNwb25kZXJdOwogfQogCg==