128082 2014-02-02 13:49:50 -0800 Add some missing override keywords 2014-02-02 13:51:26 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sam sam commit-queue japhet oldest_to_newest 974824 0 sam 2014-02-02 13:49:50 -0800 Add some missing override keywords 974825 1 222938 sam 2014-02-02 13:50:12 -0800 Created attachment 222938 Patch 974826 2 sam 2014-02-02 13:51:26 -0800 Committed r163271: <http://trac.webkit.org/changeset/163271> 222938 2014-02-02 13:50:12 -0800 2014-02-02 13:50:37 -0800 Patch bug-128082-20140202135011.patch text/plain 5189 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MzI3MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAyLTAyICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRkIHNvbWUgbWlzc2luZyBvdmVycmlk ZSBrZXl3b3JkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTI4MDgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBsb2FkZXIvRG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVyLmg6CisgICAgICAgICogbG9hZGVy L0xpbmtMb2FkZXIuaDoKKyAgICAgICAgKiBsb2FkZXIvVGV4dFRyYWNrTG9hZGVyLmg6CisgICAg ICAgICogeG1sL3BhcnNlci9YTUxEb2N1bWVudFBhcnNlci5oOgorCiAyMDE0LTAyLTAyICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBJREI6IFN1cHBvcnQgSURC RmFjdG9yeS5kZWxldGVEYXRhYmFzZSgpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9j dW1lbnRUaHJlYWRhYmxlTG9hZGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9h ZGVyL0RvY3VtZW50VGhyZWFkYWJsZUxvYWRlci5oCShyZXZpc2lvbiAxNjMyNzApCisrKyBTb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRUaHJlYWRhYmxlTG9hZGVyLmgJKHdvcmtpbmcgY29w eSkKQEAgLTc4LDExICs3OCwxMSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHZvaWQg Y2xlYXJSZXNvdXJjZSgpOwogCiAgICAgICAgIC8vIENhY2hlZFJhd1Jlc291cmNlQ2xpZW50Ci0g ICAgICAgIHZpcnR1YWwgdm9pZCBkYXRhU2VudChDYWNoZWRSZXNvdXJjZSosIHVuc2lnbmVkIGxv bmcgbG9uZyBieXRlc1NlbnQsIHVuc2lnbmVkIGxvbmcgbG9uZyB0b3RhbEJ5dGVzVG9CZVNlbnQp OwotICAgICAgICB2aXJ0dWFsIHZvaWQgcmVzcG9uc2VSZWNlaXZlZChDYWNoZWRSZXNvdXJjZSos IGNvbnN0IFJlc291cmNlUmVzcG9uc2UmKTsKLSAgICAgICAgdmlydHVhbCB2b2lkIGRhdGFSZWNl aXZlZChDYWNoZWRSZXNvdXJjZSosIGNvbnN0IGNoYXIqIGRhdGEsIGludCBkYXRhTGVuZ3RoKTsK LSAgICAgICAgdmlydHVhbCB2b2lkIHJlZGlyZWN0UmVjZWl2ZWQoQ2FjaGVkUmVzb3VyY2UqLCBS ZXNvdXJjZVJlcXVlc3QmLCBjb25zdCBSZXNvdXJjZVJlc3BvbnNlJik7Ci0gICAgICAgIHZpcnR1 YWwgdm9pZCBub3RpZnlGaW5pc2hlZChDYWNoZWRSZXNvdXJjZSopOworICAgICAgICB2aXJ0dWFs IHZvaWQgZGF0YVNlbnQoQ2FjaGVkUmVzb3VyY2UqLCB1bnNpZ25lZCBsb25nIGxvbmcgYnl0ZXNT ZW50LCB1bnNpZ25lZCBsb25nIGxvbmcgdG90YWxCeXRlc1RvQmVTZW50KSBvdmVycmlkZTsKKyAg ICAgICAgdmlydHVhbCB2b2lkIHJlc3BvbnNlUmVjZWl2ZWQoQ2FjaGVkUmVzb3VyY2UqLCBjb25z dCBSZXNvdXJjZVJlc3BvbnNlJikgb3ZlcnJpZGU7CisgICAgICAgIHZpcnR1YWwgdm9pZCBkYXRh UmVjZWl2ZWQoQ2FjaGVkUmVzb3VyY2UqLCBjb25zdCBjaGFyKiBkYXRhLCBpbnQgZGF0YUxlbmd0 aCkgb3ZlcnJpZGU7CisgICAgICAgIHZpcnR1YWwgdm9pZCByZWRpcmVjdFJlY2VpdmVkKENhY2hl ZFJlc291cmNlKiwgUmVzb3VyY2VSZXF1ZXN0JiwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYpIG92 ZXJyaWRlOworICAgICAgICB2aXJ0dWFsIHZvaWQgbm90aWZ5RmluaXNoZWQoQ2FjaGVkUmVzb3Vy Y2UqKSBvdmVycmlkZTsKIAogICAgICAgICB2b2lkIGRpZFJlY2VpdmVSZXNwb25zZSh1bnNpZ25l ZCBsb25nIGlkZW50aWZpZXIsIGNvbnN0IFJlc291cmNlUmVzcG9uc2UmKTsKICAgICAgICAgdm9p ZCBkaWRSZWNlaXZlRGF0YSh1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIsIGNvbnN0IGNoYXIqIGRh dGEsIGludCBkYXRhTGVuZ3RoKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9MaW5rTG9h ZGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL0xpbmtMb2FkZXIuaAko cmV2aXNpb24gMTYzMjcwKQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL0xpbmtMb2FkZXIuaAko d29ya2luZyBjb3B5KQpAQCAtNTMsNyArNTMsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB+TGlu a0xvYWRlcigpOwogCiAgICAgLy8gZnJvbSBDYWNoZWRSZXNvdXJjZUNsaWVudAotICAgIHZpcnR1 YWwgdm9pZCBub3RpZnlGaW5pc2hlZChDYWNoZWRSZXNvdXJjZSopOworICAgIHZpcnR1YWwgdm9p ZCBub3RpZnlGaW5pc2hlZChDYWNoZWRSZXNvdXJjZSopIG92ZXJyaWRlOwogCiAgICAgdm9pZCBy ZWxlYXNlZCgpOwogICAgIGJvb2wgbG9hZExpbmsoY29uc3QgTGlua1JlbEF0dHJpYnV0ZSYsIGNv bnN0IFN0cmluZyYgdHlwZSwgY29uc3QgU3RyaW5nJiBzaXplcywgY29uc3QgVVJMJiwgRG9jdW1l bnQqKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9UZXh0VHJhY2tMb2FkZXIuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvVGV4dFRyYWNrTG9hZGVyLmgJKHJldmlz aW9uIDE2MzI3MCkKKysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9UZXh0VHJhY2tMb2FkZXIuaAko d29ya2luZyBjb3B5KQpAQCAtNzEsMTUgKzcxLDE1IEBAIHB1YmxpYzoKIHByaXZhdGU6CiAKICAg ICAvLyBDYWNoZWRSZXNvdXJjZUNsaWVudAotICAgIHZpcnR1YWwgdm9pZCBub3RpZnlGaW5pc2hl ZChDYWNoZWRSZXNvdXJjZSopOwotICAgIHZpcnR1YWwgdm9pZCBkZXByZWNhdGVkRGlkUmVjZWl2 ZUNhY2hlZFJlc291cmNlKENhY2hlZFJlc291cmNlKik7CisgICAgdmlydHVhbCB2b2lkIG5vdGlm eUZpbmlzaGVkKENhY2hlZFJlc291cmNlKikgb3ZlcnJpZGU7CisgICAgdmlydHVhbCB2b2lkIGRl cHJlY2F0ZWREaWRSZWNlaXZlQ2FjaGVkUmVzb3VyY2UoQ2FjaGVkUmVzb3VyY2UqKSBvdmVycmlk ZTsKICAgICAKICAgICAvLyBXZWJWVFRQYXJzZXJDbGllbnQKLSAgICB2aXJ0dWFsIHZvaWQgbmV3 Q3Vlc1BhcnNlZCgpOworICAgIHZpcnR1YWwgdm9pZCBuZXdDdWVzUGFyc2VkKCkgb3ZlcnJpZGU7 CiAjaWYgRU5BQkxFKFdFQlZUVF9SRUdJT05TKQotICAgIHZpcnR1YWwgdm9pZCBuZXdSZWdpb25z UGFyc2VkKCk7CisgICAgdmlydHVhbCB2b2lkIG5ld1JlZ2lvbnNQYXJzZWQoKSBvdmVycmlkZTsK ICNlbmRpZgotICAgIHZpcnR1YWwgdm9pZCBmaWxlRmFpbGVkVG9QYXJzZSgpOworICAgIHZpcnR1 YWwgdm9pZCBmaWxlRmFpbGVkVG9QYXJzZSgpIG92ZXJyaWRlOwogICAgIAogICAgIFRleHRUcmFj a0xvYWRlcihUZXh0VHJhY2tMb2FkZXJDbGllbnQmLCBTY3JpcHRFeGVjdXRpb25Db250ZXh0Kik7 CiAgICAgCkluZGV4OiBTb3VyY2UvV2ViQ29yZS94bWwvcGFyc2VyL1hNTERvY3VtZW50UGFyc2Vy LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUveG1sL3BhcnNlci9YTUxEb2N1bWVudFBh cnNlci5oCShyZXZpc2lvbiAxNjMyNzApCisrKyBTb3VyY2UvV2ViQ29yZS94bWwvcGFyc2VyL1hN TERvY3VtZW50UGFyc2VyLmgJKHdvcmtpbmcgY29weSkKQEAgLTk5LDE1ICs5OSwxNSBAQCBjbGFz cyBUZXh0OwogICAgICAgICBYTUxEb2N1bWVudFBhcnNlcihEb2N1bWVudEZyYWdtZW50JiwgRWxl bWVudCosIFBhcnNlckNvbnRlbnRQb2xpY3kpOwogCiAgICAgICAgIC8vIEZyb20gRG9jdW1lbnRQ YXJzZXIKLSAgICAgICAgdmlydHVhbCB2b2lkIGluc2VydChjb25zdCBTZWdtZW50ZWRTdHJpbmcm KTsKLSAgICAgICAgdmlydHVhbCB2b2lkIGFwcGVuZChQYXNzUmVmUHRyPFN0cmluZ0ltcGw+KTsK LSAgICAgICAgdmlydHVhbCB2b2lkIGZpbmlzaCgpOwotICAgICAgICB2aXJ0dWFsIGJvb2wgaXNX YWl0aW5nRm9yU2NyaXB0cygpIGNvbnN0OwotICAgICAgICB2aXJ0dWFsIHZvaWQgc3RvcFBhcnNp bmcoKTsKLSAgICAgICAgdmlydHVhbCB2b2lkIGRldGFjaCgpOworICAgICAgICB2aXJ0dWFsIHZv aWQgaW5zZXJ0KGNvbnN0IFNlZ21lbnRlZFN0cmluZyYpIG92ZXJyaWRlOworICAgICAgICB2aXJ0 dWFsIHZvaWQgYXBwZW5kKFBhc3NSZWZQdHI8U3RyaW5nSW1wbD4pIG92ZXJyaWRlOworICAgICAg ICB2aXJ0dWFsIHZvaWQgZmluaXNoKCkgb3ZlcnJpZGU7CisgICAgICAgIHZpcnR1YWwgYm9vbCBp c1dhaXRpbmdGb3JTY3JpcHRzKCkgY29uc3Qgb3ZlcnJpZGU7CisgICAgICAgIHZpcnR1YWwgdm9p ZCBzdG9wUGFyc2luZygpIG92ZXJyaWRlOworICAgICAgICB2aXJ0dWFsIHZvaWQgZGV0YWNoKCkg b3ZlcnJpZGU7CiAKICAgICAgICAgLy8gZnJvbSBDYWNoZWRSZXNvdXJjZUNsaWVudAotICAgICAg ICB2aXJ0dWFsIHZvaWQgbm90aWZ5RmluaXNoZWQoQ2FjaGVkUmVzb3VyY2UqKTsKKyAgICAgICAg dmlydHVhbCB2b2lkIG5vdGlmeUZpbmlzaGVkKENhY2hlZFJlc291cmNlKikgb3ZlcnJpZGU7CiAK ICAgICAgICAgdm9pZCBlbmQoKTsKIApAQCAtMTE2LDcgKzExNiw3IEBAIGNsYXNzIFRleHQ7CiAK ICAgICAgICAgYm9vbCBhcHBlbmRGcmFnbWVudFNvdXJjZShjb25zdCBTdHJpbmcmKTsKIAotcHVi bGljOgorICAgIHB1YmxpYzoKICAgICAgICAgLy8gY2FsbGJhY2tzIGZyb20gcGFyc2VyIFNBWAog ICAgICAgICB2b2lkIGVycm9yKFhNTEVycm9yczo6RXJyb3JUeXBlLCBjb25zdCBjaGFyKiBtZXNz YWdlLCB2YV9saXN0IGFyZ3MpIFdURl9BVFRSSUJVVEVfUFJJTlRGKDMsIDApOwogICAgICAgICB2 b2lkIHN0YXJ0RWxlbWVudE5zKGNvbnN0IHhtbENoYXIqIHhtbExvY2FsTmFtZSwgY29uc3QgeG1s Q2hhciogeG1sUHJlZml4LCBjb25zdCB4bWxDaGFyKiB4bWxVUkksIGludCBuYl9uYW1lc3BhY2Vz LAo=