128059 2014-02-01 19:53:56 -0800 [EFL] REGRESSION(r163234) EFL debug build is broken 2014-02-01 23:57:46 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 1 hs85.jeong webkit-unassigned alecflett commit-queue gyuyoung.kim jsbell lucas.de.marchi ryuan.choi oldest_to_newest 974695 0 hs85.jeong 2014-02-01 19:53:56 -0800 EFL debug build is broken after r163234 on EFL. 974697 1 222902 hs85.jeong 2014-02-01 20:06:25 -0800 Created attachment 222902 Patch 974699 2 222902 ryuan.choi 2014-02-01 20:39:08 -0800 Comment on attachment 222902 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222902&action=review > Source/WebCore/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Because this is build fix, you can make the patch as "Unreviewed build fix" > Source/WebCore/ChangeLog:11 > + Fixed the broken build on EFL after r163234. > + > + * Modules/indexeddb/IDBKeyData.cpp: > + (WebCore::IDBKeyData::loggingString): Added the default: case. I am not sure whether it is EFL specific. Maybe "Debug build is broken with INDEXED_DATABASE > Source/WebCore/Modules/indexeddb/IDBKeyData.cpp:279 > } Like other statements, Can we add it out of switch() with "ASSERT_NOT_REACHED();" 974713 3 222906 hs85.jeong 2014-02-01 21:35:14 -0800 Created attachment 222906 Patch 974716 4 222906 gyuyoung.kim 2014-02-01 21:48:55 -0800 Comment on attachment 222906 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222906&action=review You don't need to request review in unreviewed case. > Source/WebCore/ChangeLog:3 > + [EFL] REGRESSION(r163234) EFL debug build is broken Remove [EFL] prefix. > Source/WebCore/ChangeLog:6 > + Unriewed. Debug build is broken with INDEXED_DATABASE. Typo. Unreviewed. 974722 5 222909 hs85.jeong 2014-02-01 22:08:21 -0800 Created attachment 222909 Patch 974743 6 222909 commit-queue 2014-02-01 23:57:43 -0800 Comment on attachment 222909 Patch Clearing flags on attachment: 222909 Committed r163261: <http://trac.webkit.org/changeset/163261> 974744 7 commit-queue 2014-02-01 23:57:46 -0800 All reviewed patches have been landed. Closing bug. 222902 2014-02-01 20:06:25 -0800 2014-02-01 21:35:06 -0800 Patch bug-128059-20140202130625.patch text/plain 1312 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2FlZGIxYmJmZmY3NGIy MzY2NTc0M2RjYjkyOWE1YjlmOGRiNTE4Yi4uMGRlMmFjOTgyODdlMzA3MjdkZTRmMzU0M2M3YWE5 YzA4YjZhY2I3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAyLTAxICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBSRUdS RVNTSU9OKHIxNjMyMzQpIEVGTCBkZWJ1ZyBidWlsZCBpcyBicm9rZW4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODA1OQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIHRoZSBicm9rZW4gYnVpbGQg b24gRUZMIGFmdGVyIHIxNjMyMzQuCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9JREJL ZXlEYXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklEQktleURhdGE6OmxvZ2dpbmdTdHJpbmcp OiBBZGRlZCB0aGUgZGVmYXVsdDogY2FzZS4KKwogMjAxNC0wMi0wMSAgRW5yaWNhIENhc3VjY2kg IDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzdXBwb3J0IGZvciBBY3Rpb25TaGVl dHMgaW4gV0syIGZvciBpT1MuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2lu ZGV4ZWRkYi9JREJLZXlEYXRhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRi L0lEQktleURhdGEuY3BwCmluZGV4IDE1MTc2YTE1MWFlNDBiNmViNDA1OTU0YzIwNTVjYWRhY2Qw YTdmZDMuLjFiYmFhM2MwNTlkYzFlMDg3OWJjMzMzNzQ1MmI1MjJkMzRiN2MxYzYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQktleURhdGEuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQktleURhdGEuY3BwCkBAIC0yNzQs NiArMjc0LDggQEAgU3RyaW5nIElEQktleURhdGE6OmxvZ2dpbmdTdHJpbmcoKSBjb25zdAogICAg ICAgICByZXR1cm4gU3RyaW5nOjpmb3JtYXQoIjxudW1iZXI+IC0gJWYiLCBudW1iZXJWYWx1ZSk7 CiAgICAgY2FzZSBJREJLZXk6Ok1pblR5cGU6CiAgICAgICAgIHJldHVybiAiPG1pbmltdW0+IjsK KyAgICBkZWZhdWx0OgorICAgICAgICByZXR1cm4gU3RyaW5nKCk7CiAgICAgfQogfQogI2VuZGlm Cg== 222906 2014-02-01 21:35:14 -0800 2014-02-01 22:08:11 -0800 Patch bug-128059-20140202143514.patch text/plain 1313 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2FlZGIxYmJmZmY3NGIy MzY2NTc0M2RjYjkyOWE1YjlmOGRiNTE4Yi4uMDRhMTA5MDQ1MDllY2NkNzI5YzhlN2FlMzFjYzk3 YjBhMTI0YmJiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAyLTAxICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBSRUdS RVNTSU9OKHIxNjMyMzQpIEVGTCBkZWJ1ZyBidWlsZCBpcyBicm9rZW4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODA1OQorCisgICAgICAgIFVucmll d2VkLiBEZWJ1ZyBidWlsZCBpcyBicm9rZW4gd2l0aCBJTkRFWEVEX0RBVEFCQVNFLgorCisgICAg ICAgICogTW9kdWxlcy9pbmRleGVkZGIvSURCS2V5RGF0YS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpJREJLZXlEYXRhOjpsb2dnaW5nU3RyaW5nKTogQWRkZWQgdGhlIGRlZmF1bHQ6IGNhc2UuCisK IDIwMTQtMDItMDEgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAg ICBBZGQgc3VwcG9ydCBmb3IgQWN0aW9uU2hlZXRzIGluIFdLMiBmb3IgaU9TLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCS2V5RGF0YS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJLZXlEYXRhLmNwcAppbmRleCAxNTE3NmEx NTFhZTQwYjZlYjQwNTk1NGMyMDU1Y2FkYWNkMGE3ZmQzLi5mNzU3ODFkOWUwYjQyYTJhZGZmZTc0 OGQyM2M0YTU0MzlmOTY5Nzk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2lu ZGV4ZWRkYi9JREJLZXlEYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4 ZWRkYi9JREJLZXlEYXRhLmNwcApAQCAtMjc0LDcgKzI3NCwxMCBAQCBTdHJpbmcgSURCS2V5RGF0 YTo6bG9nZ2luZ1N0cmluZygpIGNvbnN0CiAgICAgICAgIHJldHVybiBTdHJpbmc6OmZvcm1hdCgi PG51bWJlcj4gLSAlZiIsIG51bWJlclZhbHVlKTsKICAgICBjYXNlIElEQktleTo6TWluVHlwZToK ICAgICAgICAgcmV0dXJuICI8bWluaW11bT4iOworICAgIGRlZmF1bHQ6CisgICAgICAgIHJldHVy biBTdHJpbmcoKTsKICAgICB9CisgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiB9CiAjZW5kaWYK IAo= 222909 2014-02-01 22:08:21 -0800 2014-02-01 23:57:43 -0800 Patch bug-128059-20140202150821.patch text/plain 1305 hs85.jeong U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2FlZGIxYmJmZmY3NGIy MzY2NTc0M2RjYjkyOWE1YjlmOGRiNTE4Yi4uM2I0NzA1YmI2NWQ2NzRmZTg1YzkxYzgxYzViY2Zm NjE0Yjk1ODJhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAyLTAxICBIdW5z ZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9O KHIxNjMyMzQpIERlYnVnIGJ1aWxkIGlzIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MDU5CisKKyAgICAgICAgVW5yZXZpZXdlZC4gRGVi dWcgYnVpbGQgaXMgYnJva2VuIHdpdGggSU5ERVhFRF9EQVRBQkFTRS4KKworICAgICAgICAqIE1v ZHVsZXMvaW5kZXhlZGRiL0lEQktleURhdGEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCS2V5 RGF0YTo6bG9nZ2luZ1N0cmluZyk6IEFkZGVkIHRoZSBkZWZhdWx0OiBjYXNlLgorCiAyMDE0LTAy LTAxICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHN1 cHBvcnQgZm9yIEFjdGlvblNoZWV0cyBpbiBXSzIgZm9yIGlPUy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQktleURhdGEuY3BwIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9pbmRleGVkZGIvSURCS2V5RGF0YS5jcHAKaW5kZXggMTUxNzZhMTUxYWU0MGI2 ZWI0MDU5NTRjMjA1NWNhZGFjZDBhN2ZkMy4uZjc1NzgxZDllMGI0MmEyYWRmZmU3NDhkMjNjNGE1 NDM5Zjk2OTc5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIv SURCS2V5RGF0YS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURC S2V5RGF0YS5jcHAKQEAgLTI3NCw3ICsyNzQsMTAgQEAgU3RyaW5nIElEQktleURhdGE6OmxvZ2dp bmdTdHJpbmcoKSBjb25zdAogICAgICAgICByZXR1cm4gU3RyaW5nOjpmb3JtYXQoIjxudW1iZXI+ IC0gJWYiLCBudW1iZXJWYWx1ZSk7CiAgICAgY2FzZSBJREJLZXk6Ok1pblR5cGU6CiAgICAgICAg IHJldHVybiAiPG1pbmltdW0+IjsKKyAgICBkZWZhdWx0OgorICAgICAgICByZXR1cm4gU3RyaW5n KCk7CiAgICAgfQorICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogfQogI2VuZGlmCiAK