128056 2014-02-01 19:06:59 -0800 Subpixel rendering: LayoutUnit operator++ is broken. 2014-02-01 23:40:49 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 127524 128036 1 zalan zalan commit-queue jonlee simon.fraser oldest_to_newest 974685 0 zalan 2014-02-01 19:06:59 -0800 It defines post-increment only and implements it as if it was pre-increment. 974691 1 222899 zalan 2014-02-01 19:27:46 -0800 Created attachment 222899 Patch 974706 2 222899 darin 2014-02-01 21:17:05 -0800 Comment on attachment 222899 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222899&action=review > Source/WebCore/platform/LayoutUnit.h:197 > - LayoutUnit operator++(int) > + LayoutUnit& operator++() > { > m_value += kEffectiveFixedPointDenominator; > return *this; > } Great fix! > Source/WebCore/platform/LayoutUnit.h:204 > + LayoutUnit operator++(int) > + { > + LayoutUnit result = *this; > + ++(*this); > + return result; > + } Not sure we really need to add this, although I suppose it does little harm. On a separate note, if it was me I would have written ++*this without parentheses. 974707 3 zalan 2014-02-01 21:20:46 -0800 (In reply to comment #2) > (From update of attachment 222899 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=222899&action=review > > > Source/WebCore/platform/LayoutUnit.h:197 > > - LayoutUnit operator++(int) > > + LayoutUnit& operator++() > > { > > m_value += kEffectiveFixedPointDenominator; > > return *this; > > } > > Great fix! > > > Source/WebCore/platform/LayoutUnit.h:204 > > + LayoutUnit operator++(int) > > + { > > + LayoutUnit result = *this; > > + ++(*this); > > + return result; > > + } > > Not sure we really need to add this, although I suppose it does little harm. Indeed! I guess we can add it back when it is actually needed. I'll land this without the post increment. Thanks! 974714 4 222907 zalan 2014-02-01 21:40:48 -0800 Created attachment 222907 Patch 974715 5 222907 zalan 2014-02-01 21:41:12 -0800 Comment on attachment 222907 Patch EWS testing 974739 6 222907 commit-queue 2014-02-01 23:40:47 -0800 Comment on attachment 222907 Patch Clearing flags on attachment: 222907 Committed r163260: <http://trac.webkit.org/changeset/163260> 974740 7 commit-queue 2014-02-01 23:40:49 -0800 All reviewed patches have been landed. Closing bug. 222899 2014-02-01 19:27:46 -0800 2014-02-01 21:40:45 -0800 Patch bug-128056-20140201192740.patch text/plain 1577 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2FlOGNmZGVkODYyYWEz NThkNWZiNGViOTI0Y2U0MGIxZWI3MGQzNi4uNGZkODJlNmJkYmEwZjFjMGZmNmM0N2VkODAzNmVj MDBlM2E2NzQ3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAyLTAxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgU3VicGl4ZWwgcmVuZGVyaW5n OiBMYXlvdXRVbml0IG9wZXJhdG9yKysgaXMgYnJva2VuLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MDU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHByZS1pbmNyZW1lbnQgb3BlcmF0b3IrKyBh bmQgZml4IHRoZSBwb3MtaW5jcmVtZW50IGltcGxlbWVudGF0aW9uLgorCisgICAgICAgICogcGxh dGZvcm0vTGF5b3V0VW5pdC5oOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0VW5pdDo6b3BlcmF0 b3IrKyk6CisKIDIwMTQtMDItMDEgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+ CiAKICAgICAgICAgVXBkYXRlIFdlYkNyeXB0byBKV0sgbWFwcGluZyB0byB1c2Uga2V5X29wcwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGF5b3V0VW5pdC5oIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vTGF5b3V0VW5pdC5oCmluZGV4IDkxZjQ5YjhjODUzMTU0OTMwN2Mx ZDYyNDFlZTdkYTk0N2Q5NGU0YmYuLjZlMTI2YzRiNGY3NjY2MGYxMzRlMzgyZjJiZjRjODFlNTQ3 YjNkMzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xheW91dFVuaXQuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9MYXlvdXRVbml0LmgKQEAgLTE5MCwxMiArMTkw LDE5IEBAIHB1YmxpYzoKICAgICBvcGVyYXRvciBkb3VibGUoKSBjb25zdCB7IHJldHVybiB0b0Rv dWJsZSgpOyB9CiAgICAgb3BlcmF0b3IgYm9vbCgpIGNvbnN0IHsgcmV0dXJuIG1fdmFsdWU7IH0K IAotICAgIExheW91dFVuaXQgb3BlcmF0b3IrKyhpbnQpCisgICAgTGF5b3V0VW5pdCYgb3BlcmF0 b3IrKygpCiAgICAgewogICAgICAgICBtX3ZhbHVlICs9IGtFZmZlY3RpdmVGaXhlZFBvaW50RGVu b21pbmF0b3I7CiAgICAgICAgIHJldHVybiAqdGhpczsKICAgICB9CiAKKyAgICBMYXlvdXRVbml0 IG9wZXJhdG9yKysoaW50KQorICAgIHsKKyAgICAgICAgTGF5b3V0VW5pdCByZXN1bHQgPSAqdGhp czsKKyAgICAgICAgKysoKnRoaXMpOworICAgICAgICByZXR1cm4gcmVzdWx0OworICAgIH0KKwog ICAgIGlubGluZSBpbnQgcmF3VmFsdWUoKSBjb25zdCB7IHJldHVybiBtX3ZhbHVlOyB9CiAgICAg aW5saW5lIHZvaWQgc2V0UmF3VmFsdWUoaW50IHZhbHVlKSB7IG1fdmFsdWUgPSB2YWx1ZTsgfQog ICAgIHZvaWQgc2V0UmF3VmFsdWUobG9uZyBsb25nIHZhbHVlKQo= 222907 2014-02-01 21:40:48 -0800 2014-02-01 23:40:47 -0800 Patch bug-128056-20140201214041.patch text/plain 1241 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2FlOGNmZGVkODYyYWEz NThkNWZiNGViOTI0Y2U0MGIxZWI3MGQzNi4uZTMzODM2NTQ2OTEyNjFkMTBhMTIwNzRmYjI0Y2Yx MDQzMWQxMDBhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAyLTAxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgU3VicGl4ZWwgcmVuZGVyaW5n OiBMYXlvdXRVbml0IG9wZXJhdG9yKysgaXMgYnJva2VuLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MDU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4gQWRsZXIuCisKKyAgICAgICAgQWRkIHByZS1pbmNyZW1lbnQgb3BlcmF0b3IrKy4KKwor ICAgICAgICAqIHBsYXRmb3JtL0xheW91dFVuaXQuaDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91 dFVuaXQ6Om9wZXJhdG9yKyspOgorCiAyMDE0LTAyLTAxICBBbGV4ZXkgUHJvc2t1cnlha292ICA8 YXBAYXBwbGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSBXZWJDcnlwdG8gSldLIG1hcHBpbmcgdG8g dXNlIGtleV9vcHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xheW91dFVu aXQuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xheW91dFVuaXQuaAppbmRleCA5MWY0OWI4 Yzg1MzE1NDkzMDdjMWQ2MjQxZWU3ZGE5NDdkOTRlNGJmLi45NzZjMDZhMzYyOWEyMGI1MmY1NTZl YmNkZjk3YWZiODdiNGQ0OTlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9M YXlvdXRVbml0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTGF5b3V0VW5pdC5oCkBA IC0xOTAsNyArMTkwLDcgQEAgcHVibGljOgogICAgIG9wZXJhdG9yIGRvdWJsZSgpIGNvbnN0IHsg cmV0dXJuIHRvRG91YmxlKCk7IH0KICAgICBvcGVyYXRvciBib29sKCkgY29uc3QgeyByZXR1cm4g bV92YWx1ZTsgfQogCi0gICAgTGF5b3V0VW5pdCBvcGVyYXRvcisrKGludCkKKyAgICBMYXlvdXRV bml0JiBvcGVyYXRvcisrKCkKICAgICB7CiAgICAgICAgIG1fdmFsdWUgKz0ga0VmZmVjdGl2ZUZp eGVkUG9pbnREZW5vbWluYXRvcjsKICAgICAgICAgcmV0dXJuICp0aGlzOwo=