128048 2014-02-01 12:24:56 -0800 SVGTextLayoutAttributesBuilder shouldn't use RenderText::deprecatedCharacters() 2014-02-01 12:32:30 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue d-r esprehn+autocc fmalita glenn gyuyoung.kim kondapallykalyan pdr schenney oldest_to_newest 974644 0 andersca 2014-02-01 12:24:56 -0800 SVGTextLayoutAttributesBuilder shouldn't use RenderText::deprecatedCharacters() 974646 1 222887 andersca 2014-02-01 12:28:12 -0800 Created attachment 222887 Patch 974647 2 andersca 2014-02-01 12:32:30 -0800 Committed r163248: <http://trac.webkit.org/changeset/163248> 222887 2014-02-01 12:28:12 -0800 2014-02-01 12:30:43 -0800 Patch bug-128048-20140201122814.patch text/plain 5843 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2Y4MWNlZDcyZTgxOWE5 NDQ5Njc1MThmZmU1ZDU4ZmVjOTgwYzkyMi4uZWRmN2E0ZmMzYmViMGQ1MTMxNTc3ZGFjNDU2MGEw ZDJmMzIxOGI4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE0LTAyLTAxICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgU1ZHVGV4dExheW91 dEF0dHJpYnV0ZXNCdWlsZGVyIHNob3VsZG4ndCB1c2UgUmVuZGVyVGV4dDo6ZGVwcmVjYXRlZENo YXJhY3RlcnMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTI4MDQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQ2hhbmdlIFVDaGFyKiYgbGFzdENoYXJhY3RlciB0byBib29sJiBsYXN0Q2hhcmFjdGVyV2Fz U3BhY2Ugc2luY2UgdGhhdCdzIHdoYXQgdGhlIHBhcmFtZXRlciB3YXMgdXNlZCBmb3IuCisKKyAg ICAgICAgKiByZW5kZXJpbmcvc3ZnL1NWR1RleHRMYXlvdXRBdHRyaWJ1dGVzQnVpbGRlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpTVkdUZXh0TGF5b3V0QXR0cmlidXRlc0J1aWxkZXI6OmJ1aWxk TGF5b3V0QXR0cmlidXRlc0ZvclRleHRSZW5kZXJlcik6CisgICAgICAgIEluaXRpYWxpemUgbGFz dENoYXJhY3Rlcldhc1NwYWNlIHRvIHRydWUgdG8gbWF0Y2ggdGhlIHByZXZpb3VzIGJlaGF2aW9y LgorCisgICAgICAgIChXZWJDb3JlOjpTVkdUZXh0TGF5b3V0QXR0cmlidXRlc0J1aWxkZXI6OmJ1 aWxkTGF5b3V0QXR0cmlidXRlc0ZvckZvclN1YnRyZWUpOgorICAgICAgICBEaXR0by4KKworICAg ICAgICAoV2ViQ29yZTo6cHJvY2Vzc1JlbmRlclNWR0lubGluZVRleHQpOgorICAgICAgICBUYWtl IGEgcmVmZXJlbmNlIGluc3RlYWQgb2YgYSBwb2ludGVyLCBnZXQgdGhlIGNoYXJhY3RlciB1c2lu ZyBSZW5kZXJUZXh0OjpvcGVyYXRvcltdIGFuZCBjb21wdXRlIGxhc3RDaGFyYWN0ZXJXYXNTcGFj ZS4KKworICAgICAgICAoV2ViQ29yZTo6U1ZHVGV4dExheW91dEF0dHJpYnV0ZXNCdWlsZGVyOjpj b2xsZWN0VGV4dFBvc2l0aW9uaW5nRWxlbWVudHMpOgorICAgICAgICBUaGlzIG5vdyB0YWtlcyBh IGJvb2wgcmVmZXJlbmNlIGluc3RlYWQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvc3ZnL1NWR1Rl eHRMYXlvdXRBdHRyaWJ1dGVzQnVpbGRlci5oOgorCiAyMDE0LTAyLTAxICBEYXZpZCBLaWx6ZXIg IDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHNlY3VyaXR5LWNoZWNrZWQgY2Fz dHMgZm9yIGFsbCBXZWJDb3JlOjpDYWNoZWRSZXNvdXJjZSBzdWJjbGFzc2VzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR1RleHRMYXlvdXRBdHRyaWJ1dGVzQnVp bGRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1NWR1RleHRMYXlvdXRBdHRy aWJ1dGVzQnVpbGRlci5jcHAKaW5kZXggMWRiYjAxZmQ5ZDQ4NDNhYWRhZjBjMjAyOGQyNGRhOGQ5 YzMzYWZlYy4uNjUyOGE5NmQ1NGFhYTc2MDAyOGI4NDBiYjg2MzY4NzNlOTRiNmVmMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdUZXh0TGF5b3V0QXR0cmlidXRl c0J1aWxkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHVGV4dExh eW91dEF0dHJpYnV0ZXNCdWlsZGVyLmNwcApAQCAtNDMsOCArNDMsOCBAQCB2b2lkIFNWR1RleHRM YXlvdXRBdHRyaWJ1dGVzQnVpbGRlcjo6YnVpbGRMYXlvdXRBdHRyaWJ1dGVzRm9yVGV4dFJlbmRl cmVyKFJlbmRlcgogICAgICAgICBtX2NoYXJhY3RlckRhdGFNYXAuY2xlYXIoKTsKIAogICAgICAg ICBtX3RleHRMZW5ndGggPSAwOwotICAgICAgICBjb25zdCBVQ2hhciogbGFzdENoYXJhY3RlciA9 IDA7Ci0gICAgICAgIGNvbGxlY3RUZXh0UG9zaXRpb25pbmdFbGVtZW50cyh0ZXh0Um9vdCwgbGFz dENoYXJhY3Rlcik7CisgICAgICAgIGJvb2wgbGFzdENoYXJhY3Rlcldhc1NwYWNlID0gdHJ1ZTsK KyAgICAgICAgY29sbGVjdFRleHRQb3NpdGlvbmluZ0VsZW1lbnRzKHRleHRSb290LCBsYXN0Q2hh cmFjdGVyV2FzU3BhY2UpOwogCiAgICAgICAgIGlmICghbV90ZXh0TGVuZ3RoKQogICAgICAgICAg ICAgcmV0dXJuOwpAQCAtNjMsOCArNjMsOCBAQCBib29sIFNWR1RleHRMYXlvdXRBdHRyaWJ1dGVz QnVpbGRlcjo6YnVpbGRMYXlvdXRBdHRyaWJ1dGVzRm9yRm9yU3VidHJlZShSZW5kZXJTVgogCiAg ICAgaWYgKG1fdGV4dFBvc2l0aW9ucy5pc0VtcHR5KCkpIHsKICAgICAgICAgbV90ZXh0TGVuZ3Ro ID0gMDsKLSAgICAgICAgY29uc3QgVUNoYXIqIGxhc3RDaGFyYWN0ZXIgPSAwOwotICAgICAgICBj b2xsZWN0VGV4dFBvc2l0aW9uaW5nRWxlbWVudHModGV4dFJvb3QsIGxhc3RDaGFyYWN0ZXIpOwor ICAgICAgICBib29sIGxhc3RDaGFyYWN0ZXJXYXNTcGFjZSA9IHRydWU7CisgICAgICAgIGNvbGxl Y3RUZXh0UG9zaXRpb25pbmdFbGVtZW50cyh0ZXh0Um9vdCwgbGFzdENoYXJhY3Rlcldhc1NwYWNl KTsKICAgICB9CiAKICAgICBpZiAoIW1fdGV4dExlbmd0aCkKQEAgLTgxLDMyICs4MSwzMCBAQCB2 b2lkIFNWR1RleHRMYXlvdXRBdHRyaWJ1dGVzQnVpbGRlcjo6cmVidWlsZE1ldHJpY3NGb3JUZXh0 UmVuZGVyZXIoUmVuZGVyU1ZHSW5saQogICAgIG1fbWV0cmljc0J1aWxkZXIubWVhc3VyZVRleHRS ZW5kZXJlcih0ZXh0KTsKIH0KIAotc3RhdGljIGlubGluZSB2b2lkIHByb2Nlc3NSZW5kZXJTVkdJ bmxpbmVUZXh0KFJlbmRlclNWR0lubGluZVRleHQqIHRleHQsIHVuc2lnbmVkJiBhdENoYXJhY3Rl ciwgY29uc3QgVUNoYXIqJiBsYXN0Q2hhcmFjdGVyKQorc3RhdGljIGlubGluZSB2b2lkIHByb2Nl c3NSZW5kZXJTVkdJbmxpbmVUZXh0KGNvbnN0IFJlbmRlclNWR0lubGluZVRleHQmIHRleHQsIHVu c2lnbmVkJiBhdENoYXJhY3RlciwgYm9vbCYgbGFzdENoYXJhY3Rlcldhc1NwYWNlKQogewotICAg IGlmICh0ZXh0LT5zdHlsZSgpLndoaXRlU3BhY2UoKSA9PSBQUkUpIHsKLSAgICAgICAgYXRDaGFy YWN0ZXIgKz0gdGV4dC0+dGV4dExlbmd0aCgpOworICAgIGlmICh0ZXh0LnN0eWxlKCkud2hpdGVT cGFjZSgpID09IFBSRSkgeworICAgICAgICBhdENoYXJhY3RlciArPSB0ZXh0LnRleHRMZW5ndGgo KTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJz ID0gdGV4dC0+ZGVwcmVjYXRlZENoYXJhY3RlcnMoKTsKLSAgICB1bnNpZ25lZCB0ZXh0TGVuZ3Ro ID0gdGV4dC0+dGV4dExlbmd0aCgpOyAgICAKLSAgICBmb3IgKHVuc2lnbmVkIHRleHRQb3NpdGlv biA9IDA7IHRleHRQb3NpdGlvbiA8IHRleHRMZW5ndGg7ICsrdGV4dFBvc2l0aW9uKSB7Ci0gICAg ICAgIGNvbnN0IFVDaGFyKiBjdXJyZW50Q2hhcmFjdGVyID0gY2hhcmFjdGVycyArIHRleHRQb3Np dGlvbjsKLSAgICAgICAgaWYgKCpjdXJyZW50Q2hhcmFjdGVyID09ICcgJyAmJiAoIWxhc3RDaGFy YWN0ZXIgfHwgKmxhc3RDaGFyYWN0ZXIgPT0gJyAnKSkKKyAgICBmb3IgKHVuc2lnbmVkIHRleHRQ b3NpdGlvbiA9IDAsIHRleHRMZW5ndGggPSB0ZXh0LnRleHRMZW5ndGgoKTsgdGV4dFBvc2l0aW9u IDwgdGV4dExlbmd0aDsgKyt0ZXh0UG9zaXRpb24pIHsKKyAgICAgICAgY29uc3QgVUNoYXIgY3Vy cmVudENoYXJhY3RlciA9IHRleHRbdGV4dFBvc2l0aW9uXTsKKyAgICAgICAgaWYgKGN1cnJlbnRD aGFyYWN0ZXIgPT0gJyAnICYmIGxhc3RDaGFyYWN0ZXJXYXNTcGFjZSkKICAgICAgICAgICAgIGNv bnRpbnVlOwogCi0gICAgICAgIGxhc3RDaGFyYWN0ZXIgPSBjdXJyZW50Q2hhcmFjdGVyOworICAg ICAgICBsYXN0Q2hhcmFjdGVyV2FzU3BhY2UgPSBjdXJyZW50Q2hhcmFjdGVyID09ICcgJzsKICAg ICAgICAgKythdENoYXJhY3RlcjsKICAgICB9CiB9CiAKLXZvaWQgU1ZHVGV4dExheW91dEF0dHJp YnV0ZXNCdWlsZGVyOjpjb2xsZWN0VGV4dFBvc2l0aW9uaW5nRWxlbWVudHMoUmVuZGVyT2JqZWN0 KiBzdGFydCwgY29uc3QgVUNoYXIqJiBsYXN0Q2hhcmFjdGVyKQordm9pZCBTVkdUZXh0TGF5b3V0 QXR0cmlidXRlc0J1aWxkZXI6OmNvbGxlY3RUZXh0UG9zaXRpb25pbmdFbGVtZW50cyhSZW5kZXJP YmplY3QqIHN0YXJ0LCBib29sJiBsYXN0Q2hhcmFjdGVyV2FzU3BhY2UpCiB7CiAgICAgQVNTRVJU KCFzdGFydC0+aXNTVkdUZXh0KCkgfHwgbV90ZXh0UG9zaXRpb25zLmlzRW1wdHkoKSk7CiAKICAg ICBmb3IgKFJlbmRlck9iamVjdCogY2hpbGQgPSBzdGFydC0+Zmlyc3RDaGlsZFNsb3coKTsgY2hp bGQ7IGNoaWxkID0gY2hpbGQtPm5leHRTaWJsaW5nKCkpIHsKICAgICAgICAgaWYgKGNoaWxkLT5p c1NWR0lubGluZVRleHQoKSkgewotICAgICAgICAgICAgcHJvY2Vzc1JlbmRlclNWR0lubGluZVRl eHQodG9SZW5kZXJTVkdJbmxpbmVUZXh0KGNoaWxkKSwgbV90ZXh0TGVuZ3RoLCBsYXN0Q2hhcmFj dGVyKTsKKyAgICAgICAgICAgIHByb2Nlc3NSZW5kZXJTVkdJbmxpbmVUZXh0KCp0b1JlbmRlclNW R0lubGluZVRleHQoY2hpbGQpLCBtX3RleHRMZW5ndGgsIGxhc3RDaGFyYWN0ZXJXYXNTcGFjZSk7 CiAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgfQogCkBAIC0xMTgsNyArMTE2LDcgQEAg dm9pZCBTVkdUZXh0TGF5b3V0QXR0cmlidXRlc0J1aWxkZXI6OmNvbGxlY3RUZXh0UG9zaXRpb25p bmdFbGVtZW50cyhSZW5kZXJPYmplY3QKICAgICAgICAgaWYgKGVsZW1lbnQpCiAgICAgICAgICAg ICBtX3RleHRQb3NpdGlvbnMuYXBwZW5kKFRleHRQb3NpdGlvbihlbGVtZW50LCBtX3RleHRMZW5n dGgpKTsKIAotICAgICAgICBjb2xsZWN0VGV4dFBvc2l0aW9uaW5nRWxlbWVudHMoY2hpbGQsIGxh c3RDaGFyYWN0ZXIpOworICAgICAgICBjb2xsZWN0VGV4dFBvc2l0aW9uaW5nRWxlbWVudHMoY2hp bGQsIGxhc3RDaGFyYWN0ZXJXYXNTcGFjZSk7CiAKICAgICAgICAgaWYgKCFlbGVtZW50KQogICAg ICAgICAgICAgY29udGludWU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv c3ZnL1NWR1RleHRMYXlvdXRBdHRyaWJ1dGVzQnVpbGRlci5oIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL3N2Zy9TVkdUZXh0TGF5b3V0QXR0cmlidXRlc0J1aWxkZXIuaAppbmRleCA1YWE2MGU5 MjNkM2Y0YzRhMWZiNTYwZGE3OTNjNDM1YzEyZTk3MTdjLi5lOTk0ODY0NDZiYzIyNjk0MDI3YmI5 Y2NjM2RkY2E2ZjYxMGU3M2M4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv c3ZnL1NWR1RleHRMYXlvdXRBdHRyaWJ1dGVzQnVpbGRlci5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9zdmcvU1ZHVGV4dExheW91dEF0dHJpYnV0ZXNCdWlsZGVyLmgKQEAgLTY2LDcg KzY2LDcgQEAgcHJpdmF0ZToKICAgICB9OwogCiAgICAgdm9pZCBidWlsZENoYXJhY3RlckRhdGFN YXAoUmVuZGVyU1ZHVGV4dCopOwotICAgIHZvaWQgY29sbGVjdFRleHRQb3NpdGlvbmluZ0VsZW1l bnRzKFJlbmRlck9iamVjdCosIGNvbnN0IFVDaGFyKiYgbGFzdENoYXJhY3Rlcik7CisgICAgdm9p ZCBjb2xsZWN0VGV4dFBvc2l0aW9uaW5nRWxlbWVudHMoUmVuZGVyT2JqZWN0KiwgYm9vbCYgbGFz dENoYXJhY3Rlcldhc1NwYWNlKTsKICAgICB2b2lkIGZpbGxDaGFyYWN0ZXJEYXRhTWFwKGNvbnN0 IFRleHRQb3NpdGlvbiYpOwogCiBwcml2YXRlOgo=