128045 2014-02-01 11:14:42 -0800 Saying "jitType() == JITCode::DFGJIT" is almost never correct 2014-02-01 12:26:39 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 112840 1 fpizlo mark.lam barraclough fpizlo ggaren mark.lam mhahnenberg mmirman msaboff oliver sam oldest_to_newest 974636 0 fpizlo 2014-02-01 11:14:42 -0800 JITCode::isOptimizingJIT(jitType()) is the right way to say it. There is at least one place in the profiling/debugging code where we make this mistake. 974641 1 mark.lam 2014-02-01 11:59:51 -0800 (In reply to comment #0) > JITCode::isOptimizingJIT(jitType()) is the right way to say it. > > There is at least one place in the profiling/debugging code where we make this mistake. That was deliberate because it was assumed that we would have never optimized to the FTL tier if the debugger or profiler is enabled. But I’ll be changing it anyway because we’ll want to enable the FTL as well soon. 974642 2 222885 mark.lam 2014-02-01 12:15:35 -0800 Created attachment 222885 the patch. 974643 3 222886 mark.lam 2014-02-01 12:22:30 -0800 Created attachment 222886 Oops missing a ')'. Here's the fixed patch for landing. 974645 4 mark.lam 2014-02-01 12:26:39 -0800 Thanks. Landed in r163247: <http://trac.webkit.org/r163247>. 222885 2014-02-01 12:15:35 -0800 2014-02-01 12:22:30 -0800 the patch. bug-128045.patch text/plain 2215 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYzMjQ2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE0LTAyLTAxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBT YXlpbmcgImppdFR5cGUoKSA9PSBKSVRDb2RlOjpERkdKSVQiIGlzIGFsbW9zdCBuZXZlciBjb3Jy ZWN0LgorICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMjgwNDU+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSklUQ29kZTo6aXNPcHRpbWl6aW5n SklUKGppdFR5cGUoKSkgaXMgdGhlIHJpZ2h0IHdheSB0byBzYXkgaXQuCisKKyAgICAgICAgKiBi eXRlY29kZS9Db2RlQmxvY2suY3BwOgorICAgICAgICAoSlNDOjpDb2RlQmxvY2s6OmFkZEJyZWFr cG9pbnQpOgorICAgICAgICAoSlNDOjpDb2RlQmxvY2s6OnNldFN0ZXBwaW5nTW9kZSk6CisgICAg ICAgICogcnVudGltZS9WTS5jcHA6CisgICAgICAgIChKU0M6OlNldEVuYWJsZWRQcm9maWxlckZ1 bmN0b3I6Om9wZXJhdG9yKCkpOgorCiAyMDE0LTAyLTAxICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJv ZmZAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxNjMwMjc/KTogQ3Jhc2hUcmFj ZXI6IFtVU0VSXSBjb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuRGV2ZWxvcG1lbnQgYXQgY29t LmFwcGxlLkphdmFTY3JpcHRDb3JlOiBKU0M6OkFycmF5UHJvZmlsZTo6Y29tcHV0ZVVwZGF0ZWRQ cmVkaWN0aW9uICsgNApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVC bG9jay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0Nv ZGVCbG9jay5jcHAJKHJldmlzaW9uIDE2MzI0NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9i eXRlY29kZS9Db2RlQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNTU4LDE0ICszNTU4LDE0 IEBAIHZvaWQgQ29kZUJsb2NrOjphZGRCcmVha3BvaW50KHVuc2lnbmVkIG4KIHsKICAgICBtX251 bUJyZWFrcG9pbnRzICs9IG51bUJyZWFrcG9pbnRzOwogICAgIEFTU0VSVChtX251bUJyZWFrcG9p bnRzKTsKLSAgICBpZiAoaml0VHlwZSgpID09IEpJVENvZGU6OkRGR0pJVCkKKyAgICBpZiAoSklU Q29kZTo6aXNPcHRpbWl6aW5nSklUKGppdFR5cGUoKSkpCiAgICAgICAgIGpldHRpc29uKCk7CiB9 CiAKIHZvaWQgQ29kZUJsb2NrOjpzZXRTdGVwcGluZ01vZGUoQ29kZUJsb2NrOjpTdGVwcGluZ01v ZGUgbW9kZSkKIHsKICAgICBtX3N0ZXBwaW5nTW9kZSA9IG1vZGU7Ci0gICAgaWYgKG1vZGUgPT0g U3RlcHBpbmdNb2RlRW5hYmxlZCAmJiBqaXRUeXBlKCkgPT0gSklUQ29kZTo6REZHSklUKQorICAg IGlmIChtb2RlID09IFN0ZXBwaW5nTW9kZUVuYWJsZWQgJiYgSklUQ29kZTo6aXNPcHRpbWl6aW5n SklUKGppdFR5cGUoKSkpCiAgICAgICAgIGpldHRpc29uKCk7CiB9CiAKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9WTS5jcHAJKHJldmlzaW9uIDE2MzI0NikKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODM1LDcgKzgzNSw3 IEBAIGNsYXNzIFNldEVuYWJsZWRQcm9maWxlckZ1bmN0b3IgewogcHVibGljOgogICAgIGJvb2wg b3BlcmF0b3IoKShDb2RlQmxvY2sqIGNvZGVCbG9jaykKICAgICB7Ci0gICAgICAgIGlmIChjb2Rl QmxvY2stPmppdFR5cGUoKSA9PSBKSVRDb2RlOjpERkdKSVQpCisgICAgICAgIGlmIChKSVRDb2Rl Ojppc09wdGltaXppbmdKSVQoY29kZUJsb2NrLT5qaXRUeXBlKCkpCiAgICAgICAgICAgICBjb2Rl QmxvY2stPmpldHRpc29uKCk7CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9Cg== 222886 2014-02-01 12:22:30 -0800 2014-02-01 12:22:30 -0800 Oops missing a ')'. Here's the fixed patch for landing. bug-128045.patch text/plain 2213 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYzMjQ2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE0LTAyLTAxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBT YXlpbmcgImppdFR5cGUoKSA9PSBKSVRDb2RlOjpERkdKSVQiIGlzIGFsbW9zdCBuZXZlciBjb3Jy ZWN0LgorICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMjgwNDU+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgRmlsaXAgUGl6bG8uCisKKyAgICAgICAgSklUQ29kZTo6aXNPcHRpbWl6aW5nSklU KGppdFR5cGUoKSkgaXMgdGhlIHJpZ2h0IHdheSB0byBzYXkgaXQuCisKKyAgICAgICAgKiBieXRl Y29kZS9Db2RlQmxvY2suY3BwOgorICAgICAgICAoSlNDOjpDb2RlQmxvY2s6OmFkZEJyZWFrcG9p bnQpOgorICAgICAgICAoSlNDOjpDb2RlQmxvY2s6OnNldFN0ZXBwaW5nTW9kZSk6CisgICAgICAg ICogcnVudGltZS9WTS5jcHA6CisgICAgICAgIChKU0M6OlNldEVuYWJsZWRQcm9maWxlckZ1bmN0 b3I6Om9wZXJhdG9yKCkpOgorCiAyMDE0LTAyLTAxICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZA YXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxNjMwMjc/KTogQ3Jhc2hUcmFjZXI6 IFtVU0VSXSBjb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuRGV2ZWxvcG1lbnQgYXQgY29tLmFw cGxlLkphdmFTY3JpcHRDb3JlOiBKU0M6OkFycmF5UHJvZmlsZTo6Y29tcHV0ZVVwZGF0ZWRQcmVk aWN0aW9uICsgNApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9j ay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVC bG9jay5jcHAJKHJldmlzaW9uIDE2MzI0NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRl Y29kZS9Db2RlQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNTU4LDE0ICszNTU4LDE0IEBA IHZvaWQgQ29kZUJsb2NrOjphZGRCcmVha3BvaW50KHVuc2lnbmVkIG4KIHsKICAgICBtX251bUJy ZWFrcG9pbnRzICs9IG51bUJyZWFrcG9pbnRzOwogICAgIEFTU0VSVChtX251bUJyZWFrcG9pbnRz KTsKLSAgICBpZiAoaml0VHlwZSgpID09IEpJVENvZGU6OkRGR0pJVCkKKyAgICBpZiAoSklUQ29k ZTo6aXNPcHRpbWl6aW5nSklUKGppdFR5cGUoKSkpCiAgICAgICAgIGpldHRpc29uKCk7CiB9CiAK IHZvaWQgQ29kZUJsb2NrOjpzZXRTdGVwcGluZ01vZGUoQ29kZUJsb2NrOjpTdGVwcGluZ01vZGUg bW9kZSkKIHsKICAgICBtX3N0ZXBwaW5nTW9kZSA9IG1vZGU7Ci0gICAgaWYgKG1vZGUgPT0gU3Rl cHBpbmdNb2RlRW5hYmxlZCAmJiBqaXRUeXBlKCkgPT0gSklUQ29kZTo6REZHSklUKQorICAgIGlm IChtb2RlID09IFN0ZXBwaW5nTW9kZUVuYWJsZWQgJiYgSklUQ29kZTo6aXNPcHRpbWl6aW5nSklU KGppdFR5cGUoKSkpCiAgICAgICAgIGpldHRpc29uKCk7CiB9CiAKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9WTS5jcHAJKHJldmlzaW9uIDE2MzI0NikKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL1ZNLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODM1LDcgKzgzNSw3IEBA IGNsYXNzIFNldEVuYWJsZWRQcm9maWxlckZ1bmN0b3IgewogcHVibGljOgogICAgIGJvb2wgb3Bl cmF0b3IoKShDb2RlQmxvY2sqIGNvZGVCbG9jaykKICAgICB7Ci0gICAgICAgIGlmIChjb2RlQmxv Y2stPmppdFR5cGUoKSA9PSBKSVRDb2RlOjpERkdKSVQpCisgICAgICAgIGlmIChKSVRDb2RlOjpp c09wdGltaXppbmdKSVQoY29kZUJsb2NrLT5qaXRUeXBlKCkpKQogICAgICAgICAgICAgY29kZUJs b2NrLT5qZXR0aXNvbigpOwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQo=