128040 2014-01-31 22:45:26 -0800 IDB: Handle "nextunique" and "prevunique" cursors, and handle "advance()" correctly 2014-01-31 23:00:03 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 124521 1 beidson beidson oldest_to_newest 974581 0 beidson 2014-01-31 22:45:26 -0800 IDB: Handle "nextunique" and "prevunique" cursors, and handle "advance()" correctly 974582 1 222873 beidson 2014-01-31 22:47:31 -0800 Created attachment 222873 Patch v1 974583 2 222873 jer.noble 2014-01-31 22:57:55 -0800 Comment on attachment 222873 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=222873&action=review r=me with not even a nit, just a feckless comment: > Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:213 > + bool isUnique = m_cursorDirection == IndexedDB::CursorDirection::NextNoDuplicate || m_cursorDirection == IndexedDB::CursorDirection::PrevNoDuplicate; This is slightly confusing, but I can't come up with a better solution here, so. 974584 3 beidson 2014-01-31 23:00:03 -0800 http://trac.webkit.org/changeset/163237 222873 2014-01-31 22:47:31 -0800 2014-01-31 22:57:55 -0800 Patch v1 patch text/plain 3053 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5M2VlYmVjNy4uZDJiMmU1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5 IEBACiAyMDE0LTAxLTMxICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAorICAg ICAgICBJREI6IEhhbmRsZSAibmV4dHVuaXF1ZSIgYW5kICJwcmV2dW5pcXVlIiBjdXJzb3JzLCBh bmQgaGFuZGxlICJhZHZhbmNlKCkiIGNvcnJlY3RseQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MDQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEYXRhYmFzZVByb2Nlc3MvSW5kZXhlZERCL3NxbGl0 ZS9TUUxpdGVJREJDdXJzb3IuY3BwOgorICAgICAgICAoV2ViS2l0OjpTUUxpdGVJREJDdXJzb3I6 OmFkdmFuY2UpOiBFbnRyeSBwb2ludCBmb3IgYWR2YW5jaW5nIGJ5IGEgbnVtYmVyIG9mIHN0ZXBz LAorICAgICAgICAgIGNhbGxzIGVpdGhlciBhZHZhbmNlVW5pcXVlIG9yIGFkdmFuY2VPbmNlIHRo ZSBhcHByb3ByaWF0ZSBudW1iZXIgb2YgdGltZXMuCisgICAgICAgIChXZWJLaXQ6OlNRTGl0ZUlE QkN1cnNvcjo6YWR2YW5jZVVuaXF1ZSk6IENhbGwgYWR2YW5jZU9uY2UgdW50aWwgdGhlIGtleSBo YXMgY2hhbmdlZC4KKyAgICAgICAgKFdlYktpdDo6U1FMaXRlSURCQ3Vyc29yOjphZHZhbmNlT25j ZSk6CisgICAgICAgICogRGF0YWJhc2VQcm9jZXNzL0luZGV4ZWREQi9zcWxpdGUvU1FMaXRlSURC Q3Vyc29yLmg6CisKKzIwMTQtMDEtMzEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29t PgorCiAgICAgICAgIElEQjogSW5kZXggY3Vyc29ycyB1c2Ugd3JvbmcgZGVzZXJpYWxpemF0aW9u IGZvciB0aGUgcmV0cmlldmVkIHZhbHVlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjgwMzUKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvRGF0 YWJhc2VQcm9jZXNzL0luZGV4ZWREQi9zcWxpdGUvU1FMaXRlSURCQ3Vyc29yLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL0RhdGFiYXNlUHJvY2Vzcy9JbmRleGVkREIvc3FsaXRlL1NRTGl0ZUlEQkN1cnNv ci5jcHAKaW5kZXggZTQ2NTE4Mi4uYTE1MjUwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv RGF0YWJhc2VQcm9jZXNzL0luZGV4ZWREQi9zcWxpdGUvU1FMaXRlSURCQ3Vyc29yLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9EYXRhYmFzZVByb2Nlc3MvSW5kZXhlZERCL3NxbGl0ZS9TUUxpdGVJ REJDdXJzb3IuY3BwCkBAIC0yMTAsNiArMjEwLDQxIEBAIGJvb2wgU1FMaXRlSURCQ3Vyc29yOjpj cmVhdGVTUUxpdGVTdGF0ZW1lbnQoY29uc3QgU3RyaW5nJiBzcWwsIGludDY0X3QgaWRUb0JpbmQp CiAKIGJvb2wgU1FMaXRlSURCQ3Vyc29yOjphZHZhbmNlKHVpbnQ2NF90IGNvdW50KQogeworICAg IGJvb2wgaXNVbmlxdWUgPSBtX2N1cnNvckRpcmVjdGlvbiA9PSBJbmRleGVkREI6OkN1cnNvckRp cmVjdGlvbjo6TmV4dE5vRHVwbGljYXRlIHx8IG1fY3Vyc29yRGlyZWN0aW9uID09IEluZGV4ZWRE Qjo6Q3Vyc29yRGlyZWN0aW9uOjpQcmV2Tm9EdXBsaWNhdGU7CisKKyAgICBmb3IgKHVpbnQ2NF90 IGkgPSAwOyBpIDwgY291bnQ7ICsraSkgeworICAgICAgICBpZiAoIWlzVW5pcXVlKSB7CisgICAg ICAgICAgICBpZiAoIWFkdmFuY2VPbmNlKCkpCisgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNl OworICAgICAgICAgICAgY29udGludWU7CisgICAgICAgIH0KKworICAgICAgICBpZiAoIWFkdmFu Y2VVbmlxdWUoKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CisKKyAgICByZXR1 cm4gdHJ1ZTsKK30KKworYm9vbCBTUUxpdGVJREJDdXJzb3I6OmFkdmFuY2VVbmlxdWUoKQorewor ICAgIElEQktleURhdGEgY3VycmVudEtleSA9IG1fY3VycmVudEtleTsKKworICAgIHdoaWxlICgh bV9jb21wbGV0ZWQpIHsKKyAgICAgICAgaWYgKCFhZHZhbmNlT25jZSgpKQorICAgICAgICAgICAg cmV0dXJuIGZhbHNlOworCisgICAgICAgIC8vIElmIHRoZSBuZXcgY3VycmVudCBrZXkgaXMgZGlm ZmVyZW50IGZyb20gdGhlIG9sZCBjdXJyZW50IGtleSwgd2UncmUgZG9uZS4KKyAgICAgICAgaWYg KGN1cnJlbnRLZXkuY29tcGFyZShtX2N1cnJlbnRLZXkpKQorICAgICAgICAgICAgcmV0dXJuIHRy dWU7CisgICAgfQorCisgICAgcmV0dXJuIGZhbHNlOworfQorCisKK2Jvb2wgU1FMaXRlSURCQ3Vy c29yOjphZHZhbmNlT25jZSgpCit7CiAgICAgQVNTRVJUKG1fdHJhbnNhY3Rpb24tPnNxbGl0ZVRy YW5zYWN0aW9uKCkpOwogICAgIEFTU0VSVChtX3N0YXRlbWVudCk7CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL0RhdGFiYXNlUHJvY2Vzcy9JbmRleGVkREIvc3FsaXRlL1NRTGl0ZUlEQkN1 cnNvci5oIGIvU291cmNlL1dlYktpdDIvRGF0YWJhc2VQcm9jZXNzL0luZGV4ZWREQi9zcWxpdGUv U1FMaXRlSURCQ3Vyc29yLmgKaW5kZXggYzViZDNiMi4uNjQwOTUyZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvRGF0YWJhc2VQcm9jZXNzL0luZGV4ZWREQi9zcWxpdGUvU1FMaXRlSURCQ3Vy c29yLmgKKysrIGIvU291cmNlL1dlYktpdDIvRGF0YWJhc2VQcm9jZXNzL0luZGV4ZWREQi9zcWxp dGUvU1FMaXRlSURCQ3Vyc29yLmgKQEAgLTcwLDYgKzcwLDkgQEAgcHJpdmF0ZToKICAgICBib29s IGVzdGFibGlzaFN0YXRlbWVudCgpOwogICAgIGJvb2wgY3JlYXRlU1FMaXRlU3RhdGVtZW50KGNv bnN0IFN0cmluZyYgc3FsLCBpbnQ2NF90IGlkVG9CaW5kKTsKIAorICAgIGJvb2wgYWR2YW5jZU9u Y2UoKTsKKyAgICBib29sIGFkdmFuY2VVbmlxdWUoKTsKKwogICAgIFNRTGl0ZUlEQlRyYW5zYWN0 aW9uKiBtX3RyYW5zYWN0aW9uOwogICAgIElEQklkZW50aWZpZXIgbV9jdXJzb3JJZGVudGlmaWVy OwogICAgIGludDY0X3QgbV9vYmplY3RTdG9yZUlEOwo=