12804 2007-02-18 05:06:31 -0800 REGRESSION (r19043-r19063): suggestion popup doesn't work after pressing Option+Esc 2007-02-22 07:57:29 -0800 1 1 1 Unclassified WebKit HTML Editing 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 ap webkit-unassigned adele KwhiteRight mitz oldest_to_newest 22585 0 ap 2007-02-18 05:06:31 -0800 Steps to reproduce: 1. Type something in a text filed (e.g. in this Bugzilla bug). 2. Press Option+Esc Results: a suggestion popup appears for a moment, but disappears immediately. See also: bug 11573 22361 1 mitz 2007-02-21 13:17:35 -0800 Probably introduced in <http://trac.webkit.org/projects/webkit/changeset/19049>. 22348 2 13305 mitz 2007-02-21 14:43:04 -0800 Created attachment 13305 Don't let the event that opened the popup close it; fix another suggestion popup bug 22290 3 13305 mjs 2007-02-22 02:56:05 -0800 Comment on attachment 13305 Don't let the event that opened the popup close it; fix another suggestion popup bug r=me 22270 4 sam 2007-02-22 07:57:29 -0800 Landed in r19790. 13305 2007-02-21 14:43:04 -0800 2007-02-22 02:56:05 -0800 Don't let the event that opened the popup close it; fix another suggestion popup bug 12804_r1.patch text/plain 3992 mitz SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMTk3NzcpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMjQgQEAKKzIwMDctMDItMjIgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4IGh0 dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODA0CisgICAgICAgICAgUkVH UkVTU0lPTiAocjE5MDQzLXIxOTA2Myk6IHN1Z2dlc3Rpb24gcG9wdXAgZG9lc24ndCB3b3JrIGFm dGVyIHByZXNzaW5nIE9wdGlvbitFc2MKKworICAgICAgICBUaGlzIHBhdGNoIGFsc28gZml4ZXMg YSBidWcgd2hlcmUgdXNpbmcgdGhlIGFycm93IGtleXMgd2hpbGUKKyAgICAgICAgdGhlIHN1Z2dl c3Rpb24gcG9wdXAgaXMgb3BlbiBtb3ZlcyB0aGUgY2FyZXQgaW5zdGVhZCBvZiBjaGFuZ2luZyB0 aGUKKyAgICAgICAgc2VsZWN0aW9uIGluIHRoZSBwb3B1cCAoZm9yIHVwL2Rvd24pIG9yIGFjY2Vw dGluZyB0aGUgc2VsZWN0aW9uIGFuZAorICAgICAgICBjbG9zaW5nIHRoZSBwb3B1cCAoZm9yIGxl ZnQvcmlnaHQpLgorCisgICAgICAgICogV2ViVmlldy9XZWJIVE1MVmlldy5tbToKKyAgICAgICAg KC1bV2ViSFRNTFZpZXcga2V5RG93bjpdKTogQ2hhbmdlZCB0byBjbG9zZSB0aGUgcG9wdXAgb25s eSBpZiBpdCB3YXMgb3BlbgorICAgICAgICBiZWZvcmUgdGhlIGN1cnJlbnQgZXZlbnQsIHNvIHRo YXQgdGhlIE9wdGlvbi1Fc2MgdGhhdCBvcGVucyB0aGUgcG9wdXAgd2lsbAorICAgICAgICBub3Qg Y2xvc2UgaXQgaW1tZWRpYXRlbHkuCisgICAgICAgICgtW1dlYkhUTUxWaWV3IF9pbnRlcmNlcHRF ZGl0aW5nS2V5RXZlbnQ6XSk6IEdpdmUgdGhlIGNvbXBsZXRpb24gcG9wdXAgYQorICAgICAgICBj aGFuY2UgdG8gaW50ZXJjZXB0IGtleWRvd24gZXZlbnRzLgorICAgICAgICAoLVtXZWJUZXh0Q29t cGxldGVDb250cm9sbGVyIHBvcHVwV2luZG93SXNPcGVuXSk6IEFkZGVkLiBSZXR1cm5zIHdoZXRo ZXIgdGhlCisgICAgICAgIHN1Z2dlc3Rpb24gcG9wdXAgaXMgb3Blbi4KKwogMjAwNy0wMi0yMCAg QmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFj aWVqLgpJbmRleDogV2ViS2l0L1dlYlZpZXcvV2ViSFRNTFZpZXcubW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L1dlYlZpZXcvV2ViSFRNTFZpZXcubW0JKHJldmlzaW9uIDE5NzY4KQorKysgV2ViS2l0 L1dlYlZpZXcvV2ViSFRNTFZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTI2OCw2ICsyNjgsNyBA QCBzdGF0aWMgV2ViSFRNTFZpZXcgKmxhc3RIaXRWaWV3OwogLSAoaWQpaW5pdFdpdGhIVE1MVmll dzooV2ViSFRNTFZpZXcgKil2aWV3OwogLSAodm9pZClkb0NvbXBsZXRpb247CiAtICh2b2lkKWVu ZFJldmVydGluZ0NoYW5nZTooQk9PTClyZXZlcnRDaGFuZ2UgbW92ZUxlZnQ6KEJPT0wpZ29MZWZ0 OworLSAoQk9PTClwb3B1cFdpbmRvd0lzT3BlbjsKIC0gKEJPT0wpZmlsdGVyS2V5RG93bjooTlNF dmVudCAqKWV2ZW50OwogLSAodm9pZClfcmVmbGVjdFNlbGVjdGlvbjsKIEBlbmQKQEAgLTMzODEs MTIgKzMzODIsMTMgQEAgZG9uZToKICAgICBbX3ByaXZhdGUtPmtleURvd25FdmVudCByZWxlYXNl XTsKICAgICBfcHJpdmF0ZS0+a2V5RG93bkV2ZW50ID0gW2V2ZW50IHJldGFpbl07CiAKKyAgICBC T09MIGNvbXBsZXRpb25Qb3B1cFdhc09wZW4gPSBfcHJpdmF0ZS0+Y29tcENvbnRyb2xsZXIgJiYg W19wcml2YXRlLT5jb21wQ29udHJvbGxlciBwb3B1cFdpbmRvd0lzT3Blbl07CiAgICAgaWYgKCFl dmVudFdhc1NlbnRUb1dlYkNvcmUgJiYgY29yZShbc2VsZiBfZnJhbWVdKS0+ZXZlbnRIYW5kbGVy KCktPmtleUV2ZW50KGV2ZW50KSkgewotICAgICAgICAvLyBXZWJDb3JlIHByb2Nlc3NlZCBhIGtl eSBldmVudCwgYmFpbCBvbiBhbnkgb3V0c3RhbmRpbmcgY29tcGxldGU6IFVJCi0gICAgICAgIFtf cHJpdmF0ZS0+Y29tcENvbnRyb2xsZXIgZW5kUmV2ZXJ0aW5nQ2hhbmdlOllFUyBtb3ZlTGVmdDpO T107Ci0gICAgfSBlbHNlIGlmIChfcHJpdmF0ZS0+Y29tcENvbnRyb2xsZXIgJiYgW19wcml2YXRl LT5jb21wQ29udHJvbGxlciBmaWx0ZXJLZXlEb3duOmV2ZW50XSkgewotICAgICAgICAvLyBDb25z dW1lZCBieSBjb21wbGV0ZTogcG9wdXAgd2luZG93Ci0gICAgfSBlbHNlIHsKKyAgICAgICAgLy8g V2ViQ29yZSBwcm9jZXNzZWQgYSBrZXkgZXZlbnQsIGJhaWwgb24gYW55IHByZWV4aXN0aW5nIGNv bXBsZXRlOiBVSQorICAgICAgICBpZiAoY29tcGxldGlvblBvcHVwV2FzT3BlbikKKyAgICAgICAg ICAgIFtfcHJpdmF0ZS0+Y29tcENvbnRyb2xsZXIgZW5kUmV2ZXJ0aW5nQ2hhbmdlOllFUyBtb3Zl TGVmdDpOT107CisgICAgfSBlbHNlIGlmICghX3ByaXZhdGUtPmNvbXBDb250cm9sbGVyIHx8ICFb X3ByaXZhdGUtPmNvbXBDb250cm9sbGVyIGZpbHRlcktleURvd246ZXZlbnRdKSB7CisgICAgICAg IC8vIE5vdCBjb25zdW1lZCBieSBjb21wbGV0ZTogcG9wdXAgd2luZG93CiAgICAgICAgIFtfcHJp dmF0ZS0+Y29tcENvbnRyb2xsZXIgZW5kUmV2ZXJ0aW5nQ2hhbmdlOllFUyBtb3ZlTGVmdDpOT107 CiAgICAgICAgIGNhbGxTdXBlciA9IFlFUzsKICAgICB9CkBAIC01MjMwLDkgKzUyMzIsMTIgQEAg c3RhdGljIENHUG9pbnQgY29yZUdyYXBoaWNzU2NyZWVuUG9pbnRGbwogICAgIFdlYkhUTUxWaWV3 SW50ZXJwcmV0S2V5RXZlbnRzUGFyYW1ldGVycyBwYXJhbWV0ZXJzOwogICAgIHBhcmFtZXRlcnMu ZXZlbnRXYXNIYW5kbGVkID0gZmFsc2U7CiAgICAgaWYgKGNvbnN0IFBsYXRmb3JtS2V5Ym9hcmRF dmVudCogcGxhdGZvcm1FdmVudCA9IGV2ZW50LT5rZXlFdmVudCgpKSB7CisgICAgICAgIE5TRXZl bnQgKm1hY0V2ZW50ID0gcGxhdGZvcm1FdmVudC0+bWFjRXZlbnQoKTsKKyAgICAgICAgaWYgKFtt YWNFdmVudCB0eXBlXSA9PSBOU0tleURvd24gJiYgW19wcml2YXRlLT5jb21wQ29udHJvbGxlciBm aWx0ZXJLZXlEb3duOm1hY0V2ZW50XSkKKyAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAg ICBwYXJhbWV0ZXJzLmV2ZW50ID0gZXZlbnQ7CiAgICAgICAgIF9wcml2YXRlLT5pbnRlcnByZXRL ZXlFdmVudHNQYXJhbWV0ZXJzID0gJnBhcmFtZXRlcnM7Ci0gICAgICAgIFtzZWxmIGludGVycHJl dEtleUV2ZW50czpbTlNBcnJheSBhcnJheVdpdGhPYmplY3Q6cGxhdGZvcm1FdmVudC0+bWFjRXZl bnQoKV1dOworICAgICAgICBbc2VsZiBpbnRlcnByZXRLZXlFdmVudHM6W05TQXJyYXkgYXJyYXlX aXRoT2JqZWN0Om1hY0V2ZW50XV07CiAgICAgICAgIF9wcml2YXRlLT5pbnRlcnByZXRLZXlFdmVu dHNQYXJhbWV0ZXJzID0gMDsKICAgICB9CiAgICAgcmV0dXJuIHBhcmFtZXRlcnMuZXZlbnRXYXNI YW5kbGVkOwpAQCAtNTc2Niw2ICs1NzcxLDExIEBAIHN0YXRpYyBDR1BvaW50IGNvcmVHcmFwaGlj c1NjcmVlblBvaW50Rm8KICAgICAvLyBlbHNlIHRoZXJlIGlzIG5vIHN0YXRlIHRvIGFib3J0IGlm IHRoZSB3aW5kb3cgd2FzIG5vdCB1cAogfQogCistIChCT09MKXBvcHVwV2luZG93SXNPcGVuCit7 CisgICAgcmV0dXJuIF9wb3B1cFdpbmRvdyAhPSBuaWw7Cit9CisKIC8vIFdlYkhUTUxWaWV3IGdp dmVzIHVzIGEgY3JhY2sgYXQga2V5IGV2ZW50cyBpdCBzZWVzLiAgUmV0dXJuIHdoZXRoZXIgd2Ug Y29uc3VtZWQgdGhlIGV2ZW50LgogLy8gVGhlIGZlYXR1cmVzIGZvciB0aGUgdmFyaW91cyBrZXlz IG1pbWljIE5TVGV4dFZpZXcuCiAtIChCT09MKWZpbHRlcktleURvd246KE5TRXZlbnQgKilldmVu dAo=