128024 2014-01-31 15:02:04 -0800 Don't need a JSNameScope for the callee name just for the debugger 2014-01-31 15:14:26 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 127910 1 mark.lam mark.lam fpizlo ggaren joethomas mhahnenberg msaboff oliver timothy oldest_to_newest 974499 0 mark.lam 2014-01-31 15:02:04 -0800 Currently, in the bytecode for a function, we push a JSNamedScope for the name of the function when a debugger is attached. The name scope for the function name is only needed for evals which can redefined the name to resolve to something else, and can later delete the redefined name which should revert the resolution of the name to the original function. The debugger does not add the need for this functionality. Hence, we can remove the presence of the debugger as a criteria for pushing the JSNameScope. 974501 1 222859 mark.lam 2014-01-31 15:05:44 -0800 Created attachment 222859 the patch. 974502 2 222859 ggaren 2014-01-31 15:08:56 -0800 Comment on attachment 222859 the patch. View in context: https://bugs.webkit.org/attachment.cgi?id=222859&action=review r=me > Source/JavaScriptCore/ChangeLog:10 > + the function name is only needed for evals which can redefined the name "redefine" > Source/JavaScriptCore/ChangeLog:14 > + The debugger does not add the need for this functionality. Hence, we can > + remove the presence of the debugger as a criteria for pushing the The reason the debugger doesn't need this feature is that it declares all new vars in a temporary, nested scope. 974505 3 mark.lam 2014-01-31 15:14:07 -0800 Thanks. Landed in r163210: <http://trac.webkit.org/r163210>. 222859 2014-01-31 15:05:44 -0800 2014-01-31 15:08:55 -0800 the patch. bug-128024.patch text/plain 2463 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYzMjA3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE0LTAxLTMxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBE b24ndCBuZWVkIGEgSlNOYW1lU2NvcGUgZm9yIHRoZSBjYWxsZWUgbmFtZSBqdXN0IGZvciB0aGUg ZGVidWdnZXIuCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjgwMjQ+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudGx5LCBpbiB0 aGUgYnl0ZWNvZGUgZm9yIGEgZnVuY3Rpb24sIHdlIHB1c2ggYSBKU05hbWVkU2NvcGUgZm9yCisg ICAgICAgIHRoZSBuYW1lIG9mIHRoZSBmdW5jdGlvbiB3aGVuIGEgZGVidWdnZXIgaXMgYXR0YWNo ZWQuIFRoZSBuYW1lIHNjb3BlIGZvcgorICAgICAgICB0aGUgZnVuY3Rpb24gbmFtZSBpcyBvbmx5 IG5lZWRlZCBmb3IgZXZhbHMgd2hpY2ggY2FuIHJlZGVmaW5lZCB0aGUgbmFtZQorICAgICAgICB0 byByZXNvbHZlIHRvIHNvbWV0aGluZyBlbHNlLCBhbmQgY2FuIGxhdGVyIGRlbGV0ZSB0aGUgcmVk ZWZpbmVkIG5hbWUKKyAgICAgICAgd2hpY2ggc2hvdWxkIHJldmVydCB0aGUgcmVzb2x1dGlvbiBv ZiB0aGUgbmFtZSB0byB0aGUgb3JpZ2luYWwgZnVuY3Rpb24uCisgICAgICAgIFRoZSBkZWJ1Z2dl ciBkb2VzIG5vdCBhZGQgdGhlIG5lZWQgZm9yIHRoaXMgZnVuY3Rpb25hbGl0eS4gSGVuY2UsIHdl IGNhbgorICAgICAgICByZW1vdmUgdGhlIHByZXNlbmNlIG9mIHRoZSBkZWJ1Z2dlciBhcyBhIGNy aXRlcmlhIGZvciBwdXNoaW5nIHRoZQorICAgICAgICBKU05hbWVTY29wZS4KKworICAgICAgICAq IGJ5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHA6CisgICAgICAgIChKU0M6OkJ5dGVj b2RlR2VuZXJhdG9yOjpyZXNvbHZlQ2FsbGVlKToKKyAgICAgICAgKEpTQzo6Qnl0ZWNvZGVHZW5l cmF0b3I6OmFkZENhbGxlZSk6CisKIDIwMTQtMDEtMzEgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFw cGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBidWlsZCBmaXguCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJh dG9yLmNwcAkocmV2aXNpb24gMTYzMTk3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVj b21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ5MCw3ICs0 OTAsNyBAQCBSZWdpc3RlcklEKiBCeXRlY29kZUdlbmVyYXRvcjo6cmVzb2x2ZUNhCiAgICAgbV9j YWxsZWVSZWdpc3Rlci5zZXRJbmRleChKU1N0YWNrOjpDYWxsZWUpOwogCiAgICAgLy8gSWYgbm9u LXN0cmljdCBldmFsIGlzIGluIHBsYXksIHdlIHVzZSBhIHNlcGFyYXRlIG9iamVjdCBpbiB0aGUg c2NvcGUgY2hhaW4gZm9yIHRoZSBjYWxsZWUncyBuYW1lLgotICAgIGlmICgobV9jb2RlQmxvY2st PnVzZXNFdmFsKCkgJiYgIW1fY29kZUJsb2NrLT5pc1N0cmljdE1vZGUoKSkgfHwgbV9zaG91bGRF bWl0RGVidWdIb29rcykKKyAgICBpZiAobV9jb2RlQmxvY2stPnVzZXNFdmFsKCkgJiYgIW1fY29k ZUJsb2NrLT5pc1N0cmljdE1vZGUoKSkKICAgICAgICAgZW1pdFB1c2hOYW1lU2NvcGUoZnVuY3Rp b25Cb2R5Tm9kZS0+aWRlbnQoKSwgJm1fY2FsbGVlUmVnaXN0ZXIsIFJlYWRPbmx5IHwgRG9udERl bGV0ZSk7CiAKICAgICBpZiAoIWZ1bmN0aW9uQm9keU5vZGUtPmNhcHR1cmVzKGZ1bmN0aW9uQm9k eU5vZGUtPmlkZW50KCkpKQpAQCAtNTA2LDcgKzUwNiw3IEBAIHZvaWQgQnl0ZWNvZGVHZW5lcmF0 b3I6OmFkZENhbGxlZShGdW5jdGkKICAgICAgICAgcmV0dXJuOwogCiAgICAgLy8gSWYgbm9uLXN0 cmljdCBldmFsIGlzIGluIHBsYXksIHdlIHVzZSBhIHNlcGFyYXRlIG9iamVjdCBpbiB0aGUgc2Nv cGUgY2hhaW4gZm9yIHRoZSBjYWxsZWUncyBuYW1lLgotICAgIGlmICgobV9jb2RlQmxvY2stPnVz ZXNFdmFsKCkgJiYgIW1fY29kZUJsb2NrLT5pc1N0cmljdE1vZGUoKSkgfHwgbV9zaG91bGRFbWl0 RGVidWdIb29rcykKKyAgICBpZiAobV9jb2RlQmxvY2stPnVzZXNFdmFsKCkgJiYgIW1fY29kZUJs b2NrLT5pc1N0cmljdE1vZGUoKSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgQVNTRVJUKGNhbGxl ZVJlZ2lzdGVyKTsK