12802 2007-02-18 02:56:30 -0800 WebKit.framework is built with SVG_SUPPORT for No-SVG build 2007-02-20 02:22:51 -0800 1 1 1 Unclassified WebKit Tools / Tests 420+ Mac OS X 10.4 RESOLVED FIXED P2 Minor --- 1 Graham.Dennis Graham.Dennis dwood oldest_to_newest 22574 0 Graham.Dennis 2007-02-18 02:56:30 -0800 The build-webkit script only causes WebCore to be built without the SVG_SUPPORT define for No-SVG builds, and doesn't do this for WebKit. This causes issues when WebKit tries to access virtual functions on Node as the SVG version of the Node class has an additional function (isSVGElement) that the No-SVG Node doesn't. Patch forthcoming. 22576 1 13221 Graham.Dennis 2007-02-18 03:05:33 -0800 Created attachment 13221 patch Patch that modifies the build-webkit script. 22643 2 13221 darin 2007-02-19 08:30:19 -0800 Comment on attachment 13221 patch This looks slightly sloppy to me. I'm not sure why JavaScriptCore should not have FEATURE_DEFINES, yet JavaScriptGlue should have it. And why have a separate elsif for WebCore if it's the same as the else case? Would you be willing to try again? I think passing FEATURE_DEFINES to all the projects is fine, so the entire if/elsif/else can go. 22682 3 13252 Graham.Dennis 2007-02-19 14:34:08 -0800 Created attachment 13252 patch 2 New patch addressing Darin's comments 22688 4 13252 darin 2007-02-19 14:46:02 -0800 Comment on attachment 13252 patch 2 r=me 22781 5 Graham.Dennis 2007-02-20 02:22:51 -0800 Fixed in r19727. 13221 2007-02-18 03:05:33 -0800 2007-02-19 14:34:08 -0800 patch patch-12802-v1.diff text/plain 2023 Graham.Dennis SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE5Njg4KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDctMDItMTggIEdyYWhhbSBEZW5uaXMgIDxn cmFoYW0uZGVubmlzQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKyAgICAgICAgCisgICAgICAgIEZpeCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTI4MDIKKyAgICAgICAgV2ViS2l0LmZyYW1ld29yayBpcyBidWlsdCB3 aXRoIFNWR19TVVBQT1JUIGZvciBOby1TVkcgYnVpbGQKKworICAgICAgICAqIFNjcmlwdHMvYnVp bGQtd2Via2l0OiBQYXNzIHRoZSAiRkVBVFVSRV9ERUZJTkVTPSIgb3B0aW9uIHdoZW4gYnVpbGRp bmcgV2ViS2l0IGFzIHdlbGwuCisKIDIwMDctMDItMTYgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxl LmNvbT4KIAogICAgICAgICBOb3QgcmV2aWV3ZWQuCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRz L2J1aWxkLXdlYmtpdAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL2J1aWxkLXdl YmtpdAkocmV2aXNpb24gMTk2ODgpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtp dAkod29ya2luZyBjb3B5KQpAQCAtNTAsOSArNTAsOSBAQCBjaGRpcldlYktpdCgpOwogCiBteSAk cHJvZHVjdERpciA9IHByb2R1Y3REaXIoKTsKIG15IEBvcHRpb25zID0gWGNvZGVPcHRpb25zKCk7 Ci1teSBAYWRkaXRpb25hbFdlYkNvcmVPcHRpb25zID0gKCk7CitteSBAb3ZlcnJpZGVGZWF0dXJl RGVmaW5lc09wdGlvbiA9ICgpOwogCi1wdXNoIEBhZGRpdGlvbmFsV2ViQ29yZU9wdGlvbnMsICJG RUFUVVJFX0RFRklORVM9IiBpZiAhJHN2Z1N1cHBvcnQ7CitwdXNoIEBvdmVycmlkZUZlYXR1cmVE ZWZpbmVzT3B0aW9uLCAiRkVBVFVSRV9ERUZJTkVTPSIgaWYgISRzdmdTdXBwb3J0OwogCiAjIENo ZWNrIHRoYXQgYWxsIHRoZSBwcm9qZWN0IGRpcmVjdG9yaWVzIGFyZSB0aGVyZS4KIG15IEBwcm9q ZWN0cyA9ICgiSmF2YVNjcmlwdENvcmUiLCAiSmF2YVNjcmlwdEdsdWUiLCAiV2ViQ29yZSIsICJX ZWJLaXQiKTsKQEAgLTEwMyw5ICsxMDMsOSBAQCBmb3IgbXkgJGRpciAoQHByb2plY3RzKSB7CiAg ICAgICAgIGlmICgkZGlyIGVxICJKYXZhU2NyaXB0Q29yZSIpIHsKICAgICAgICAgICAgICRyZXN1 bHQgPSBzeXN0ZW0gInhjb2RlYnVpbGQiLCAiLXByb2plY3QiLCAiJGRpci54Y29kZXByb2oiLCBA b3B0aW9ucywgQEFSR1Y7CiAgICAgICAgIH0gZWxzaWYgKCRkaXIgZXEgIldlYkNvcmUiKSB7Ci0g ICAgICAgICAgICAkcmVzdWx0ID0gc3lzdGVtICJ4Y29kZWJ1aWxkIiwgIi1wcm9qZWN0IiwgIiRk aXIueGNvZGVwcm9qIiwgQG9wdGlvbnMsIEBhZGRpdGlvbmFsV2ViQ29yZU9wdGlvbnMsIEBBUkdW OworICAgICAgICAgICAgJHJlc3VsdCA9IHN5c3RlbSAieGNvZGVidWlsZCIsICItcHJvamVjdCIs ICIkZGlyLnhjb2RlcHJvaiIsIEBvcHRpb25zLCBAb3ZlcnJpZGVGZWF0dXJlRGVmaW5lc09wdGlv biwgQEFSR1Y7CiAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAkcmVzdWx0ID0gc3lzdGVt ICJ4Y29kZWJ1aWxkIiwgIi1wcm9qZWN0IiwgIiRkaXIueGNvZGVwcm9qIiwgQG9wdGlvbnMsIEBB UkdWOworICAgICAgICAgICAgJHJlc3VsdCA9IHN5c3RlbSAieGNvZGVidWlsZCIsICItcHJvamVj dCIsICIkZGlyLnhjb2RlcHJvaiIsIEBvcHRpb25zLCBAb3ZlcnJpZGVGZWF0dXJlRGVmaW5lc09w dGlvbiwgQEFSR1Y7CiAgICAgICAgIH0KICAgICB9IGVsc2lmIChpc0N5Z3dpbigpKSB7CiAgICAg ICAgIGlmICgkZGlyIGVxICJXZWJLaXQiKSB7Cg== 13252 2007-02-19 14:34:08 -0800 2007-02-19 14:46:02 -0800 patch 2 patch-12802-v2.diff text/plain 2052 Graham.Dennis SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE5Njg4KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDctMDItMTggIEdyYWhhbSBEZW5uaXMgIDxn cmFoYW0uZGVubmlzQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKyAgICAgICAgCisgICAgICAgIEZpeCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTI4MDIKKyAgICAgICAgV2ViS2l0LmZyYW1ld29yayBpcyBidWlsdCB3 aXRoIFNWR19TVVBQT1JUIGZvciBOby1TVkcgYnVpbGQKKworICAgICAgICAqIFNjcmlwdHMvYnVp bGQtd2Via2l0OiBQYXNzIHRoZSAiRkVBVFVSRV9ERUZJTkVTPSIgb3B0aW9uIHdoZW4gYnVpbGRp bmcgV2ViS2l0IGFzIHdlbGwuCisKIDIwMDctMDItMTYgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxl LmNvbT4KIAogICAgICAgICBOb3QgcmV2aWV3ZWQuCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRz L2J1aWxkLXdlYmtpdAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL2J1aWxkLXdl YmtpdAkocmV2aXNpb24gMTk2ODgpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtp dAkod29ya2luZyBjb3B5KQpAQCAtNTAsOSArNTAsOSBAQCBjaGRpcldlYktpdCgpOwogCiBteSAk cHJvZHVjdERpciA9IHByb2R1Y3REaXIoKTsKIG15IEBvcHRpb25zID0gWGNvZGVPcHRpb25zKCk7 Ci1teSBAYWRkaXRpb25hbFdlYkNvcmVPcHRpb25zID0gKCk7CitteSBAb3ZlcnJpZGVGZWF0dXJl RGVmaW5lc09wdGlvbiA9ICgpOwogCi1wdXNoIEBhZGRpdGlvbmFsV2ViQ29yZU9wdGlvbnMsICJG RUFUVVJFX0RFRklORVM9IiBpZiAhJHN2Z1N1cHBvcnQ7CitwdXNoIEBvdmVycmlkZUZlYXR1cmVE ZWZpbmVzT3B0aW9uLCAiRkVBVFVSRV9ERUZJTkVTPSIgaWYgISRzdmdTdXBwb3J0OwogCiAjIENo ZWNrIHRoYXQgYWxsIHRoZSBwcm9qZWN0IGRpcmVjdG9yaWVzIGFyZSB0aGVyZS4KIG15IEBwcm9q ZWN0cyA9ICgiSmF2YVNjcmlwdENvcmUiLCAiSmF2YVNjcmlwdEdsdWUiLCAiV2ViQ29yZSIsICJX ZWJLaXQiKTsKQEAgLTEwMCwxMyArMTAwLDcgQEAgZm9yIG15ICRkaXIgKEBwcm9qZWN0cykgewog ICAgICAgICAgICAgJHJlc3VsdCA9IGJ1aWxkQ01ha2VQcm9qZWN0KCRkaXIsICRjb2xvclN1cHBv cnQpOwogICAgICAgICB9CiAgICAgfSBlbHNpZiAoaXNPU1goKSkgewotICAgICAgICBpZiAoJGRp ciBlcSAiSmF2YVNjcmlwdENvcmUiKSB7Ci0gICAgICAgICAgICAkcmVzdWx0ID0gc3lzdGVtICJ4 Y29kZWJ1aWxkIiwgIi1wcm9qZWN0IiwgIiRkaXIueGNvZGVwcm9qIiwgQG9wdGlvbnMsIEBBUkdW OwotICAgICAgICB9IGVsc2lmICgkZGlyIGVxICJXZWJDb3JlIikgewotICAgICAgICAgICAgJHJl c3VsdCA9IHN5c3RlbSAieGNvZGVidWlsZCIsICItcHJvamVjdCIsICIkZGlyLnhjb2RlcHJvaiIs IEBvcHRpb25zLCBAYWRkaXRpb25hbFdlYkNvcmVPcHRpb25zLCBAQVJHVjsKLSAgICAgICAgfSBl bHNlIHsKLSAgICAgICAgICAgICRyZXN1bHQgPSBzeXN0ZW0gInhjb2RlYnVpbGQiLCAiLXByb2pl Y3QiLCAiJGRpci54Y29kZXByb2oiLCBAb3B0aW9ucywgQEFSR1Y7Ci0gICAgICAgIH0KKyAgICAg ICAgJHJlc3VsdCA9IHN5c3RlbSAieGNvZGVidWlsZCIsICItcHJvamVjdCIsICIkZGlyLnhjb2Rl cHJvaiIsIEBvcHRpb25zLCBAb3ZlcnJpZGVGZWF0dXJlRGVmaW5lc09wdGlvbiwgQEFSR1Y7CiAg ICAgfSBlbHNpZiAoaXNDeWd3aW4oKSkgewogICAgICAgICBpZiAoJGRpciBlcSAiV2ViS2l0Iikg ewogICAgICAgICAgICAgJHJlc3VsdCA9IGJ1aWxkVmlzdWFsU3R1ZGlvUHJvamVjdCgkZGlyKTsK