128014 2014-01-31 13:44:16 -0800 Add options to force debugger / profiler bytecode generation. 2014-01-31 13:54:53 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam fpizlo ggaren joepeck mhahnenberg msaboff oliver timothy oldest_to_newest 974454 0 mark.lam 2014-01-31 13:44:16 -0800 Add Options::forceDebuggerBytecodeGeneration() and Options::forceProfilerBytecodeGeneration(). These options make it more convenient to do correctness testing when debugger / profiler bytecodes are generated. These options are disabled by default. 974456 1 222844 mark.lam 2014-01-31 13:46:27 -0800 Created attachment 222844 the patch. 974461 2 mark.lam 2014-01-31 13:54:53 -0800 Thanks. Landed in r163197: <http://trac.webkit.org/r163197>. 222844 2014-01-31 13:46:27 -0800 2014-01-31 13:51:03 -0800 the patch. bug-128014.patch text/plain 3869 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYzMTk1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE0LTAxLTMxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgb3B0aW9ucyB0byBmb3JjZSBkZWJ1Z2dlciAvIHByb2ZpbGVyIGJ5dGVjb2RlIGdlbmVyYXRp b24uCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xMjgwMTQ+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIE9wdGlvbnM6OmZvcmNlRGVi dWdnZXJCeXRlY29kZUdlbmVyYXRpb24oKSBhbmQKKyAgICAgICAgT3B0aW9uczo6Zm9yY2VQcm9m aWxlckJ5dGVjb2RlR2VuZXJhdGlvbigpLiBUaGVzZSBvcHRpb25zIG1ha2UgaXQgbW9yZQorICAg ICAgICBjb252ZW5pZW50IHRvIGRvIGNvcnJlY3RuZXNzIHRlc3Rpbmcgd2hlbiBkZWJ1Z2dlciAv IHByb2ZpbGVyIGJ5dGVjb2RlcworICAgICAgICBhcmUgZ2VuZXJhdGVkLgorCisgICAgICAgIFRo ZXNlIG9wdGlvbnMgYXJlIGRpc2FibGVkIGJ5IGRlZmF1bHQuCisKKyAgICAgICAgKiBieXRlY29t cGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwOgorICAgICAgICAoSlNDOjpCeXRlY29kZUdlbmVy YXRvcjo6Qnl0ZWNvZGVHZW5lcmF0b3IpOgorICAgICAgICAqIHJ1bnRpbWUvT3B0aW9ucy5oOgor CiAyMDE0LTAxLTI5ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAg TWFrZSBpdCBwb3NzaWJsZSB0byBpbXBsZW1lbnQgSlMgYnVpbHRpbnMgaW4gSlMKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVH ZW5lcmF0b3IuY3BwCShyZXZpc2lvbiAxNjMwNDApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv Ynl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTUx LDggKzE1MSw4IEBAIHZvaWQgQnl0ZWNvZGVHZW5lcmF0b3I6OnByZXNlcnZlTGFzdFZhcigKIH0K IAogQnl0ZWNvZGVHZW5lcmF0b3I6OkJ5dGVjb2RlR2VuZXJhdG9yKFZNJiB2bSwgUHJvZ3JhbU5v ZGUqIHByb2dyYW1Ob2RlLCBVbmxpbmtlZFByb2dyYW1Db2RlQmxvY2sqIGNvZGVCbG9jaywgRGVi dWdnZXJNb2RlIGRlYnVnZ2VyTW9kZSwgUHJvZmlsZXJNb2RlIHByb2ZpbGVyTW9kZSkKLSAgICA6 IG1fc2hvdWxkRW1pdERlYnVnSG9va3MoZGVidWdnZXJNb2RlID09IERlYnVnZ2VyT24pCi0gICAg LCBtX3Nob3VsZEVtaXRQcm9maWxlSG9va3MocHJvZmlsZXJNb2RlID09IFByb2ZpbGVyT24pCisg ICAgOiBtX3Nob3VsZEVtaXREZWJ1Z0hvb2tzKE9wdGlvbnM6OmZvcmNlRGVidWdnZXJCeXRlY29k ZUdlbmVyYXRpb24oKSB8fCBkZWJ1Z2dlck1vZGUgPT0gRGVidWdnZXJPbikKKyAgICAsIG1fc2hv dWxkRW1pdFByb2ZpbGVIb29rcyhPcHRpb25zOjpmb3JjZVByb2ZpbGVyQnl0ZWNvZGVHZW5lcmF0 aW9uKCkgfHwgcHJvZmlsZXJNb2RlID09IFByb2ZpbGVyT24pCiAgICAgLCBtX3N5bWJvbFRhYmxl KDApCiAgICAgLCBtX3Njb3BlTm9kZShwcm9ncmFtTm9kZSkKICAgICAsIG1fY29kZUJsb2NrKHZt LCBjb2RlQmxvY2spCkBAIC0xOTgsOCArMTk4LDggQEAgQnl0ZWNvZGVHZW5lcmF0b3I6OkJ5dGVj b2RlR2VuZXJhdG9yKFZNJgogfQogCiBCeXRlY29kZUdlbmVyYXRvcjo6Qnl0ZWNvZGVHZW5lcmF0 b3IoVk0mIHZtLCBGdW5jdGlvbkJvZHlOb2RlKiBmdW5jdGlvbkJvZHksIFVubGlua2VkRnVuY3Rp b25Db2RlQmxvY2sqIGNvZGVCbG9jaywgRGVidWdnZXJNb2RlIGRlYnVnZ2VyTW9kZSwgUHJvZmls ZXJNb2RlIHByb2ZpbGVyTW9kZSkKLSAgICA6IG1fc2hvdWxkRW1pdERlYnVnSG9va3MoZGVidWdn ZXJNb2RlID09IERlYnVnZ2VyT24pCi0gICAgLCBtX3Nob3VsZEVtaXRQcm9maWxlSG9va3MocHJv ZmlsZXJNb2RlID09IFByb2ZpbGVyT24pCisgICAgOiBtX3Nob3VsZEVtaXREZWJ1Z0hvb2tzKE9w dGlvbnM6OmZvcmNlRGVidWdnZXJCeXRlY29kZUdlbmVyYXRpb24oKSB8fCBkZWJ1Z2dlck1vZGUg PT0gRGVidWdnZXJPbikKKyAgICAsIG1fc2hvdWxkRW1pdFByb2ZpbGVIb29rcyhPcHRpb25zOjpm b3JjZVByb2ZpbGVyQnl0ZWNvZGVHZW5lcmF0aW9uKCkgfHwgcHJvZmlsZXJNb2RlID09IFByb2Zp bGVyT24pCiAgICAgLCBtX3N5bWJvbFRhYmxlKGNvZGVCbG9jay0+c3ltYm9sVGFibGUoKSkKICAg ICAsIG1fc2NvcGVOb2RlKGZ1bmN0aW9uQm9keSkKICAgICAsIG1fY29kZUJsb2NrKHZtLCBjb2Rl QmxvY2spCkBAIC00MTQsOCArNDE0LDggQEAgQnl0ZWNvZGVHZW5lcmF0b3I6OkJ5dGVjb2RlR2Vu ZXJhdG9yKFZNJgogfQogCiBCeXRlY29kZUdlbmVyYXRvcjo6Qnl0ZWNvZGVHZW5lcmF0b3IoVk0m IHZtLCBFdmFsTm9kZSogZXZhbE5vZGUsIFVubGlua2VkRXZhbENvZGVCbG9jayogY29kZUJsb2Nr LCBEZWJ1Z2dlck1vZGUgZGVidWdnZXJNb2RlLCBQcm9maWxlck1vZGUgcHJvZmlsZXJNb2RlKQot ICAgIDogbV9zaG91bGRFbWl0RGVidWdIb29rcyhkZWJ1Z2dlck1vZGUgPT0gRGVidWdnZXJPbikK LSAgICAsIG1fc2hvdWxkRW1pdFByb2ZpbGVIb29rcyhwcm9maWxlck1vZGUgPT0gUHJvZmlsZXJP bikKKyAgICA6IG1fc2hvdWxkRW1pdERlYnVnSG9va3MoT3B0aW9uczo6Zm9yY2VEZWJ1Z2dlckJ5 dGVjb2RlR2VuZXJhdGlvbigpIHx8IGRlYnVnZ2VyTW9kZSA9PSBEZWJ1Z2dlck9uKQorICAgICwg bV9zaG91bGRFbWl0UHJvZmlsZUhvb2tzKE9wdGlvbnM6OmZvcmNlUHJvZmlsZXJCeXRlY29kZUdl bmVyYXRpb24oKSB8fCBwcm9maWxlck1vZGUgPT0gUHJvZmlsZXJPbikKICAgICAsIG1fc3ltYm9s VGFibGUoY29kZUJsb2NrLT5zeW1ib2xUYWJsZSgpKQogICAgICwgbV9zY29wZU5vZGUoZXZhbE5v ZGUpCiAgICAgLCBtX2NvZGVCbG9jayh2bSwgY29kZUJsb2NrKQpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL09wdGlvbnMuaAkocmV2aXNpb24gMTYzMDQwKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMDYsNiAr MTA2LDggQEAgdHlwZWRlZiBPcHRpb25SYW5nZSBvcHRpb25SYW5nZTsKICAgICB2KGJvb2wsIGR1 bXBHZW5lcmF0ZWRCeXRlY29kZXMsIGZhbHNlKSBcCiAgICAgdihib29sLCBkdW1wQnl0ZWNvZGVM aXZlbmVzc1Jlc3VsdHMsIGZhbHNlKSBcCiAgICAgdihib29sLCB2YWxpZGF0ZUJ5dGVjb2RlLCBm YWxzZSkgXAorICAgIHYoYm9vbCwgZm9yY2VEZWJ1Z2dlckJ5dGVjb2RlR2VuZXJhdGlvbiwgZmFs c2UpIFwKKyAgICB2KGJvb2wsIGZvcmNlUHJvZmlsZXJCeXRlY29kZUdlbmVyYXRpb24sIGZhbHNl KSBcCiAgICAgXAogICAgIC8qIHNob3dEaXNhc3NlbWJseSBpbXBsaWVzIHNob3dERkdEaXNhc3Nl bWJseS4gKi8gXAogICAgIHYoYm9vbCwgc2hvd0Rpc2Fzc2VtYmx5LCBmYWxzZSkgXAo=