128013 2014-01-31 13:03:20 -0800 WebKit2 View Gestures (Swipe): Crashes swiping around a Google Docs spreadsheet 2014-01-31 13:13:33 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca sam simon.fraser oldest_to_newest 974441 0 thorton 2014-01-31 13:03:20 -0800 We should never (currently) start a swipe from a non-begin-phase wheel event. We already check this in handleScrollWheelEvent, but can still get non-begin-phase events in wheelEventWasNotHandled. And, AppKit throws an exception when we try to start a swipe from end-phase events. <rdar://problem/15959481> 974445 1 222841 thorton 2014-01-31 13:09:24 -0800 Created attachment 222841 patch 974446 2 222841 thorton 2014-01-31 13:09:53 -0800 Comment on attachment 222841 patch View in context: https://bugs.webkit.org/attachment.cgi?id=222841&action=review > Source/WebKit2/ChangeLog:24 > - Sideways 'wobble' when scrolling with trackpad on Mavericks > - https://bugs.webkit.org/show_bug.cgi?id=127521 > - -and corresponding- > + Sideways 'wobble' when scrolling with trackpad on Mavericks > + https://bugs.webkit.org/show_bug.cgi?id=127521 > + -and corresponding- I don't know what my editor is doing here. 974447 3 thorton 2014-01-31 13:13:33 -0800 http://trac.webkit.org/changeset/163192 222841 2014-01-31 13:09:24 -0800 2014-01-31 13:10:45 -0800 patch exceptions.diff text/plain 2095 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5OGJlMTYwLi5lZTFiMGEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDggKzEsMjcg QEAKKzIwMTQtMDEtMzEgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgV2ViS2l0MiBWaWV3IEdlc3R1cmVzIChTd2lwZSk6IENyYXNoZXMgc3dpcGluZyBh cm91bmQgYSBHb29nbGUgRG9jcyBzcHJlYWRzaGVldAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MDEzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8x NTk1OTQ4MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9tYWMvVmlld0dlc3R1cmVDb250cm9sbGVyLm1tOgorICAgICAgICAoV2Vi S2l0OjpWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OndoZWVsRXZlbnRXYXNOb3RIYW5kbGVkQnlXZWJD b3JlKToKKyAgICAgICAgV2Ugc2hvdWxkIG5ldmVyIChjdXJyZW50bHkpIHN0YXJ0IGEgc3dpcGUg ZnJvbSBhIG5vbi1iZWdpbi1waGFzZSB3aGVlbCBldmVudC4KKyAgICAgICAgV2UgYWxyZWFkeSBj aGVjayB0aGlzIGluIGhhbmRsZVNjcm9sbFdoZWVsRXZlbnQsIGJ1dCBjYW4gc3RpbGwgZ2V0Cisg ICAgICAgIG5vbi1iZWdpbi1waGFzZSBldmVudHMgaW4gd2hlZWxFdmVudFdhc05vdEhhbmRsZWQu CisKKyAgICAgICAgV2Ugb25seSBzdGFydCAicGVuZGluZyIgc3dpcGVzIHdpdGggQmVnaW4gZXZl bnRzLCBzbyB3ZSBzaG91bGQgbmV2ZXIgbWFrZSB0aGVtCisgICAgICAgIG5vbi1wZW5kaW5nIHdp dGggYW55dGhpbmcgYnV0IGEgQmVnaW4gZXZlbnQgKHdlJ2xsIGdldCBpdCB3aGVuIGl0IGJ1YmJs ZXMgYmFjayB1cCwKKyAgICAgICAgdW5oYW5kbGVkLCBmcm9tIFdlYkNvcmUpLiBJbiBhZGRpdGlv biwgQXBwS2l0IHRocm93cyBhbiBleGNlcHRpb24gd2hlbiB3ZSB0cnkKKyAgICAgICAgdG8gc3Rh cnQgYSBzd2lwZSBmcm9tIGVuZC1waGFzZSBldmVudHMuCisKIDIwMTQtMDEtMzEgIEJldGggRGFr aW4gIDxiZGFraW5AYXBwbGUuY29tPgogCi0gICAgICAgIFNpZGV3YXlzICd3b2JibGUnIHdoZW4g c2Nyb2xsaW5nIHdpdGggdHJhY2twYWQgb24gTWF2ZXJpY2tzDQotICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3NTIxDQotICAgICAgICAtYW5kIGNvcnJl c3BvbmRpbmctDQorICAgICAgICBTaWRld2F5cyAnd29iYmxlJyB3aGVuIHNjcm9sbGluZyB3aXRo IHRyYWNrcGFkIG9uIE1hdmVyaWNrcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTI3NTIxCisgICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KICAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzE0MTM3MzA2PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9u IEZyYXNlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvVmlld0dl c3R1cmVDb250cm9sbGVyLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9WaWV3R2Vz dHVyZUNvbnRyb2xsZXIubW0KaW5kZXggOWI4ZWJjYy4uYTA2Y2IzNiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9WaWV3R2VzdHVyZUNvbnRyb2xsZXIubW0KKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9WaWV3R2VzdHVyZUNvbnRyb2xsZXIubW0KQEAg LTI4Niw2ICsyODYsMTAgQEAgdm9pZCBWaWV3R2VzdHVyZUNvbnRyb2xsZXI6OndoZWVsRXZlbnRX YXNOb3RIYW5kbGVkQnlXZWJDb3JlKE5TRXZlbnQgKmV2ZW50KQogICAgICAgICByZXR1cm47CiAK ICAgICBtX2hhc1BlbmRpbmdTd2lwZSA9IGZhbHNlOworCisgICAgaWYgKGV2ZW50LnBoYXNlICE9 IE5TRXZlbnRQaGFzZUJlZ2FuKQorICAgICAgICByZXR1cm47CisKICAgICB0cmFja1N3aXBlR2Vz dHVyZShldmVudCwgbV9wZW5kaW5nU3dpcGVEaXJlY3Rpb24pOwogfQogCg==