128011 2014-01-31 12:47:46 -0800 Web Inspector: Layers and Node side panels shortcuts are not triggered when using Spanish keyboard layout 2016-12-13 15:32:34 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All NEW InRadar P2 Minor --- 1 dpino webkit-unassigned inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 974427 0 dpino 2014-01-31 12:47:46 -0800 Shortcuts 'CmdOrCtrl+Shift+2' (open Node side panel) and 'CmdOrCtrl+Shift+3' (open Layers side panel) don't work when using Spanish keyboard layout. It works fine if I use US keyboard layout (Environment: WebKitGTK/Minibrowser; Ubuntu 13.04). I debugged the issue and it seems that KeyboardShortcut.matchesEvent (KeyboardShortcut:74) returns false for these two shortcuts. What it happens is that an unexpected event.keyCode is sent: * 'Ctrl+Shift+2' sends event.keyCode = 222 (when it should be 50). * 'Ctrl+Shift+3' sends event.keyCode = 0 (when it should be 51). This page is useful for testing purporses: http://www.asquare.net/javascript/tests/KeyCode.html. I researched a bit on the internet and I saw that this is a problem related to Javascript Key Events. In this page (http://news.qooxdoo.org/key-event-nightmare-resolved) it reads: "The key code of keys that require the shift key on some keyboard layouts are not reliable. The key code which is generated depends on the current language-specific keyboard layout of the user." So, I grepped shortcuts involving the Shift key and tested whether they work or not. Here is the result: | *File* | *Shortcut* | *Action* | *Works* | | ContentBrowser.js:46 | CmdOrCtrl + Shift + 'S' | _saveAs | Yes | | DebuggerSidebarPanel.js:50 | CmdOrCtrl + Shift + ';' | _debuggerStepOutButtonClicked | Yes | | FindBanner.js:84 | CmdOrCtrl + Shift + 'G' | _previousResultButtonClicked | Yes | | JavaScriptLogViewController.js:55 | CmdOrCtrl + Shift + 'G' | _handleFindPreviousShortcut | Yes | | JavaScriptLogViewController.js:60 | CmdOrCtrl + Shift + 'G' | _handleFindPreviousShortcut | Yes | | Main.js:219 | CmdOrCtrl + Shift + 'R' | _reloadPageIgnoringCache | Yes | | Main.js:221 | CmdOrCtrl + Shift + 'C' | _toggleInspectMode | Yes | | Main.js:224 | CmdOrCtrl + Shift + 'Z' | _redoKeyboardShortcut | Yes | | ResourceSidebarPanel.js:51 | CmdOrCtrl + Shift + 'F' | _focusSearchField | Yes | Conclusion, all the other shortcuts (involving the Shift key) work and the only ones that fail are 'CmdOrCtrl+Shift+2' and 'CmdOrCtrl+Shift+3'. 974428 1 webkit-bug-importer 2014-01-31 12:48:00 -0800 <rdar://problem/15959734> 974437 2 222839 dpino 2014-01-31 12:54:00 -0800 Created attachment 222839 Patch 974442 3 dpino 2014-01-31 13:05:07 -0800 The solution proposed in the patch is to use 'Option' instead of 'Shift' for the DetailsSidebarPanel.js buttons. I preferred not to change the other shortcuts as they are working. I'm aware this solution may solve only the issue for Spanish keyboard layout, but it might persist in other keyboard layouts. My gut feeling is that 'Shift' is problematic in combination with number keys, but works fine with alphabetic characters (or punctuaction symbols like ';'). But this is just a wild guess, I have nothing to back up this statement :( 976971 4 timothy 2014-02-05 11:16:03 -0800 What platform were you using? I am wondering if Mac can stay as Option, since we match Xcode there. 977150 5 dpino 2014-02-05 17:09:44 -0800 My environment is: * OS: Ubuntu 13.04. * WebKit: WebKitGTK+/Minibrowser. I'm using WebKit2. Maybe another possibility is to remap the shortcut as Ctrl + Number. That's the shortcut for the Menu buttons on the left side and it's working. But doing that means that the shorcut for the Menu buttons on the right side should start at 4. If I'm not wrong, up to 5 different sidepanels can be shown on the right side. 979658 6 timothy 2014-02-11 16:38:19 -0800 (In reply to comment #5) > My environment is: > > * OS: Ubuntu 13.04. > * WebKit: WebKitGTK+/Minibrowser. I'm using WebKit2. > > Maybe another possibility is to remap the shortcut as Ctrl + Number. That's the shortcut for the Menu buttons on the left side and it's working. But doing that means that the shorcut for the Menu buttons on the right side should start at 4. If I'm not wrong, up to 5 different sidepanels can be shown on the right side. That wouldn't be ideal. The idea of using a modifier and starting with 1 was to have left and right sidebars use the same modifiers and start with 1 — matching Xcode. 1088652 7 222839 timothy 2015-04-25 18:37:17 -0700 Comment on attachment 222839 Patch We don't have the shortcuts as of r183342. 222839 2014-01-31 12:54:00 -0800 2015-04-25 18:37:17 -0700 Patch bug-128011-20140131215359.patch text/plain 2022 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyOTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm M2RkOWJlNmM2NWNmZTI5YjdiOGZjNGUwMGY5YWIwMzI4ODkxYjQwLi4wMGFjMmY4NGMzZjgxYzA0 ODJiODM5MGQxZDAyNzRkOWQ1YjgxNDQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNC0wMS0zMSAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IExheWVycyBhbmQgTm9kZSBzaWRlIHBhbmVs cyBzaG9ydGN1dHMgYXJlIG5vdCB0cmlnZ2VyZWQgd2hlbiB1c2luZyBTcGFuaXNoIGtleWJvYXJk IGxheW91dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTI4MDExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL0RldGFpbHNTaWRlYmFyUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuRGV0YWlsc1NpZGViYXJQYW5lbCk6CisgICAgICAgIFJlcGxhY2UgJ1NoaWZ0JyBmb3Ig J09wdGlvbicgYXMgc2hvcnRjdXQgbW9kaWZpZXIga2V5LgorCiAyMDE0LTAxLTI4ICBEaWVnbyBQ aW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog SW4gYSBEYXRhR3JpZCwgc3RvcmUgdmFsdWUgb2YgY29sdW1uSWRlbnRpZmllciB0byBET00gbm9k ZSByZXByZXNlbnRpbmcgYSBjZWxsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9EZXRhaWxzU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvRGV0YWlsc1NpZGViYXJQYW5lbC5qcwppbmRleCA3MDMxN2U2NTFi ZGY0MzY0N2Q2OGNhOTg3NjU1Yjk5NTkwMzA1YjRhLi4yM2FmMTU3OTMyMmQyNTczYjE5ZTA4YTA3 MTE1MjNhNDdkZjg2MmE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9EZXRhaWxzU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL0RldGFpbHNTaWRlYmFyUGFuZWwuanMKQEAgLTI1LDcgKzI1LDcgQEAK IAogV2ViSW5zcGVjdG9yLkRldGFpbHNTaWRlYmFyUGFuZWwgPSBmdW5jdGlvbihpZGVudGlmaWVy LCBkaXNwbGF5TmFtZSwgc2luZ3VsYXJEaXNwbGF5TmFtZSwgaW1hZ2UsIGtleWJvYXJkU2hvcnRj dXRLZXksIGVsZW1lbnQpIHsKICAgICBpZiAoa2V5Ym9hcmRTaG9ydGN1dEtleSkKLSAgICAgICAg dGhpcy5fa2V5Ym9hcmRTaG9ydGN1dCA9IG5ldyBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1 dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5Db250cm9sIHwgV2ViSW5z cGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuU2hpZnQsIGtleWJvYXJkU2hvcnRjdXRL ZXksIHRoaXMudG9nZ2xlLmJpbmQodGhpcykpOworICAgICAgICB0aGlzLl9rZXlib2FyZFNob3J0 Y3V0ID0gbmV3IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rvci5LZXli b2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbnRyb2wgfCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9y dGN1dC5Nb2RpZmllci5PcHRpb24sIGtleWJvYXJkU2hvcnRjdXRLZXksIHRoaXMudG9nZ2xlLmJp bmQodGhpcykpOwogCiAgICAgaWYgKHRoaXMuX2tleWJvYXJkU2hvcnRjdXQpIHsKICAgICAgICAg dmFyIHNob3dUb29sVGlwID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJTaG93IHRoZSAlcyBkZXRh aWxzIHNpZGViYXIgKCVzKSIpLmZvcm1hdChzaW5ndWxhckRpc3BsYXlOYW1lLCB0aGlzLl9rZXli b2FyZFNob3J0Y3V0LmRpc3BsYXlOYW1lKTsK