127974 2014-01-30 17:29:25 -0800 Fixed position objects are clipped in iOS WK2 2014-01-30 17:43:50 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 974129 0 simon.fraser 2014-01-30 17:29:25 -0800 Fixed position objects are clipped in iOS WK2 974136 1 222769 simon.fraser 2014-01-30 17:34:53 -0800 Created attachment 222769 Patch 974137 2 222769 darin 2014-01-30 17:36:53 -0800 Comment on attachment 222769 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222769&action=review > Source/WebCore/page/FrameView.cpp:1572 > +#endif > + return viewportConstrainedVisibleContentRect(); This should be #else/#endif instead of having a double return on IOS. 974140 3 simon.fraser 2014-01-30 17:43:50 -0800 http://trac.webkit.org/changeset/163146 222769 2014-01-30 17:34:53 -0800 2014-01-30 17:36:53 -0800 Patch bug-127974-20140130173447.patch text/plain 4205 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMDg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTEzZjE4OGFlNjUyYjk1 ZjNiNTcyYWMxNzcwZWExMjViYmFlNzVkMi4uNmFiYTg2NmFiY2JlYmYyNjcyY2U2M2YyZDI0OWE3 ODU3M2I4ZjU1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE0LTAxLTMwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEZpeGVkIHBvc2l0 aW9uIG9iamVjdHMgYXJlIGNsaXBwZWQgaW4gaU9TIFdLMgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3OTc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBXZSBjbGlwIGNvbXBvc2l0aW5nIGxh eWVycyBmb3IgZml4ZWQgcG9zaXRpb24gb2JqZWN0cyB0byB0aGUgdmlld3BvcnQKKyAgICAgICAg dG8gYXZvaWQgaHVnZSBsYXllcnMuIEhvd2V2ZXIsIGJlY2F1c2UgaU9TIGNoYW5nZXMgdGhlIGZp eGVkIHBvc2l0aW9uCisgICAgICAgIHJlY3Qgd2hlbiB6b29taW5nLCB3ZSBuZWVkIGEgZGlmZmVy ZW50IHJlY3QgZm9yIGlPUy4KKyAgICAgICAgCisgICAgICAgIEluIFdLMSAod2hlbiB3ZSBoYXZl IGEgcGxhdGZvcm1XaWRnZXQpLCB3ZSBjYW4gdXNlCisgICAgICAgIHZpc2libGVDb250ZW50UmVj dChTY3JvbGxhYmxlQXJlYTo6TGVnYWN5SU9TRG9jdW1lbnRWaXNpYmxlUmVjdCkKKyAgICAgICAg d2hpY2ggaXMgZWZmZWN0aXZlbHkgdGhlIHdob2xlIGRvY3VtZW50LiBIb3dldmVyIGluIFdLMiB0 aGlzIGlzCisgICAgICAgIHRoZSByZWFsIHZpc2libGVDb250ZW50UmVjdCgpLCBzbyB0aGVyZSB3 ZSB1c2UgdW5zY2FsZWREb2N1bWVudFJlY3QoKS4KKworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6dmlld3BvcnRDb25zdHJhaW5lZEV4 dGVudFJlY3QpOgorICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3Lmg6CisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckxheWVyQmFja2luZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXll ckJhY2tpbmc6OnVwZGF0ZUNvbXBvc2l0ZWRCb3VuZHMpOgorCiAyMDE0LTAxLTMwICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJQYWdlOjpkZXRlcm1pbmVQ cmltYXJ5U25hcHNob3R0ZWRQbHVnSW4gaXMgc2xvdwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3Bw CmluZGV4IDQ3MTE5ZTFlYzY4ODE0ZDg2YjdiOTYzMThmMDUyM2ZlZGZiNWJkZDYuLjQ2ZjQyMDgx YTE5YjZmMThiYjBhOWNlNTk0OTQ0Yzk2NDIzNzExMzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmll dy5jcHAKQEAgLTE1NjEsNiArMTU2MSwxNyBAQCBMYXlvdXRSZWN0IEZyYW1lVmlldzo6dmlld3Bv cnRDb25zdHJhaW5lZFZpc2libGVDb250ZW50UmVjdCgpIGNvbnN0CiAgICAgcmV0dXJuIHZpZXdw b3J0UmVjdDsKIH0KIAorTGF5b3V0UmVjdCBGcmFtZVZpZXc6OnZpZXdwb3J0Q29uc3RyYWluZWRF eHRlbnRSZWN0KCkgY29uc3QKK3sKKyNpZiBQTEFURk9STShJT1MpCisgICAgaWYgKHBsYXRmb3Jt V2lkZ2V0KCkpCisgICAgICAgIHJldHVybiB2aXNpYmxlQ29udGVudFJlY3QoU2Nyb2xsYWJsZUFy ZWE6OkxlZ2FjeUlPU0RvY3VtZW50VmlzaWJsZVJlY3QpOworICAgIAorICAgIHJldHVybiByZW5k ZXJWaWV3KCktPnVuc2NhbGVkRG9jdW1lbnRSZWN0KCk7CisjZW5kaWYKKyAgICByZXR1cm4gdmll d3BvcnRDb25zdHJhaW5lZFZpc2libGVDb250ZW50UmVjdCgpOworfQorCiBJbnRTaXplIEZyYW1l Vmlldzo6c2Nyb2xsT2Zmc2V0Rm9yRml4ZWRQb3NpdGlvbihjb25zdCBJbnRSZWN0JiB2aXNpYmxl Q29udGVudFJlY3QsIGNvbnN0IEludFNpemUmIHRvdGFsQ29udGVudHNTaXplLCBjb25zdCBJbnRQ b2ludCYgc2Nyb2xsUG9zaXRpb24sIGNvbnN0IEludFBvaW50JiBzY3JvbGxPcmlnaW4sIGZsb2F0 IGZyYW1lU2NhbGVGYWN0b3IsIGJvb2wgZml4ZWRFbGVtZW50c0xheW91dFJlbGF0aXZlVG9GcmFt ZSwgU2Nyb2xsQmVoYXZpb3JGb3JGaXhlZEVsZW1lbnRzIGJlaGF2aW9yRm9yRml4ZWQsIGludCBo ZWFkZXJIZWlnaHQsIGludCBmb290ZXJIZWlnaHQpCiB7CiAgICAgSW50UG9pbnQgcG9zaXRpb247 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oIGIvU291cmNlL1dl YkNvcmUvcGFnZS9GcmFtZVZpZXcuaAppbmRleCBlZDIwYmQyNjMyODFlOTZkNmVkYmQyYzliMDU4 OGQyZWMxMzAxYzBmLi41NDJlMGQyMmZiN2QxY2MyNTc3MTE4ZTQ5NGIxODdjYmE5ODkxZDhjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgKQEAgLTIyNiw2ICsyMjYsOSBAQCBwdWJsaWM6CiAgICAg Ly8gb2Zmc2V0cyBmcm9tIHJ1YmJlci1iYW5kaW5nLCBhbmQgaXQgdGFrZXMgem9vbWluZyBpbnRv IGFjY291bnQuIAogICAgIExheW91dFJlY3Qgdmlld3BvcnRDb25zdHJhaW5lZFZpc2libGVDb250 ZW50UmVjdCgpIGNvbnN0OwogCisgICAgLy8gQSByZWN0YW5nbGUgaW4gY29udGVudCBjb29yZGlu YXRlcyB0aGF0IGlzIHVzZWQgdG8gY2xpcCBsYXllcnMgZm9yIGZpeGVkLXBvc2l0aW9uIG9iamVj dHMuCisgICAgTGF5b3V0UmVjdCB2aWV3cG9ydENvbnN0cmFpbmVkRXh0ZW50UmVjdCgpIGNvbnN0 OworCiAgICAgU3RyaW5nIG1lZGlhVHlwZSgpIGNvbnN0OwogICAgIHZvaWQgc2V0TWVkaWFUeXBl KGNvbnN0IFN0cmluZyYpOwogICAgIHZvaWQgYWRqdXN0TWVkaWFUeXBlRm9yUHJpbnRpbmcoYm9v bCBwcmludGluZyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJCYWNraW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJh Y2tpbmcuY3BwCmluZGV4IGIzZTY0YzM4MDBhMGE1NzU0OTNjOWY1ZGIyZmQ2OTA0YzJiNWRlNjMu LmI2Y2VlZWJkMWM5MDlkMjUzNmUzNWFmZTZkYTU4ZDNjZTcwMjU4ZGYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCkBAIC00NzYsMTMgKzQ3 Niw5IEBAIHZvaWQgUmVuZGVyTGF5ZXJCYWNraW5nOjp1cGRhdGVDb21wb3NpdGVkQm91bmRzKCkK ICAgICAgICAgUmVuZGVyTGF5ZXIqIHJvb3RMYXllciA9IHZpZXcubGF5ZXIoKTsKIAogICAgICAg ICBMYXlvdXRSZWN0IGNsaXBwaW5nQm91bmRzOwotICAgICAgICBpZiAocmVuZGVyZXIoKS5zdHls ZSgpLnBvc2l0aW9uKCkgPT0gRml4ZWRQb3NpdGlvbiAmJiByZW5kZXJlcigpLmNvbnRhaW5lcigp ID09ICZ2aWV3KSB7Ci0jaWYgUExBVEZPUk0oSU9TKQotICAgICAgICAgICAgY2xpcHBpbmdCb3Vu ZHMgPSB2aWV3LmZyYW1lVmlldygpLnZpc2libGVDb250ZW50UmVjdChTY3JvbGxhYmxlQXJlYTo6 TGVnYWN5SU9TRG9jdW1lbnRWaXNpYmxlUmVjdCk7Ci0jZWxzZQotICAgICAgICAgICAgY2xpcHBp bmdCb3VuZHMgPSB2aWV3LmZyYW1lVmlldygpLnZpZXdwb3J0Q29uc3RyYWluZWRWaXNpYmxlQ29u dGVudFJlY3QoKTsKLSNlbmRpZgotICAgICAgICB9IGVsc2UKKyAgICAgICAgaWYgKHJlbmRlcmVy KCkuc3R5bGUoKS5wb3NpdGlvbigpID09IEZpeGVkUG9zaXRpb24gJiYgcmVuZGVyZXIoKS5jb250 YWluZXIoKSA9PSAmdmlldykKKyAgICAgICAgICAgIGNsaXBwaW5nQm91bmRzID0gdmlldy5mcmFt ZVZpZXcoKS52aWV3cG9ydENvbnN0cmFpbmVkRXh0ZW50UmVjdCgpOworICAgICAgICBlbHNlCiAg ICAgICAgICAgICBjbGlwcGluZ0JvdW5kcyA9IHZpZXcudW5zY2FsZWREb2N1bWVudFJlY3QoKTsK IAogICAgICAgICBpZiAoJm1fb3duaW5nTGF5ZXIgIT0gcm9vdExheWVyKQo=