127966 2014-01-30 16:32:10 -0800 NRWT shouldn't say "Finished writing JSON files" if it failed to to so 2014-01-30 16:58:53 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa ap commit-queue glenn oldest_to_newest 974087 0 rniwa 2014-01-30 16:32:10 -0800 NRWT shouldn't say "Finished writing JSON files" if it failed to to so 974089 1 222758 rniwa 2014-01-30 16:34:58 -0800 Created attachment 222758 Fixes the bug 974101 2 rniwa 2014-01-30 16:58:53 -0800 Committed r163134: <http://trac.webkit.org/changeset/163134> 222758 2014-01-30 16:34:58 -0800 2014-01-30 16:50:51 -0800 Fixes the bug bug-127966-20140130163458.patch text/plain 3900 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MzEzMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDE0LTAxLTMwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIE5SV1Qgc2hvdWxkbid0IHNheSAiRmluaXNoZWQgd3JpdGluZyBKU09OIGZpbGVz IiBpZiBpdCBmYWlsZWQgdG8gdG8gc28KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyNzk2NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIERvbid0IHNheSAiRmluaXNoZWQgd3JpdGluZyBKU09OIGZpbGVzIiBp ZiB3ZSBoYWQgZmFpbGVkIHRvIGdlbmVyYXRlIHRoZSBKU09OIGZpbGUuCisgICAgICAgIEFsc28g ZXhwbGljaXRseSBzYXkgdGhpcyBpcyBmb3IgdGVzdCByZXN1bHRzIHNlcnZlciBhcyB3ZSdyZSBn ZW5lcmF0aW5nIHR3byBKU09OIGZpbGVzLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weToKKyAgICAgICAgKE1hbmFnZXIuX3Vw bG9hZF9qc29uX2ZpbGVzKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9sYXlvdXRfcGFja2FnZS9qc29uX2xheW91dF9yZXN1bHRzX2dlbmVyYXRvci5weToKKyAgICAg ICAgKEpTT05MYXlvdXRSZXN1bHRzR2VuZXJhdG9yLl9faW5pdF9fKTogRG9uJ3QgZ2VuZXJhdGUg SlNPTiBmaWxlIGltcGxpY2l0bHkgaW5zaWRlIHRoZSBjb25zdHJ1Y3Rvci4KKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29uX3Jlc3VsdHNf Z2VuZXJhdG9yLnB5OgorICAgICAgICAoSlNPTlJlc3VsdHNHZW5lcmF0b3IuZ2VuZXJhdGVfanNv bl9vdXRwdXQpOiBSZXR1cm4gYSBib29sZWFuIGluZGljYXRpbmcgd2hldGhlciB0aGUgZ2VuZXJh dGlvbgorICAgICAgICBoYWQgc3VjY2VlZGVkIG9yIG5vdC4KKwogMjAxNC0wMS0zMCAgQW5kZXJz IENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhIHdlYlZpZXc6 ZGlkU3RhcnRQcm92aXNpb25hbE5hdmlnYXRpb246IGRlbGVnYXRlIG1ldGhvZApJbmRleDogVG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9s bGVycy9tYW5hZ2VyLnB5CShyZXZpc2lvbiAxNjMxMjgpCisrKyBUb29scy9TY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5CSh3b3JraW5nIGNvcHkpCkBA IC0zNTgsOCArMzU4LDEwIEBAIGNsYXNzIE1hbmFnZXIob2JqZWN0KToKICAgICAgICAgICAgICJs YXlvdXQtdGVzdHMiLAogICAgICAgICAgICAgc2VsZi5fb3B0aW9ucy5tYXN0ZXJfbmFtZSkKIAot ICAgICAgICBfbG9nLmRlYnVnKCJGaW5pc2hlZCB3cml0aW5nIEpTT04gZmlsZXMuIikKLQorICAg ICAgICBpZiBnZW5lcmF0b3IuZ2VuZXJhdGVfanNvbl9vdXRwdXQoKToKKyAgICAgICAgICAgIF9s b2cuZGVidWcoIkZpbmlzaGVkIHdyaXRpbmcgSlNPTiBmaWxlIGZvciB0aGUgdGVzdCByZXN1bHRz IHNlcnZlci4iKQorICAgICAgICBlbHNlOgorICAgICAgICAgICAgX2xvZy5kZWJ1ZygiRmFpbGVk IHRvIGdlbmVyYXRlIEpTT04gZmlsZSBmb3IgdGhlIHRlc3QgcmVzdWx0cyBzZXJ2ZXIuIikKIAog ICAgICAgICBqc29uX2ZpbGVzID0gWyJpbmNyZW1lbnRhbF9yZXN1bHRzLmpzb24iLCAiZnVsbF9y ZXN1bHRzLmpzb24iLCAidGltZXNfbXMuanNvbiJdCiAKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL2pzb25fbGF5b3V0X3Jlc3VsdHNfZ2Vu ZXJhdG9yLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL2xheW91dF9wYWNrYWdlL2pzb25fbGF5b3V0X3Jlc3VsdHNfZ2VuZXJhdG9yLnB5CShyZXZp c2lvbiAxNjMxMjgpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlv dXRfcGFja2FnZS9qc29uX2xheW91dF9yZXN1bHRzX2dlbmVyYXRvci5weQkod29ya2luZyBjb3B5 KQpAQCAtNzIsOCArNzIsNiBAQCBjbGFzcyBKU09OTGF5b3V0UmVzdWx0c0dlbmVyYXRvcihqc29u X3JlCiAgICAgICAgIHNlbGYuX2ZhaWx1cmVzID0gZGljdCgodGVzdF9uYW1lLCBydW5fcmVzdWx0 cy5yZXN1bHRzX2J5X25hbWVbdGVzdF9uYW1lXS50eXBlKSBmb3IgdGVzdF9uYW1lIGluIHJ1bl9y ZXN1bHRzLmZhaWx1cmVzX2J5X25hbWUpCiAgICAgICAgIHNlbGYuX3Rlc3RfdGltaW5ncyA9IHJ1 bl9yZXN1bHRzLnJlc3VsdHNfYnlfbmFtZQogCi0gICAgICAgIHNlbGYuZ2VuZXJhdGVfanNvbl9v dXRwdXQoKQotCiAgICAgZGVmIF9nZXRfcGF0aF9yZWxhdGl2ZV90b19sYXlvdXRfdGVzdF9yb290 KHNlbGYsIHRlc3QpOgogICAgICAgICAiIiJSZXR1cm5zIHRoZSBwYXRoIG9mIHRoZSB0ZXN0IHJl bGF0aXZlIHRvIHRoZSBsYXlvdXQgdGVzdCByb290LgogICAgICAgICBGb3IgZXhhbXBsZSwgZm9y OgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2th Z2UvanNvbl9yZXN1bHRzX2dlbmVyYXRvci5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29uX3Jlc3VsdHNfZ2VuZXJh dG9yLnB5CShyZXZpc2lvbiAxNjMxMjgpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9qc29uX3Jlc3VsdHNfZ2VuZXJhdG9yLnB5CSh3b3JraW5n IGNvcHkpCkBAIC0yMzUsOSArMjM1LDExIEBAIGNsYXNzIEpTT05SZXN1bHRzR2VuZXJhdG9yKG9i amVjdCk6CiAKICAgICBkZWYgZ2VuZXJhdGVfanNvbl9vdXRwdXQoc2VsZik6CiAgICAgICAgIGpz b25fb2JqZWN0ID0gc2VsZi5nZXRfanNvbigpCi0gICAgICAgIGlmIGpzb25fb2JqZWN0OgotICAg ICAgICAgICAgZmlsZV9wYXRoID0gc2VsZi5fZmlsZXN5c3RlbS5qb2luKHNlbGYuX3Jlc3VsdHNf ZGlyZWN0b3J5LCBzZWxmLklOQ1JFTUVOVEFMX1JFU1VMVFNfRklMRU5BTUUpCi0gICAgICAgICAg ICB3cml0ZV9qc29uKHNlbGYuX2ZpbGVzeXN0ZW0sIGpzb25fb2JqZWN0LCBmaWxlX3BhdGgpCisg ICAgICAgIGlmIG5vdCBqc29uX29iamVjdDoKKyAgICAgICAgICAgIHJldHVybiBGYWxzZQorICAg ICAgICBmaWxlX3BhdGggPSBzZWxmLl9maWxlc3lzdGVtLmpvaW4oc2VsZi5fcmVzdWx0c19kaXJl Y3RvcnksIHNlbGYuSU5DUkVNRU5UQUxfUkVTVUxUU19GSUxFTkFNRSkKKyAgICAgICAgd3JpdGVf anNvbihzZWxmLl9maWxlc3lzdGVtLCBqc29uX29iamVjdCwgZmlsZV9wYXRoKQorICAgICAgICBy ZXR1cm4gVHJ1ZQogCiAgICAgZGVmIGdlbmVyYXRlX3RpbWVzX21zX2ZpbGUoc2VsZik6CiAgICAg ICAgICMgRklYTUU6IHJlbmFtZSB0byBnZW5lcmF0ZV90aW1lc19tc19maWxlLiBUaGlzIG5lZWRz IHRvIGJlIGNvb3JkaW5hdGVkIHdpdGgK