127962 2014-01-30 15:14:47 -0800 Implement NavigationState::PolicyClient::decidePolicyForNewWindowAction 2014-01-30 15:19:32 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 974056 0 andersca 2014-01-30 15:14:47 -0800 Implement NavigationState::PolicyClient::decidePolicyForNewWindowAction 974058 1 222748 andersca 2014-01-30 15:17:14 -0800 Created attachment 222748 Patch 974061 2 commit-queue 2014-01-30 15:19:10 -0800 Attachment 222748 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.h:64: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.h:65: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 974062 3 andersca 2014-01-30 15:19:32 -0800 Committed r163129: <http://trac.webkit.org/changeset/163129> 222748 2014-01-30 15:17:14 -0800 2014-01-30 15:18:24 -0800 Patch bug-127962-20140130151714.patch text/plain 4836 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDMwMGFmNmI5MzUwZWZl M2JkNDYxYWM1Y2VlMjJiOGUzZTM4NGRkOC4uNWJlYzc5OGJlZTU3YTJkODMxYjg3NzhmN2IwOGQw NmU3M2U3N2Y2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTAxLTMwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgSW1wbGVtZW50IE5h dmlnYXRpb25TdGF0ZTo6UG9saWN5Q2xpZW50OjpkZWNpZGVQb2xpY3lGb3JOZXdXaW5kb3dBY3Rp b24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzk2 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhdmUg ZGVjaWRlUG9saWN5Rm9yTmV3V2luZG93QWN0aW9uIGNhbGwgZGVjaWRlUG9saWN5Rm9yTmF2aWdh dGlvbkFjdGlvbiB3aXRoIGEgbnVsbCBkZXN0aW5hdGlvbiBmcmFtZS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9Db2NvYS9OYXZpZ2F0aW9uU3RhdGUuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29j b2EvTmF2aWdhdGlvblN0YXRlLm1tOgorICAgICAgICAoV2ViS2l0OjpOYXZpZ2F0aW9uU3RhdGU6 OlBvbGljeUNsaWVudDo6ZGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbik6CisgICAgICAg IChXZWJLaXQ6Ok5hdmlnYXRpb25TdGF0ZTo6UG9saWN5Q2xpZW50OjpkZWNpZGVQb2xpY3lGb3JO ZXdXaW5kb3dBY3Rpb24pOgorCisyMDE0LTAxLTMwICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNj YUBhcHBsZS5jb20+CisKICAgICAgICAgZGVjaWRlUG9saWN5Rm9yTmV3V2luZG93QWN0aW9uIHNo b3VsZCB0YWtlIGEgTmF2aWdhdGlvbkFjdGlvbkRhdGEgb2JqZWN0CiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc5NTIKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL05hdmlnYXRpb25TdGF0ZS5oIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0NvY29hL05hdmlnYXRpb25TdGF0ZS5oCmluZGV4IGVlNjRkZjdmMmFj NzdjN2Y5YjhjYTIzNDdmNzUyOWIwNGZlMDExNTAuLmFhMzQxM2M4OTJiNWQ3NDBjY2FjYzZjZjc1 NGRhYzk5YTE5ZDIxNmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2Nv YS9OYXZpZ2F0aW9uU3RhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2Ev TmF2aWdhdGlvblN0YXRlLmgKQEAgLTYxLDcgKzYxLDggQEAgcHJpdmF0ZToKIAogICAgIHByaXZh dGU6CiAgICAgICAgIC8vIEFQSTo6UG9saWN5Q2xpZW50Ci0gICAgICAgIHZpcnR1YWwgdm9pZCBk ZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKFdlYlBhZ2VQcm94eSosIFdlYkZyYW1lUHJv eHkqLCBjb25zdCBOYXZpZ2F0aW9uQWN0aW9uRGF0YSYsIFdlYkZyYW1lUHJveHkqIG9yaWdpbmF0 aW5nRnJhbWUsIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYgb3JpZ2luYWxSZXF1ZXN0 LCBjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmLCBSZWZQdHI8V2ViRnJhbWVQb2xpY3lM aXN0ZW5lclByb3h5PiwgQVBJOjpPYmplY3QqIHVzZXJEYXRhKSBvdmVycmlkZTsKKyAgICAgICAg dmlydHVhbCB2b2lkIGRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24oV2ViUGFnZVByb3h5 KiwgV2ViRnJhbWVQcm94eSogZGVzdGluYXRpb25GcmFtZSwgY29uc3QgTmF2aWdhdGlvbkFjdGlv bkRhdGEmLCBXZWJGcmFtZVByb3h5KiBzb3VyY2VGcmFtZSwgY29uc3QgV2ViQ29yZTo6UmVzb3Vy Y2VSZXF1ZXN0JiBvcmlnaW5hbFJlcXVlc3QsIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVz dCYsIFJlZlB0cjxXZWJGcmFtZVBvbGljeUxpc3RlbmVyUHJveHk+LCBBUEk6Ok9iamVjdCogdXNl ckRhdGEpIG92ZXJyaWRlOworICAgICAgICB2aXJ0dWFsIHZvaWQgZGVjaWRlUG9saWN5Rm9yTmV3 V2luZG93QWN0aW9uKFdlYlBhZ2VQcm94eSosIFdlYkZyYW1lUHJveHkqIHNvdXJjZUZyYW1lLCBj b25zdCBOYXZpZ2F0aW9uQWN0aW9uRGF0YSYsIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVz dCYsIGNvbnN0IFdURjo6U3RyaW5nJiBmcmFtZU5hbWUsIFJlZlB0cjxXZWJGcmFtZVBvbGljeUxp c3RlbmVyUHJveHk+LCBBUEk6Ok9iamVjdCogdXNlckRhdGEpIG92ZXJyaWRlOwogICAgICAgICB2 aXJ0dWFsIHZvaWQgZGVjaWRlUG9saWN5Rm9yUmVzcG9uc2UoV2ViUGFnZVByb3h5KiwgV2ViRnJh bWVQcm94eSosIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2UmLCBjb25zdCBXZWJDb3Jl OjpSZXNvdXJjZVJlcXVlc3QmLCBib29sIGNhblNob3dNSU1FVHlwZSwgUmVmUHRyPFdlYkZyYW1l UG9saWN5TGlzdGVuZXJQcm94eT4sIEFQSTo6T2JqZWN0KiB1c2VyRGF0YSkgb3ZlcnJpZGU7CiAK ICAgICAgICAgTmF2aWdhdGlvblN0YXRlJiBtX25hdmlnYXRpb25TdGF0ZTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9OYXZpZ2F0aW9uU3RhdGUubW0gYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvTmF2aWdhdGlvblN0YXRlLm1tCmluZGV4IGUxZTA2 MzU2YzQzYjkyY2Y5NTNmMGY2OTI2NzhjYTcyYTVhYjgyMjIuLjdlZjZmYWRjNjJlMjhjYjU1OWIx MGFhMjVjNjU3ZDgxZTMwNTk5YTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9Db2NvYS9OYXZpZ2F0aW9uU3RhdGUubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0NvY29hL05hdmlnYXRpb25TdGF0ZS5tbQpAQCAtODIsNyArODIsNyBAQCBOYXZpZ2F0aW9uU3Rh dGU6OlBvbGljeUNsaWVudDo6flBvbGljeUNsaWVudCgpCiB7CiB9CiAKLXZvaWQgTmF2aWdhdGlv blN0YXRlOjpQb2xpY3lDbGllbnQ6OmRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24oV2Vi UGFnZVByb3h5KiwgV2ViRnJhbWVQcm94eSosIGNvbnN0IE5hdmlnYXRpb25BY3Rpb25EYXRhJiwg V2ViRnJhbWVQcm94eSogb3JpZ2luYXRpbmdGcmFtZSwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VS ZXF1ZXN0JiBvcmlnaW5hbFJlcXVlc3QsIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYs IFJlZlB0cjxXZWJGcmFtZVBvbGljeUxpc3RlbmVyUHJveHk+IGxpc3RlbmVyLCBBUEk6Ok9iamVj dCogdXNlckRhdGEpCit2b2lkIE5hdmlnYXRpb25TdGF0ZTo6UG9saWN5Q2xpZW50OjpkZWNpZGVQ b2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKFdlYlBhZ2VQcm94eSosIFdlYkZyYW1lUHJveHkqIGRl c3RpbmF0aW9uRnJhbWUsIGNvbnN0IE5hdmlnYXRpb25BY3Rpb25EYXRhJiwgV2ViRnJhbWVQcm94 eSogc291cmNlRnJhbWUsIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYgb3JpZ2luYWxS ZXF1ZXN0LCBjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmLCBSZWZQdHI8V2ViRnJhbWVQ b2xpY3lMaXN0ZW5lclByb3h5PiBsaXN0ZW5lciwgQVBJOjpPYmplY3QqIHVzZXJEYXRhKQogewog ICAgIGlmICghbV9uYXZpZ2F0aW9uU3RhdGUubV9uYXZpZ2F0aW9uRGVsZWdhdGVNZXRob2RzLndl YlZpZXdEZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uRGVjaXNpb25IYW5kbGVyKSB7CiAg ICAgICAgIC8vIEZJWE1FOiA8cmRhcjovL3Byb2JsZW0vMTU5NDk4MjI+IEZpZ3VyZSBvdXQgd2hh dCB0aGUgImRlZmF1bHQgZGVsZWdhdGUgYmVoYXZpb3IiIHNob3VsZCBiZSBoZXJlLgpAQCAtMTE0 LDYgKzExNCwxMSBAQCB2b2lkIE5hdmlnYXRpb25TdGF0ZTo6UG9saWN5Q2xpZW50OjpkZWNpZGVQ b2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKFdlYlBhZ2VQcm94eQogICAgIH1dOwogfQogCit2b2lk IE5hdmlnYXRpb25TdGF0ZTo6UG9saWN5Q2xpZW50OjpkZWNpZGVQb2xpY3lGb3JOZXdXaW5kb3dB Y3Rpb24oV2ViUGFnZVByb3h5KiB3ZWJQYWdlUHJveHksIFdlYkZyYW1lUHJveHkqIHNvdXJjZUZy YW1lLCBjb25zdCBOYXZpZ2F0aW9uQWN0aW9uRGF0YSYgbmF2aWdhdGlvbkFjdGlvbkRhdGEsIGNv bnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwgY29uc3QgV1RGOjpTdHJpbmcm IGZyYW1lTmFtZSwgUmVmUHRyPFdlYkZyYW1lUG9saWN5TGlzdGVuZXJQcm94eT4gbGlzdGVuZXIs IEFQSTo6T2JqZWN0KiB1c2VyRGF0YSkKK3sKKyAgICBkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9u QWN0aW9uKHdlYlBhZ2VQcm94eSwgbnVsbHB0ciwgbmF2aWdhdGlvbkFjdGlvbkRhdGEsIHNvdXJj ZUZyYW1lLCByZXF1ZXN0LCByZXF1ZXN0LCBzdGQ6Om1vdmUobGlzdGVuZXIpLCB1c2VyRGF0YSk7 Cit9CisKIHZvaWQgTmF2aWdhdGlvblN0YXRlOjpQb2xpY3lDbGllbnQ6OmRlY2lkZVBvbGljeUZv clJlc3BvbnNlKFdlYlBhZ2VQcm94eSosIFdlYkZyYW1lUHJveHkqLCBjb25zdCBXZWJDb3JlOjpS ZXNvdXJjZVJlc3BvbnNlJiwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiByZXNvdXJj ZVJlcXVlc3QsIGJvb2wgY2FuU2hvd01JTUVUeXBlLCBSZWZQdHI8V2ViRnJhbWVQb2xpY3lMaXN0 ZW5lclByb3h5PiBsaXN0ZW5lciwgQVBJOjpPYmplY3QqIHVzZXJEYXRhKQogewogICAgIGlmICgh bV9uYXZpZ2F0aW9uU3RhdGUubV9uYXZpZ2F0aW9uRGVsZWdhdGVNZXRob2RzLndlYlZpZXdEZWNp ZGVQb2xpY3lGb3JOYXZpZ2F0aW9uUmVzcG9uc2VEZWNpc2lvbkhhbmRsZXIpIHsK