127952 2014-01-30 14:45:47 -0800 decidePolicyForNewWindowAction should take a NavigationActionData object 2014-01-30 14:59:38 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 974017 0 andersca 2014-01-30 14:45:47 -0800 decidePolicyForNewWindowAction should take a NavigationActionData object 974020 1 222741 andersca 2014-01-30 14:46:23 -0800 Created attachment 222741 Patch 974025 2 commit-queue 2014-01-30 14:49:16 -0800 Attachment 222741 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/APIPolicyClient.h:55: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 974035 3 222741 kling 2014-01-30 14:58:18 -0800 Comment on attachment 222741 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222741&action=review > Source/WebKit2/UIProcess/API/C/WKPage.cpp:1014 > - virtual void decidePolicyForNewWindowAction(WebPageProxy* page, WebFrameProxy* frame, NavigationType type, WebEvent::Modifiers modifiers, WebMouseEvent::Button mouseButton, const ResourceRequest& resourceRequest, const String& frameName, WebFramePolicyListenerProxy* listener, API::Object* userData) override > + virtual void decidePolicyForNewWindowAction(WebPageProxy* page, WebFrameProxy* frame, const NavigationActionData& navigationActionData, const ResourceRequest& resourceRequest, const String& frameName, RefPtr<WebFramePolicyListenerProxy> listener, API::Object* userData) override This 'listener' should get moved. 974037 4 andersca 2014-01-30 14:59:38 -0800 Committed r163123: <http://trac.webkit.org/changeset/163123> 222741 2014-01-30 14:46:23 -0800 2014-01-30 14:58:18 -0800 Patch bug-127952-20140130144622.patch text/plain 6304 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTEyMGMwOWM3YWE3YjEy OWQ3MDU1YWMzMTg1Zjk1ZWVmNjUwYmY5My4uOGM2ODViZTBmOWY0OWQ4YWEyMWNmNWU5ZjhjYTk4 YjVhYWZkZDg5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTAxLTMwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgZGVjaWRlUG9saWN5 Rm9yTmV3V2luZG93QWN0aW9uIHNob3VsZCB0YWtlIGEgTmF2aWdhdGlvbkFjdGlvbkRhdGEgb2Jq ZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc5 NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvQVBJUG9saWN5Q2xpZW50Lmg6CisgICAgICAgIChBUEk6OlBvbGljeUNsaWVu dDo6ZGVjaWRlUG9saWN5Rm9yTmV3V2luZG93QWN0aW9uKToKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL0MvV0tQYWdlLmNwcDoKKyAgICAgICAgKFdLUGFnZVNldFBhZ2VQb2xpY3lDbGllbnQpOgor ICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJQYWdlUHJveHk6OmRlY2lkZVBvbGljeUZvck5ld1dpbmRvd0FjdGlvbik6CisKKzIwMTQtMDEt MzAgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBJbXBs ZW1lbnQgcG9saWN5IHJlc3BvbnNlIGRlbGVnYXRlIGhhbmRsaW5nCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc5NDUKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9BUElQb2xpY3lDbGllbnQuaCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvQVBJUG9saWN5Q2xpZW50LmgKaW5kZXggYTEzYzFhOThhYjI1MWU3 MmYzNDY5NjY4OGZkZWUxN2VlMmMxZTBmNC4uNDA5MDljZTY4NDU2MjFiY2ZlYmI4N2YzZTc2Njgw ZGUwNmE2ZmUzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9BUElQ b2xpY3lDbGllbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0FQSVBvbGlj eUNsaWVudC5oCkBAIC01Miw3ICs1Miw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5Qb2xpY3lD bGllbnQoKSB7IH0KIAogICAgIHZpcnR1YWwgdm9pZCBkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9u QWN0aW9uKFdlYktpdDo6V2ViUGFnZVByb3h5KiwgV2ViS2l0OjpXZWJGcmFtZVByb3h5KiwgY29u c3QgV2ViS2l0OjpOYXZpZ2F0aW9uQWN0aW9uRGF0YSYsIFdlYktpdDo6V2ViRnJhbWVQcm94eSog b3JpZ2luYXRpbmdGcmFtZSwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiBvcmlnaW5h bFJlcXVlc3QsIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYsIFJlZlB0cjxXZWJLaXQ6 OldlYkZyYW1lUG9saWN5TGlzdGVuZXJQcm94eT4gbGlzdGVuZXIsIEFQSTo6T2JqZWN0KiB1c2Vy RGF0YSkgeyBsaXN0ZW5lci0+dXNlKCk7IH0KLSAgICB2aXJ0dWFsIHZvaWQgZGVjaWRlUG9saWN5 Rm9yTmV3V2luZG93QWN0aW9uKFdlYktpdDo6V2ViUGFnZVByb3h5KiwgV2ViS2l0OjpXZWJGcmFt ZVByb3h5KiwgV2ViQ29yZTo6TmF2aWdhdGlvblR5cGUsIFdlYktpdDo6V2ViRXZlbnQ6Ok1vZGlm aWVycywgV2ViS2l0OjpXZWJNb3VzZUV2ZW50OjpCdXR0b24sIGNvbnN0IFdlYkNvcmU6OlJlc291 cmNlUmVxdWVzdCYsIGNvbnN0IFdURjo6U3RyaW5nJiBmcmFtZU5hbWUsIFdlYktpdDo6V2ViRnJh bWVQb2xpY3lMaXN0ZW5lclByb3h5KiBsaXN0ZW5lciwgQVBJOjpPYmplY3QqIHVzZXJEYXRhKSB7 IGxpc3RlbmVyLT51c2UoKTsgfQorICAgIHZpcnR1YWwgdm9pZCBkZWNpZGVQb2xpY3lGb3JOZXdX aW5kb3dBY3Rpb24oV2ViS2l0OjpXZWJQYWdlUHJveHkqLCBXZWJLaXQ6OldlYkZyYW1lUHJveHkq LCBjb25zdCBXZWJLaXQ6Ok5hdmlnYXRpb25BY3Rpb25EYXRhJiwgY29uc3QgV2ViQ29yZTo6UmVz b3VyY2VSZXF1ZXN0JiwgY29uc3QgV1RGOjpTdHJpbmcmIGZyYW1lTmFtZSwgUmVmUHRyPFdlYktp dDo6V2ViRnJhbWVQb2xpY3lMaXN0ZW5lclByb3h5PiBsaXN0ZW5lciwgQVBJOjpPYmplY3QqIHVz ZXJEYXRhKSB7IGxpc3RlbmVyLT51c2UoKTsgfQogICAgIHZpcnR1YWwgdm9pZCBkZWNpZGVQb2xp Y3lGb3JSZXNwb25zZShXZWJLaXQ6OldlYlBhZ2VQcm94eSosIFdlYktpdDo6V2ViRnJhbWVQcm94 eSosIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2UmLCBjb25zdCBXZWJDb3JlOjpSZXNv dXJjZVJlcXVlc3QmLCBib29sIGNhblNob3dNSU1FVHlwZSwgUmVmUHRyPFdlYktpdDo6V2ViRnJh bWVQb2xpY3lMaXN0ZW5lclByb3h5PiBsaXN0ZW5lciwgQVBJOjpPYmplY3QqIHVzZXJEYXRhKSB7 IGxpc3RlbmVyLT51c2UoKTsgfQogICAgIHZpcnR1YWwgdm9pZCB1bmFibGVUb0ltcGxlbWVudFBv bGljeShXZWJLaXQ6OldlYlBhZ2VQcm94eSosIFdlYktpdDo6V2ViRnJhbWVQcm94eSosIGNvbnN0 IFdlYkNvcmU6OlJlc291cmNlRXJyb3ImLCBBUEk6Ok9iamVjdCogdXNlckRhdGEpIHsgfQogfTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5jcHAKaW5kZXggMDkxNmJkYjIz MjRiN2NjNTVhNWRiNmQwNzcxYzZiYjM1NWIxYmIzOS4uNWNmMTM1MWRjZTYyOWUxZDgxODA1ODI2 ODhhZWUwOWI1MDFhOTE3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9DL1dLUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFn ZS5jcHAKQEAgLTEwMTEsNyArMTAxMSw3IEBAIHZvaWQgV0tQYWdlU2V0UGFnZVBvbGljeUNsaWVu dChXS1BhZ2VSZWYgcGFnZVJlZiwgY29uc3QgV0tQYWdlUG9saWN5Q2xpZW50QmFzZSoKICAgICAg ICAgICAgICAgICBtX2NsaWVudC5kZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uKHRvQVBJ KHBhZ2UpLCB0b0FQSShmcmFtZSksIHRvQVBJKG5hdmlnYXRpb25BY3Rpb25EYXRhLm5hdmlnYXRp b25UeXBlKSwgdG9BUEkobmF2aWdhdGlvbkFjdGlvbkRhdGEubW9kaWZpZXJzKSwgdG9BUEkobmF2 aWdhdGlvbkFjdGlvbkRhdGEubW91c2VCdXR0b24pLCB0b0FQSShvcmlnaW5hdGluZ0ZyYW1lKSwg dG9BUEkob3JpZ2luYWxSZXF1ZXN0LmdldCgpKSwgdG9BUEkocmVxdWVzdC5nZXQoKSksIHRvQVBJ KGxpc3RlbmVyLmdldCgpKSwgdG9BUEkodXNlckRhdGEpLCBtX2NsaWVudC5iYXNlLmNsaWVudElu Zm8pOwogICAgICAgICB9CiAKLSAgICAgICAgdmlydHVhbCB2b2lkIGRlY2lkZVBvbGljeUZvck5l d1dpbmRvd0FjdGlvbihXZWJQYWdlUHJveHkqIHBhZ2UsIFdlYkZyYW1lUHJveHkqIGZyYW1lLCBO YXZpZ2F0aW9uVHlwZSB0eXBlLCBXZWJFdmVudDo6TW9kaWZpZXJzIG1vZGlmaWVycywgV2ViTW91 c2VFdmVudDo6QnV0dG9uIG1vdXNlQnV0dG9uLCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlc291 cmNlUmVxdWVzdCwgY29uc3QgU3RyaW5nJiBmcmFtZU5hbWUsIFdlYkZyYW1lUG9saWN5TGlzdGVu ZXJQcm94eSogbGlzdGVuZXIsIEFQSTo6T2JqZWN0KiB1c2VyRGF0YSkgb3ZlcnJpZGUKKyAgICAg ICAgdmlydHVhbCB2b2lkIGRlY2lkZVBvbGljeUZvck5ld1dpbmRvd0FjdGlvbihXZWJQYWdlUHJv eHkqIHBhZ2UsIFdlYkZyYW1lUHJveHkqIGZyYW1lLCBjb25zdCBOYXZpZ2F0aW9uQWN0aW9uRGF0 YSYgbmF2aWdhdGlvbkFjdGlvbkRhdGEsIGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVzb3VyY2VS ZXF1ZXN0LCBjb25zdCBTdHJpbmcmIGZyYW1lTmFtZSwgUmVmUHRyPFdlYkZyYW1lUG9saWN5TGlz dGVuZXJQcm94eT4gbGlzdGVuZXIsIEFQSTo6T2JqZWN0KiB1c2VyRGF0YSkgb3ZlcnJpZGUKICAg ICAgICAgewogICAgICAgICAgICAgaWYgKCFtX2NsaWVudC5kZWNpZGVQb2xpY3lGb3JOZXdXaW5k b3dBY3Rpb24pIHsKICAgICAgICAgICAgICAgICBsaXN0ZW5lci0+dXNlKCk7CkBAIC0xMDIwLDcg KzEwMjAsNyBAQCB2b2lkIFdLUGFnZVNldFBhZ2VQb2xpY3lDbGllbnQoV0tQYWdlUmVmIHBhZ2VS ZWYsIGNvbnN0IFdLUGFnZVBvbGljeUNsaWVudEJhc2UqCiAKICAgICAgICAgICAgIFJlZlB0cjxB UEk6OlVSTFJlcXVlc3Q+IHJlcXVlc3QgPSBBUEk6OlVSTFJlcXVlc3Q6OmNyZWF0ZShyZXNvdXJj ZVJlcXVlc3QpOwogCi0gICAgICAgICAgICBtX2NsaWVudC5kZWNpZGVQb2xpY3lGb3JOZXdXaW5k b3dBY3Rpb24odG9BUEkocGFnZSksIHRvQVBJKGZyYW1lKSwgdG9BUEkodHlwZSksIHRvQVBJKG1v ZGlmaWVycyksIHRvQVBJKG1vdXNlQnV0dG9uKSwgdG9BUEkocmVxdWVzdC5nZXQoKSksIHRvQVBJ KGZyYW1lTmFtZS5pbXBsKCkpLCB0b0FQSShsaXN0ZW5lciksIHRvQVBJKHVzZXJEYXRhKSwgbV9j bGllbnQuYmFzZS5jbGllbnRJbmZvKTsKKyAgICAgICAgICAgIG1fY2xpZW50LmRlY2lkZVBvbGlj eUZvck5ld1dpbmRvd0FjdGlvbih0b0FQSShwYWdlKSwgdG9BUEkoZnJhbWUpLCB0b0FQSShuYXZp Z2F0aW9uQWN0aW9uRGF0YS5uYXZpZ2F0aW9uVHlwZSksIHRvQVBJKG5hdmlnYXRpb25BY3Rpb25E YXRhLm1vZGlmaWVycyksIHRvQVBJKG5hdmlnYXRpb25BY3Rpb25EYXRhLm1vdXNlQnV0dG9uKSwg dG9BUEkocmVxdWVzdC5nZXQoKSksIHRvQVBJKGZyYW1lTmFtZS5pbXBsKCkpLCB0b0FQSShsaXN0 ZW5lci5nZXQoKSksIHRvQVBJKHVzZXJEYXRhKSwgbV9jbGllbnQuYmFzZS5jbGllbnRJbmZvKTsK ICAgICAgICAgfQogCiAgICAgICAgIHZpcnR1YWwgdm9pZCBkZWNpZGVQb2xpY3lGb3JSZXNwb25z ZShXZWJQYWdlUHJveHkqIHBhZ2UsIFdlYkZyYW1lUHJveHkqIGZyYW1lLCBjb25zdCBSZXNvdXJj ZVJlc3BvbnNlJiByZXNvdXJjZVJlc3BvbnNlLCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlc291 cmNlUmVxdWVzdCwgYm9vbCBjYW5TaG93TUlNRVR5cGUsIFJlZlB0cjxXZWJGcmFtZVBvbGljeUxp c3RlbmVyUHJveHk+IGxpc3RlbmVyLCBBUEk6Ok9iamVjdCogdXNlckRhdGEpIG92ZXJyaWRlCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCmluZGV4IGVhNGE1Zjk1ZDQx NTQ5OGVlODYwNjUxZDZhMTJiZTRiYTU2Mjg4ZjQuLmM1MmU4ZWNjMGEyZjhmYWMxN2ZhYjY3NTk4 ZDc4NzIzNWE5Yjg5ODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHku Y3BwCkBAIC0yNDc3LDcgKzI0NzcsNyBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6ZGVjaWRlUG9saWN5 Rm9yTmV3V2luZG93QWN0aW9uKHVpbnQ2NF90IGZyYW1lSUQsIGNvbnN0IE5hdmlnYQogCiAgICAg UmVmUHRyPFdlYkZyYW1lUG9saWN5TGlzdGVuZXJQcm94eT4gbGlzdGVuZXIgPSBmcmFtZS0+c2V0 VXBQb2xpY3lMaXN0ZW5lclByb3h5KGxpc3RlbmVySUQpOwogCi0gICAgbV9wb2xpY3lDbGllbnQt PmRlY2lkZVBvbGljeUZvck5ld1dpbmRvd0FjdGlvbih0aGlzLCBmcmFtZSwgbmF2aWdhdGlvbkFj dGlvbkRhdGEubmF2aWdhdGlvblR5cGUsIG5hdmlnYXRpb25BY3Rpb25EYXRhLm1vZGlmaWVycywg bmF2aWdhdGlvbkFjdGlvbkRhdGEubW91c2VCdXR0b24sIHJlcXVlc3QsIGZyYW1lTmFtZSwgbGlz dGVuZXIuZ2V0KCksIHVzZXJEYXRhLmdldCgpKTsKKyAgICBtX3BvbGljeUNsaWVudC0+ZGVjaWRl UG9saWN5Rm9yTmV3V2luZG93QWN0aW9uKHRoaXMsIGZyYW1lLCBuYXZpZ2F0aW9uQWN0aW9uRGF0 YSwgcmVxdWVzdCwgZnJhbWVOYW1lLCBsaXN0ZW5lci5nZXQoKSwgdXNlckRhdGEuZ2V0KCkpOwog fQogCiB2b2lkIFdlYlBhZ2VQcm94eTo6ZGVjaWRlUG9saWN5Rm9yUmVzcG9uc2UodWludDY0X3Qg ZnJhbWVJRCwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVzcG9uc2UsIGNvbnN0IFJlc291cmNl UmVxdWVzdCYgcmVxdWVzdCwgYm9vbCBjYW5TaG93TUlNRVR5cGUsIHVpbnQ2NF90IGxpc3RlbmVy SUQsIElQQzo6TWVzc2FnZURlY29kZXImIGRlY29kZXIpCg==