127936 2014-01-30 12:54:30 -0800 De-virtual-ize CachedResource::isImage() 2014-01-30 13:44:55 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer commit-queue japhet kling koivisto oldest_to_newest 973920 0 ddkilzer 2014-01-30 12:54:30 -0800 De-virtual-ize CachedResource::isImage() by using type(). Also replace some explicit type() checks with call to isImage(). 973932 1 222719 ddkilzer 2014-01-30 13:02:41 -0800 Created attachment 222719 Patch v1 973948 2 222719 kling 2014-01-30 13:15:45 -0800 Comment on attachment 222719 Patch v1 r=me 973980 3 222719 commit-queue 2014-01-30 13:44:53 -0800 Comment on attachment 222719 Patch v1 Clearing flags on attachment: 222719 Committed r163111: <http://trac.webkit.org/changeset/163111> 973981 4 commit-queue 2014-01-30 13:44:55 -0800 All reviewed patches have been landed. Closing bug. 222719 2014-01-30 13:02:41 -0800 2014-01-30 13:44:53 -0800 Patch v1 bug-127936-20140130130238.patch text/plain 5622 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzMDgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTEzZjE4OGFlNjUyYjk1 ZjNiNTcyYWMxNzcwZWExMjViYmFlNzVkMi4uNWExMjI0ODBkNTQyZGYzYjEyOWUxMTk2MDEwOTg4 NTk3NmQ1OWEzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTAxLTMwICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgRGUtdmlydHVhbC1pemUg Q2FjaGVkUmVzb3VyY2U6OmlzSW1hZ2UoKQorICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8x Mjc5MzY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWxzbyByZXBsYWNlIGV4cGxpY2l0IHR5cGUoKSBjaGVja3Mgd2l0aCBpc0ltYWdlKCkuCisKKyAg ICAgICAgKiBsb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 U3VicmVzb3VyY2VMb2FkZXI6OndpbGxTZW5kUmVxdWVzdCk6IFVzZSBpc0ltYWdlKCkuCisgICAg ICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZEltYWdlLmg6CisgICAgICAgIChXZWJDb3JlOjpDYWNo ZWRSZXNvdXJjZTo6aXNJbWFnZSk6IFJlbW92ZSB2aXJ0dWFsIG92ZXJyaWRlLgorICAgICAgICAq IGxvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5oOgorICAgICAgICAoV2ViQ29yZTo6Q2FjaGVk UmVzb3VyY2U6OmlzSW1hZ2UpOiBDaGVjayB0eXBlKCkgaW5zdGVhZCBvZgorICAgICAgICBkZWZp bmluZyBhIHZpcnR1YWwgbWV0aG9kIHRoYXQgcmV0dXJucyBmYWxzZSBieSBkZWZhdWx0LgorICAg ICAgICAqIGxvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZUxvYWRlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpDYWNoZWRSZXNvdXJjZUxvYWRlcjo6cmVsb2FkSW1hZ2VzSWZOb3REZWZlcnJlZCk6 IFVzZSBpc0ltYWdlKCkuCisKIDIwMTQtMDEtMzAgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBw bGUuY29tPgogCiAgICAgICAgIFdlYlBhZ2U6OmRldGVybWluZVByaW1hcnlTbmFwc2hvdHRlZFBs dWdJbiBpcyBzbG93CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggNzdiMTE2ZWRjMTEzZWJjMGQ1YWU4YjI3 OTI4MjJhYzRmZDM4YWMzYS4uZDZiYTE5ZmUxMDNjZjk4NWExNmZlOThiMWI5OWJiNDRjNzdiYjVk ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAxLTMwICBEYXZpZCBL aWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgRGUtdmlydHVhbC1pemUgQ2Fj aGVkUmVzb3VyY2U6OmlzSW1hZ2UoKQorICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMjc5 MzY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxz byByZXBsYWNlIGV4cGxpY2l0IHR5cGUoKSBjaGVja3Mgd2l0aCBpc0ltYWdlKCkuCisKKyAgICAg ICAgKiBNaXNjL1dlYkNhY2hlLm1tOgorICAgICAgICAoK1tXZWJDYWNoZSBpbWFnZUZvclVSTDpd KTogVXNlICFpc0ltYWdlKCkuCisKIDIwMTQtMDEtMzAgIEFuZHJlaSBCdWN1ciAgPGFidWN1ckBh ZG9iZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHRoZSBBQ0NFTEVSQVRFRF9DT01QT1NJVElORyBm bGFnCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvU3VicmVzb3VyY2VMb2FkZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL1N1YnJlc291cmNlTG9hZGVyLmNwcAppbmRleCAw ZjE3MjY0ZTA1MzA3YTIxNGY1MjQwYzE4YmVlYjdiMGVlOGIyOGRjLi40MzZlMzE0Mjk3MTRhZDIz MWExOTU4NjFkNzkyZTIwODQzZWU3YWI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvU3VicmVzb3VyY2VMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9TdWJy ZXNvdXJjZUxvYWRlci5jcHAKQEAgLTE2NCw3ICsxNjQsNyBAQCB2b2lkIFN1YnJlc291cmNlTG9h ZGVyOjp3aWxsU2VuZFJlcXVlc3QoUmVzb3VyY2VSZXF1ZXN0JiBuZXdSZXF1ZXN0LCBjb25zdCBS ZXNvdQogICAgICAgICAgICAgY2FuY2VsKCk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAg IH0KLSAgICAgICAgaWYgKG1fcmVzb3VyY2UtPnR5cGUoKSA9PSBDYWNoZWRSZXNvdXJjZTo6SW1h Z2VSZXNvdXJjZSAmJiBtX2RvY3VtZW50TG9hZGVyLT5jYWNoZWRSZXNvdXJjZUxvYWRlcigpLnNo b3VsZERlZmVySW1hZ2VMb2FkKG5ld1JlcXVlc3QudXJsKCkpKSB7CisgICAgICAgIGlmIChtX3Jl c291cmNlLT5pc0ltYWdlKCkgJiYgbV9kb2N1bWVudExvYWRlci0+Y2FjaGVkUmVzb3VyY2VMb2Fk ZXIoKS5zaG91bGREZWZlckltYWdlTG9hZChuZXdSZXF1ZXN0LnVybCgpKSkgewogICAgICAgICAg ICAgY2FuY2VsKCk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRJbWFnZS5oIGIvU291cmNlL1dlYkNv cmUvbG9hZGVyL2NhY2hlL0NhY2hlZEltYWdlLmgKaW5kZXggMTJiNzdjYzQ2YmFkZGI4MTcxMmNk MTcyYjg4ODNhYTRlMmM2NTIyMi4uMGMwMmE2NTJlNjJlNzVhZWMwMmY3NDBjZTFhNjVkNDc3MWRh YzQ0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZEltYWdl LmgKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZEltYWdlLmgKQEAgLTEy Miw3ICsxMjIsNiBAQCBwcml2YXRlOgogICAgIC8vIEZvciBjb21wYXRpYmlsaXR5LCBpbWFnZXMg a2VlcCBsb2FkaW5nIGV2ZW4gaWYgdGhlcmUgYXJlIEhUVFAgZXJyb3JzLgogICAgIHZpcnR1YWwg Ym9vbCBzaG91bGRJZ25vcmVIVFRQU3RhdHVzQ29kZUVycm9ycygpIGNvbnN0IG92ZXJyaWRlIHsg cmV0dXJuIHRydWU7IH0KIAotICAgIHZpcnR1YWwgYm9vbCBpc0ltYWdlKCkgY29uc3Qgb3ZlcnJp ZGUgeyByZXR1cm4gdHJ1ZTsgfQogICAgIHZpcnR1YWwgYm9vbCBzdGlsbE5lZWRzTG9hZCgpIGNv bnN0IG92ZXJyaWRlIHsgcmV0dXJuICFlcnJvck9jY3VycmVkKCkgJiYgc3RhdHVzKCkgPT0gVW5r bm93biAmJiAhaXNMb2FkaW5nKCk7IH0KIAogICAgIC8vIEltYWdlT2JzZXJ2ZXIKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5oIGIvU291cmNl L1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmgKaW5kZXggOGRlNjljZGJmMDk4 YWVjZTU2OTY2YjMxODZiYWVhOGRiNTZmNzZhYy4uZjMzOWFlMjY0YWJiMDA1MzQ4NDc5MDU0OTY2 Y2I3OWI0OTY4MmY0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0Nh Y2hlZFJlc291cmNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJl c291cmNlLmgKQEAgLTE1NSw3ICsxNTUsNyBAQCBwdWJsaWM6CiAKICAgICBTdWJyZXNvdXJjZUxv YWRlciogbG9hZGVyKCkgeyByZXR1cm4gbV9sb2FkZXIuZ2V0KCk7IH0KIAotICAgIHZpcnR1YWwg Ym9vbCBpc0ltYWdlKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH0KKyAgICBib29sIGlzSW1hZ2Uo KSBjb25zdCB7IHJldHVybiB0eXBlKCkgPT0gSW1hZ2VSZXNvdXJjZTsgfQogICAgIGJvb2wgaWdu b3JlRm9yUmVxdWVzdENvdW50KCkgY29uc3QKICAgICB7CiAgICAgICAgIHJldHVybiB0eXBlKCkg PT0gTWFpblJlc291cmNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUv Q2FjaGVkUmVzb3VyY2VMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0Nh Y2hlZFJlc291cmNlTG9hZGVyLmNwcAppbmRleCBlZmJkYmU1ZjM2YmRmMDA3Mjk0NTRiOWU0NjZm M2IxMDc4NTZjMzcwLi5hOTQ3Y2MzYzczYzRhMDhiMmRlYmVmMzFjYmZjZDYzZDI2OTY0MTZlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VMb2Fk ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZUxv YWRlci5jcHAKQEAgLTY4Niw3ICs2ODYsNyBAQCB2b2lkIENhY2hlZFJlc291cmNlTG9hZGVyOjpy ZWxvYWRJbWFnZXNJZk5vdERlZmVycmVkKCkKICAgICBEb2N1bWVudFJlc291cmNlTWFwOjppdGVy YXRvciBlbmQgPSBtX2RvY3VtZW50UmVzb3VyY2VzLmVuZCgpOwogICAgIGZvciAoRG9jdW1lbnRS ZXNvdXJjZU1hcDo6aXRlcmF0b3IgaXQgPSBtX2RvY3VtZW50UmVzb3VyY2VzLmJlZ2luKCk7IGl0 ICE9IGVuZDsgKytpdCkgewogICAgICAgICBDYWNoZWRSZXNvdXJjZSogcmVzb3VyY2UgPSBpdC0+ dmFsdWUuZ2V0KCk7Ci0gICAgICAgIGlmIChyZXNvdXJjZS0+dHlwZSgpID09IENhY2hlZFJlc291 cmNlOjpJbWFnZVJlc291cmNlICYmIHJlc291cmNlLT5zdGlsbE5lZWRzTG9hZCgpICYmICFjbGll bnREZWZlcnNJbWFnZShyZXNvdXJjZS0+dXJsKCkpKQorICAgICAgICBpZiAocmVzb3VyY2UtPmlz SW1hZ2UoKSAmJiByZXNvdXJjZS0+c3RpbGxOZWVkc0xvYWQoKSAmJiAhY2xpZW50RGVmZXJzSW1h Z2UocmVzb3VyY2UtPnVybCgpKSkKICAgICAgICAgICAgIGNvbnN0X2Nhc3Q8Q2FjaGVkUmVzb3Vy Y2UqPihyZXNvdXJjZSktPmxvYWQodGhpcywgZGVmYXVsdENhY2hlZFJlc291cmNlT3B0aW9ucygp KTsKICAgICB9CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9NaXNjL1dlYkNhY2hl Lm1tIGIvU291cmNlL1dlYktpdC9tYWMvTWlzYy9XZWJDYWNoZS5tbQppbmRleCAxOGU2YzIzNjlk YzJiODc1YzQ0YWJjM2NmNTFiZjVhYTNlZTZkZTY4Li5jMzU4ZTMxZDI2Njg5MGIwOTE2YTYyZDJi MjE1YWY5ZGViNjY2MTQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9NaXNjL1dlYkNh Y2hlLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL01pc2MvV2ViQ2FjaGUubW0KQEAgLTIzNCw3 ICsyMzQsNyBAQCArIChDR0ltYWdlUmVmKWltYWdlRm9yVVJMOihOU1VSTCAqKXVybAogICAgICAg ICByZXR1cm4gbnVsbHB0cjsKICAgICAKICAgICBXZWJDb3JlOjpDYWNoZWRSZXNvdXJjZSogY2Fj aGVkUmVzb3VyY2UgPSBXZWJDb3JlOjptZW1vcnlDYWNoZSgpLT5yZXNvdXJjZUZvclVSTCh1cmwp OwotICAgIGlmICghY2FjaGVkUmVzb3VyY2UgfHwgY2FjaGVkUmVzb3VyY2UtPnR5cGUoKSAhPSBX ZWJDb3JlOjpDYWNoZWRSZXNvdXJjZTo6SW1hZ2VSZXNvdXJjZSkKKyAgICBpZiAoIWNhY2hlZFJl c291cmNlIHx8ICFjYWNoZWRSZXNvdXJjZS0+aXNJbWFnZSgpKQogICAgICAgICByZXR1cm4gbnVs bHB0cjsKICAgICBXZWJDb3JlOjpDYWNoZWRJbWFnZSogY2FjaGVkSW1hZ2UgPSBzdGF0aWNfY2Fz dDxXZWJDb3JlOjpDYWNoZWRJbWFnZSo+KGNhY2hlZFJlc291cmNlKTsKICAgICBpZiAoIWNhY2hl ZEltYWdlIHx8ICFjYWNoZWRJbWFnZS0+aGFzSW1hZ2UoKSkK