127917 2014-01-30 10:00:18 -0800 WebKitTestRunner fails to link - missing rowHeaders and columnHeaders 2014-01-30 14:48:10 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) iPhone / iPad All RESOLVED FIXED P2 Normal --- 1 dfarler cfleizach cfleizach commit-queue dfarler oldest_to_newest 973780 0 dfarler 2014-01-30 10:00:18 -0800 After 162986, https://bugs.webkit.org/show_bug.cgi?id=127688, an implementation for rowHeaders and columnHeaders was left out of AccessibilityUIElementIOS. We need stubs or reference a common Mac implementation of these methods. 973782 1 cfleizach 2014-01-30 10:01:35 -0800 i'll take care of this now 973785 2 dfarler 2014-01-30 10:04:58 -0800 Thanks! I've added the Tools subdirectory to the CI builds. 973788 3 222681 cfleizach 2014-01-30 10:06:13 -0800 Created attachment 222681 patch 973813 4 dfarler 2014-01-30 10:42:31 -0800 Sorry, one more thing - DumpRenderTree also needs implementations. 973819 5 cfleizach 2014-01-30 10:57:24 -0800 (In reply to comment #4) > Sorry, one more thing - DumpRenderTree also needs implementations. Did DRT fail, because I saw this line was added #if !PLATFORM(MAC) void AccessibilityUIElement::uiElementArrayAttributeValue(JSStringRef, Vector<AccessibilityUIElement>&) const { } void AccessibilityUIElement::columnHeaders(Vector<AccessibilityUIElement>&) const { } void AccessibilityUIElement::rowHeaders(Vector<AccessibilityUIElement>&) const { } #endif 973825 6 dfarler 2014-01-30 10:59:09 -0800 It did but I must be behind that change, I don't have those lines in r163079. If those were added after that, then disregard and I'll update :) 973998 7 222681 cfleizach 2014-01-30 14:20:11 -0800 Comment on attachment 222681 patch Thanks! 974022 8 222681 commit-queue 2014-01-30 14:48:08 -0800 Comment on attachment 222681 patch Clearing flags on attachment: 222681 Committed r163117: <http://trac.webkit.org/changeset/163117> 974023 9 commit-queue 2014-01-30 14:48:10 -0800 All reviewed patches have been landed. Closing bug. 222681 2014-01-30 10:06:13 -0800 2014-01-30 14:48:08 -0800 patch patch text/plain 1391 cfleizach SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE2MzA4OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE0LTAxLTMwICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5j b20+CisKKyAgICAgICAgV2ViS2l0VGVzdFJ1bm5lciBmYWlscyB0byBsaW5rIC0gbWlzc2luZyBy b3dIZWFkZXJzIGFuZCBjb2x1bW5IZWFkZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc5MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvaW9z L0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRJT1MubW06CisgICAgICAgIChXVFI6OkFjY2Vzc2liaWxp dHlVSUVsZW1lbnQ6OnJvd0hlYWRlcnMpOgorICAgICAgICAoV1RSOjpBY2Nlc3NpYmlsaXR5VUlF bGVtZW50Ojpjb2x1bW5IZWFkZXJzKToKKwogMjAxNC0wMS0zMCAgRGF2aWQgRmFybGVyICA8ZGZh cmxlckBhcHBsZS5jb20+CiAKICAgICAgICAgcGFja2FnZS1yb290IHNob3VsZCBjb3B5IC4vdXNy IGZyb20gdGhlIGJ1aWxkIHByb2R1Y3RzIGRpcmVjdG9yeQpJbmRleDogVG9vbHMvV2ViS2l0VGVz dFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9pb3MvQWNjZXNzaWJpbGl0eVVJRWxlbWVudElPUy5tbQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL2lvcy9B Y2Nlc3NpYmlsaXR5VUlFbGVtZW50SU9TLm1tCShyZXZpc2lvbiAxNjMwODcpCisrKyBUb29scy9X ZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL2lvcy9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50 SU9TLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xOTgsNiArMTk4LDE2IEBACiAgICAgcmV0dXJuIDA7 CiB9CiAKK0pTVmFsdWVSZWYgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6cm93SGVhZGVycygpIGNv bnN0Cit7CisgICAgcmV0dXJuIG51bGxwdHI7Cit9CisKK0pTVmFsdWVSZWYgQWNjZXNzaWJpbGl0 eVVJRWxlbWVudDo6Y29sdW1uSGVhZGVycygpIGNvbnN0Cit7CisgICAgcmV0dXJuIG51bGxwdHI7 Cit9CisKIFBhc3NSZWZQdHI8QWNjZXNzaWJpbGl0eVVJRWxlbWVudD4gQWNjZXNzaWJpbGl0eVVJ RWxlbWVudDo6dWlFbGVtZW50QXR0cmlidXRlVmFsdWUoSlNTdHJpbmdSZWYgYXR0cmlidXRlKSBj b25zdAogewogICAgIHJldHVybiAwOwo=