127909 2014-01-30 07:45:35 -0800 [GTK] Disable optimizations for JSC that turned out malignant after jsCStack branch merge 2014-01-31 10:58:49 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 127777 1 zan zan berto cgarcia ggaren gustavo mrobinson ossy oldest_to_newest 973723 0 zan 2014-01-30 07:45:35 -0800 [GTK] Disable optimizations for JSC that turned out malignant after jsCStack branch merge 973727 1 222668 zan 2014-01-30 07:51:30 -0800 Created attachment 222668 Patch 973729 2 ossy 2014-01-30 08:11:07 -0800 -fno-omit-frame-pointer is reasonable, but I'm a little bit sceptic about -fno-tree-dce . Of course it can be good as a workaround, but it would be great to find the root of this problem. Could you possibly add a detailed comment with bug URL to the GNUmakefile.am too? I'm not so familiar with autotools files, so I'd like to let the final review for the GTK maintainers. 973731 3 cgarcia 2014-01-30 08:14:28 -0800 (In reply to comment #2) > -fno-omit-frame-pointer is reasonable, but I'm a little bit sceptic about > -fno-tree-dce . Of course it can be good as a workaround, but it would be > great to find the root of this problem. Could you possibly add a detailed > comment with bug URL to the GNUmakefile.am too? > > I'm not so familiar with autotools files, so I'd like > to let the final review for the GTK maintainers. I agree, let's land this just as a workaround, but we should re-enable the optimizations at some point. Maybe we could file bug reports for that. 973733 4 berto 2014-01-30 08:16:42 -0800 I think that should go to CFLAGS (compiler flags), not CPPFLAGS (preprocessor flags). --- Source/JavaScriptCore/GNUmakefile.am (revision 163081) +++ Source/JavaScriptCore/GNUmakefile.am (working copy) @@ -70,6 +70,8 @@ javascriptcore_cppflags += \ -I$(srcdir)/Source/JavaScriptCore/yarr \ -I$(top_builddir)/DerivedSources/JavaScriptCore \ -I$(srcdir)/Source/WTF \ + -fno-omit-frame-pointer \ + -fno-tree-dce \ $(LLVM_CFLAGS) javascriptcore_cflags += \ 973736 5 berto 2014-01-30 08:19:52 -0800 (In reply to comment #4) > I think that should go to CFLAGS (compiler flags), not CPPFLAGS > (preprocessor flags). CXXFLAGS actually, or are we using CPPFLAGS to make sure that they're included in both cases? :) 973739 6 zan 2014-01-30 08:28:19 -0800 (In reply to comment #5) > (In reply to comment #4) > > I think that should go to CFLAGS (compiler flags), not CPPFLAGS > > (preprocessor flags). > > CXXFLAGS actually, or are we using CPPFLAGS to make sure that they're > included in both cases? :) Yes, we're trying to cover both cases. 973744 7 berto 2014-01-30 08:48:20 -0800 My clang installation (3.4) doesn't seem to like this flag: clang: error: unknown argument: '-fno-tree-dce' 973827 8 ggaren 2014-01-30 11:01:09 -0800 > -fno-omit-frame-pointer is reasonable, but I'm a little bit sceptic about > -fno-tree-dce . Me too. 973845 9 zan 2014-01-30 11:18:00 -0800 (In reply to comment #7) > My clang installation (3.4) doesn't seem to like this flag: > > clang: error: unknown argument: '-fno-tree-dce' Already addressed in bug #127911. 973846 10 zan 2014-01-30 11:18:45 -0800 (In reply to comment #8) > > -fno-omit-frame-pointer is reasonable, but I'm a little bit sceptic about > > -fno-tree-dce . > > Me too. The optimization is only problematic with GCC 4.8 but not with GCC 4.7, so this might be a bug introduced in the compiler. 974365 11 zan 2014-01-31 10:58:30 -0800 Landed in r163083. http://trac.webkit.org/changeset/163083 222668 2014-01-30 07:51:30 -0800 2014-01-30 08:11:13 -0800 Patch bug-127909-20140130075129.patch text/plain 1363 zan SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYzMDgyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE0LTAxLTMwICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAg ICAgICBbR1RLXSBEaXNhYmxlIG9wdGltaXphdGlvbnMgZm9yIEpTQyB0aGF0IHR1cm5lZCBvdXQg bWFsaWduYW50IGFmdGVyIGpzQ1N0YWNrIGJyYW5jaCBtZXJnZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3OTA5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbTogRGlzYWJsZSB0 aGUgLWZvbWl0LWZyYW1lLXBvaW50ZXIgb3B0aW1pemF0aW9uIHRvIGFjaGlldmUgcHJvcGVyIHJl Z2lzdGVyIHVzYWdlCisgICAgICAgIGluIG9wZXJhdGlvbkNhbGxFdmFsLiBEaXNhYmxlIHRoZSAt ZnRyZWUtZGNlIG9wdGltaXphdGlvbiBzaW5jZSBpdCBpcyBjYXVzaW5nIGFkZGl0aW9uYWwgZmFp bHVyZXMKKyAgICAgICAgd2hlbiB1c2luZyBHQ0MgNC44LCBwb3NzaWJseSBkdWUgdG8gYSBidWcg aW4gdGhlIGNvbXBpbGVyIGl0c2VsZi4KKwogMjAxNC0wMS0yOSAgQ3NhYmEgT3N6dHJvZ29uw6Fj ICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSBFTkFCTEUoSkFWQVNDUklQVF9E RUJVR0dFUikgbGVmdG92ZXJzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvR05VbWFrZWZp bGUuYW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0dOVW1ha2VmaWxlLmFt CShyZXZpc2lvbiAxNjMwODEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvR05VbWFrZWZpbGUu YW0JKHdvcmtpbmcgY29weSkKQEAgLTcwLDYgKzcwLDggQEAgamF2YXNjcmlwdGNvcmVfY3BwZmxh Z3MgKz0gXAogCS1JJChzcmNkaXIpL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS95YXJyIFwKIAktSSQo dG9wX2J1aWxkZGlyKS9EZXJpdmVkU291cmNlcy9KYXZhU2NyaXB0Q29yZSBcCiAJLUkkKHNyY2Rp cikvU291cmNlL1dURiBcCisJLWZuby1vbWl0LWZyYW1lLXBvaW50ZXIgXAorCS1mbm8tdHJlZS1k Y2UgXAogCSQoTExWTV9DRkxBR1MpCiAKIGphdmFzY3JpcHRjb3JlX2NmbGFncyArPSBcCg==