127904 2014-01-30 03:52:18 -0800 Fix compilation on ARM traditional after jsCStack branch merge 2014-01-31 07:06:28 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Unspecified RESOLVED FIXED P2 Normal --- 108645 127763 1 p.jacquemart webkit-unassigned commit-queue jbriance mhahnenberg msaboff ossy rgabor oldest_to_newest 973688 0 p.jacquemart 2014-01-30 03:52:18 -0800 Speculative / untested patch to fix compilation for ARM traditional 973689 1 222658 p.jacquemart 2014-01-30 03:58:09 -0800 Created attachment 222658 Speculative fix compilation for ARM traditional 973695 2 ossy 2014-01-30 04:34:36 -0800 *** Bug 127856 has been marked as a duplicate of this bug. *** 974263 3 p.jacquemart 2014-01-31 03:38:30 -0800 I tried to run on board but the build is crashing In the meantime, it also crashed while disabling JIT at runtime so I might have another issue here ;-( 974274 4 222810 jbriance 2014-01-31 06:12:54 -0800 Created attachment 222810 Add missing pushPair/popPair implementations in macro assembler for traditional ARM. This one should work better :) 974279 5 222810 zherczeg 2014-01-31 06:30:46 -0800 Comment on attachment 222810 Add missing pushPair/popPair implementations in macro assembler for traditional ARM. r=me 974281 6 222810 commit-queue 2014-01-31 07:06:24 -0800 Comment on attachment 222810 Add missing pushPair/popPair implementations in macro assembler for traditional ARM. Clearing flags on attachment: 222810 Committed r163169: <http://trac.webkit.org/changeset/163169> 974282 7 commit-queue 2014-01-31 07:06:28 -0800 All reviewed patches have been landed. Closing bug. 222658 2014-01-30 03:58:09 -0800 2014-01-30 03:58:09 -0800 Speculative fix compilation for ARM traditional jit-comiplation-arm-traditional.diff text/plain 1327 p.jacquemart ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGQ2MGUxNDMuLmZlZGUwNzggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAxLTMwICBQYXNjYWwgSmFjcXVl bWFydCAgPHAuamFjcXVlbWFydEBzYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggY29tcGlsYXRp b24gZm9yIEFSTSB0cmFkaXRpb25hbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTI3OTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaDoKKyAgICAgICAg KEpTQzo6TWFjcm9Bc3NlbWJsZXJBUk06OnBvcFBhaXIpOgorICAgICAgICAoSlNDOjpNYWNyb0Fz c2VtYmxlckFSTTo6cHVzaFBhaXIpOgorCiAyMDE0LTAxLTI5ICBDc2FiYSBPc3p0cm9nb27DoWMg IDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIEVOQUJMRShKQVZBU0NSSVBUX0RF QlVHR0VSKSBsZWZ0b3ZlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3Nl bWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAppbmRleCAwNDk2MzAzLi5jNGNiYjE4IDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oCkBA IC01MzQsNiArNTM0LDE2IEBAIHB1YmxpYzoKICAgICAgICAgcHVzaChBUk1SZWdpc3RlcnM6OlMw KTsKICAgICB9CiAKKyAgICB2b2lkIHBvcFBhaXIoUmVnaXN0ZXJJRCBkZXN0MSwgUmVnaXN0ZXJJ RCBkZXN0MikKKyAgICB7CisgICAgICAgIG1fYXNzZW1ibGVyLnBvcCgxIDw8IGRlc3QxIHwgMSA8 PCBkZXN0Mik7CisgICAgfQorCisgICAgdm9pZCBwdXNoUGFpcihSZWdpc3RlcklEIHNyYzEsIFJl Z2lzdGVySUQgc3JjMikKKyAgICB7CisgICAgICAgIG1fYXNzZW1ibGVyLnB1c2goMSA8PCBzcmMx IHwgMSA8PCBzcmMyKTsKKyAgICB9CisKICAgICB2b2lkIG1vdmUoVHJ1c3RlZEltbTMyIGltbSwg UmVnaXN0ZXJJRCBkZXN0KQogICAgIHsKICAgICAgICAgbV9hc3NlbWJsZXIubW92ZUltbShpbW0u bV92YWx1ZSwgZGVzdCk7Cg== 222810 2014-01-31 06:12:54 -0800 2014-01-31 07:06:24 -0800 Add missing pushPair/popPair implementations in macro assembler for traditional ARM. bug-127904.patch text/plain 1574 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYzMTY3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE0LTAxLTMxICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFthcm1dIEFkZCBtaXNzaW5nIHB1c2hQYWlyL3BvcFBhaXIgaW1wbGVtZW50YXRpb25z IGluIE1hY3JvQXNzZW1ibGVyQVJNLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyNzkwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmg6CisgICAgICAg IChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNOjpwb3BQYWlyKToKKyAgICAgICAgKEpTQzo6TWFjcm9B c3NlbWJsZXJBUk06OnB1c2hQYWlyKToKKwogMjAxNC0wMS0zMCAgTWFydGluIFJvYmluc29uICA8 bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gW0NNYWtlXSBBZGQgc3VwcG9y dCBmb3IgYnVpbGRpbmcgYWdhaW5zdCBHVEsrIDIKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgJKHJldmlzaW9uIDE2MzE2 NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0u aAkod29ya2luZyBjb3B5KQpAQCAtNTE3LDYgKzUxNywxMiBAQCBwdWJsaWM6CiAgICAgICAgIG1f YXNzZW1ibGVyLnBvcChkZXN0KTsKICAgICB9CiAKKyAgICB2b2lkIHBvcFBhaXIoUmVnaXN0ZXJJ RCBkZXN0MSwgUmVnaXN0ZXJJRCBkZXN0MikKKyAgICB7CisgICAgICAgIG1fYXNzZW1ibGVyLnBv cChkZXN0MSk7CisgICAgICAgIG1fYXNzZW1ibGVyLnBvcChkZXN0Mik7CisgICAgfQorCiAgICAg dm9pZCBwdXNoKFJlZ2lzdGVySUQgc3JjKQogICAgIHsKICAgICAgICAgbV9hc3NlbWJsZXIucHVz aChzcmMpOwpAQCAtNTM0LDYgKzU0MCwxMiBAQCBwdWJsaWM6CiAgICAgICAgIHB1c2goQVJNUmVn aXN0ZXJzOjpTMCk7CiAgICAgfQogCisgICAgdm9pZCBwdXNoUGFpcihSZWdpc3RlcklEIHNyYzEs IFJlZ2lzdGVySUQgc3JjMikKKyAgICB7CisgICAgICAgIG1fYXNzZW1ibGVyLnB1c2goc3JjMik7 CisgICAgICAgIG1fYXNzZW1ibGVyLnB1c2goc3JjMSk7CisgICAgfQorCiAgICAgdm9pZCBtb3Zl KFRydXN0ZWRJbW0zMiBpbW0sIFJlZ2lzdGVySUQgZGVzdCkKICAgICB7CiAgICAgICAgIG1fYXNz ZW1ibGVyLm1vdmVJbW0oaW1tLm1fdmFsdWUsIGRlc3QpOwo=