127903 2014-01-30 03:41:54 -0800 Fix the ARM Thumb2 build after jsCStack branch merge 2014-01-31 10:55:20 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Blocker --- 108645 127763 1 ossy webkit-unassigned commit-queue fpizlo ggaren msaboff ossy rgabor oldest_to_newest 973687 0 ossy 2014-01-30 03:41:54 -0800 The merge broke the ARM Thumb2 build on Linux. Here is the error log: {standard input}: Assembler messages: {standard input}:63: Error: r13 not allowed here -- `subs sp,r7,#8' {standard input}:67: Error: r13 not allowed here -- `adds sp,r7,#40' {standard input}:153: Error: r13 not allowed here -- `adds sp,r7,#40' {standard input}:207: Error: r13 not allowed here -- `subs sp,r7,#8' {standard input}:211: Error: r13 not allowed here -- `adds sp,r7,#40' {standard input}:283: Error: r13 not allowed here -- `adds sp,r7,#40' {standard input}:357: Error: r13 not allowed here -- `subs sp,r7,r2' {standard input}:392: Error: r13 not allowed here -- `subs sp,r7,r2' {standard input}:432: Error: r13 not allowed here -- `subs sp,r7,r2' {standard input}:511: Error: r13 not allowed here -- `subs sp,r7,r2' {standard input}:591: Error: r13 not allowed here -- `subs sp,r7,r2' {standard input}:683: Error: r13 not allowed here -- `subs sp,r7,r2' {standard input}:759: Error: r13 not allowed here -- `adds sp,r7,#40' {standard input}:4774: Error: r13 not allowed here -- `subs sp,r7,r8' {standard input}:6707: Error: r13 not allowed here -- `subs sp,r7,r8' {standard input}:6726: Error: r13 not allowed here -- `adds sp,r1,#8' {standard input}:6733: Error: r13 not allowed here -- `subs sp,r7,r8' {standard input}:6799: Error: r13 not allowed here -- `subs sp,r7,r8' {standard input}:6818: Error: r13 not allowed here -- `adds sp,r1,#8' {standard input}:6825: Error: r13 not allowed here -- `subs sp,r7,r8' {standard input}:6860: Error: r13 not allowed here -- `subs sp,r1,#8' {standard input}:6867: Error: r13 not allowed here -- `adds sp,r1,#8' {standard input}:6874: Error: r13 not allowed here -- `subs sp,r7,r8' {standard input}:6898: Error: r13 not allowed here -- `adds sp,r1,#8' {standard input}:6905: Error: r13 not allowed here -- `subs sp,r7,r8' {standard input}:7144: Error: r13 not allowed here -- `subs sp,r7,r8' {standard input}:7206: Error: r13 not allowed here -- `subs sp,r7,r8' make[2]: *** [Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/llint/LowLevelInterpreter.cpp.o] Error 1 974290 1 222813 rgabor 2014-01-31 07:37:33 -0800 Created attachment 222813 proposed patch 974305 2 ggaren 2014-01-31 08:41:26 -0800 Are you sure about this? These instructions compile OK on the Apple ARM Thumb2 build. Michael, can you comment? 974341 3 msaboff 2014-01-31 10:27:59 -0800 (In reply to comment #2) > Are you sure about this? These instructions compile OK on the Apple ARM Thumb2 build. Michael, can you comment? It depends on what add or sub instruction the assembler chooses to use as to whether sp is a legal target. I'm fine with the change. 974361 4 222813 commit-queue 2014-01-31 10:55:18 -0800 Comment on attachment 222813 proposed patch Clearing flags on attachment: 222813 Committed r163179: <http://trac.webkit.org/changeset/163179> 974362 5 commit-queue 2014-01-31 10:55:20 -0800 All reviewed patches have been landed. Closing bug. 222813 2014-01-31 07:37:33 -0800 2014-01-31 10:55:17 -0800 proposed patch thumb2.patch3 text/plain 3259 rgabor ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGQ2MGUxNDMuLmQxYzIyNjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAxLTMxICBHYWJvciBSYXBjc2Fu eWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4KKworICAgICAgICBGaXggdGhlIEFSTSBUaHVtYjIgYnVp bGQgYWZ0ZXIganNDU3RhY2sgYnJhbmNoIG1lcmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc5MDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBTUCByZWdpc3RlciBjYW5ub3QgYmUgdXNlZCBhcyBhIGRl c3RpbmF0aW9uIHJlZ2lzdGVyIG9mIFNVQiBvciBBREQgb24gVGh1bWIgbW9kZS4KKworICAgICAg ICAqIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtOgorICAgICAgICAqIGxsaW50L0xvd0xl dmVsSW50ZXJwcmV0ZXIzMl82NC5hc206CisKIDIwMTQtMDEtMjkgIENzYWJhIE9zenRyb2dvbsOh YyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgRU5BQkxFKEpBVkFTQ1JJUFRf REVCVUdHRVIpIGxlZnRvdmVycwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xs aW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50 L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCmluZGV4IDE5ZTdmMzMuLjk4ZDIzYzQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20K QEAgLTMzOSw3ICszMzksMTMgQEAgbWFjcm8gY2FsbFRvSmF2YVNjcmlwdFByb2xvZ3VlKCkKIGVu ZAogCiBtYWNybyBjYWxsVG9KYXZhU2NyaXB0RXBpbG9ndWUoKQotICAgIGFkZHAgQ2FsbEZyYW1l SGVhZGVyU2xvdHMgKiA4LCBjZnIsIHNwCisgICAgaWYgQVJNdjcKKyAgICAgICAgYWRkcCBDYWxs RnJhbWVIZWFkZXJTbG90cyAqIDgsIGNmciwgdDQKKyAgICAgICAgbW92ZSB0NCwgc3AKKyAgICBl bHNlCisgICAgICAgIGFkZHAgQ2FsbEZyYW1lSGVhZGVyU2xvdHMgKiA4LCBjZnIsIHNwCisgICAg ZW5kCisKICAgICBsb2FkcCBDYWxsZXJGcmFtZVtjZnJdLCBjZnIKIAogICAgIGlmIFg4NgpAQCAt MzY4LDcgKzM3NCwxMiBAQCBtYWNybyBtb3ZlU3RhY2tQb2ludGVyRm9yQ29kZUJsb2NrKGNvZGVC bG9jaywgc2NyYXRjaCkKICAgICBsb2FkaSBDb2RlQmxvY2s6Om1fbnVtQ2FsbGVlUmVnaXN0ZXJz W2NvZGVCbG9ja10sIHNjcmF0Y2gKICAgICBsc2hpZnRwIDMsIHNjcmF0Y2gKICAgICBhZGRwIG1h eEZyYW1lRXh0ZW50Rm9yU2xvd1BhdGhDYWxsLCBzY3JhdGNoCi0gICAgc3VicCBjZnIsIHNjcmF0 Y2gsIHNwCisgICAgaWYgQVJNdjcKKyAgICAgICAgc3VicCBjZnIsIHNjcmF0Y2gsIHNjcmF0Y2gK KyAgICAgICAgbW92ZSBzY3JhdGNoLCBzcAorICAgIGVsc2UKKyAgICAgICAgc3VicCBjZnIsIHNj cmF0Y2gsIHNwCisgICAgZW5kCiBlbmQKIAogbWFjcm8gcmVzdG9yZVN0YWNrUG9pbnRlckFmdGVy Q2FsbCgpCkBAIC0zOTgsNyArNDA5LDEyIEBAIG1hY3JvIHNsb3dQYXRoRm9yQ2FsbChzbG93UGF0 aCkKICAgICAgICAgc2xvd1BhdGgsCiAgICAgICAgIG1hY3JvIChjYWxsZWUpCiAgICAgICAgICAg ICBidHB6IHQxLCAuZG9udFVwZGF0ZVNQCi0gICAgICAgICAgICBhZGRwIENhbGxlckZyYW1lQW5k UENTaXplLCB0MSwgc3AKKyAgICAgICAgICAgIGlmIEFSTXY3CisgICAgICAgICAgICAgICAgYWRk cCBDYWxsZXJGcmFtZUFuZFBDU2l6ZSwgdDEsIHQxCisgICAgICAgICAgICAgICAgbW92ZSB0MSwg c3AKKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBhZGRwIENhbGxlckZyYW1lQW5k UENTaXplLCB0MSwgc3AKKyAgICAgICAgICAgIGVuZAogICAgICAgICAuZG9udFVwZGF0ZVNQOgog ICAgICAgICAgICAgaWYgQ19MT09QCiAgICAgICAgICAgICAgICAgY2xvb3BDYWxsSlNGdW5jdGlv biBjYWxsZWUKQEAgLTk1Niw3ICs5NzIsMTIgQEAgX2xsaW50X29wX2NhbGxfdmFyYXJnczoKICAg ICAgICAgbW92ZSB0MSwgc3AKICAgICBlbHNlCiAgICAgICAgICMgVGhlIGNhbGxlZUZyYW1lIGlz IG5vdCBzdGFjayBhbGlnbmVkLCBtb3ZlIGRvd24gYnkgQ2FsbGVyRnJhbWVBbmRQQ1NpemUgdG8g YWxpZ24KLSAgICAgICAgc3VicCB0MSwgQ2FsbGVyRnJhbWVBbmRQQ1NpemUsIHNwCisgICAgICAg IGlmIEFSTXY3CisgICAgICAgICAgICBzdWJwIHQxLCBDYWxsZXJGcmFtZUFuZFBDU2l6ZSwgdDIK KyAgICAgICAgICAgIG1vdmUgdDIsIHNwCisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHN1YnAg dDEsIENhbGxlckZyYW1lQW5kUENTaXplLCBzcAorICAgICAgICBlbmQKICAgICBlbmQKICAgICBz bG93UGF0aEZvckNhbGwoX2xsaW50X3Nsb3dfcGF0aF9jYWxsX3ZhcmFyZ3MpCiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyMzJfNjQu YXNtIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82 NC5hc20KaW5kZXggYzg4ZmZjZS4uMWRkY2NkNSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KQEAgLTIzOCw3 ICsyMzgsMTIgQEAgbWFjcm8gZG9DYWxsVG9KYXZhU2NyaXB0KG1ha2VDYWxsKQogICAgICMgYmVm b3JlIHdlIHN0YXJ0IGNvcHlpbmcgdGhlIGFyZ3MgZnJvbSB0aGUgcHJvdG9DYWxsRnJhbWUgYmVs b3cuCiAgICAgYnBhZXEgdGVtcDEsIFZNOjptX2pzU3RhY2tMaW1pdFt2bV0sIC5zdGFja0hlaWdo dE9LCiAKLSAgICBzdWJwIGNmciwgOCwgc3AKKyAgICBpZiBBUk12NworICAgICAgICBzdWJwIGNm ciwgOCwgdGVtcDIKKyAgICAgICAgbW92ZSB0ZW1wMiwgc3AKKyAgICBlbHNlCisgICAgICAgIHN1 YnAgY2ZyLCA4LCBzcAorICAgIGVuZAogCiAgICAgaWYgQ19MT09QCiAgICAgICAgIG1vdmUgZW50 cnksIHRlbXAyCg==