127896 2014-01-30 00:48:15 -0800 Web Inspector: Implement open/close Console window shortcut 2014-01-30 09:50:04 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 dpino webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 973642 0 dpino 2014-01-30 00:48:15 -0800 Console toolbar button tooltip (Option + Command + C) doesn't work. How to reproduce: * Open the Web Inspector. * Press Option + Command + C. Expected result: The console window opens up (or closes if it was opened). Actual result: The console window doesn't open. The problem is that the shortcut tooltip is shown but its operation is not implemented. 973643 1 webkit-bug-importer 2014-01-30 00:48:30 -0800 <rdar://problem/15944643> 973644 2 222641 dpino 2014-01-30 00:56:06 -0800 Created attachment 222641 Patch 973734 3 222641 timothy 2014-01-30 08:18:42 -0800 Comment on attachment 222641 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222641&action=review > Source/WebInspectorUI/UserInterface/KeyboardShortcut.js:183 > + result += InspectorFrontendHost.platform() === "mac" ? "\u2325" : "\u2387"; Arn't these the same symbol? 973735 4 222641 timothy 2014-01-30 08:19:13 -0800 Comment on attachment 222641 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222641&action=review >> Source/WebInspectorUI/UserInterface/KeyboardShortcut.js:183 >> + result += InspectorFrontendHost.platform() === "mac" ? "\u2325" : "\u2387"; > > Arn't these the same symbol? I guess on Mac they might be, but not on other platforms. 973745 5 222641 dpino 2014-01-30 08:49:25 -0800 Comment on attachment 222641 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222641&action=review >>> Source/WebInspectorUI/UserInterface/KeyboardShortcut.js:183 >>> + result += InspectorFrontendHost.platform() === "mac" ? "\u2325" : "\u2387"; >> >> Arn't these the same symbol? > > I guess on Mac they might be, but not on other platforms. \u2325 is the 'Option' key symbol (http://en.wikipedia.org/wiki/Option_key) \u2387 is the 'Alternative' key symbol (http://en.wikipedia.org/wiki/Alt_key) In Mac the 'Option' key (which is also labeled as 'Alt' I think) has always the '\u2325' symbol printed on the key. In no mac keyboards, the equivalent of the 'Option' key is the 'Alt' key, and although it has no symbol printed on it I think it's better to print the correspondent Unicode symbol for the 'Alt' key. As a matter of fact, the first time I checked the shortcuts I could understand the symbols for Shift and Control, but as for the Option or Command key (Mac key) symbols I had to figure out what keys were those. 973769 6 222641 commit-queue 2014-01-30 09:50:02 -0800 Comment on attachment 222641 Patch Clearing flags on attachment: 222641 Committed r163086: <http://trac.webkit.org/changeset/163086> 973770 7 commit-queue 2014-01-30 09:50:04 -0800 All reviewed patches have been landed. Closing bug. 222641 2014-01-30 00:56:06 -0800 2014-01-30 09:50:02 -0800 Patch bug-127896-20140130095605.patch text/plain 4434 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyOTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBm M2RkOWJlNmM2NWNmZTI5YjdiOGZjNGUwMGY5YWIwMzI4ODkxYjQwLi40NjRkOTI4MDkwMjY2NDAx N2I5YWY1YzY3MjVmNDQ4MGEyZTlmYzY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNC0wMS0zMCAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEltcGxlbWVudCBvcGVuL2Nsb3NlIENvbnNv bGUgd2luZG93IHNob3J0Y3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjc4OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvS2V5Ym9hcmRTaG9ydGN1dC5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0LnByb3RvdHlwZS5nZXQgZGlzcGxheU5hbWUp OgorICAgICAgICBCdWc6IE9wdGlvbiBzeW1ib2wgc2hvdWxkIGJlIGRpc3BsYXllZCBhcyBBbHRl cm5hdGl2ZSBzeW1ib2wgKFx1MjM4NykKKyAgICAgICAgaW4gbm9uIE1hYyBwbGF0Zm9ybXMuCisg ICAgICAgICogVXNlckludGVyZmFjZS9NYWluLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLmNv bnRlbnRMb2FkZWQpOgorICAgICAgICBDcmVhdGUga2V5Ym9hcmQgc2hvcnRjdXQgZm9yIHRvZ2ds aW5nIGNvbnNvbGUgd2luZG93LgorCiAyMDE0LTAxLTI4ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRw aW5vQGlnYWxpYS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogSW4gYSBEYXRhR3JpZCwg c3RvcmUgdmFsdWUgb2YgY29sdW1uSWRlbnRpZmllciB0byBET00gbm9kZSByZXByZXNlbnRpbmcg YSBjZWxsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9L ZXlib2FyZFNob3J0Y3V0LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv S2V5Ym9hcmRTaG9ydGN1dC5qcwppbmRleCA2YTNmMjhhZWEzMTM1NGFjNmE0MTZmYWI5MGIxMTI0 OGFjYmFiZmMzLi5lZjY4YzI0ZGY3ZGE5ZTY4M2QwNjBlNmVmYjA3NzI2OGVkMzRiNjUwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9LZXlib2FyZFNob3J0 Y3V0LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0tleWJvYXJk U2hvcnRjdXQuanMKQEAgLTE4MCw3ICsxODAsNyBAQCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9y dGN1dC5wcm90b3R5cGUgPSB7CiAgICAgICAgIGlmICh0aGlzLl9tb2RpZmllcnMgJiBXZWJJbnNw ZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5Db250cm9sKQogICAgICAgICAgICAgcmVz dWx0ICs9ICJcdTIzMDMiOwogICAgICAgICBpZiAodGhpcy5fbW9kaWZpZXJzICYgV2ViSW5zcGVj dG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuT3B0aW9uKQotICAgICAgICAgICAgcmVzdWx0 ICs9ICJcdTIzMjUiOworICAgICAgICAgICAgcmVzdWx0ICs9IEluc3BlY3RvckZyb250ZW5kSG9z dC5wbGF0Zm9ybSgpID09PSAibWFjIiA/ICJcdTIzMjUiIDogIlx1MjM4NyI7CiAgICAgICAgIGlm ICh0aGlzLl9tb2RpZmllcnMgJiBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmll ci5TaGlmdCkKICAgICAgICAgICAgIHJlc3VsdCArPSAiXHUyMWU3IjsKICAgICAgICAgaWYgKHRo aXMuX21vZGlmaWVycyAmIFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNv bW1hbmQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9N YWluLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTWFpbi5qcwppbmRl eCBhNjA3N2QyNmFhZGExMGQ4OTRiNjQ3MTU1MmY1ZmEwOWFhZjNjNDMzLi4yNzllMThiYmI4YTRk MDdjMmY5OTQ0Mzg1ZjIxZjgxZjJlMmM1ZGUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9NYWluLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL01haW4uanMKQEAgLTIxOCw2ICsyMTgsOCBAQCBXZWJJbnNwZWN0b3IuY29u dGVudExvYWRlZCA9IGZ1bmN0aW9uKCkKICAgICB0aGlzLl9yZWxvYWRQYWdlS2V5Ym9hcmRTaG9y dGN1dCA9IG5ldyBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJbnNwZWN0b3IuS2V5 Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5Db21tYW5kT3JDb250cm9sLCAiUiIsIHRoaXMuX3JlbG9h ZFBhZ2UuYmluZCh0aGlzKSk7CiAgICAgdGhpcy5fcmVsb2FkUGFnZUlnbm9yaW5nQ2FjaGVLZXli b2FyZFNob3J0Y3V0ID0gbmV3IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0KFdlYkluc3Bl Y3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRPckNvbnRyb2wgfCBXZWJJbnNw ZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5TaGlmdCwgIlIiLCB0aGlzLl9yZWxvYWRQ YWdlSWdub3JpbmdDYWNoZS5iaW5kKHRoaXMpKTsKIAorICAgIHRoaXMuX2NvbnNvbGVLZXlib2Fy ZFNob3J0Y3V0ID0gbmV3IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rv ci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLk9wdGlvbiB8IFdlYkluc3BlY3Rvci5LZXlib2Fy ZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRPckNvbnRyb2wsICJDIiwgdGhpcy50b2dnbGVDb25z b2xlVmlldy5iaW5kKHRoaXMpKTsKKwogICAgIHRoaXMuX2luc3BlY3RNb2RlS2V5Ym9hcmRTaG9y dGN1dCA9IG5ldyBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJbnNwZWN0b3IuS2V5 Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5Db21tYW5kT3JDb250cm9sIHwgV2ViSW5zcGVjdG9yLktl eWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuU2hpZnQsICJDIiwgdGhpcy5fdG9nZ2xlSW5zcGVjdE1v ZGUuYmluZCh0aGlzKSk7CiAKICAgICB0aGlzLl91bmRvS2V5Ym9hcmRTaG9ydGN1dCA9IG5ldyBX ZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1 dC5Nb2RpZmllci5Db21tYW5kT3JDb250cm9sLCAiWiIsIHRoaXMuX3VuZG9LZXlib2FyZFNob3J0 Y3V0LmJpbmQodGhpcykpOwpAQCAtMjQ2LDkgKzI0OCw4IEBAIFdlYkluc3BlY3Rvci5jb250ZW50 TG9hZGVkID0gZnVuY3Rpb24oKQogICAgIHRoaXMudG9vbGJhci5hZGRUb29sYmFySXRlbSh0aGlz LmRlYnVnZ2VyU2lkZWJhclBhbmVsLnRvb2xiYXJJdGVtLCBXZWJJbnNwZWN0b3IuVG9vbGJhci5T ZWN0aW9uLkxlZnQpOwogCiAgICAgLy8gVGhlIHRvb2xiYXIgYnV0dG9uIGZvciB0aGUgY29uc29s ZS4KLSAgICBjb25zdCBjb25zb2xlS2V5Ym9hcmRTaG9ydGN1dCA9ICJcdTIzMjVcdTIzMThDIjsg Ly8gT3B0aW9uLUNvbW1hbmQtQwotICAgIHZhciB0b29sVGlwID0gV2ViSW5zcGVjdG9yLlVJU3Ry aW5nKCJTaG93IGNvbnNvbGUgKCVzKSIpLmZvcm1hdChjb25zb2xlS2V5Ym9hcmRTaG9ydGN1dCk7 Ci0gICAgdmFyIGFjdGl2YXRlZFRvb2xUaXAgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkhpZGUg Y29uc29sZSIpOworICAgIHZhciB0b29sVGlwID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJTaG93 IGNvbnNvbGUgKCVzKSIpLmZvcm1hdChXZWJJbnNwZWN0b3IuX2NvbnNvbGVLZXlib2FyZFNob3J0 Y3V0LmRpc3BsYXlOYW1lKTsKKyAgICB2YXIgYWN0aXZhdGVkVG9vbFRpcCA9IFdlYkluc3BlY3Rv ci5VSVN0cmluZygiSGlkZSBjb25zb2xlICglcykiKS5mb3JtYXQoV2ViSW5zcGVjdG9yLl9jb25z b2xlS2V5Ym9hcmRTaG9ydGN1dC5kaXNwbGF5TmFtZSk7CiAgICAgdGhpcy5fY29uc29sZVRvb2xi YXJCdXR0b24gPSBuZXcgV2ViSW5zcGVjdG9yLkFjdGl2YXRlQnV0dG9uVG9vbGJhckl0ZW0oImNv bnNvbGUiLCB0b29sVGlwLCBhY3RpdmF0ZWRUb29sVGlwLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmco IkNvbnNvbGUiKSwgIkltYWdlcy9OYXZpZ2F0aW9uSXRlbUxvZy5zdmciKTsKICAgICB0aGlzLl9j b25zb2xlVG9vbGJhckJ1dHRvbi5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5CdXR0b25O YXZpZ2F0aW9uSXRlbS5FdmVudC5DbGlja2VkLCB0aGlzLnRvZ2dsZUNvbnNvbGVWaWV3LCB0aGlz KTsKICAgICB0aGlzLnRvb2xiYXIuYWRkVG9vbGJhckl0ZW0odGhpcy5fY29uc29sZVRvb2xiYXJC dXR0b24sIFdlYkluc3BlY3Rvci5Ub29sYmFyLlNlY3Rpb24uQ2VudGVyKTsK