127879 2014-01-29 17:52:37 -0800 50% time on Dromaeo Selector * benchmark spent allocating oversized backing stores (but not in Chrome) 2014-01-29 17:57:46 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ggaren ggaren webkit-bug-importer oldest_to_newest 973551 0 ggaren 2014-01-29 17:52:37 -0800 50% time on Dromaeo Selector * benchmark spent allocating oversized backing stores (but not in Chrome) 973552 1 ggaren 2014-01-29 17:52:50 -0800 <rdar://problem/15922368> 973558 2 222615 ggaren 2014-01-29 17:56:09 -0800 Created attachment 222615 Patch 973561 3 ggaren 2014-01-29 17:57:46 -0800 Committed r163057: <http://trac.webkit.org/changeset/163057> 222615 2014-01-29 17:56:09 -0800 2014-01-29 17:56:47 -0800 Patch bug-127879-20140129175608.patch text/plain 4229 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYzMDU2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDE0LTAxLTI5ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgNTAlIHRpbWUgb24gRHJvbWFlbyBTZWxlY3RvciAqIGJlbmNobWFyayBzcGVudCBhbGxvY2F0 aW5nIG92ZXJzaXplZCBiYWNraW5nIHN0b3JlcyAoYnV0IG5vdCBpbiBDaHJvbWUpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc4NzkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMZXQncyBub3QgZHluYW1p Y2FsbHkgcmVzaXplIGFuIGFycmF5IHdob3NlIHNpemUgaXMgc3RhdGljYWxseSBrbm93biwKKyAg ICAgICAgbW1ta2F5PworCisgICAgICAgICogcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHA6Cisg ICAgICAgIChKU0M6OmFycmF5UHJvdG9GdW5jQ29uY2F0KTogVXNlIG51bGxwdHIgdG8gZGlzYW1i aWd1YXRlIHZzIHRoZSBudW1lcmljCisgICAgICAgIGFyZ3VtZW50LgorCisgICAgICAgIChKU0M6 OmFycmF5UHJvdG9GdW5jU2xpY2UpOiBUaGUgZml4LgorCisgICAgICAgIChKU0M6OmFycmF5UHJv dG9GdW5jU29ydCk6CisgICAgICAgIChKU0M6OmFycmF5UHJvdG9GdW5jU3BsaWNlKToKKyAgICAg ICAgKEpTQzo6YXJyYXlQcm90b0Z1bmNGaWx0ZXIpOgorICAgICAgICAoSlNDOjphcnJheVByb3Rv RnVuY01hcCk6IFVzZSBudWxscHRyLgorCiAyMDE0LTAxLTI5ICBKb3NlcGggUGVjb3Jhcm8gIDxw ZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUnVuIEpTQyBJbnNw ZWN0b3IgRXZlbnRMb29wIGluIGEgY3VzdG9tIHJ1biBsb29wIG1vZGUgdG8gcHJldmVudCBkZWZh dWx0IG9ic2VydmVycyBmcm9tIHJ1bm5pbmcKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0FycmF5UHJvdG90eXBlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHAJKHJldmlzaW9uIDE2MzA1NikKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNDIwLDcgKzQyMCw3IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgYXJy YXlQcm90b0YKIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgYXJyYXlQcm90b0Z1bmNDb25j YXQoRXhlY1N0YXRlKiBleGVjKQogewogICAgIEpTVmFsdWUgdGhpc1ZhbHVlID0gZXhlYy0+aG9z dFRoaXNWYWx1ZSgpLnRvVGhpcyhleGVjLCBTdHJpY3RNb2RlKTsKLSAgICBKU0FycmF5KiBhcnIg PSBjb25zdHJ1Y3RFbXB0eUFycmF5KGV4ZWMsIDApOworICAgIEpTQXJyYXkqIGFyciA9IGNvbnN0 cnVjdEVtcHR5QXJyYXkoZXhlYywgbnVsbHB0cik7CiAgICAgdW5zaWduZWQgbiA9IDA7CiAgICAg SlNWYWx1ZSBjdXJBcmcgPSB0aGlzVmFsdWUudG9PYmplY3QoZXhlYyk7CiAgICAgaWYgKGV4ZWMt PmhhZEV4Y2VwdGlvbigpKQpAQCAtNTgxLDIyICs1ODEsMjAgQEAgRW5jb2RlZEpTVmFsdWUgSlND X0hPU1RfQ0FMTCBhcnJheVByb3RvRgogICAgIGlmIChleGVjLT5oYWRFeGNlcHRpb24oKSkKICAg ICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKIAotICAgIC8vIFdl IHJldHVybiBhIG5ldyBhcnJheQotICAgIEpTQXJyYXkqIHJlc09iaiA9IGNvbnN0cnVjdEVtcHR5 QXJyYXkoZXhlYywgMCk7Ci0gICAgSlNWYWx1ZSByZXN1bHQgPSByZXNPYmo7Ci0KICAgICB1bnNp Z25lZCBiZWdpbiA9IGFyZ3VtZW50Q2xhbXBlZEluZGV4RnJvbVN0YXJ0T3JFbmQoZXhlYywgMCwg bGVuZ3RoKTsKICAgICB1bnNpZ25lZCBlbmQgPSBhcmd1bWVudENsYW1wZWRJbmRleEZyb21TdGFy dE9yRW5kKGV4ZWMsIDEsIGxlbmd0aCwgbGVuZ3RoKTsKIAorICAgIEpTQXJyYXkqIHJlc3VsdCA9 IGNvbnN0cnVjdEVtcHR5QXJyYXkoZXhlYywgbnVsbHB0ciwgZW5kIC0gYmVnaW4pOworCiAgICAg dW5zaWduZWQgbiA9IDA7CiAgICAgZm9yICh1bnNpZ25lZCBrID0gYmVnaW47IGsgPCBlbmQ7IGsr KywgbisrKSB7CiAgICAgICAgIEpTVmFsdWUgdiA9IGdldFByb3BlcnR5KGV4ZWMsIHRoaXNPYmos IGspOwogICAgICAgICBpZiAoZXhlYy0+aGFkRXhjZXB0aW9uKCkpCiAgICAgICAgICAgICByZXR1 cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzVW5kZWZpbmVkKCkpOwogICAgICAgICBpZiAodikKLSAgICAg ICAgICAgIHJlc09iai0+cHV0RGlyZWN0SW5kZXgoZXhlYywgbiwgdik7CisgICAgICAgICAgICBy ZXN1bHQtPnB1dERpcmVjdEluZGV4KGV4ZWMsIG4sIHYpOwogICAgIH0KLSAgICByZXNPYmotPnNl dExlbmd0aChleGVjLCBuKTsKKyAgICByZXN1bHQtPnNldExlbmd0aChleGVjLCBuKTsKICAgICBy ZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKHJlc3VsdCk7CiB9CiAKQEAgLTcwNCw3ICs3MDIsNyBAQCBF bmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGFycmF5UHJvdG9GCiAgICAgCiAgICAgSlNHbG9i YWxPYmplY3QqIGdsb2JhbE9iamVjdCA9IEpTR2xvYmFsT2JqZWN0OjpjcmVhdGUoCiAgICAgICAg IGV4ZWMtPnZtKCksIEpTR2xvYmFsT2JqZWN0OjpjcmVhdGVTdHJ1Y3R1cmUoZXhlYy0+dm0oKSwg anNOdWxsKCkpKTsKLSAgICBKU0FycmF5KiBmbGF0QXJyYXkgPSBjb25zdHJ1Y3RFbXB0eUFycmF5 KGdsb2JhbE9iamVjdC0+Z2xvYmFsRXhlYygpLCAwKTsKKyAgICBKU0FycmF5KiBmbGF0QXJyYXkg PSBjb25zdHJ1Y3RFbXB0eUFycmF5KGdsb2JhbE9iamVjdC0+Z2xvYmFsRXhlYygpLCBudWxscHRy KTsKICAgICBpZiAoZXhlYy0+aGFkRXhjZXB0aW9uKCkpCiAgICAgICAgIHJldHVybiBKU1ZhbHVl OjplbmNvZGUoanNVbmRlZmluZWQoKSk7CiAgICAgCkBAIC03NjcsNyArNzY1LDcgQEAgRW5jb2Rl ZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBhcnJheVByb3RvRgogICAgICAgICByZXR1cm4gSlNWYWx1 ZTo6ZW5jb2RlKGpzVW5kZWZpbmVkKCkpOwogICAgIAogICAgIGlmICghZXhlYy0+YXJndW1lbnRD b3VudCgpKQotICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGNvbnN0cnVjdEVtcHR5QXJy YXkoZXhlYywgMCkpOworICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGNvbnN0cnVjdEVt cHR5QXJyYXkoZXhlYywgbnVsbHB0cikpOwogCiAgICAgdW5zaWduZWQgYmVnaW4gPSBhcmd1bWVu dENsYW1wZWRJbmRleEZyb21TdGFydE9yRW5kKGV4ZWMsIDAsIGxlbmd0aCk7CiAKQEAgLTg1NCw3 ICs4NTIsNyBAQCBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGFycmF5UHJvdG9GCiAgICAg ICAgIHJldHVybiB0aHJvd1ZNVHlwZUVycm9yKGV4ZWMpOwogCiAgICAgSlNWYWx1ZSBhcHBseVRo aXMgPSBleGVjLT5hcmd1bWVudCgxKTsKLSAgICBKU0FycmF5KiByZXN1bHRBcnJheSA9IGNvbnN0 cnVjdEVtcHR5QXJyYXkoZXhlYywgMCk7CisgICAgSlNBcnJheSogcmVzdWx0QXJyYXkgPSBjb25z dHJ1Y3RFbXB0eUFycmF5KGV4ZWMsIG51bGxwdHIpOwogCiAgICAgdW5zaWduZWQgZmlsdGVySW5k ZXggPSAwOwogICAgIHVuc2lnbmVkIGsgPSAwOwpAQCAtOTE0LDcgKzkxMiw3IEBAIEVuY29kZWRK U1ZhbHVlIEpTQ19IT1NUX0NBTEwgYXJyYXlQcm90b0YKIAogICAgIEpTVmFsdWUgYXBwbHlUaGlz ID0gZXhlYy0+YXJndW1lbnQoMSk7CiAKLSAgICBKU0FycmF5KiByZXN1bHRBcnJheSA9IGNvbnN0 cnVjdEVtcHR5QXJyYXkoZXhlYywgMCwgbGVuZ3RoKTsKKyAgICBKU0FycmF5KiByZXN1bHRBcnJh eSA9IGNvbnN0cnVjdEVtcHR5QXJyYXkoZXhlYywgbnVsbHB0ciwgbGVuZ3RoKTsKICAgICB1bnNp Z25lZCBrID0gMDsKICAgICBpZiAoY2FsbFR5cGUgPT0gQ2FsbFR5cGVKUyAmJiBpc0pTQXJyYXko dGhpc09iaikpIHsKICAgICAgICAgSlNGdW5jdGlvbiogZiA9IGpzQ2FzdDxKU0Z1bmN0aW9uKj4o ZnVuY3Rpb24pOwo=