127875 2014-01-29 17:23:54 -0800 Add IsVisibleOrOccluded to ViewState 2014-01-29 18:05:28 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough oldest_to_newest 973537 0 barraclough 2014-01-29 17:23:54 -0800 If a plugin is occluded we should not treat it as non-visible, since it may be occluding itself with a fullscreen window! So for plugins we want to know, is the window visible OR occluded. 973540 1 222610 barraclough 2014-01-29 17:28:39 -0800 Created attachment 222610 Fix 973544 2 222610 andersca 2014-01-29 17:34:37 -0800 Comment on attachment 222610 Fix View in context: https://bugs.webkit.org/attachment.cgi?id=222610&action=review > Source/WebKit2/UIProcess/PageClient.h:108 > + // Return whether the view is visible, or occulded by another window. Occulded. 973572 3 barraclough 2014-01-29 18:05:28 -0800 Transmitting file data ......... Committed revision 163061. 222610 2014-01-29 17:28:39 -0800 2014-01-29 17:34:36 -0800 Fix 127875.1.patch text/plain 7661 barraclough SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MzA1MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAxLTI5ICBHYXZpbiBC YXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgSXNWaXNp YmxlT3JPY2NsdWRlZCB0byBWaWV3U3RhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyNzg3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGFnZS9WaWV3U3RhdGUuaDoKKyAgICAgICAgICAgIC0gYWRk ZWQgSXNWaXNpYmxlT3JPY2NsdWRlZAorCiAyMDE0LTAxLTI5ICBKZXIgTm9ibGUgIDxqZXIubm9i bGVAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgTWFjIEJ1aWxkIGZpeCBhZnRlciBy MTYzMDQ2LgpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9WaWV3U3RhdGUuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL1ZpZXdTdGF0ZS5oCShyZXZpc2lvbiAxNjMwMzIpCisr KyBTb3VyY2UvV2ViQ29yZS9wYWdlL1ZpZXdTdGF0ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMywx NCArMzMsMTUgQEAgc3RydWN0IFZpZXdTdGF0ZSB7CiAgICAgICAgIFdpbmRvd0lzQWN0aXZlID0g MSA8PCAwLAogICAgICAgICBJc0ZvY3VzZWQgPSAxIDw8IDEsCiAgICAgICAgIElzVmlzaWJsZSA9 IDEgPDwgMiwKLSAgICAgICAgSXNJbldpbmRvdyA9IDEgPDwgMywKLSAgICAgICAgSXNWaXN1YWxs eUlkbGUgPSAxIDw8IDQsCisgICAgICAgIElzVmlzaWJsZU9yT2NjbHVkZWQgPSAxIDw8IDMsCisg ICAgICAgIElzSW5XaW5kb3cgPSAxIDw8IDQsCisgICAgICAgIElzVmlzdWFsbHlJZGxlID0gMSA8 PCA1LAogICAgIH07CiAKICAgICB0eXBlZGVmIHVuc2lnbmVkIEZsYWdzOwogCiAgICAgc3RhdGlj IGNvbnN0IEZsYWdzIE5vRmxhZ3MgPSAwOwotICAgIHN0YXRpYyBjb25zdCBGbGFncyBBbGxGbGFn cyA9IFdpbmRvd0lzQWN0aXZlIHwgSXNGb2N1c2VkIHwgSXNWaXNpYmxlIHwgSXNJbldpbmRvdyB8 IElzVmlzdWFsbHlJZGxlOworICAgIHN0YXRpYyBjb25zdCBGbGFncyBBbGxGbGFncyA9IFdpbmRv d0lzQWN0aXZlIHwgSXNGb2N1c2VkIHwgSXNWaXNpYmxlIHwgSXNWaXNpYmxlT3JPY2NsdWRlZCB8 IElzSW5XaW5kb3cgfCBJc1Zpc3VhbGx5SWRsZTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNv cmUKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MzA1MykKKysrIFNvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM1IEBACisyMDE0LTAxLTI5ICBHYXZp biBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgSXNW aXNpYmxlT3JPY2NsdWRlZCB0byBWaWV3U3RhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzg3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gdGhlIFdLVmlldyBhc3NvY2lhdGVkIHdpdGggYSBw bHVnaW4gYmFjb21lcyBvY2NsdWRlZAorICAgICAgICB3ZSB0ZWxsIHRoZSBwbHVnaW4gaXQgaXMg bm8gbG9uZ2VyIHZpc2libGUuIFRoaXMgaXMgYSBwcm9ibGVtCisgICAgICAgIGlmIHRoZSBwbHVn aW4gaXMgYmVpbmcgb2NjbHVkZWQgYnkgaXRzIG93biBmdWxsc2NyZWVuIHdpbmRvdy4KKworICAg ICAgICBJbnN0ZWFkLCBjb25zaWRlciBwbHVnaW5zIHRvIGJlIHZpc2libGUgYW55IHRpbWUgdGhl eSBhcmUgaW4KKyAgICAgICAgYSB2aXNpYmxlIHdpbmRvdyDigJPCoGkuZS4gd2hlbiB0aGV5IGFy ZSB2aXNpYmxlIG9yIG9jY2x1ZGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvUGFn ZUNsaWVudEltcGwuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9QYWdlQ2xpZW50SW1w bC5tbToKKyAgICAgICAgKFdlYktpdDo6UGFnZUNsaWVudEltcGw6OmlzVmlld1Zpc2libGVPck9j Y2x1ZGVkKToKKyAgICAgICAgKiBVSVByb2Nlc3MvUGFnZUNsaWVudC5oOgorICAgICAgICAoV2Vi S2l0OjpQYWdlQ2xpZW50Ojppc1ZpZXdWaXNpYmxlT3JPY2NsdWRlZCk6CisgICAgICAgICAgICAt IGFkZGVkIGlzVmlld1Zpc2libGVPck9jY2x1ZGVkLgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OnVwZGF0ZVZpZXdT dGF0ZSk6CisgICAgICAgICAgICAtIHVwZGF0ZSBJc1Zpc2libGVPck9jY2x1ZGVkLgorICAgICAg ICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OnZpZXdTdGF0ZURpZENoYW5nZSk6CisgICAgICAgICAg ICAtIHdoZW4gdXBkYXRpbmcgSXNWaXNpYmxlIGFsc28gdXBkYXRlIElzVmlzaWJsZU9yT2NjbHVk ZWQuCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwOgorICAgICAg ICAoV2ViS2l0OjpQbHVnaW5WaWV3OjpwbGF0Zm9ybVZpZXdTdGF0ZURpZENoYW5nZSk6CisgICAg ICAgICAgICAtIHVzZSBpc1Zpc2libGVPck9jY2x1ZGVkIHRvIGRldGVybWluZSBwbHVnaW4gdmlz aWJpbGl0eS4KKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5oOgorICAgICAg ICAoV2ViS2l0OjpXZWJQYWdlOjppc1Zpc2libGVPck9jY2x1ZGVkKToKKyAgICAgICAgICAgIC0g YWNjZXNzb3IuCisKIDIwMTQtMDEtMjkgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxl LmNvbT4KIAogICAgICAgICAtW1dLV2ViVmlldyBsb2FkUmVxdWVzdDpdIHNob3VsZCByZXR1cm4g YSBXS05hdmlnYXRpb24KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QYWdlQ2xpZW50 LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BhZ2VDbGllbnQuaAko cmV2aXNpb24gMTYzMDMyKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BhZ2VDbGllbnQu aAkod29ya2luZyBjb3B5KQpAQCAtMTA1LDYgKzEwNSw5IEBAIHB1YmxpYzoKICAgICAvLyBSZXR1 cm4gd2hldGhlciB0aGUgdmlldyBpcyB2aXNpYmxlLgogICAgIHZpcnR1YWwgYm9vbCBpc1ZpZXdW aXNpYmxlKCkgPSAwOwogCisgICAgLy8gUmV0dXJuIHdoZXRoZXIgdGhlIHZpZXcgaXMgdmlzaWJs ZSwgb3Igb2NjdWxkZWQgYnkgYW5vdGhlciB3aW5kb3cuCisgICAgdmlydHVhbCBib29sIGlzVmll d1Zpc2libGVPck9jY2x1ZGVkKCkgeyByZXR1cm4gaXNWaWV3VmlzaWJsZSgpOyB9CisKICAgICAv LyBSZXR1cm4gd2hldGhlciB0aGUgdmlldyBpcyBpbiBhIHdpbmRvdy4KICAgICB2aXJ0dWFsIGJv b2wgaXNWaWV3SW5XaW5kb3coKSA9IDA7CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9XZWJQYWdlUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9XZWJQYWdlUHJveHkuY3BwCShyZXZpc2lvbiAxNjMwMzIpCisrKyBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTUwLDYgKzk1MCw4 IEBAIHZvaWQgV2ViUGFnZVByb3h5Ojp1cGRhdGVWaWV3U3RhdGUoVmlld1MKICAgICAgICAgbV92 aWV3U3RhdGUgfD0gVmlld1N0YXRlOjpXaW5kb3dJc0FjdGl2ZTsKICAgICBpZiAoZmxhZ3NUb1Vw ZGF0ZSAmIFZpZXdTdGF0ZTo6SXNWaXNpYmxlICYmIG1fcGFnZUNsaWVudC5pc1ZpZXdWaXNpYmxl KCkpCiAgICAgICAgIG1fdmlld1N0YXRlIHw9IFZpZXdTdGF0ZTo6SXNWaXNpYmxlOworICAgIGlm IChmbGFnc1RvVXBkYXRlICYgVmlld1N0YXRlOjpJc1Zpc2libGVPck9jY2x1ZGVkICYmIG1fcGFn ZUNsaWVudC5pc1ZpZXdWaXNpYmxlT3JPY2NsdWRlZCgpKQorICAgICAgICBtX3ZpZXdTdGF0ZSB8 PSBWaWV3U3RhdGU6OklzVmlzaWJsZU9yT2NjbHVkZWQ7CiAgICAgaWYgKGZsYWdzVG9VcGRhdGUg JiBWaWV3U3RhdGU6OklzSW5XaW5kb3cgJiYgbV9wYWdlQ2xpZW50LmlzVmlld0luV2luZG93KCkp CiAgICAgICAgIG1fdmlld1N0YXRlIHw9IFZpZXdTdGF0ZTo6SXNJbldpbmRvdzsKICAgICBpZiAo ZmxhZ3NUb1VwZGF0ZSAmIFZpZXdTdGF0ZTo6SXNWaXN1YWxseUlkbGUgJiYgbV9wYWdlQ2xpZW50 LmlzVmlzdWFsbHlJZGxlKCkpCkBAIC05NjEsOSArOTYzLDkgQEAgdm9pZCBXZWJQYWdlUHJveHk6 OnZpZXdTdGF0ZURpZENoYW5nZShWaQogICAgIGlmICghaXNWYWxpZCgpKQogICAgICAgICByZXR1 cm47CiAKLSAgICAvLyBJZiB0aGUgdmlzaWJpbGl0eSBzdGF0ZSBtYXkgaGF2ZSBjaGFuZ2VkLCB0 aGVuIHNvIG1heSB0aGUgdmlzdWFsbHkgaWRsZS4KKyAgICAvLyBJZiB0aGUgdmlzaWJpbGl0eSBz dGF0ZSBtYXkgaGF2ZSBjaGFuZ2VkLCB0aGVuIHNvIG1heSB0aGUgdmlzdWFsbHkgaWRsZSAmIG9j Y3VsZGVkIGFnbm9zdGljIHN0YXRlLgogICAgIGlmIChtYXlIYXZlQ2hhbmdlZCAmIFZpZXdTdGF0 ZTo6SXNWaXNpYmxlKQotICAgICAgICBtYXlIYXZlQ2hhbmdlZCB8PSBWaWV3U3RhdGU6OklzVmlz dWFsbHlJZGxlOworICAgICAgICBtYXlIYXZlQ2hhbmdlZCB8PSBWaWV3U3RhdGU6OklzVmlzaWJs ZU9yT2NjbHVkZWQgfCBWaWV3U3RhdGU6OklzVmlzdWFsbHlJZGxlOwogCiAgICAgLy8gUmVjb3Jk IHRoZSBwcmlvciB2aWV3IHN0YXRlLCB1cGRhdGUgdGhlIGZsYWdzIHRoYXQgbWF5IGhhdmUgY2hh bmdlZCwKICAgICAvLyBhbmQgY2hlY2sgd2hpY2ggZmxhZ3MgaGF2ZSBhY3R1YWxseSBjaGFuZ2Vk LgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvUGFnZUNsaWVudEltcGwu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9QYWdlQ2xp ZW50SW1wbC5oCShyZXZpc2lvbiAxNjMwMzIpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL21hYy9QYWdlQ2xpZW50SW1wbC5oCSh3b3JraW5nIGNvcHkpCkBAIC02NCw2ICs2NCw3IEBA IHByaXZhdGU6CiAgICAgdmlydHVhbCBib29sIGlzVmlld1dpbmRvd0FjdGl2ZSgpOwogICAgIHZp cnR1YWwgYm9vbCBpc1ZpZXdGb2N1c2VkKCk7CiAgICAgdmlydHVhbCBib29sIGlzVmlld1Zpc2li bGUoKTsKKyAgICB2aXJ0dWFsIGJvb2wgaXNWaWV3VmlzaWJsZU9yT2NjbHVkZWQoKTsKICAgICB2 aXJ0dWFsIGJvb2wgaXNWaWV3SW5XaW5kb3coKTsKICAgICB2aXJ0dWFsIGJvb2wgaXNWaXN1YWxs eUlkbGUoKTsKICAgICB2aXJ0dWFsIExheWVySG9zdGluZ01vZGUgdmlld0xheWVySG9zdGluZ01v ZGUoKSBvdmVycmlkZTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1Bh Z2VDbGllbnRJbXBsLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvbWFjL1BhZ2VDbGllbnRJbXBsLm1tCShyZXZpc2lvbiAxNjMwMzIpCisrKyBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9QYWdlQ2xpZW50SW1wbC5tbQkod29ya2luZyBjb3B5KQpA QCAtMjA3LDYgKzIwNywxMSBAQCBib29sIFBhZ2VDbGllbnRJbXBsOjppc1ZpZXdWaXNpYmxlKCkK ICAgICByZXR1cm4gdHJ1ZTsKIH0KIAorYm9vbCBQYWdlQ2xpZW50SW1wbDo6aXNWaWV3VmlzaWJs ZU9yT2NjbHVkZWQoKQoreworICAgIHJldHVybiBbW21fd2tWaWV3IHdpbmRvd10gaXNWaXNpYmxl XTsKK30KKwogYm9vbCBQYWdlQ2xpZW50SW1wbDo6aXNWaWV3SW5XaW5kb3coKQogewogICAgIHJl dHVybiBbbV93a1ZpZXcgd2luZG93XTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv UGx1Z2lucy9QbHVnaW5WaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHAJKHJldmlzaW9uIDE2MzAzMikKKysrIFNvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNTA5LDggKzUwOSw4IEBAIHZvaWQgUGx1Z2luVmlldzo6cGxhdGZvcm1WaWV3U3RhdGVE aWRDaGEKICAgICBpZiAoIW1fcGx1Z2luIHx8ICFtX2lzSW5pdGlhbGl6ZWQpCiAgICAgICAgIHJl dHVybjsKIAotICAgIGlmIChjaGFuZ2VkICYgVmlld1N0YXRlOjpJc1Zpc2libGUpCi0gICAgICAg IG1fcGx1Z2luLT53aW5kb3dWaXNpYmlsaXR5Q2hhbmdlZChtX3dlYlBhZ2UtPmlzVmlzaWJsZSgp KTsKKyAgICBpZiAoY2hhbmdlZCAmIFZpZXdTdGF0ZTo6SXNWaXNpYmxlT3JPY2NsdWRlZCkKKyAg ICAgICAgbV9wbHVnaW4tPndpbmRvd1Zpc2liaWxpdHlDaGFuZ2VkKG1fd2ViUGFnZS0+aXNWaXNp YmxlT3JPY2NsdWRlZCgpKTsKICAgICBpZiAoY2hhbmdlZCAmIFZpZXdTdGF0ZTo6V2luZG93SXNB Y3RpdmUpCiAgICAgICAgIG1fcGx1Z2luLT53aW5kb3dGb2N1c0NoYW5nZWQobV93ZWJQYWdlLT53 aW5kb3dJc0ZvY3VzZWQoKSk7CiB9CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9XZWJQYWdlLmgJKHJldmlzaW9uIDE2MzAzMikKKysrIFNvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgJKHdvcmtpbmcgY29weSkKQEAgLTM2MSw2ICszNjEs NyBAQCBwdWJsaWM6CiAgICAgdm9pZCByZW1vdmVQbHVnaW5WaWV3KFBsdWdpblZpZXcqKTsKIAog ICAgIGJvb2wgaXNWaXNpYmxlKCkgY29uc3QgeyByZXR1cm4gbV92aWV3U3RhdGUgJiBXZWJDb3Jl OjpWaWV3U3RhdGU6OklzVmlzaWJsZTsgfQorICAgIGJvb2wgaXNWaXNpYmxlT3JPY2NsdWRlZCgp IGNvbnN0IHsgcmV0dXJuIG1fdmlld1N0YXRlICYgV2ViQ29yZTo6Vmlld1N0YXRlOjpJc1Zpc2li bGVPck9jY2x1ZGVkOyB9CiAKICAgICBMYXllckhvc3RpbmdNb2RlIGxheWVySG9zdGluZ01vZGUo KSBjb25zdCB7IHJldHVybiBtX2xheWVySG9zdGluZ01vZGU7IH0KICAgICB2b2lkIHNldExheWVy SG9zdGluZ01vZGUodW5zaWduZWQpOwo=