127870 2014-01-29 16:30:44 -0800 IDB: Index cursor complete advance() and iterate() support 2014-02-01 11:00:28 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 124521 1 jonlee beidson alecflett commit-queue jsbell mitz sam webkit-bug-importer oldest_to_newest 973521 0 jonlee 2014-01-29 16:30:44 -0800 IDB: Index cursor iterate() support <rdar://problem/15941916> 974433 1 beidson 2014-01-31 12:50:14 -0800 Retitling to IDB: Index cursor complete advance() and iterate() support as once preliminary index cursor support is in (https://bugs.webkit.org/show_bug.cgi?id=127869), then completing both advance() and iterate at once will be easy. 974589 2 222876 beidson 2014-01-31 23:48:57 -0800 Created attachment 222876 Patch v1 974632 3 222876 commit-queue 2014-02-01 10:59:19 -0800 Comment on attachment 222876 Patch v1 Clearing flags on attachment: 222876 Committed r163245: <http://trac.webkit.org/changeset/163245> 974633 4 commit-queue 2014-02-01 10:59:21 -0800 All reviewed patches have been landed. Closing bug. 974634 5 beidson 2014-02-01 11:00:28 -0800 http://trac.webkit.org/changeset/163245 222876 2014-01-31 23:48:57 -0800 2014-02-01 10:59:19 -0800 Patch v1 patch text/plain 5200 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNTM5ZGM3Li5mZjNmODYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTQtMDEtMzEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIElEQjogSW5kZXggY3Vyc29yIGNvbXBsZXRlIGFkdmFuY2UoKSBhbmQgaXRlcmF0ZSgpIHN1 cHBvcnQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE1OTQxOTE2PiBhbmQgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzg3MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvSURCUmVxdWVz dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJSZXF1ZXN0OjpvblN1Y2Nlc3MpOiBBbHdheXMg dXNlIHRoZSB2YWx1ZSBidWZmZXIgZm9yIHRoZSBzY3JpcHQgb2JqZWN0LgorCiAyMDE0LTAxLTMx ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbGVhc2UgYnVp bGQgZml4IGFmdGVyIHIxNjMyMzQuIERvbid0IGFsd2F5cyBleHBvcnQgdGhlIHN5bWJvbCB0aGF0 IGRvZXNuJ3QgZXhpc3QgdW5kZXIgTkRFQlVHLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9pbmRleGVkZGIvSURCUmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2luZGV4ZWRkYi9JREJSZXF1ZXN0LmNwcAppbmRleCA0MWE0NGY5Li44ZGE4NGNiIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJSZXF1ZXN0LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJSZXF1ZXN0LmNwcApAQCAtMjg3 LDEyICsyODcsNyBAQCB2b2lkIElEQlJlcXVlc3Q6Om9uU3VjY2VzcyhQYXNzUmVmUHRyPElEQkN1 cnNvckJhY2tlbmQ+IHBycEJhY2tlbmQpCiAgICAgUmVmUHRyPElEQktleT4ga2V5ID0gYmFja2Vu ZC0+a2V5KCk7CiAgICAgUmVmUHRyPElEQktleT4gcHJpbWFyeUtleSA9IGJhY2tlbmQtPnByaW1h cnlLZXkoKTsKIAotICAgIERlcHJlY2F0ZWQ6OlNjcmlwdFZhbHVlIHZhbHVlOwotCi0gICAgaWYg KGJhY2tlbmQtPnZhbHVlS2V5KCkpCi0gICAgICAgIHZhbHVlID0gaWRiS2V5VG9TY3JpcHRWYWx1 ZShyZXF1ZXN0U3RhdGUoKSwgYmFja2VuZC0+dmFsdWVLZXkoKSk7Ci0gICAgZWxzZQotICAgICAg ICB2YWx1ZSA9IGRlc2VyaWFsaXplSURCVmFsdWVCdWZmZXIocmVxdWVzdFN0YXRlKCksIGJhY2tl bmQtPnZhbHVlQnVmZmVyKCkpOworICAgIERlcHJlY2F0ZWQ6OlNjcmlwdFZhbHVlIHZhbHVlID0g ZGVzZXJpYWxpemVJREJWYWx1ZUJ1ZmZlcihyZXF1ZXN0U3RhdGUoKSwgYmFja2VuZC0+dmFsdWVC dWZmZXIoKSk7CiAKICAgICBBU1NFUlQoIW1fcGVuZGluZ0N1cnNvcik7CiAgICAgUmVmUHRyPElE QkN1cnNvcj4gY3Vyc29yOwpAQCAtNDA5LDcgKzQwNCw3IEBAIHZvaWQgSURCUmVxdWVzdDo6b25T dWNjZXNzKFBhc3NSZWZQdHI8SURCS2V5PiBrZXksIFBhc3NSZWZQdHI8SURCS2V5PiBwcmltYXJ5 S2V5CiAgICAgb25TdWNjZXNzKGtleSwgcHJpbWFyeUtleSwgYnVmZmVyLCBudWxscHRyKTsKIH0K IAotdm9pZCBJREJSZXF1ZXN0OjpvblN1Y2Nlc3MoUGFzc1JlZlB0cjxJREJLZXk+IGtleSwgUGFz c1JlZlB0cjxJREJLZXk+IHByaW1hcnlLZXksIFBhc3NSZWZQdHI8U2hhcmVkQnVmZmVyPiBidWZm ZXIsIFBhc3NSZWZQdHI8SURCS2V5PiB2YWx1ZUtleSkKK3ZvaWQgSURCUmVxdWVzdDo6b25TdWNj ZXNzKFBhc3NSZWZQdHI8SURCS2V5PiBrZXksIFBhc3NSZWZQdHI8SURCS2V5PiBwcmltYXJ5S2V5 LCBQYXNzUmVmUHRyPFNoYXJlZEJ1ZmZlcj4gYnVmZmVyLCBQYXNzUmVmUHRyPElEQktleT4pCiB7 CiAgICAgTE9HKFN0b3JhZ2VBUEksICJJREJSZXF1ZXN0OjpvblN1Y2Nlc3Moa2V5LCBwcmltYXJ5 S2V5LCB2YWx1ZUJ1ZmZlciwgdmFsdWVLZXkpIik7CiAgICAgaWYgKCFzaG91bGRFbnF1ZXVlRXZl bnQoKSkKQEAgLTQxNywxMSArNDEyLDcgQEAgdm9pZCBJREJSZXF1ZXN0OjpvblN1Y2Nlc3MoUGFz c1JlZlB0cjxJREJLZXk+IGtleSwgUGFzc1JlZlB0cjxJREJLZXk+IHByaW1hcnlLZXkKIAogICAg IERPTVJlcXVlc3RTdGF0ZTo6U2NvcGUgc2NvcGUobV9yZXF1ZXN0U3RhdGUpOwogCi0gICAgRGVw cmVjYXRlZDo6U2NyaXB0VmFsdWUgdmFsdWU7Ci0gICAgaWYgKHZhbHVlS2V5KQotICAgICAgICB2 YWx1ZSA9IGlkYktleVRvU2NyaXB0VmFsdWUocmVxdWVzdFN0YXRlKCksIHZhbHVlS2V5KTsKLSAg ICBlbHNlCi0gICAgICAgIHZhbHVlID0gZGVzZXJpYWxpemVJREJWYWx1ZUJ1ZmZlcihyZXF1ZXN0 U3RhdGUoKSwgYnVmZmVyKTsKKyAgICBEZXByZWNhdGVkOjpTY3JpcHRWYWx1ZSB2YWx1ZSA9IGRl c2VyaWFsaXplSURCVmFsdWVCdWZmZXIocmVxdWVzdFN0YXRlKCksIGJ1ZmZlcik7CiAKICAgICBB U1NFUlQobV9wZW5kaW5nQ3Vyc29yKTsKICAgICBzZXRSZXN1bHRDdXJzb3IobV9wZW5kaW5nQ3Vy c29yLnJlbGVhc2UoKSwga2V5LCBwcmltYXJ5S2V5LCB2YWx1ZSk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjFj NmE1YS4uOThiZTlkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE0LTAxLTMxICBC cmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAorICAgICAgICBJREI6IEluZGV4IGN1 cnNvciBjb21wbGV0ZSBhZHZhbmNlKCkgYW5kIGl0ZXJhdGUoKSBzdXBwb3J0CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8xNTk0MTkxNj4gYW5kIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjc4NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIERhdGFiYXNlUHJvY2Vzcy9JbmRleGVkREIvc3FsaXRlL1NRTGl0ZUlEQkN1 cnNvci5jcHA6CisgICAgICAgIChXZWJLaXQ6OlNRTGl0ZUlEQkN1cnNvcjo6YWR2YW5jZU9uY2Up OiBMb29rIHVwIHRoZSBmb3VuZCByZWNvcmQgdmFsdWUgZnJvbSB0aGUKKyAgICAgICAgICBvYmpl Y3Qgc3RvcmUgcmVjb3JkcyBiYXNlZCBvbiB0aGUga2V5IHdlIGZvdW5kIGZyb20gdGhlIGluZGV4 LgorCisyMDE0LTAxLTMxICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKwogICAg ICAgICBJREI6IEhhbmRsZSAibmV4dHVuaXF1ZSIgYW5kICJwcmV2dW5pcXVlIiBjdXJzb3JzLCBh bmQgaGFuZGxlICJhZHZhbmNlKCkiIGNvcnJlY3RseQogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI4MDQwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL0RhdGFiYXNlUHJvY2Vzcy9JbmRleGVkREIvc3FsaXRlL1NRTGl0ZUlEQkN1cnNvci5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9EYXRhYmFzZVByb2Nlc3MvSW5kZXhlZERCL3NxbGl0ZS9TUUxpdGVJ REJDdXJzb3IuY3BwCmluZGV4IGExNTI1MGUuLmM2YTZjNDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL0RhdGFiYXNlUHJvY2Vzcy9JbmRleGVkREIvc3FsaXRlL1NRTGl0ZUlEQkN1cnNvci5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvRGF0YWJhc2VQcm9jZXNzL0luZGV4ZWREQi9zcWxpdGUv U1FMaXRlSURCQ3Vyc29yLmNwcApAQCAtMjgzLDEzICsyODMsMjIgQEAgYm9vbCBTUUxpdGVJREJD dXJzb3I6OmFkdmFuY2VPbmNlKCkKIAogICAgIGlmIChtX2luZGV4SUQgIT0gSURCSW5kZXhNZXRh ZGF0YTo6SW52YWxpZElkKSB7CiAgICAgICAgIGlmICghZGVzZXJpYWxpemVJREJLZXlEYXRhKHJl aW50ZXJwcmV0X2Nhc3Q8Y29uc3QgdWludDhfdCo+KGtleURhdGEuZGF0YSgpKSwga2V5RGF0YS5z aXplKCksIG1fY3VycmVudFZhbHVlS2V5KSkgewotICAgICAgICAgICAgTE9HX0VSUk9SKCJVbmFi bGUgdG8gZGVzZXJpYWxpemUgdmFsdWUgZGF0YSBmcm9tIGRhdGFiYXNlIHdoaWxlIGFkdmFuY2lu ZyBjdXJzb3IiKTsKKyAgICAgICAgICAgIExPR19FUlJPUigiVW5hYmxlIHRvIGRlc2VyaWFsaXpl IHZhbHVlIGRhdGEgZnJvbSBkYXRhYmFzZSB3aGlsZSBhZHZhbmNpbmcgaW5kZXggY3Vyc29yIik7 CiAgICAgICAgICAgICBtX2NvbXBsZXRlZCA9IHRydWU7CiAgICAgICAgICAgICByZXR1cm4gZmFs c2U7CiAgICAgICAgIH0KIAotICAgICAgICAvLyBJbmRleCBjdXJzb3JzIHNob3VsZCBvbmx5IGhh dmUgYSBtX2N1cnJlbnRWYWx1ZUtleSwgYW5kIG5vdCBtX2N1cnJlbnRWYWx1ZUJ1ZmZlcgotICAg ICAgICBtX2N1cnJlbnRWYWx1ZUJ1ZmZlci5jbGVhcigpOworICAgICAgICBTUUxpdGVTdGF0ZW1l bnQgb2JqZWN0U3RvcmVTdGF0ZW1lbnQoKm1fc3RhdGVtZW50LT5kYXRhYmFzZSgpLCAiU0VMRUNU IHZhbHVlIEZST00gUmVjb3JkcyBXSEVSRSBrZXkgPSBDQVNUKD8gQVMgVEVYVCkgYW5kIG9iamVj dFN0b3JlSUQgPSA/OyIpOworCisgICAgICAgIGlmIChvYmplY3RTdG9yZVN0YXRlbWVudC5wcmVw YXJlKCkgIT0gU1FMUmVzdWx0T2sKKyAgICAgICAgICAgIHx8IG9iamVjdFN0b3JlU3RhdGVtZW50 LmJpbmRCbG9iKDEsIG1fY3VycmVudFZhbHVlQnVmZmVyLmRhdGEoKSwgbV9jdXJyZW50VmFsdWVC dWZmZXIuc2l6ZSgpKSAhPSBTUUxSZXN1bHRPaworICAgICAgICAgICAgfHwgb2JqZWN0U3RvcmVT dGF0ZW1lbnQuYmluZEludDY0KDIsIG1fb2JqZWN0U3RvcmVJRCkgIT0gU1FMUmVzdWx0T2sKKyAg ICAgICAgICAgIHx8IG9iamVjdFN0b3JlU3RhdGVtZW50LnN0ZXAoKSAhPSBTUUxSZXN1bHRSb3cp IHsKKyAgICAgICAgICAgIExPR19FUlJPUigiQ291bGQgbm90IGNyZWF0ZSBpbmRleCBjdXJzb3Ig c3RhdGVtZW50IGludG8gb2JqZWN0IHN0b3JlIHJlY29yZHMiKTsKKyAgICAgICAgICAgIHJldHVy biBmYWxzZTsKKyAgICAgICAgfQorCisgICAgICAgIG9iamVjdFN0b3JlU3RhdGVtZW50LmdldENv bHVtbkJsb2JBc1ZlY3RvcigwLCBtX2N1cnJlbnRWYWx1ZUJ1ZmZlcik7CiAgICAgfQogCiAgICAg cmV0dXJuIHRydWU7Cg==