127865 2014-01-29 16:20:03 -0800 Web Inspector: Run JSC Inspector EventLoop in a custom run loop mode to prevent default observers from running 2014-01-29 17:28:11 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue ggaren graouts joepeck mark.lam timothy webkit-bug-importer oldest_to_newest 973510 0 joepeck 2014-01-29 16:20:03 -0800 * SUMMARY When the main thread triggers a JSC event loop, an NSTimer scheduled to fire on the main thread can still run. Bad! We want to get as close to possible to having everything paused and have the debugger control execution going forward. Having NSTimers evaluate code in the context while paused is unexpected and could be bad. * NOTES As a temporary solution spin the runloop in a custom mode that won't fire default/common observers. We need to investigate better solutions for more complete pausing of the process, as this doesn't handle apps that may already have multiple threads accessing a JSContext concurrently. 973511 1 222606 joepeck 2014-01-29 16:24:10 -0800 Created attachment 222606 [PATCH] Proposed Fix 973512 2 webkit-bug-importer 2014-01-29 16:24:34 -0800 <rdar://problem/15941995> 973526 3 222606 ggaren 2014-01-29 16:36:46 -0800 Comment on attachment 222606 [PATCH] Proposed Fix r=me 973538 4 222606 commit-queue 2014-01-29 17:28:09 -0800 Comment on attachment 222606 [PATCH] Proposed Fix Clearing flags on attachment: 222606 Committed r163054: <http://trac.webkit.org/changeset/163054> 973539 5 commit-queue 2014-01-29 17:28:11 -0800 All reviewed patches have been landed. Closing bug. 222606 2014-01-29 16:24:10 -0800 2014-01-29 17:28:09 -0800 [PATCH] Proposed Fix runloopmode.patch text/plain 2428 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGE2ZDE0ODQuLjhmY2Q2OWMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE0LTAxLTI5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUnVuIEpT QyBJbnNwZWN0b3IgRXZlbnRMb29wIGluIGEgY3VzdG9tIHJ1biBsb29wIG1vZGUgdG8gcHJldmVu dCBkZWZhdWx0IG9ic2VydmVycyBmcm9tIHJ1bm5pbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzg2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gaGl0dGluZyBhIGJyZWFrcG9pbnQgaW4gYSBK U0NvbnRleHQgSW5zcGVjdG9yIHdlIHdhbnQgdG8gZW50aXJlbHkKKyAgICAgICAgcGF1c2UgdGhl IHByb2Nlc3MgYW5kIGFsbCBhY2Nlc3MgdG8gdGhlIEpTQ29udGV4dCBhbmQgb25seSBtb3ZlIGZv cndhcmQKKyAgICAgICAgYmFzZWQgb24gZGVidWdnZXIgY29tbWFuZHMuIEhhdmluZyB0aGUgbmVz dGVkIHJ1biBsb29wIHJ1biBpbiBhIGRlZmF1bHQKKyAgICAgICAgbW9kZSBhbGxvd2VkIE5TVGlt ZXJzIHNjaGVkdWxlZCBvbiB0aGUgdGhyZWFkIHRvIHJlZ3VsYXJseSBydW4gYW5kCisgICAgICAg IGV2YWx1YXRlIGNvZGUgaW4gdGhlIEpTQ29udGV4dC4gVXNpbmcgYSBjdXN0b20gcnVuIGxvb3Ag bW9kZSBnZXRzIHVzCisgICAgICAgIGEgYml0IGNsb3NlciB0byBsb2NraW5nIGRvd24gdGhlIGNv bnRleHQuIFRoaXMgZG9lc24ndCBoYW5kbGUgc2NlbmFyaW9zCisgICAgICAgIHdoZXJlIGJhY2tn cm91bmQgdGhyZWFkcyBhbHNvIGFjY2VzcyB0aGUgSlNDb250ZXh0LCBidXQgaXQgaGFuZGxlcyB0 aGUKKyAgICAgICAgbW9zdCBjb21tb24gc2NlbmFyaW8uCisKKyAgICAgICAgKiBpbnNwZWN0b3Iv RXZlbnRMb29wLmNwcDoKKyAgICAgICAgKEluc3BlY3Rvcjo6RXZlbnRMb29wOjpjeWNsZSk6CisK KzIwMTQtMDEtMjkgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBEZWFkbG9jayBoaXR0aW5nIGJyZWFrcG9pbnQgd2hpbGUgaW5z cGVjdGluZyBKU0NvbnRleHQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyNzg2NAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5z cGVjdG9yL0V2ZW50TG9vcC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0V2 ZW50TG9vcC5jcHAKaW5kZXggOWQ3NmIxZS4uNWI0MWMyZSAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2luc3BlY3Rvci9FdmVudExvb3AuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9pbnNwZWN0b3IvRXZlbnRMb29wLmNwcApAQCAtNDksOCArNDksMTQgQEAgdm9pZCBF dmVudExvb3A6OmN5Y2xlKCkKICAgICBUcmFuc2xhdGVNZXNzYWdlKCZtc2cpOwogICAgIERpc3Bh dGNoTWVzc2FnZSgmbXNnKTsKICNlbGlmIFVTRShDRikKKyAgICAvLyBSdW4gdGhlIFJ1bkxvb3Ag aW4gYSBjdXN0b20gcnVuIGxvb3AgbW9kZSB0byBwcmV2ZW50IGRlZmF1bHQgb2JzZXJ2ZXJzCisg ICAgLy8gdG8gcnVuIGFuZCBwb3RlbnRpYWxseSBldmFsdWF0ZSBKYXZhU2NyaXB0IGluIHRoaXMg Y29udGV4dCB3aGlsZSB3ZSBhcmUKKyAgICAvLyBuZXN0ZWQuIE9ubHkgdGhlIGRlYnVnZ2VyIHNo b3VsZCBjb250cm9sIHRoaW5ncyB1bnRpbCB3ZSBjb250aW51ZS4KKyAgICAvLyBGSVhNRTogVGhp cyBpcyBub3QgYSBwZXJmZWN0IHNvbHV0aW9uLCBhcyBiYWNrZ3JvdW5kIHRocmVhZHMgYXJlIG5v dAorICAgIC8vIHBhdXNlZCBhbmQgY2FuIHN0aWxsIGFjY2VzcyBhbmQgZXZhbHV0ZSBzY3JpcHQg aW4gdGhlIEpTQ29udGV4dC4KKyAgICBzdGF0aWMgY29uc3QgQ0ZTdHJpbmdSZWYga1JXSVJ1bkxv b3BNb2RlID0gQ0ZTVFIoImNvbS5hcHBsZS5KYXZhU2NyaXB0Q29yZS5yZW1vdGUtaW5zcGVjdG9y LXJ1bmxvb3AtbW9kZSIpOwogICAgIENGVGltZUludGVydmFsIHRpbWVJbnRlcnZhbCA9IDAuMDU7 Ci0gICAgQ0ZSdW5Mb29wUnVuSW5Nb2RlKGtDRlJ1bkxvb3BEZWZhdWx0TW9kZSwgdGltZUludGVy dmFsLCB0cnVlKTsKKyAgICBDRlJ1bkxvb3BSdW5Jbk1vZGUoa1JXSVJ1bkxvb3BNb2RlLCB0aW1l SW50ZXJ2YWwsIHRydWUpOwogI2VsaWYgUExBVEZPUk0oRUZMKQogICAgIGVjb3JlX21haW5fbG9v cF9pdGVyYXRlKCk7CiAjZWxpZiBQTEFURk9STShHVEspCg==