127864 2014-01-29 16:03:09 -0800 Web Inspector: Deadlock hitting breakpoint while inspecting JSContext 2014-01-29 16:56:36 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue ggaren graouts joepeck mark.lam timothy webkit-bug-importer oldest_to_newest 973503 0 joepeck 2014-01-29 16:03:09 -0800 * SUMMARY Deadlock hitting breakpoint while inspecting a JSContext application. -> MainThread -> processing UI event (click a button) -> runs JSContext evaluateScript -> takes API lock -> hit breakpoint -> in nested run loop (idle) -> RWI Dispatch Queue -> receives incoming debugger command -> determines the global object -> APIEntry shim attempting to perform the command (locked) We never continue, because we're waiting for a debugger command, and the debugger command is stuck. The main thread needs to drop the JSLock (API lock) before running the nested event loop. 973504 1 webkit-bug-importer 2014-01-29 16:03:42 -0800 <rdar://problem/15941747> 973507 2 222604 joepeck 2014-01-29 16:09:30 -0800 Created attachment 222604 [PATCH] Proposed Fix 973513 3 222604 ggaren 2014-01-29 16:24:46 -0800 Comment on attachment 222604 [PATCH] Proposed Fix r=me 973531 4 222604 commit-queue 2014-01-29 16:56:34 -0800 Comment on attachment 222604 [PATCH] Proposed Fix Clearing flags on attachment: 222604 Committed r163051: <http://trac.webkit.org/changeset/163051> 973532 5 commit-queue 2014-01-29 16:56:36 -0800 All reviewed patches have been landed. Closing bug. 222604 2014-01-29 16:09:30 -0800 2014-01-29 16:56:34 -0800 [PATCH] Proposed Fix drop-locks.patch text/plain 1596 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGU5YzM1Y2IuLmE2ZDE0ODQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAxLTI5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRGVhZGxv Y2sgaGl0dGluZyBicmVha3BvaW50IHdoaWxlIGluc3BlY3RpbmcgSlNDb250ZXh0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc4NjQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZW1wb3JhcmlseSBkcm9w IHRoZSBsb2NrIHdoaWxlIHdlIHJ1biB0aGUgbmVzdGVkIHJ1bmxvb3AuCisKKyAgICAgICAgKiBp bnNwZWN0b3IvSlNHbG9iYWxPYmplY3RTY3JpcHREZWJ1Z1NlcnZlci5jcHA6CisgICAgICAgIChJ bnNwZWN0b3I6OkpTR2xvYmFsT2JqZWN0U2NyaXB0RGVidWdTZXJ2ZXI6OnJ1bkV2ZW50TG9vcFdo aWxlUGF1c2VkKToKKwogMjAxNC0wMS0yOSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFJlbW92ZSBFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dFUikgZ3Vh cmRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0pTR2xvYmFs T2JqZWN0U2NyaXB0RGVidWdTZXJ2ZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3Bl Y3Rvci9KU0dsb2JhbE9iamVjdFNjcmlwdERlYnVnU2VydmVyLmNwcAppbmRleCAyOWQxOTUwLi42 ZjAxNTdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0pTR2xv YmFsT2JqZWN0U2NyaXB0RGVidWdTZXJ2ZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9pbnNwZWN0b3IvSlNHbG9iYWxPYmplY3RTY3JpcHREZWJ1Z1NlcnZlci5jcHAKQEAgLTI5LDYg KzI5LDcgQEAKICNpZiBFTkFCTEUoSU5TUEVDVE9SKQogCiAjaW5jbHVkZSAiRXZlbnRMb29wLmgi CisjaW5jbHVkZSAiSlNMb2NrLmgiCiAKIHVzaW5nIG5hbWVzcGFjZSBKU0M7CiAKQEAgLTc3LDYg Kzc4LDkgQEAgdm9pZCBKU0dsb2JhbE9iamVjdFNjcmlwdERlYnVnU2VydmVyOjpyZWNvbXBpbGVB bGxKU0Z1bmN0aW9ucygpCiAKIHZvaWQgSlNHbG9iYWxPYmplY3RTY3JpcHREZWJ1Z1NlcnZlcjo6 cnVuRXZlbnRMb29wV2hpbGVQYXVzZWQoKQogeworICAgIC8vIERyb3AgYWxsIGxvY2tzIHNvIGFu b3RoZXIgdGhyZWFkIGNhbiB3b3JrIGluIHRoZSBWTSB3aGlsZSB3ZSBhcmUgbmVzdGVkLgorICAg IEpTQzo6SlNMb2NrOjpEcm9wQWxsTG9ja3MgZHJvcEFsbExvY2tzKCZtX2dsb2JhbE9iamVjdC52 bSgpKTsKKwogICAgIEV2ZW50TG9vcCBsb29wOwogICAgIHdoaWxlICghbV9kb25lUHJvY2Vzc2lu Z0RlYnVnZ2VyRXZlbnRzICYmICFsb29wLmVuZGVkKCkpCiAgICAgICAgIGxvb3AuY3ljbGUoKTsK