127855 2014-01-29 13:57:21 -0800 WebKit2 View Gestures (Swipe): Update rubberBandsAt{Left,Right} when WebKit swipe is enabled 2014-01-29 14:56:53 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified NEW InRadar P2 Normal --- 1 thorton thorton andersca sam oldest_to_newest 973467 0 thorton 2014-01-29 13:57:21 -0800 In http://trac.webkit.org/changeset/156924, the implicit updating of rubberBandsAt{Left,Right} upon navigation became restricted to only apps that don't directly link against WebKit2 (a mistake), or ones that do and link against an old version (intentional). We should bring back this behavior if WebKit2 swipe is enabled, and fix the accident where we use the old behavior for apps that don't directly link against WebKit2. <rdar://problem/15933878> 973471 1 222594 thorton 2014-01-29 14:27:39 -0800 Created attachment 222594 patch 973483 2 222594 darin 2014-01-29 14:47:37 -0800 Comment on attachment 222594 patch View in context: https://bugs.webkit.org/attachment.cgi?id=222594&action=review > Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:80 > -static bool shouldUseLegacyImplicitRubberBandControl() > +static bool expectsLegacyImplicitRubberBandControl() > { > - static bool linkedAgainstExecutableExpectingImplicitRubberBandControl = NSVersionOfLinkTimeLibrary("WebKit2") < 0x021A0200 /* 538.2.0 */; > + if (applicationIsSafari()) { > + static const int32_t firstVersionOfSafariNotExpectingImplicitRubberBandControl = 0x021A0F00; // 538.15.0 > + static bool linkedAgainstSafariExpectingImplicitRubberBandControl = NSVersionOfLinkTimeLibrary("Safari") < firstVersionOfSafariNotExpectingImplicitRubberBandControl; > + return linkedAgainstSafariExpectingImplicitRubberBandControl; > + } > + > + static const int32_t firstVersionOfWebKit2WithNoImplicitRubberBandControl = 0x021A0200; // 538.2.0 > + static bool linkedAgainstExecutableExpectingImplicitRubberBandControl = NSVersionOfLinkTimeLibrary("WebKit2") < firstVersionOfWebKit2WithNoImplicitRubberBandControl; > + static bool notDirectlyLinkedAgainstExecutable = NSVersionOfLinkTimeLibrary("WebKit2") == -1; > + > + if (notDirectlyLinkedAgainstExecutable) > + return false; > + > return linkedAgainstExecutableExpectingImplicitRubberBandControl; > } We should not store these four different global booleans. We should compute this whole thing once and then just cache that boolean result in a global. In other words, write the whole function without any “static bool” and then use static bool in an outer function that calls the inner one: static inline bool expectsLegacyImplicitRubberBandControl() { static bool cachedAnswer = computeExpectsLegacyImplicitRubberBandControl(); return cachedAnswer; } I suggest marking the function inline because it’s short and only called in one place. Another way to do it is to actually put the caching outside the function: void WebPageProxy::platformInitialize() { static bool cachedAnswer = expectsLegacyImplicitRubberBandControl(); setShouldUseImplicitRubberBandControl(cachedAnswer); } The downside of that approach is that someone might later decide to call expectsLegacyImplicitRubberBandControl elsewhere. I also think it’s confusing to have “linkedAgainstExecutableExpectingImplicitRubberBandControl” be true when we’re not directly linked against any executable at all. So I would write that differently. More like this. int32_t linkedWebKit2Version = NSVersionOfLinkTimeLibrary("WebKit2"); return linkedWebKit2Version != -1 && linkedWebKit2Version < firstVersionOfWebKit2WithNoImplicitRubberBandControl; 973484 3 thorton 2014-01-29 14:56:53 -0800 (In reply to comment #2) > (From update of attachment 222594 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=222594&action=review > All good points! > The downside of that approach is that someone might later decide to call expectsLegacyImplicitRubberBandControl elsewhere. I don't think that's going to happen, so I'll do this. 222594 2014-01-29 14:27:39 -0800 2014-01-29 14:47:37 -0800 patch swipefix.diff text/plain 8075 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiODgwNDczLi5hNjQ1NjliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzIg QEAKKzIwMTQtMDEtMjkgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgV2ViS2l0MiBWaWV3IEdlc3R1cmVzIChTd2lwZSk6IFVwZGF0ZSBydWJiZXJCYW5k c0F0e0xlZnQsUmlnaHR9IHdoZW4gV2ViS2l0IHN3aXBlIGlzIGVuYWJsZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzg1NQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMTU5MzM4Nzg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW06CisgICAgICAgICgt W1dLVmlldyBzZXRBbGxvd3NCYWNrRm9yd2FyZE5hdmlnYXRpb25HZXN0dXJlczpdKToKKyAgICAg ICAgRW5hYmxlIGltcGxpY2l0IGNvbnRyb2wgb2YgcnViYmVyYmFuZGluZyB3aGVuIHVzaW5nIFdl YktpdDIncyBzd2lwZSBpbXBsZW1lbnRhdGlvbi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OldlYlBhZ2VQcm94 eSk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6c2VuZFdoZWVsRXZlbnQpOgorICAg ICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFn ZVByb3h5OjpzZXRTaG91bGRVc2VJbXBsaWNpdFJ1YmJlckJhbmRDb250cm9sKToKKyAgICAgICAg KFdlYktpdDo6V2ViUGFnZVByb3h5OjpzaG91bGRVc2VJbXBsaWNpdFJ1YmJlckJhbmRDb250cm9s KToKKyAgICAgICAgUmVuYW1lIGF3YXkgZnJvbSAibGVnYWN5IiBuYW1lLCBzaW5jZSB3ZSdyZSB1 c2luZyBpdCBvbiBwdXJwb3NlIG5vdy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV2ViUGFn ZVByb3h5TWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpleHBlY3RzTGVnYWN5SW1wbGljaXRSdWJi ZXJCYW5kQ29udHJvbCk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6cGxhdGZvcm1J bml0aWFsaXplKToKKyAgICAgICAgU2luY2UgTlNWZXJzaW9uT2ZMaW5rVGltZUxpYnJhcnkgZG9l c24ndCB3b3JrIGZvciBhcHBsaWNhdGlvbnMgdGhhdAorICAgICAgICBkb24ndCBsaW5rIGRpcmVj dGx5IGFnYWluc3QgdGhlIGxpYnJhcnkgKGxpa2UgU2FmYXJpKSwgbGV0J3MgZXhwbGljaXRseQor ICAgICAgICBjaGVjayBpZiBTYWZhcmkgaXMgZXhwZWN0aW5nIHRoZSBsZWdhY3kgYmVoYXZpb3Is IG90aGVyd2lzZSB1c2luZworICAgICAgICB0aGUgbGlua2VkIHZlcnNpb24gb2YgV2ViS2l0Miwg YnV0IHVzaW5nIHRoZSBuZXcgYmVoYXZpb3IgaWYgd2UgY2FuJ3QKKyAgICAgICAgZGV0ZXJtaW5l IHRoZSBsaW5rZWQgdmVyc2lvbiBvZiBXZWJLaXQyIGFuZCBhcmUgbm90IFNhZmFyaS4KKwogMjAx NC0wMS0yOCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAg IEZpeCBhIHRoaW5rby4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv bWFjL1dLVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5t bQppbmRleCBhODVjNzdmLi40MmQ1OTZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9tYWMvV0tWaWV3Lm1tCkBAIC0zMjc0LDYgKzMyNzQsNyBAQCBzdGF0aWMgTlNTdHJpbmcgKnBh dGhXaXRoVW5pcXVlRmlsZW5hbWVGb3JQYXRoKE5TU3RyaW5nICpwYXRoKQogewogICAgIF9kYXRh LT5fYWxsb3dzQmFja0ZvcndhcmROYXZpZ2F0aW9uR2VzdHVyZXMgPSBhbGxvd3NCYWNrRm9yd2Fy ZE5hdmlnYXRpb25HZXN0dXJlczsKICAgICBfZGF0YS0+X3BhZ2UtPnNldFNob3VsZFJlY29yZE5h dmlnYXRpb25TbmFwc2hvdHMoYWxsb3dzQmFja0ZvcndhcmROYXZpZ2F0aW9uR2VzdHVyZXMpOwor ICAgIF9kYXRhLT5fcGFnZS0+c2V0U2hvdWxkVXNlSW1wbGljaXRSdWJiZXJCYW5kQ29udHJvbChh bGxvd3NCYWNrRm9yd2FyZE5hdmlnYXRpb25HZXN0dXJlcyk7CiB9CiAKIC0gKEJPT0wpYWxsb3dz QmFja0ZvcndhcmROYXZpZ2F0aW9uR2VzdHVyZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5jcHAKaW5kZXggMmE1M2Q3MS4uMmZjYjRiMSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTMwNyw3ICszMDcsNyBAQCBXZWJQYWdlUHJv eHk6OldlYlBhZ2VQcm94eShQYWdlQ2xpZW50JiBwYWdlQ2xpZW50LCBXZWJQcm9jZXNzUHJveHkm IHByb2Nlc3MsIFdlYgogICAgICwgbV9tYWluRnJhbWVJc1Bpbm5lZFRvUmlnaHRTaWRlKGZhbHNl KQogICAgICwgbV9tYWluRnJhbWVJc1Bpbm5lZFRvVG9wU2lkZShmYWxzZSkKICAgICAsIG1fbWFp bkZyYW1lSXNQaW5uZWRUb0JvdHRvbVNpZGUoZmFsc2UpCi0gICAgLCBtX3VzZUxlZ2FjeUltcGxp Y2l0UnViYmVyQmFuZENvbnRyb2woZmFsc2UpCisgICAgLCBtX3Nob3VsZFVzZUltcGxpY2l0UnVi YmVyQmFuZENvbnRyb2woZmFsc2UpCiAgICAgLCBtX3J1YmJlckJhbmRzQXRMZWZ0KHRydWUpCiAg ICAgLCBtX3J1YmJlckJhbmRzQXRSaWdodCh0cnVlKQogICAgICwgbV9ydWJiZXJCYW5kc0F0VG9w KHRydWUpCkBAIC0xMjk3LDggKzEyOTcsOCBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6c2VuZFdoZWVs RXZlbnQoY29uc3QgV2ViV2hlZWxFdmVudCYgZXZlbnQpCiAgICAgICAgIE1lc3NhZ2VzOjpFdmVu dERpc3BhdGNoZXI6OldoZWVsRXZlbnQoCiAgICAgICAgICAgICBtX3BhZ2VJRCwKICAgICAgICAg ICAgIGV2ZW50LAotICAgICAgICAgICAgbV91c2VMZWdhY3lJbXBsaWNpdFJ1YmJlckJhbmRDb250 cm9sID8gIW1fYmFja0ZvcndhcmRMaXN0LT5iYWNrSXRlbSgpIDogcnViYmVyQmFuZHNBdExlZnQo KSwKLSAgICAgICAgICAgIG1fdXNlTGVnYWN5SW1wbGljaXRSdWJiZXJCYW5kQ29udHJvbCA/ICFt X2JhY2tGb3J3YXJkTGlzdC0+Zm9yd2FyZEl0ZW0oKSA6IHJ1YmJlckJhbmRzQXRSaWdodCgpLAor ICAgICAgICAgICAgc2hvdWxkVXNlSW1wbGljaXRSdWJiZXJCYW5kQ29udHJvbCgpID8gIW1fYmFj a0ZvcndhcmRMaXN0LT5iYWNrSXRlbSgpIDogcnViYmVyQmFuZHNBdExlZnQoKSwKKyAgICAgICAg ICAgIHNob3VsZFVzZUltcGxpY2l0UnViYmVyQmFuZENvbnRyb2woKSA/ICFtX2JhY2tGb3J3YXJk TGlzdC0+Zm9yd2FyZEl0ZW0oKSA6IHJ1YmJlckJhbmRzQXRSaWdodCgpLAogICAgICAgICAgICAg cnViYmVyQmFuZHNBdFRvcCgpLAogICAgICAgICAgICAgcnViYmVyQmFuZHNBdEJvdHRvbSgpCiAg ICAgICAgICksIDApOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBh Z2VQcm94eS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCmluZGV4 IDM5OWVmYTIuLjA2ZmUyZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJQYWdlUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5 LmgKQEAgLTU5Nyw2ICs1OTcsOSBAQCBwdWJsaWM6CiAgICAgYm9vbCBydWJiZXJCYW5kc0F0Qm90 dG9tKCkgY29uc3Q7CiAgICAgdm9pZCBzZXRSdWJiZXJCYW5kc0F0Qm90dG9tKGJvb2wpOwogCisg ICAgdm9pZCBzZXRTaG91bGRVc2VJbXBsaWNpdFJ1YmJlckJhbmRDb250cm9sKGJvb2wgc2hvdWxk VXNlSW1wbGljaXRSdWJiZXJCYW5kQ29udHJvbCkgeyBtX3Nob3VsZFVzZUltcGxpY2l0UnViYmVy QmFuZENvbnRyb2wgPSBzaG91bGRVc2VJbXBsaWNpdFJ1YmJlckJhbmRDb250cm9sOyB9CisgICAg Ym9vbCBzaG91bGRVc2VJbXBsaWNpdFJ1YmJlckJhbmRDb250cm9sKCkgY29uc3QgeyByZXR1cm4g bV9zaG91bGRVc2VJbXBsaWNpdFJ1YmJlckJhbmRDb250cm9sOyB9CisKICAgICB2b2lkIHNldEJh Y2tncm91bmRFeHRlbmRzQmV5b25kUGFnZShib29sKTsKICAgICBib29sIGJhY2tncm91bmRFeHRl bmRzQmV5b25kUGFnZSgpIGNvbnN0OwogCkBAIC0xMzU0LDcgKzEzNTcsNyBAQCBwcml2YXRlOgog ICAgIGJvb2wgbV9tYWluRnJhbWVJc1Bpbm5lZFRvVG9wU2lkZTsKICAgICBib29sIG1fbWFpbkZy YW1lSXNQaW5uZWRUb0JvdHRvbVNpZGU7CiAKLSAgICBib29sIG1fdXNlTGVnYWN5SW1wbGljaXRS dWJiZXJCYW5kQ29udHJvbDsKKyAgICBib29sIG1fc2hvdWxkVXNlSW1wbGljaXRSdWJiZXJCYW5k Q29udHJvbDsKICAgICBib29sIG1fcnViYmVyQmFuZHNBdExlZnQ7CiAgICAgYm9vbCBtX3J1YmJl ckJhbmRzQXRSaWdodDsKICAgICBib29sIG1fcnViYmVyQmFuZHNBdFRvcDsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViUGFnZVByb3h5TWFjLm1tIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJQYWdlUHJveHlNYWMubW0KaW5kZXggM2YyZDdiNC4u ODMyODA1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJQYWdl UHJveHlNYWMubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJQYWdlUHJv eHlNYWMubW0KQEAgLTQyLDYgKzQyLDcgQEAKICNpbXBvcnQgIldlYlByb2Nlc3NQcm94eS5oIgog I2ltcG9ydCA8V2ViQ29yZS9EaWN0YXRpb25BbHRlcm5hdGl2ZS5oPgogI2ltcG9ydCA8V2ViQ29y ZS9HcmFwaGljc0xheWVyLmg+CisjaW1wb3J0IDxXZWJDb3JlL1J1bnRpbWVBcHBsaWNhdGlvbkNo ZWNrcy5oPgogI2ltcG9ydCA8V2ViQ29yZS9TaGFyZWRCdWZmZXIuaD4KICNpbXBvcnQgPFdlYkNv cmUvVGV4dEFsdGVybmF0aXZlV2l0aFJhbmdlLmg+CiAjaW1wb3J0IDxXZWJDb3JlL1VzZXJBZ2Vu dC5oPgpAQCAtNjAsMTUgKzYxLDI3IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBuYW1l c3BhY2UgV2ViS2l0IHsKIAotc3RhdGljIGJvb2wgc2hvdWxkVXNlTGVnYWN5SW1wbGljaXRSdWJi ZXJCYW5kQ29udHJvbCgpCitzdGF0aWMgYm9vbCBleHBlY3RzTGVnYWN5SW1wbGljaXRSdWJiZXJC YW5kQ29udHJvbCgpCiB7Ci0gICAgc3RhdGljIGJvb2wgbGlua2VkQWdhaW5zdEV4ZWN1dGFibGVF eHBlY3RpbmdJbXBsaWNpdFJ1YmJlckJhbmRDb250cm9sID0gTlNWZXJzaW9uT2ZMaW5rVGltZUxp YnJhcnkoIldlYktpdDIiKSA8IDB4MDIxQTAyMDAgLyogNTM4LjIuMCAqLzsKKyAgICBpZiAoYXBw bGljYXRpb25Jc1NhZmFyaSgpKSB7CisgICAgICAgIHN0YXRpYyBjb25zdCBpbnQzMl90IGZpcnN0 VmVyc2lvbk9mU2FmYXJpTm90RXhwZWN0aW5nSW1wbGljaXRSdWJiZXJCYW5kQ29udHJvbCA9IDB4 MDIxQTBGMDA7IC8vIDUzOC4xNS4wCisgICAgICAgIHN0YXRpYyBib29sIGxpbmtlZEFnYWluc3RT YWZhcmlFeHBlY3RpbmdJbXBsaWNpdFJ1YmJlckJhbmRDb250cm9sID0gTlNWZXJzaW9uT2ZMaW5r VGltZUxpYnJhcnkoIlNhZmFyaSIpIDwgZmlyc3RWZXJzaW9uT2ZTYWZhcmlOb3RFeHBlY3RpbmdJ bXBsaWNpdFJ1YmJlckJhbmRDb250cm9sOworICAgICAgICByZXR1cm4gbGlua2VkQWdhaW5zdFNh ZmFyaUV4cGVjdGluZ0ltcGxpY2l0UnViYmVyQmFuZENvbnRyb2w7CisgICAgfQorCisgICAgc3Rh dGljIGNvbnN0IGludDMyX3QgZmlyc3RWZXJzaW9uT2ZXZWJLaXQyV2l0aE5vSW1wbGljaXRSdWJi ZXJCYW5kQ29udHJvbCA9IDB4MDIxQTAyMDA7IC8vIDUzOC4yLjAKKyAgICBzdGF0aWMgYm9vbCBs aW5rZWRBZ2FpbnN0RXhlY3V0YWJsZUV4cGVjdGluZ0ltcGxpY2l0UnViYmVyQmFuZENvbnRyb2wg PSBOU1ZlcnNpb25PZkxpbmtUaW1lTGlicmFyeSgiV2ViS2l0MiIpIDwgZmlyc3RWZXJzaW9uT2ZX ZWJLaXQyV2l0aE5vSW1wbGljaXRSdWJiZXJCYW5kQ29udHJvbDsKKyAgICBzdGF0aWMgYm9vbCBu b3REaXJlY3RseUxpbmtlZEFnYWluc3RFeGVjdXRhYmxlID0gTlNWZXJzaW9uT2ZMaW5rVGltZUxp YnJhcnkoIldlYktpdDIiKSA9PSAtMTsKKworICAgIGlmIChub3REaXJlY3RseUxpbmtlZEFnYWlu c3RFeGVjdXRhYmxlKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKICAgICByZXR1cm4gbGlua2Vk QWdhaW5zdEV4ZWN1dGFibGVFeHBlY3RpbmdJbXBsaWNpdFJ1YmJlckJhbmRDb250cm9sOwogfQog CiB2b2lkIFdlYlBhZ2VQcm94eTo6cGxhdGZvcm1Jbml0aWFsaXplKCkKIHsKLSAgICBtX3VzZUxl Z2FjeUltcGxpY2l0UnViYmVyQmFuZENvbnRyb2wgPSBzaG91bGRVc2VMZWdhY3lJbXBsaWNpdFJ1 YmJlckJhbmRDb250cm9sKCk7CisgICAgc2V0U2hvdWxkVXNlSW1wbGljaXRSdWJiZXJCYW5kQ29u dHJvbChleHBlY3RzTGVnYWN5SW1wbGljaXRSdWJiZXJCYW5kQ29udHJvbCgpKTsKIH0KIAogc3Rh dGljIFN0cmluZyB1c2VyVmlzaWJsZVdlYktpdFZlcnNpb25TdHJpbmcoKQpkaWZmIC0tZ2l0IGEv VG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDkxNzllNGUuLjQ3MDg1ZWUg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNC0wMS0yOSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxl LmNvbT4KKworICAgICAgICBXZWJLaXQyIFZpZXcgR2VzdHVyZXMgKFN3aXBlKTogVXBkYXRlIHJ1 YmJlckJhbmRzQXR7TGVmdCxSaWdodH0gd2hlbiBXZWJLaXQgc3dpcGUgaXMgZW5hYmxlZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3ODU1CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8xNTkzMzg3OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIE1pbmlCcm93c2VyL21hYy9XSzJCcm93c2VyV2luZG93 Q29udHJvbGxlci5tOgorICAgICAgICAoLVtXSzJCcm93c2VyV2luZG93Q29udHJvbGxlciBhd2Fr ZUZyb21OaWJdKToKKyAgICAgICAgRW5hYmxlIHN3aXBlIGluIE1pbmlCcm93c2VyIGZvciB0ZXN0 aW5nIHB1cnBvc2VzLgorCiAyMDE0LTAxLTI3ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBh cHBsZS5jb20+CiAKICAgICAgICAgQVg6IFN1cHBvcnQgQHNjb3BlIGluIEhUTUwgdGFibGVzCmRp ZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9tYWMvV0syQnJvd3NlcldpbmRvd0NvbnRyb2xs ZXIubSBiL1Rvb2xzL01pbmlCcm93c2VyL21hYy9XSzJCcm93c2VyV2luZG93Q29udHJvbGxlci5t CmluZGV4IDViMzdiZTYuLjIxOGRlODQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL21h Yy9XSzJCcm93c2VyV2luZG93Q29udHJvbGxlci5tCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL21h Yy9XSzJCcm93c2VyV2luZG93Q29udHJvbGxlci5tCkBAIC01MTksNiArNTE5LDcgQEAgLSAodm9p ZClhd2FrZUZyb21OaWIKICAgICBfd2ViVmlldyA9IFtbV0tWaWV3IGFsbG9jXSBpbml0V2l0aEZy YW1lOltjb250YWluZXJWaWV3IGJvdW5kc10gcHJvY2Vzc0dyb3VwOl9wcm9jZXNzR3JvdXAgYnJv d3NpbmdDb250ZXh0R3JvdXA6X2Jyb3dzaW5nQ29udGV4dEdyb3VwXTsKIAogICAgIF93ZWJWaWV3 LmFsbG93c01hZ25pZmljYXRpb24gPSBZRVM7CisgICAgX3dlYlZpZXcuYWxsb3dzQmFja0Zvcndh cmROYXZpZ2F0aW9uR2VzdHVyZXMgPSBZRVM7CiAKICAgICBbX3dlYlZpZXcgc2V0QXV0b3Jlc2l6 aW5nTWFzazooTlNWaWV3V2lkdGhTaXphYmxlIHwgTlNWaWV3SGVpZ2h0U2l6YWJsZSldOwogICAg IFtjb250YWluZXJWaWV3IGFkZFN1YnZpZXc6X3dlYlZpZXddOwo=