<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>127850</bug_id>
          
          <creation_ts>2014-01-29 12:21:59 -0800</creation_ts>
          <short_desc>[MediaControls][iOS] Hook up the fullscreen button</short_desc>
          <delta_ts>2014-01-29 14:10:26 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jer Noble">jer.noble</reporter>
          <assigned_to name="Jer Noble">jer.noble</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>glenn</cc>
    
    <cc>philipj</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>973442</commentid>
    <comment_count>0</comment_count>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2014-01-29 12:21:59 -0800</bug_when>
    <thetext>[MediaControls][iOS] Hook up the fullscreen button</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>973443</commentid>
    <comment_count>1</comment_count>
      <attachid>222589</attachid>
    <who name="Jer Noble">jer.noble</who>
    <bug_when>2014-01-29 12:25:59 -0800</bug_when>
    <thetext>Created attachment 222589
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>973468</commentid>
    <comment_count>2</comment_count>
      <attachid>222589</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-01-29 14:10:19 -0800</bug_when>
    <thetext>Comment on attachment 222589
Patch

Clearing flags on attachment: 222589

Committed r163041: &lt;http://trac.webkit.org/changeset/163041&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>973469</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-01-29 14:10:26 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>222589</attachid>
            <date>2014-01-29 12:25:59 -0800</date>
            <delta_ts>2014-01-29 14:10:15 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-127850-20140129122558.patch</filename>
            <type>text/plain</type>
            <size>3564</size>
            <attacher name="Jer Noble">jer.noble</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyOTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWQzZDc0OTVhYzY4NWJl
ZjI3YmEyZjRmNzJmZGMyYTdjZWY1MWQ1YS4uNmFjN2QyM2NjYmIwNzBlNGY2NTRiNmZhYTc1YWVm
Yzg1NzFjMDQxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE0LTAxLTI5ICBKZXIg
Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIFtNZWRpYUNvbnRyb2xzXVtp
T1NdIEhvb2sgdXAgdGhlIGZ1bGxzY3JlZW4gYnV0dG9uCisgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc4NTAKKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb3IgdGhlIGZ1bGxzY3JlZW4gYnV0dG9uLCBkbyB0
aGUgc2FtZSB0aGluZyB3ZSBkbyBmb3IgdGhlIHBsYXkgYnV0dG9uOiBoYW5kbGUgdG91Y2hzdGFy
dCwKKyAgICAgICAgdG91Y2hlbmQsIGFuZCB0b3VjaGNhbmNlbCwgYW5kIHBlcmZvcm0gdGhlIGFj
dGlvbiAoaS5lLiwgJ2NsaWNrJykgb24gdG91Y2hlbmQuCisKKyAgICAgICAgKiBNb2R1bGVzL21l
ZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qczoKKyAgICAgICAgKENvbnRyb2xsZXJJT1Mu
cHJvdG90eXBlLmNyZWF0ZUNvbnRyb2xzKTogQWRkIGxpc3RlbmVycyBmb3IgdGhlIGZ1bGxzY3Jl
ZW5CdXR0b24uCisgICAgICAgIChDb250cm9sbGVySU9TLnByb3RvdHlwZS5pc0Z1bGxTY3JlZW4p
OiBPdmVycmlkZS4KKyAgICAgICAgKENvbnRyb2xsZXJJT1MucHJvdG90eXBlLmhhbmRsZUZ1bGxz
Y3JlZW5CdXR0b25DbGlja2VkKTogT3ZlcnJpZGUuCisgICAgICAgIChDb250cm9sbGVySU9TLnBy
b3RvdHlwZS5oYW5kbGVGdWxsc2NyZWVuVG91Y2hTdGFydCk6IEFkZGVkLgorICAgICAgICAoQ29u
dHJvbGxlcklPUy5wcm90b3R5cGUuaGFuZGxlRnVsbHNjcmVlblRvdWNoRW5kKTogQWRkZWQuCisg
ICAgICAgIChDb250cm9sbGVySU9TLnByb3RvdHlwZS5oYW5kbGVGdWxsc2NyZWVuVG91Y2hDYW5j
ZWwpOiBBZGRlZC4KKworMjAxNC0wMS0yOSAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNv
bT4KKwogICAgICAgICBbTVNFXVtNYWNdIEluIFNvdXJjZUJ1ZmZlclByaXZhdGVBVkZPYmpDLCBv
bmx5IGluY2x1ZGUgdGhvc2UgaGVhZGVycyBhY3R1YWxseSBuZWNlc3NhcnkgdG8gY29tcGlsZS4K
ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzg0Ngog
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFD
b250cm9sc2lPUy5qcyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRp
YUNvbnRyb2xzaU9TLmpzCmluZGV4IDIxYjI1YzdlMjgxNWUxYzIzM2YzNjg1YjYwOWVmYWQzNGI4
MzZkMzUuLjIzNmVmNTAyYWNkZmMwMGM4NDBhYTRjNWJhZTA2MWEzYTY0NjNkODggMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzaU9T
LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRy
b2xzaU9TLmpzCkBAIC0zNCw2ICszNCw5IEBAIENvbnRyb2xsZXJJT1MucHJvdG90eXBlID0gewog
ICAgICAgICB0aGlzLmxpc3RlbkZvcih0aGlzLmNvbnRyb2xzLnBsYXlCdXR0b24sICd0b3VjaHN0
YXJ0JywgdGhpcy5oYW5kbGVQbGF5QnV0dG9uVG91Y2hTdGFydCk7CiAgICAgICAgIHRoaXMubGlz
dGVuRm9yKHRoaXMuY29udHJvbHMucGxheUJ1dHRvbiwgJ3RvdWNoZW5kJywgdGhpcy5oYW5kbGVQ
bGF5QnV0dG9uVG91Y2hFbmQpOwogICAgICAgICB0aGlzLmxpc3RlbkZvcih0aGlzLmNvbnRyb2xz
LnBsYXlCdXR0b24sICd0b3VjaGNhbmNlbCcsIHRoaXMuaGFuZGxlUGxheUJ1dHRvblRvdWNoQ2Fu
Y2VsKTsKKyAgICAgICAgdGhpcy5saXN0ZW5Gb3IodGhpcy5jb250cm9scy5mdWxsc2NyZWVuQnV0
dG9uLCAndG91Y2hzdGFydCcsIHRoaXMuaGFuZGxlRnVsbHNjcmVlblRvdWNoU3RhcnQpOworICAg
ICAgICB0aGlzLmxpc3RlbkZvcih0aGlzLmNvbnRyb2xzLmZ1bGxzY3JlZW5CdXR0b24sICd0b3Vj
aGVuZCcsIHRoaXMuaGFuZGxlRnVsbHNjcmVlblRvdWNoRW5kKTsKKyAgICAgICAgdGhpcy5saXN0
ZW5Gb3IodGhpcy5jb250cm9scy5mdWxsc2NyZWVuQnV0dG9uLCAndG91Y2hjYW5jZWwnLCB0aGlz
LmhhbmRsZUZ1bGxzY3JlZW5Ub3VjaENhbmNlbCk7CiAgICAgICAgIHRoaXMuc3RvcExpc3Rlbmlu
Z0Zvcih0aGlzLmNvbnRyb2xzLnBsYXlCdXR0b24sICdjbGljaycsIHRoaXMuaGFuZGxlUGxheUJ1
dHRvbkNsaWNrZWQpOwogICAgIH0sCiAKQEAgLTk2LDYgKzk5LDM4IEBAIENvbnRyb2xsZXJJT1Mu
cHJvdG90eXBlID0gewogICAgIGhhbmRsZVBhbmVsVG91Y2hDYW5jZWw6IGZ1bmN0aW9uKGV2ZW50
KSB7CiAgICAgICAgIHRoaXMudmlkZW8uc3R5bGUucmVtb3ZlUHJvcGVydHkoJy13ZWJraXQtdXNl
ci1zZWxlY3QnKTsKICAgICB9LAorCisgICAgaXNGdWxsU2NyZWVuOiBmdW5jdGlvbigpCisgICAg
eworICAgICAgICByZXR1cm4gdGhpcy52aWRlby53ZWJraXREaXNwbGF5aW5nRnVsbHNjcmVlbjsK
KyAgICB9LAorCisgICAgaGFuZGxlRnVsbHNjcmVlbkJ1dHRvbkNsaWNrZWQ6IGZ1bmN0aW9uKGV2
ZW50KQorICAgIHsKKyAgICAgICAgY29uc29sZS50cmFjZSgpOworICAgICAgICBpZiAodGhpcy5p
c0Z1bGxTY3JlZW4oKSkKKyAgICAgICAgICAgIHRoaXMudmlkZW8ud2Via2l0RXhpdEZ1bGxzY3Jl
ZW4oKTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgdGhpcy52aWRlby53ZWJraXRFbnRlckZ1
bGxzY3JlZW4oKTsKKyAgICB9LAorCisgICAgaGFuZGxlRnVsbHNjcmVlblRvdWNoU3RhcnQ6IGZ1
bmN0aW9uKCkgeworICAgICAgICB0aGlzLmNvbnRyb2xzLmZ1bGxzY3JlZW5CdXR0b24uY2xhc3NM
aXN0LmFkZCgnYWN0aXZlJyk7CisgICAgfSwKKworICAgIGhhbmRsZUZ1bGxzY3JlZW5Ub3VjaEVu
ZDogZnVuY3Rpb24oZXZlbnQpIHsKKyAgICAgICAgdGhpcy5jb250cm9scy5mdWxsc2NyZWVuQnV0
dG9uLmNsYXNzTGlzdC5yZW1vdmUoJ2FjdGl2ZScpOworCisgICAgICAgIHRoaXMuaGFuZGxlRnVs
bHNjcmVlbkJ1dHRvbkNsaWNrZWQoKTsKKworICAgICAgICBldmVudC5zdG9wUHJvcGFnYXRpb24o
KTsKKyAgICB9LAorCisgICAgaGFuZGxlRnVsbHNjcmVlblRvdWNoQ2FuY2VsOiBmdW5jdGlvbihl
dmVudCkgeworICAgICAgICB0aGlzLmNvbnRyb2xzLmZ1bGxzY3JlZW5CdXR0b24uY2xhc3NMaXN0
LnJlbW92ZSgnYWN0aXZlJyk7CisgICAgICAgIGV2ZW50LnN0b3BQcm9wYWdhdGlvbigpOworICAg
IH0sCisKIH07CiAKIENvbnRyb2xsZXJJT1MucHJvdG90eXBlLmluaGVyaXRGcm9tKE9iamVjdC5j
cmVhdGUoQ29udHJvbGxlci5wcm90b3R5cGUpKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>