127848 2014-01-29 11:36:33 -0800 LICM should gracefully handle unprofiled code 2014-02-11 09:49:22 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 112840 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg mmirman msaboff nrotem oliver sam oldest_to_newest 973428 0 fpizlo 2014-01-29 11:36:33 -0800 Consider: loop { if (never happens) o.f++; // this thing } This thing will look like a clobber-the-world side-effect. But, it's also an exit site. I don't think that the IR makes clear that that basic block doesn't belong in the loop. We should investigate this more. 979310 1 223818 fpizlo 2014-02-10 23:45:42 -0800 Created attachment 223818 the patch 979396 2 223818 mhahnenberg 2014-02-11 07:06:33 -0800 Comment on attachment 223818 the patch r=me 979480 3 fpizlo 2014-02-11 09:49:22 -0800 Landed in http://trac.webkit.org/changeset/163879 223818 2014-02-10 23:45:42 -0800 2014-02-11 07:06:32 -0800 the patch blah.patch text/plain 4631 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYzODY3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTAyLTEwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg TElDTSBzaG91bGQgZ3JhY2VmdWxseSBoYW5kbGUgdW5wcm9maWxlZCBjb2RlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc4NDgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRmZy9ERkdMSUNNUGhhc2Uu Y3BwOgorICAgICAgICAoSlNDOjpERkc6OkxJQ01QaGFzZTo6cnVuKToKKwogMjAxNC0wMi0xMCAg TWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBSZS1lbmFibGUg QVJNIFRodW1iMiBkaXNhc3NlbWJsZXIKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHTElDTVBoYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR0xJQ01QaGFzZS5jcHAJKHJldmlzaW9uIDE2Mzg2NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHTElDTVBoYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODIsMTIgKzgyLDI4 IEBAIHB1YmxpYzoKICAgICAgICAgICAgIEJhc2ljQmxvY2sqIGJsb2NrID0gbV9ncmFwaC5ibG9j ayhibG9ja0luZGV4KTsKICAgICAgICAgICAgIGlmICghYmxvY2spCiAgICAgICAgICAgICAgICAg Y29udGludWU7CisgICAgICAgICAgICAKKyAgICAgICAgICAgIC8vIFNraXAgYmxvY2tzIHRoYXQg YXJlIHByb3ZlZCB0byBub3QgZXhlY3V0ZS4KKyAgICAgICAgICAgIC8vIEZJWE1FOiBUaGlzIHNo b3VsZG4ndCBiZSBuZWVkZWQuCisgICAgICAgICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTI4NTg0CisgICAgICAgICAgICBpZiAoIWJsb2NrLT5jZmFIYXNW aXNpdGVkKQorICAgICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAgCiAgICAgICAg ICAgICBjb25zdCBOYXR1cmFsTG9vcCogbG9vcCA9IG1fZ3JhcGgubV9uYXR1cmFsTG9vcHMuaW5u ZXJNb3N0TG9vcE9mKGJsb2NrKTsKICAgICAgICAgICAgIGlmICghbG9vcCkKICAgICAgICAgICAg ICAgICBjb250aW51ZTsKICAgICAgICAgICAgIExvb3BEYXRhJiBkYXRhID0gbV9kYXRhW2xvb3At PmluZGV4KCldOwotICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBub2RlSW5kZXggPSBibG9jay0+ c2l6ZSgpOyBub2RlSW5kZXgtLTspCi0gICAgICAgICAgICAgICAgYWRkV3JpdGVzKG1fZ3JhcGgs IGJsb2NrLT5hdChub2RlSW5kZXgpLCBkYXRhLndyaXRlcyk7CisgICAgICAgICAgICBmb3IgKHVu c2lnbmVkIG5vZGVJbmRleCA9IDA7IG5vZGVJbmRleCA8IGJsb2NrLT5zaXplKCk7ICsrbm9kZUlu ZGV4KSB7CisgICAgICAgICAgICAgICAgTm9kZSogbm9kZSA9IGJsb2NrLT5hdChub2RlSW5kZXgp OworICAgICAgICAgICAgICAgIAorICAgICAgICAgICAgICAgIC8vIERvbid0IGxvb2sgYmV5b25k IHBhcnRzIG9mIHRoZSBjb2RlIHRoYXQgZGVmaW5pdGVseSBhbHdheXMgZXhpdC4KKyAgICAgICAg ICAgICAgICAvLyBGSVhNRTogVGhpcyBzaG91bGRuJ3QgYmUgbmVlZGVkLgorICAgICAgICAgICAg ICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg1ODQKKyAg ICAgICAgICAgICAgICBpZiAobm9kZS0+b3AoKSA9PSBGb3JjZU9TUkV4aXQpCisgICAgICAgICAg ICAgICAgICAgIGJyZWFrOworCisgICAgICAgICAgICAgICAgYWRkV3JpdGVzKG1fZ3JhcGgsIG5v ZGUsIGRhdGEud3JpdGVzKTsKKyAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgICAgICAKICAg ICAgICAgLy8gRm9yIGVhY2ggbG9vcDoKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2Mzg2NykKKysrIExh eW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0 LTAyLTEwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAgTElDTSBz aG91bGQgZ3JhY2VmdWxseSBoYW5kbGUgdW5wcm9maWxlZCBjb2RlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc4NDgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGpzL3JlZ3Jlc3Mvc2NyaXB0LXRlc3Rz L3VucHJvZmlsZWQtbGljbS5qczogQWRkZWQuCisgICAgICAgIChmb28pOgorICAgICAgICAqIGpz L3JlZ3Jlc3MvdW5wcm9maWxlZC1saWNtLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog anMvcmVncmVzcy91bnByb2ZpbGVkLWxpY20uaHRtbDogQWRkZWQuCisKIDIwMTQtMDItMTAgIEJy YWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIEluZGV4ZWREQiBhc3Nl cnRpb24gYXQgSURCVHJhbnNhY3Rpb25CYWNrZW5kOjp+SURCVHJhbnNhY3Rpb25CYWNrZW5kKCkK SW5kZXg6IExheW91dFRlc3RzL2pzL3JlZ3Jlc3MvdW5wcm9maWxlZC1saWNtLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9qcy9yZWdyZXNzL3VucHJvZmlsZWQtbGljbS1l eHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9qcy9yZWdyZXNzL3VucHJv ZmlsZWQtbGljbS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxMCBAQAor SlNSZWdyZXNzL3VucHJvZmlsZWQtbGljbQorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBz ZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisK KworUEFTUyBubyBleGNlcHRpb24gdGhyb3duCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0 cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvanMvcmVncmVzcy91bnBy b2ZpbGVkLWxpY20uaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9qcy9yZWdyZXNzL3Vu cHJvZmlsZWQtbGljbS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvanMvcmVncmVz cy91bnByb2ZpbGVkLWxpY20uaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDEyIEBACis8 IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxo ZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3Jp cHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvcmVncmVzcy1wcmUu anMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9InNjcmlwdC10ZXN0cy91bnByb2ZpbGVkLWxpY20u anMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9InJlc291cmNlcy9yZWdyZXNzLXBvc3QuanMiPjwv c2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwv c2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvanMvcmVncmVzcy9z Y3JpcHQtdGVzdHMvdW5wcm9maWxlZC1saWNtLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2pzL3JlZ3Jlc3Mvc2NyaXB0LXRlc3RzL3VucHJvZmlsZWQtbGljbS5qcwkocmV2aXNpb24gMCkK KysrIExheW91dFRlc3RzL2pzL3JlZ3Jlc3Mvc2NyaXB0LXRlc3RzL3VucHJvZmlsZWQtbGljbS5q cwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDE3IEBACitmdW5jdGlvbiBmb28obykgeworICAg IHZhciByZXN1bHQgPSAwOworICAgIGZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDAwOyArK2kpIHsK KyAgICAgICAgcmVzdWx0ICs9IG8uZi5nLmguaS5qOworICAgICAgICBpZiAoby5nKQorICAgICAg ICAgICAgcmVzdWx0ICs9IG8uaDsKKyAgICB9CisgICAgcmV0dXJuIHJlc3VsdDsKK30KKworZm9y ICh2YXIgaSA9IDA7IGkgPCAxMDA7ICsraSkgeworICAgIHZhciBvID0ge2Y6e2c6e2g6e2k6e2o6 MX19fX0sIGc6ZmFsc2UsIGg6NDJ9OworICAgIHZhciByZXN1bHQgPSBmb28obyk7CisgICAgaWYg KHJlc3VsdCAhPSAxMDAwMDApCisgICAgICAgIHRocm93ICJFcnJvcjogYmFkIHJlc3VsdDogIiAr IHJlc3VsdDsKK30KKwo=