127842 2014-01-29 10:10:32 -0800 Fix wrong mix of fcntl commands and flags 2014-02-03 00:14:39 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto webkit-unassigned sergio oldest_to_newest 973397 0 berto 2014-01-29 10:10:32 -0800 Using F_SETFL to set the FD_CLOEXEC flag in the following code is wrong, the correct command here is F_SETFD. while (fcntl(fileDescriptors[i], F_SETFL, FD_CLOEXEC) == -1) { if (errno != EINTR) { ASSERT_NOT_REACHED(); break; } } 973398 1 222579 berto 2014-01-29 10:14:13 -0800 Created attachment 222579 Patch 974080 2 sergio 2014-01-30 16:17:24 -0800 Nice catch! After a quick look, SharedMemory::createHandle() [WebKit2/Platform/unix/SharedMemoryUnix.cpp] seems suspicious, as in it does fcntl(duplicatedHandle, F_SETFD, FD_CLOEXEC | accessModeFile(protection)) == -1). Seems like it should be F_SETFD for FD_CLOEXEC and F_SETFL for the access mode (O_RDONLY or O_RDWR, in this case), no? 974246 3 berto 2014-01-31 00:29:55 -0800 I think you're right, I'll update the patch. 974249 4 222804 berto 2014-01-31 00:35:33 -0800 Created attachment 222804 Patch 974414 5 222804 darin 2014-01-31 12:19:05 -0800 Comment on attachment 222804 Patch Would be much better if these had test coverage. 974948 6 berto 2014-02-03 00:14:39 -0800 Committed r163292: <http://trac.webkit.org/changeset/163292> 222579 2014-01-29 10:14:13 -0800 2014-01-31 00:35:33 -0800 Patch 127842.diff text/plain 1547 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjYTVjYmZhLi44MDFiNmJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTQtMDEtMjkgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KKworICAg ICAgICBDb25uZWN0aW9uVW5peDogdXNlIEZfU0VURkQgdG8gc2V0IHRoZSBGRF9DTE9FWEVDIGZs YWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzg0 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBG X1NFVEZEIGluc3RlYWQgb2YgRl9TRVRGTCB0byBzZXQgRkRfQ0xPRVhFQywgZWxzZSB3ZSBhcmUK KyAgICAgICAgc2V0dGluZyBhIGNvbXBsZXRlbHkgZGlmZmVyZW50IGZsYWcuCisKKyAgICAgICAg KiBQbGF0Zm9ybS9JUEMvdW5peC9Db25uZWN0aW9uVW5peC5jcHA6CisgICAgICAgIChJUEM6OnJl YWRCeXRlc0Zyb21Tb2NrZXQpOgorCiAyMDE0LTAxLTI5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAg PGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXggR1RLKyBidWls ZCBhZnRlciByMTYyOTgxLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vSVBD L3VuaXgvQ29ubmVjdGlvblVuaXguY3BwIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vSVBDL3Vu aXgvQ29ubmVjdGlvblVuaXguY3BwCmluZGV4IDcxZGI3NDQuLjU1Y2E5NGYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy91bml4L0Nvbm5lY3Rpb25Vbml4LmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvdW5peC9Db25uZWN0aW9uVW5peC5jcHAKQEAg LTMyMSw3ICszMjEsNyBAQCBzdGF0aWMgc3NpemVfdCByZWFkQnl0ZXNGcm9tU29ja2V0KGludCBz b2NrZXREZXNjcmlwdG9yLCB1aW50OF90KiBidWZmZXIsIGludCBjbwogICAgICAgICAgICAgICAg IG1lbWNweShmaWxlRGVzY3JpcHRvcnMsIENNU0dfREFUQShjb250cm9sTWVzc2FnZSksIHNpemVv ZihpbnQpICogKmZpbGVEZXNjcmlwdG9yc0NvdW50KTsKIAogICAgICAgICAgICAgICAgIGZvciAo c2l6ZV90IGkgPSAwOyBpIDwgKmZpbGVEZXNjcmlwdG9yc0NvdW50OyArK2kpIHsKLSAgICAgICAg ICAgICAgICAgICAgd2hpbGUgKGZjbnRsKGZpbGVEZXNjcmlwdG9yc1tpXSwgRl9TRVRGTCwgRkRf Q0xPRVhFQykgPT0gLTEpIHsKKyAgICAgICAgICAgICAgICAgICAgd2hpbGUgKGZjbnRsKGZpbGVE ZXNjcmlwdG9yc1tpXSwgRl9TRVRGRCwgRkRfQ0xPRVhFQykgPT0gLTEpIHsKICAgICAgICAgICAg ICAgICAgICAgICAgIGlmIChlcnJubyAhPSBFSU5UUikgewogICAgICAgICAgICAgICAgICAgICAg ICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgICAgICAgICAgICAgICAgICAgICAgICAg IGJyZWFrOwo= 222804 2014-01-31 00:35:33 -0800 2014-01-31 12:19:05 -0800 Patch 127842.diff text/plain 2554 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2ZTU1MzFjLi41YzVjZDI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTQtMDEtMzEgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KKworICAg ICAgICBGaXggd3JvbmcgbWl4IG9mIGZjbnRsIGNvbW1hbmRzIGFuZCBmbGFncworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3ODQyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgYXJlIG1peGluZyB0aGUg Y29tbWFuZHMgdG8gc2V0IGZpbGUgZGVzY3JpcHRvciBhbmQgZmlsZSBzdGF0dXMKKyAgICAgICAg ZmxhZ3MgaW4gYSBjb3VwbGUgb2YgZmNudGwoKSBjYWxscy4gRkRfQ0xPRVhFQyBtdXN0IGJlIHNl dCB1c2luZworICAgICAgICBGX1NFVEZELCBhbmQgdGhlIGFjY2VzcyBtb2RlIGZsYWdzIChPX1JE T05MWSwgT19XUk9OTFksIE9fUkRXUikKKyAgICAgICAgd2l0aCBGX1NFVEZMLgorCisgICAgICAg IFRoaXMgY29tYmluZXMgcGF0Y2hlcyBieSBHdWlsbGVtIEpvdmVyIGFuZCBTZXJnaW8gQ29ycmVp YS4KKworICAgICAgICAqIFBsYXRmb3JtL0lQQy91bml4L0Nvbm5lY3Rpb25Vbml4LmNwcDoKKyAg ICAgICAgKElQQzo6cmVhZEJ5dGVzRnJvbVNvY2tldCk6CisgICAgICAgICogUGxhdGZvcm0vdW5p eC9TaGFyZWRNZW1vcnlVbml4LmNwcDoKKyAgICAgICAgKFdlYktpdDo6U2hhcmVkTWVtb3J5Ojpj cmVhdGVIYW5kbGUpOgorCiAyMDE0LTAxLTMwICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0Bz YW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIFVucmV2aWV3ZWQgRUZMIFdlYktpdDIg YnVpbGQgZml4IGFmdGVyIHIxNjMxMTYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0 Zm9ybS9JUEMvdW5peC9Db25uZWN0aW9uVW5peC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9y bS9JUEMvdW5peC9Db25uZWN0aW9uVW5peC5jcHAKaW5kZXggNzFkYjc0NC4uNTVjYTk0ZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vSVBDL3VuaXgvQ29ubmVjdGlvblVuaXgu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy91bml4L0Nvbm5lY3Rpb25Vbml4 LmNwcApAQCAtMzIxLDcgKzMyMSw3IEBAIHN0YXRpYyBzc2l6ZV90IHJlYWRCeXRlc0Zyb21Tb2Nr ZXQoaW50IHNvY2tldERlc2NyaXB0b3IsIHVpbnQ4X3QqIGJ1ZmZlciwgaW50IGNvCiAgICAgICAg ICAgICAgICAgbWVtY3B5KGZpbGVEZXNjcmlwdG9ycywgQ01TR19EQVRBKGNvbnRyb2xNZXNzYWdl KSwgc2l6ZW9mKGludCkgKiAqZmlsZURlc2NyaXB0b3JzQ291bnQpOwogCiAgICAgICAgICAgICAg ICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCAqZmlsZURlc2NyaXB0b3JzQ291bnQ7ICsraSkgewot ICAgICAgICAgICAgICAgICAgICB3aGlsZSAoZmNudGwoZmlsZURlc2NyaXB0b3JzW2ldLCBGX1NF VEZMLCBGRF9DTE9FWEVDKSA9PSAtMSkgeworICAgICAgICAgICAgICAgICAgICB3aGlsZSAoZmNu dGwoZmlsZURlc2NyaXB0b3JzW2ldLCBGX1NFVEZELCBGRF9DTE9FWEVDKSA9PSAtMSkgewogICAg ICAgICAgICAgICAgICAgICAgICAgaWYgKGVycm5vICE9IEVJTlRSKSB7CiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgYnJlYWs7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS91bml4 L1NoYXJlZE1lbW9yeVVuaXguY3BwIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vdW5peC9TaGFy ZWRNZW1vcnlVbml4LmNwcAppbmRleCA2MzgwY2NkLi43ZDEyODA4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9QbGF0Zm9ybS91bml4L1NoYXJlZE1lbW9yeVVuaXguY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1BsYXRmb3JtL3VuaXgvU2hhcmVkTWVtb3J5VW5peC5jcHAKQEAgLTIwMCw3ICsy MDAsNyBAQCBib29sIFNoYXJlZE1lbW9yeTo6Y3JlYXRlSGFuZGxlKEhhbmRsZSYgaGFuZGxlLCBQ cm90ZWN0aW9uIHByb3RlY3Rpb24pCiAgICAgICAgIH0KICAgICB9CiAKLSAgICB3aGlsZSAoKGZj bnRsKGR1cGxpY2F0ZWRIYW5kbGUsIEZfU0VURkQsIEZEX0NMT0VYRUMgfCBhY2Nlc3NNb2RlRmls ZShwcm90ZWN0aW9uKSkgPT0gLTEpKSB7CisgICAgd2hpbGUgKGZjbnRsKGR1cGxpY2F0ZWRIYW5k bGUsIEZfU0VURkQsIEZEX0NMT0VYRUMpID09IC0xIHx8IGZjbnRsKGR1cGxpY2F0ZWRIYW5kbGUs IEZfU0VURkwsIGFjY2Vzc01vZGVGaWxlKHByb3RlY3Rpb24pKSA9PSAtMSkgewogICAgICAgICBp ZiAoZXJybm8gIT0gRUlOVFIpIHsKICAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwog ICAgICAgICAgICAgY2xvc2VXaXRoUmV0cnkoZHVwbGljYXRlZEhhbmRsZSk7Cg==