127838 2014-01-29 08:40:30 -0800 AX: Clean up AccessibilityRenderObject 2014-01-30 01:02:41 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 k.czech webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs mario samuel_white webkit-bug-importer oldest_to_newest 973377 0 k.czech 2014-01-29 08:40:30 -0800 Reducing some code by implementing ariaElementsFromAttribute. It is used as a helper for other methods. 973378 1 222575 k.czech 2014-01-29 08:51:33 -0800 Created attachment 222575 patch 973379 2 webkit-bug-importer 2014-01-29 08:51:48 -0800 <rdar://problem/15936250> 973645 3 222575 commit-queue 2014-01-30 01:02:33 -0800 Comment on attachment 222575 patch Clearing flags on attachment: 222575 Committed r163078: <http://trac.webkit.org/changeset/163078> 973646 4 commit-queue 2014-01-30 01:02:41 -0800 All reviewed patches have been landed. Closing bug. 222575 2014-01-29 08:51:33 -0800 2014-01-30 01:02:33 -0800 patch aria-elements-from-attr.patch text/plain 4734 k.czech ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4YmIyZDE1Li4wMjZmNzkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQg QEAKIDIwMTQtMDEtMjkgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CiAK KyAgICAgICAgQVg6IENsZWFuIHVwIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzgzOAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlZHVjaW5nIHNvbWUgY29k ZSBieSBpbXBsZW1lbnRpbmcgYXJpYUVsZW1lbnRzRnJvbUF0dHJpYnV0ZS4KKyAgICAgICAgSXQg aXMgdXNlZCBhcyBhIGhlbHBlciBmb3Igb3RoZXIgbWV0aG9kcy4KKworICAgICAgICBObyBuZXcg dGVzdHMuIENvdmVyZWQgYnkgZXhpc3Rpbmcgb25lcy4KKworICAgICAgICAqIGFjY2Vzc2liaWxp dHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBY2Nl c3NpYmlsaXR5UmVuZGVyT2JqZWN0OjphcmlhRWxlbWVudHNGcm9tQXR0cmlidXRlKToKKyAgICAg ICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OmFyaWFGbG93VG9FbGVtZW50 cyk6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjphcmlhRGVz Y3JpYmVkQnlFbGVtZW50cyk6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5UmVuZGVy T2JqZWN0OjphcmlhT3duc0VsZW1lbnRzKToKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vz c2liaWxpdHlSZW5kZXJPYmplY3QuaDoKKworMjAxNC0wMS0yOSAgS3J6eXN6dG9mIEN6ZWNoICA8 ay5jemVjaEBzYW1zdW5nLmNvbT4KKwogICAgICAgICBbQVRLXSBFeHBvc2UgYXJpYS1kZXNjcmli ZWRieSB3aXRoIEFUS19SRUxBVElPTl9ERVNDUklCRURfQlkKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTY4NAogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwIGIvU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcApp bmRleCA4MGU1OTQyLi5iMzdkMDI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAKQEAgLTEwMTAsNiAr MTAxMCwxNyBAQCBib29sIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OmFyaWFIYXNQb3B1cCgp IGNvbnN0CiAgICAgcmV0dXJuIGVsZW1lbnRBdHRyaWJ1dGVWYWx1ZShhcmlhX2hhc3BvcHVwQXR0 cik7CiB9CiAKK3ZvaWQgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6YXJpYUVsZW1lbnRzRnJv bUF0dHJpYnV0ZShBY2Nlc3NpYmlsaXR5Q2hpbGRyZW5WZWN0b3ImIGNoaWxkcmVuLCBjb25zdCBR dWFsaWZpZWROYW1lJiBhdHRyaWJ1dGVOYW1lKSBjb25zdAoreworICAgIFZlY3RvcjxFbGVtZW50 Kj4gZWxlbWVudHM7CisgICAgZWxlbWVudHNGcm9tQXR0cmlidXRlKGVsZW1lbnRzLCBhdHRyaWJ1 dGVOYW1lKTsKKyAgICBBWE9iamVjdENhY2hlKiBjYWNoZSA9IGF4T2JqZWN0Q2FjaGUoKTsKKyAg ICBmb3IgKGNvbnN0IGF1dG8mIGVsZW1lbnQgOiBlbGVtZW50cykgeworICAgICAgICBpZiAoQWNj ZXNzaWJpbGl0eU9iamVjdCogYXhPYmplY3QgPSBjYWNoZS0+Z2V0T3JDcmVhdGUoZWxlbWVudCkp CisgICAgICAgICAgICBjaGlsZHJlbi5hcHBlbmQoYXhPYmplY3QpOworICAgIH0KK30KKwogYm9v bCBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjpzdXBwb3J0c0FSSUFGbG93VG8oKSBjb25zdAog ewogICAgIHJldHVybiAhZ2V0QXR0cmlidXRlKGFyaWFfZmxvd3RvQXR0cikuaXNFbXB0eSgpOwpA QCAtMTAxNywxNiArMTAyOCw3IEBAIGJvb2wgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6c3Vw cG9ydHNBUklBRmxvd1RvKCkgY29uc3QKICAgICAKIHZvaWQgQWNjZXNzaWJpbGl0eVJlbmRlck9i amVjdDo6YXJpYUZsb3dUb0VsZW1lbnRzKEFjY2Vzc2liaWxpdHlDaGlsZHJlblZlY3RvciYgZmxv d1RvKSBjb25zdAogewotICAgIFZlY3RvcjxFbGVtZW50Kj4gZWxlbWVudHM7Ci0gICAgZWxlbWVu dHNGcm9tQXR0cmlidXRlKGVsZW1lbnRzLCBhcmlhX2Zsb3d0b0F0dHIpOwotICAgIAotICAgIEFY T2JqZWN0Q2FjaGUqIGNhY2hlID0gYXhPYmplY3RDYWNoZSgpOwotICAgIGZvciAoY29uc3QgYXV0 byYgZWxlbWVudCA6IGVsZW1lbnRzKSB7Ci0gICAgICAgIEFjY2Vzc2liaWxpdHlPYmplY3QqIGZs b3dUb0VsZW1lbnQgPSBjYWNoZS0+Z2V0T3JDcmVhdGUoZWxlbWVudCk7Ci0gICAgICAgIGlmIChm bG93VG9FbGVtZW50KQotICAgICAgICAgICAgZmxvd1RvLmFwcGVuZChmbG93VG9FbGVtZW50KTsK LSAgICB9Ci0gICAgICAgIAorICAgIGFyaWFFbGVtZW50c0Zyb21BdHRyaWJ1dGUoZmxvd1RvLCBh cmlhX2Zsb3d0b0F0dHIpOwogfQogCiBib29sIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnN1 cHBvcnRzQVJJQURlc2NyaWJlZEJ5KCkgY29uc3QKQEAgLTEwMzYsMTQgKzEwMzgsNyBAQCBib29s IEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnN1cHBvcnRzQVJJQURlc2NyaWJlZEJ5KCkgY29u c3QKIAogdm9pZCBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjphcmlhRGVzY3JpYmVkQnlFbGVt ZW50cyhBY2Nlc3NpYmlsaXR5Q2hpbGRyZW5WZWN0b3ImIGFyaWFEZXNjcmliZWRCeSkgY29uc3QK IHsKLSAgICBWZWN0b3I8RWxlbWVudCo+IGVsZW1lbnRzOwotICAgIGVsZW1lbnRzRnJvbUF0dHJp YnV0ZShlbGVtZW50cywgYXJpYV9kZXNjcmliZWRieUF0dHIpOwotCi0gICAgQVhPYmplY3RDYWNo ZSogY2FjaGUgPSBheE9iamVjdENhY2hlKCk7Ci0gICAgZm9yIChjb25zdCBhdXRvJiBlbGVtZW50 IDogZWxlbWVudHMpIHsKLSAgICAgICAgaWYgKEFjY2Vzc2liaWxpdHlPYmplY3QqIGRlc2NyaWJl ZEJ5RWxlbWVudCA9IGNhY2hlLT5nZXRPckNyZWF0ZShlbGVtZW50KSkKLSAgICAgICAgICAgIGFy aWFEZXNjcmliZWRCeS5hcHBlbmQoZGVzY3JpYmVkQnlFbGVtZW50KTsKLSAgICB9CisgICAgYXJp YUVsZW1lbnRzRnJvbUF0dHJpYnV0ZShhcmlhRGVzY3JpYmVkQnksIGFyaWFfZGVzY3JpYmVkYnlB dHRyKTsKIH0KIAogYm9vbCBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjpzdXBwb3J0c0FSSUFE cm9wcGluZygpIGNvbnN0IApAQCAtMTY4NywxNSArMTY4Miw3IEBAIHZvaWQgQWNjZXNzaWJpbGl0 eVJlbmRlck9iamVjdDo6c2V0VmFsdWUoY29uc3QgU3RyaW5nJiBzdHJpbmcpCiAKIHZvaWQgQWNj ZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6YXJpYU93bnNFbGVtZW50cyhBY2Nlc3NpYmlsaXR5Q2hp bGRyZW5WZWN0b3ImIGF4T2JqZWN0cykgY29uc3QKIHsKLSAgICBWZWN0b3I8RWxlbWVudCo+IGVs ZW1lbnRzOwotICAgIGVsZW1lbnRzRnJvbUF0dHJpYnV0ZShlbGVtZW50cywgYXJpYV9vd25zQXR0 cik7Ci0gICAgCi0gICAgZm9yIChjb25zdCBhdXRvJiBlbGVtZW50IDogZWxlbWVudHMpIHsKLSAg ICAgICAgUmVuZGVyT2JqZWN0KiByZW5kZXIgPSBlbGVtZW50LT5yZW5kZXJlcigpOwotICAgICAg ICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBvYmogPSBheE9iamVjdENhY2hlKCktPmdldE9yQ3JlYXRl KHJlbmRlcik7Ci0gICAgICAgIGlmIChvYmopCi0gICAgICAgICAgICBheE9iamVjdHMuYXBwZW5k KG9iaik7Ci0gICAgfQorICAgIGFyaWFFbGVtZW50c0Zyb21BdHRyaWJ1dGUoYXhPYmplY3RzLCBh cmlhX293bnNBdHRyKTsKIH0KIAogYm9vbCBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjpzdXBw b3J0c0FSSUFPd25zKCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5oIGIvU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmgKaW5kZXggMzkwMmZiOC4uMzVhZDJk MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5 UmVuZGVyT2JqZWN0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3Np YmlsaXR5UmVuZGVyT2JqZWN0LmgKQEAgLTIyNSw2ICsyMjUsNyBAQCBwcm90ZWN0ZWQ6CiAgICAg dmlydHVhbCBib29sIGNvbXB1dGVBY2Nlc3NpYmlsaXR5SXNJZ25vcmVkKCkgY29uc3Qgb3ZlcnJp ZGU7CiAKIHByaXZhdGU6CisgICAgdm9pZCBhcmlhRWxlbWVudHNGcm9tQXR0cmlidXRlKEFjY2Vz c2liaWxpdHlDaGlsZHJlblZlY3RvciYsIGNvbnN0IFF1YWxpZmllZE5hbWUmKSBjb25zdDsKICAg ICB2b2lkIGFyaWFMaXN0Ym94U2VsZWN0ZWRDaGlsZHJlbihBY2Nlc3NpYmlsaXR5Q2hpbGRyZW5W ZWN0b3ImKTsKICAgICB2b2lkIGFyaWFMaXN0Ym94VmlzaWJsZUNoaWxkcmVuKEFjY2Vzc2liaWxp dHlDaGlsZHJlblZlY3RvciYpOwogICAgIGJvb2wgaXNBbGxvd2VkQ2hpbGRPZlRyZWUoKSBjb25z dDsK