127836 2014-01-29 01:22:19 -0800 REGRESSION(r162922): [SOUP] Several tests are failing in EFL and GTK+ after r162922 2014-01-29 06:47:53 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Regression, Soup P2 Normal --- 1 cgarcia webkit-unassigned cdumez commit-queue danw gustavo mrobinson oldest_to_newest 973321 0 cgarcia 2014-01-29 01:22:19 -0800 I think the problem is that I assumed that several things done in ResourceRequest::soupURI() were always desired, so moved them to URL. I'm going to restore the previous behaviour, so that those tings are only done right before making a request. 973326 1 222560 cgarcia 2014-01-29 02:03:47 -0800 Created attachment 222560 Patch 973360 2 cgarcia 2014-01-29 06:47:53 -0800 Committed r163017: <http://trac.webkit.org/changeset/163017> 222560 2014-01-29 02:03:47 -0800 2014-01-29 06:44:29 -0800 Patch wk-soup-uri-regressions.diff text/plain 4688 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlOTM2N2I5Li4yY2RhNDg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTQtMDEtMjkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjE2MjkyMik6IFtTT1VQXSBTZXZlcmFsIHRlc3RzIGFy ZSBmYWlsaW5nIGluIEVGTCBhbmQgR1RLKyBhZnRlciByMTYyOTIyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjc4MzYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgcHJvYmxlbSBpcyB0aGF0IEkgYXNz dW1lZCB0aGF0IHNldmVyYWwgdGhpbmdzIGRvbmUgaW4KKyAgICAgICAgUmVzb3VyY2VSZXF1ZXN0 Ojpzb3VwVVJJKCkgd2VyZSBhbHdheXMgZGVzaXJlZCwgc28gSSBtb3ZlZCB0aGVtIHRvCisgICAg ICAgIFVSTC4gVGhpcyBwYXRjaCByZXN0b3JlcyB0aGUgcHJldmlvdXMgYmVoYXZpb3VyLCBzbyB0 aGF0IHRob3NlCisgICAgICAgIHRpbmdzIGFyZSBvbmx5IGRvbmUgcmlnaHQgYmVmb3JlIG1ha2lu ZyBhIHJlcXVlc3QuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VS ZXF1ZXN0U291cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3Q6OmNyZWF0 ZVNvdXBVUkkpOgorICAgICAgICAqIHBsYXRmb3JtL3NvdXAvVVJMU291cC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpVUkw6OmNyZWF0ZVNvdXBVUkkpOgorCiAyMDE0LTAxLTI4ICBKZXIgTm9ibGUg IDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIEhhbmRsZSBOU1VSTEF1dGhl bnRpY2F0aW9uTWV0aG9kU2VydmVyVHJ1c3QgY2hhbGxlbmdlcyBmcm9tIC1yZXNvdXJjZUxvYWRl cjpzaG91bGRXYWl0Rm9yUmVzcG9uc2VUb0F1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlOgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVxdWVz dFNvdXAuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNl UmVxdWVzdFNvdXAuY3BwCmluZGV4IDQ0ZDEzOTIuLjU2Njk3NTQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlcXVlc3RTb3VwLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VSZXF1ZXN0 U291cC5jcHAKQEAgLTE0MSw5ICsxNDEsMzYgQEAgdW5zaWduZWQgaW5pdGlhbGl6ZU1heGltdW1I VFRQQ29ubmVjdGlvbkNvdW50UGVySG9zdCgpCiAKIEdVbmlxdWVQdHI8U291cFVSST4gUmVzb3Vy Y2VSZXF1ZXN0OjpjcmVhdGVTb3VwVVJJKCkgY29uc3QKIHsKLSAgICBVUkwgdXJsID0gbV91cmw7 Ci0gICAgdXJsLnJlbW92ZUZyYWdtZW50SWRlbnRpZmllcigpOwotICAgIHJldHVybiB1cmwuY3Jl YXRlU291cFVSSSgpOworICAgIC8vIFdlYktpdCBkb2VzIG5vdCBzdXBwb3J0IGZyYWdtZW50IGlk ZW50aWZpZXJzIGluIGRhdGEgVVJMcywgYnV0IHNvdXAgZG9lcy4KKyAgICAvLyBCZWZvcmUgcGFz c2luZyB0aGUgVVJMIHRvIHNvdXAsIHdlIHNob3VsZCBtYWtlIHN1cmUgdG8gdXJsZW5jb2RlIGFu eSAnIycKKyAgICAvLyBjaGFyYWN0ZXJzLCBzbyB0aGF0IHNvdXAgZG9lcyBub3QgaW50ZXJwcmV0 IHRoZW0gYXMgZnJhZ21lbnQgaWRlbnRpZmllcnMuCisgICAgLy8gU2VlIGh0dHA6Ly93a2J1Zy5j b20vNjgwODkKKyAgICBpZiAobV91cmwucHJvdG9jb2xJc0RhdGEoKSkgeworICAgICAgICBTdHJp bmcgdXJsU3RyaW5nID0gbV91cmwuc3RyaW5nKCk7CisgICAgICAgIHVybFN0cmluZy5yZXBsYWNl KCIjIiwgIiUyMyIpOworICAgICAgICByZXR1cm4gR1VuaXF1ZVB0cjxTb3VwVVJJPihzb3VwX3Vy aV9uZXcodXJsU3RyaW5nLnV0ZjgoKS5kYXRhKCkpKTsKKyAgICB9CisKKyAgICBHVW5pcXVlUHRy PFNvdXBVUkk+IHNvdXBVUkk7CisgICAgaWYgKG1fdXJsLmhhc0ZyYWdtZW50SWRlbnRpZmllcigp KSB7CisgICAgICAgIFVSTCB1cmwgPSBtX3VybDsKKyAgICAgICAgdXJsLnJlbW92ZUZyYWdtZW50 SWRlbnRpZmllcigpOworICAgICAgICBzb3VwVVJJLnJlc2V0KHNvdXBfdXJpX25ldyh1cmwuc3Ry aW5nKCkudXRmOCgpLmRhdGEoKSkpOworICAgIH0gZWxzZQorICAgICAgICBzb3VwVVJJID0gbV91 cmwuY3JlYXRlU291cFVSSSgpOworCisgICAgLy8gVmVyc2lvbnMgb2YgbGlic291cCBwcmlvciB0 byAyLjQyIGhhdmUgYSBzb3VwX3VyaV9uZXcgdGhhdCB3aWxsIGNvbnZlcnQgZW1wdHkgcGFzc3dv cmRzIHRoYXQgYXJlIG5vdAorICAgIC8vIHByZWZpeGVkIGJ5IGEgY29sb24gaW50byBudWxsLiBT b21lIHBhcnRzIG9mIHNvdXAgbGlrZSB0aGUgU291cEF1dGhlbnRpY2F0aW9uTWFuYWdlciB3aWxs IG9ubHkgYmUgYWN0aXZlCisgICAgLy8gd2hlbiBib3RoIHRoZSB1c2VybmFtZSBhbmQgcGFzc3dv cmQgYXJlIG5vbi1udWxsLiBXaGVuIHdlIGhhdmUgY3JlZGVudGlhbHMsIGVtcHR5IHVzZXJuYW1l cyBhbmQgcGFzc3dvcmRzCisgICAgLy8gc2hvdWxkIGJlIGVtcHR5IHN0cmluZ3MgaW5zdGVhZCBv ZiBudWxsLgorICAgIFN0cmluZyB1cmxVc2VyID0gbV91cmwudXNlcigpOworICAgIFN0cmluZyB1 cmxQYXNzID0gbV91cmwucGFzcygpOworICAgIGlmICghdXJsVXNlci5pc0VtcHR5KCkgfHwgIXVy bFBhc3MuaXNFbXB0eSgpKSB7CisgICAgICAgIHNvdXBfdXJpX3NldF91c2VyKHNvdXBVUkkuZ2V0 KCksIHVybFVzZXIudXRmOCgpLmRhdGEoKSk7CisgICAgICAgIHNvdXBfdXJpX3NldF9wYXNzd29y ZChzb3VwVVJJLmdldCgpLCB1cmxQYXNzLnV0ZjgoKS5kYXRhKCkpOworICAgIH0KKworICAgIHJl dHVybiBzb3VwVVJJOwogfQogCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9zb3VwL1VSTFNvdXAuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vc291cC9VUkxTb3Vw LmNwcAppbmRleCBiZThlM2YzLi43MGM3ZDI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9zb3VwL1VSTFNvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3Nv dXAvVVJMU291cC5jcHAKQEAgLTU3LDMwICs1Nyw3IEBAIEdVbmlxdWVQdHI8U291cFVSST4gVVJM OjpjcmVhdGVTb3VwVVJJKCkgY29uc3QKICAgICBpZiAoIWlzVmFsaWQoKSkKICAgICAgICAgcmV0 dXJuIG51bGxwdHI7CiAKLSAgICAvLyBXZWJLaXQgZG9lcyBub3Qgc3VwcG9ydCBmcmFnbWVudCBp ZGVudGlmaWVycyBpbiBkYXRhIFVSTHMsIGJ1dCBzb3VwIGRvZXMuCi0gICAgLy8gQmVmb3JlIHBh c3NpbmcgdGhlIFVSTCB0byBzb3VwLCB3ZSBzaG91bGQgbWFrZSBzdXJlIHRvIHVybGVuY29kZSBh bnkgJyMnCi0gICAgLy8gY2hhcmFjdGVycywgc28gdGhhdCBzb3VwIGRvZXMgbm90IGludGVycHJl dCB0aGVtIGFzIGZyYWdtZW50IGlkZW50aWZpZXJzLgotICAgIC8vIFNlZSBodHRwOi8vd2tidWcu Y29tLzY4MDg5Ci0gICAgaWYgKHByb3RvY29sSXNEYXRhKCkpIHsKLSAgICAgICAgU3RyaW5nIHVy bFN0cmluZyA9IHN0cmluZygpOwotICAgICAgICB1cmxTdHJpbmcucmVwbGFjZSgiIyIsICIlMjMi KTsKLSAgICAgICAgcmV0dXJuIEdVbmlxdWVQdHI8U291cFVSST4oc291cF91cmlfbmV3KHVybFN0 cmluZy51dGY4KCkuZGF0YSgpKSk7Ci0gICAgfQotCi0gICAgR1VuaXF1ZVB0cjxTb3VwVVJJPiBz b3VwVVJJKHNvdXBfdXJpX25ldyhzdHJpbmcoKS51dGY4KCkuZGF0YSgpKSk7Ci0KLSAgICAvLyBW ZXJzaW9ucyBvZiBsaWJzb3VwIHByaW9yIHRvIDIuNDIgaGF2ZSBhIHNvdXBfdXJpX25ldyB0aGF0 IHdpbGwgY29udmVydCBlbXB0eSBwYXNzd29yZHMgdGhhdCBhcmUgbm90Ci0gICAgLy8gcHJlZml4 ZWQgYnkgYSBjb2xvbiBpbnRvIG51bGwuIFNvbWUgcGFydHMgb2Ygc291cCBsaWtlIHRoZSBTb3Vw QXV0aGVudGljYXRpb25NYW5hZ2VyIHdpbGwgb25seSBiZSBhY3RpdmUKLSAgICAvLyB3aGVuIGJv dGggdGhlIHVzZXJuYW1lIGFuZCBwYXNzd29yZCBhcmUgbm9uLW51bGwuIFdoZW4gd2UgaGF2ZSBj cmVkZW50aWFscywgZW1wdHkgdXNlcm5hbWVzIGFuZCBwYXNzd29yZHMKLSAgICAvLyBzaG91bGQg YmUgZW1wdHkgc3RyaW5ncyBpbnN0ZWFkIG9mIG51bGwuCi0gICAgU3RyaW5nIHVybFVzZXIgPSB1 c2VyKCk7Ci0gICAgU3RyaW5nIHVybFBhc3MgPSBwYXNzKCk7Ci0gICAgaWYgKCF1cmxVc2VyLmlz RW1wdHkoKSB8fCAhdXJsUGFzcy5pc0VtcHR5KCkpIHsKLSAgICAgICAgc291cF91cmlfc2V0X3Vz ZXIoc291cFVSSS5nZXQoKSwgdXJsVXNlci51dGY4KCkuZGF0YSgpKTsKLSAgICAgICAgc291cF91 cmlfc2V0X3Bhc3N3b3JkKHNvdXBVUkkuZ2V0KCksIHVybFBhc3MudXRmOCgpLmRhdGEoKSk7Ci0g ICAgfQotCi0gICAgcmV0dXJuIHNvdXBVUkk7CisgICAgcmV0dXJuIEdVbmlxdWVQdHI8U291cFVS ST4oc291cF91cmlfbmV3KHN0cmluZygpLnV0ZjgoKS5kYXRhKCkpKTsKIH0KIAogfSAvLyBuYW1l c3BhY2UgV2ViQ29yZQo=