127831 2014-01-28 23:36:44 -0800 Rename notifyRendererOfSelectionChange 2014-01-29 10:14:50 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 127834 1 rniwa rniwa barraclough darin enrica kling koivisto sam oldest_to_newest 973311 0 rniwa 2014-01-28 23:36:44 -0800 notifyRendererOfSelectionChange doesn't notify renderer EVER. The name comes from the era where shadow DOM was a render tree concept. The sole purpose of this function is to update text form controls' selection cache so it should be named so. 973316 1 222556 rniwa 2014-01-29 00:25:53 -0800 Created attachment 222556 Cleanup 973323 2 rniwa 2014-01-29 01:27:48 -0800 Committed r163012: <http://trac.webkit.org/changeset/163012> 973399 3 222556 darin 2014-01-29 10:14:50 -0800 Comment on attachment 222556 Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=222556&action=review > Source/WebCore/ChangeLog:8 > + Renamed notifyRendererOfSelectionChange to updateSelectionCachesIfSelectionIsInsideTextFormControl. I think that the name updateFormControlSelectionCaches would be better. It’s true that there is nothing to update if the selection is not inside a text form control, but I don’t think that needs to be stated in the function name. 222556 2014-01-29 00:25:53 -0800 2014-01-29 10:14:50 -0800 Cleanup bug-127831-20140129002552.patch text/plain 6305 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MzAxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE0LTAxLTI5ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbmFtZSBub3RpZnlSZW5kZXJl ck9mU2VsZWN0aW9uQ2hhbmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjc4MzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSZW5hbWVkIG5vdGlmeVJlbmRlcmVyT2ZTZWxlY3Rpb25DaGFuZ2UgdG8gdXBk YXRlU2VsZWN0aW9uQ2FjaGVzSWZTZWxlY3Rpb25Jc0luc2lkZVRleHRGb3JtQ29udHJvbC4KKwor ICAgICAgICAqIFdlYkNvcmUub3JkZXI6IFJlbW92ZWQgdGhlIGV4cG9ydGVkIHN5bWJvbCBuYW1l IGFzIGl0J3Mgbm90IHVzZWQgaW4gV2ViS2l0IG9yIFdlYktpdDIgY29kZS4KKyAgICAgICAgKiBl ZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lU2VsZWN0 aW9uOjpzZXRTZWxlY3Rpb24pOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVTZWxlY3Rpb246OnNl bGVjdEFsbCk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVNlbGVjdGlvbjo6dXBkYXRlU2VsZWN0 aW9uQ2FjaGVzSWZTZWxlY3Rpb25Jc0luc2lkZVRleHRGb3JtQ29udHJvbCk6IERvbid0IHVwZGF0 ZSB0aGUgc3R5bGUgc2luY2UgdGhlIGV4aXN0ZW5jZQorICAgICAgICBvZiB0ZXh0IGZvcm0gY29u dHJvbCdzIHNoYWRvdyBET00gbm8gbG9uZ2VyIGRlcGVuZHMgb24gcmVuZGVyZXIuCisgICAgICAg ICogZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5oOgorICAgICAgICAqIGh0bWwvSFRNTFRleHRGb3Jt Q29udHJvbEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRleHRGb3JtQ29udHJv bEVsZW1lbnQ6OnNlbGVjdGlvbkNoYW5nZWQpOiBEb24ndCBjaGVjayByZW5kZXJlcigpIGZvciB0 aGUgc2FtZSByZWFzb24uCisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpoYW5kbGVNb3VzZVJlbGVhc2VFdmVudCk6CisKIDIw MTQtMDEtMjggIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW01h Y10gSGFuZGxlIE5TVVJMQXV0aGVudGljYXRpb25NZXRob2RTZXJ2ZXJUcnVzdCBjaGFsbGVuZ2Vz IGZyb20gLXJlc291cmNlTG9hZGVyOnNob3VsZFdhaXRGb3JSZXNwb25zZVRvQXV0aGVudGljYXRp b25DaGFsbGVuZ2U6CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9XZWJDb3JlLm9yZGVyCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUub3JkZXIJKHJldmlzaW9uIDE2MzAwNikKKysr IFNvdXJjZS9XZWJDb3JlL1dlYkNvcmUub3JkZXIJKHdvcmtpbmcgY29weSkKQEAgLTMyMzAsNyAr MzIzMCw2IEBAIF9fWk43V2ViQ29yZTE0RnJhbWVTZWxlY3Rpb24yMXByZXBhcmVGb3IKIF9fWk43 V2ViQ29yZTE0RnJhbWVTZWxlY3Rpb24xMnNldFNlbGVjdGlvbkVSS05TXzE2VmlzaWJsZVNlbGVj dGlvbkVqTlMwXzE5Q3Vyc29yQWxpZ25PblNjcm9sbEVOU18xNVRleHRHcmFudWxhcml0eUUKIF9f Wk43V2ViQ29yZTEzVHlwaW5nQ29tbWFuZDExY2xvc2VUeXBpbmdFUE5TXzVGcmFtZUUKIF9fWk43 V2ViQ29yZWVxRVJLTlNfMTZWaXNpYmxlU2VsZWN0aW9uRVMyXwotX19aTjdXZWJDb3JlMTRGcmFt ZVNlbGVjdGlvbjMxbm90aWZ5UmVuZGVyZXJPZlNlbGVjdGlvbkNoYW5nZUVOU18xNEVVc2VyVHJp Z2dlcmVkRQogX19aTjdXZWJDb3JlMjRlbmNsb3NpbmdUZXh0Rm9ybUNvbnRyb2xFUktOU184UG9z aXRpb25FCiBfX1pOSzdXZWJDb3JlOFBvc2l0aW9uMTNjb250YWluZXJOb2RlRXYKIF9fWk43V2Vi Q29yZTlGcmFtZVZpZXc1Y2xlYXJFdgpJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFt ZVNlbGVjdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFt ZVNlbGVjdGlvbi5jcHAJKHJldmlzaW9uIDE2MzAwNikKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRp bmcvRnJhbWVTZWxlY3Rpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOTUsNyArMjk1LDcgQEAg dm9pZCBGcmFtZVNlbGVjdGlvbjo6c2V0U2VsZWN0aW9uKGNvbnN0IAogCiAgICAgaWYgKG1fc2Vs ZWN0aW9uID09IHMpIHsKICAgICAgICAgLy8gRXZlbiBpZiBzZWxlY3Rpb24gd2FzIG5vdCBjaGFu Z2VkLCBzZWxlY3Rpb24gb2Zmc2V0cyBtYXkgaGF2ZSBiZWVuIGNoYW5nZWQuCi0gICAgICAgIG5v dGlmeVJlbmRlcmVyT2ZTZWxlY3Rpb25DaGFuZ2UodXNlclRyaWdnZXJlZCk7CisgICAgICAgIHVw ZGF0ZVNlbGVjdGlvbkNhY2hlc0lmU2VsZWN0aW9uSXNJbnNpZGVUZXh0Rm9ybUNvbnRyb2wodXNl clRyaWdnZXJlZCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKQEAgLTMyMCw3ICszMjAsNyBA QCB2b2lkIEZyYW1lU2VsZWN0aW9uOjpzZXRTZWxlY3Rpb24oY29uc3QgCiAgICAgLy8gSXQgd2ls bCBiZSByZXN0b3JlZCBieSB0aGUgdmVydGljYWwgYXJyb3cgbmF2aWdhdGlvbiBjb2RlIGlmIG5l Y2Vzc2FyeS4KICAgICBtX3hQb3NGb3JWZXJ0aWNhbEFycm93TmF2aWdhdGlvbiA9IE5vWFBvc0Zv clZlcnRpY2FsQXJyb3dOYXZpZ2F0aW9uKCk7CiAgICAgc2VsZWN0RnJhbWVFbGVtZW50SW5QYXJl bnRJZkZ1bGx5U2VsZWN0ZWQoKTsKLSAgICBub3RpZnlSZW5kZXJlck9mU2VsZWN0aW9uQ2hhbmdl KHVzZXJUcmlnZ2VyZWQpOworICAgIHVwZGF0ZVNlbGVjdGlvbkNhY2hlc0lmU2VsZWN0aW9uSXNJ bnNpZGVUZXh0Rm9ybUNvbnRyb2wodXNlclRyaWdnZXJlZCk7CiAgICAgbV9mcmFtZS0+ZWRpdG9y KCkucmVzcG9uZFRvQ2hhbmdlZFNlbGVjdGlvbihvbGRTZWxlY3Rpb24sIG9wdGlvbnMpOwogICAg IGlmICh1c2VyVHJpZ2dlcmVkID09IFVzZXJUcmlnZ2VyZWQpIHsKICAgICAgICAgU2Nyb2xsQWxp Z25tZW50IGFsaWdubWVudDsKQEAgLTE3MDIsNyArMTcwMiw3IEBAIHZvaWQgRnJhbWVTZWxlY3Rp b246OnNlbGVjdEFsbCgpCiAgICAgICAgIHNldFNlbGVjdGlvbihuZXdTZWxlY3Rpb24pOwogCiAg ICAgc2VsZWN0RnJhbWVFbGVtZW50SW5QYXJlbnRJZkZ1bGx5U2VsZWN0ZWQoKTsKLSAgICBub3Rp ZnlSZW5kZXJlck9mU2VsZWN0aW9uQ2hhbmdlKFVzZXJUcmlnZ2VyZWQpOworICAgIHVwZGF0ZVNl bGVjdGlvbkNhY2hlc0lmU2VsZWN0aW9uSXNJbnNpZGVUZXh0Rm9ybUNvbnRyb2woVXNlclRyaWdn ZXJlZCk7CiB9CiAKIGJvb2wgRnJhbWVTZWxlY3Rpb246OnNldFNlbGVjdGVkUmFuZ2UoUmFuZ2Uq IHJhbmdlLCBFQWZmaW5pdHkgYWZmaW5pdHksIGJvb2wgY2xvc2VUeXBpbmcpCkBAIC0xOTEwLDEw ICsxOTEwLDggQEAgdm9pZCBGcmFtZVNlbGVjdGlvbjo6Y2FyZXRCbGlua1RpbWVyRmlyZQogI2Vu ZGlmCiB9CiAKLXZvaWQgRnJhbWVTZWxlY3Rpb246Om5vdGlmeVJlbmRlcmVyT2ZTZWxlY3Rpb25D aGFuZ2UoRVVzZXJUcmlnZ2VyZWQgdXNlclRyaWdnZXJlZCkKK3ZvaWQgRnJhbWVTZWxlY3Rpb246 OnVwZGF0ZVNlbGVjdGlvbkNhY2hlc0lmU2VsZWN0aW9uSXNJbnNpZGVUZXh0Rm9ybUNvbnRyb2wo RVVzZXJUcmlnZ2VyZWQgdXNlclRyaWdnZXJlZCkKIHsKLSAgICBtX2ZyYW1lLT5kb2N1bWVudCgp LT51cGRhdGVTdHlsZUlmTmVlZGVkKCk7Ci0KICAgICBpZiAoSFRNTFRleHRGb3JtQ29udHJvbEVs ZW1lbnQqIHRleHRDb250cm9sID0gZW5jbG9zaW5nVGV4dEZvcm1Db250cm9sKHN0YXJ0KCkpKQog ICAgICAgICB0ZXh0Q29udHJvbC0+c2VsZWN0aW9uQ2hhbmdlZCh1c2VyVHJpZ2dlcmVkID09IFVz ZXJUcmlnZ2VyZWQpOwogfQpJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVj dGlvbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rp b24uaAkocmV2aXNpb24gMTYzMDA2KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNl bGVjdGlvbi5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNzMsNyArMjczLDcgQEAgcHVibGljOgogICAg IGJvb2wgc2hvdWxkRGVsZXRlU2VsZWN0aW9uKGNvbnN0IFZpc2libGVTZWxlY3Rpb24mKSBjb25z dDsKICAgICBlbnVtIEVuZFBvaW50c0FkanVzdG1lbnRNb2RlIHsgQWRqdXN0RW5kcG9pbnRzQXRC aWRpQm91bmRhcnksIERvTm90QWRqc3V0RW5kcG9pbnRzIH07CiAgICAgdm9pZCBzZXROb25EaXJl Y3Rpb25hbFNlbGVjdGlvbklmTmVlZGVkKGNvbnN0IFZpc2libGVTZWxlY3Rpb24mLCBUZXh0R3Jh bnVsYXJpdHksIEVuZFBvaW50c0FkanVzdG1lbnRNb2RlID0gRG9Ob3RBZGpzdXRFbmRwb2ludHMp OwotICAgIHZvaWQgbm90aWZ5UmVuZGVyZXJPZlNlbGVjdGlvbkNoYW5nZShFVXNlclRyaWdnZXJl ZCk7CisgICAgdm9pZCB1cGRhdGVTZWxlY3Rpb25DYWNoZXNJZlNlbGVjdGlvbklzSW5zaWRlVGV4 dEZvcm1Db250cm9sKEVVc2VyVHJpZ2dlcmVkKTsKIAogICAgIHZvaWQgcGFpbnREcmFnQ2FyZXQo R3JhcGhpY3NDb250ZXh0KiwgY29uc3QgTGF5b3V0UG9pbnQmLCBjb25zdCBMYXlvdXRSZWN0JiBj bGlwUmVjdCkgY29uc3Q7CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFRleHRGb3Jt Q29udHJvbEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TFRleHRGb3JtQ29udHJvbEVsZW1lbnQuY3BwCShyZXZpc2lvbiAxNjMwMDYpCisrKyBTb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNDc3LDkgKzQ3NywxMCBAQCB2b2lkIEhUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50Ojpy ZXN0b3JlCiAKIHZvaWQgSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OnNlbGVjdGlvbkNoYW5n ZWQoYm9vbCB1c2VyVHJpZ2dlcmVkKQogewotICAgIGlmICghcmVuZGVyZXIoKSB8fCAhaXNUZXh0 Rm9ybUNvbnRyb2woKSkKKyAgICBpZiAoIWlzVGV4dEZvcm1Db250cm9sKCkpCiAgICAgICAgIHJl dHVybjsKIAorICAgIC8vIEZJWE1FOiBEb24ndCByZS1jb21wdXRlIHNlbGVjdGlvbiBzdGFydCBh bmQgZW5kIGlmIHRoaXMgZnVuY3Rpb24gd2FzIGNhbGxlZCBpbnNpZGUgc2V0U2VsZWN0aW9uUmFu Z2UuCiAgICAgLy8gc2VsZWN0aW9uU3RhcnQoKSBvciBzZWxlY3Rpb25FbmQoKSB3aWxsIHJldHVy biBjYWNoZWQgc2VsZWN0aW9uIHdoZW4gdGhpcyBub2RlIGRvZXNuJ3QgaGF2ZSBmb2N1cwogICAg IGNhY2hlU2VsZWN0aW9uKGNvbXB1dGVTZWxlY3Rpb25TdGFydCgpLCBjb21wdXRlU2VsZWN0aW9u RW5kKCksIGNvbXB1dGVTZWxlY3Rpb25EaXJlY3Rpb24oKSk7CiAKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9w YWdlL0V2ZW50SGFuZGxlci5jcHAJKHJldmlzaW9uIDE2MzAwNikKKysrIFNvdXJjZS9XZWJDb3Jl L3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTg0LDcgKzk4NCw3IEBA IGJvb2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVNb3VzZVJlbGVhc2VFdmUKICAgICAgICAgaGFuZGxl ZCA9IHRydWU7CiAgICAgfQogCi0gICAgbV9mcmFtZS5zZWxlY3Rpb24oKS5ub3RpZnlSZW5kZXJl ck9mU2VsZWN0aW9uQ2hhbmdlKFVzZXJUcmlnZ2VyZWQpOworICAgIG1fZnJhbWUuc2VsZWN0aW9u KCkudXBkYXRlU2VsZWN0aW9uQ2FjaGVzSWZTZWxlY3Rpb25Jc0luc2lkZVRleHRGb3JtQ29udHJv bChVc2VyVHJpZ2dlcmVkKTsKIAogICAgIG1fZnJhbWUuc2VsZWN0aW9uKCkuc2VsZWN0RnJhbWVF bGVtZW50SW5QYXJlbnRJZkZ1bGx5U2VsZWN0ZWQoKTsKIAo=