127824 2014-01-28 20:07:29 -0800 WKRemoteObjectCoder should support more argument types 2014-01-28 21:09:34 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ian webkit-unassigned andersca commit-queue oldest_to_newest 973269 0 ian 2014-01-28 20:07:29 -0800 BOOL becomes char on some platforms, so we need to support at least 'c'. 973270 1 222548 ian 2014-01-28 20:09:32 -0800 Created attachment 222548 proposed patch 973281 2 222548 andersca 2014-01-28 20:24:54 -0800 Comment on attachment 222548 proposed patch What about decoding? 973282 3 222551 ian 2014-01-28 20:31:33 -0800 Created attachment 222551 revised patch 973284 4 ian 2014-01-28 20:32:55 -0800 It's strange that things seemed to work without throwing exceptions. I updated the decoding method too. 973291 5 222551 commit-queue 2014-01-28 21:09:33 -0800 Comment on attachment 222551 revised patch Clearing flags on attachment: 222551 Committed r163000: <http://trac.webkit.org/changeset/163000> 973292 6 commit-queue 2014-01-28 21:09:34 -0800 All reviewed patches have been landed. Closing bug. 222548 2014-01-28 20:09:32 -0800 2014-01-28 20:31:33 -0800 proposed patch 127824.patch text/plain 1298 ian ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiNDRiNzU2Li40ODQ1OTlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTQtMDEtMjggIElhbiBIZW5kZXJzb24gIDxpYW5oQGFwcGxlLmNvbT4KKworICAgICAg ICBXS1JlbW90ZU9iamVjdENvZGVyIHNob3VsZCBzdXBwb3J0IG1vcmUgYXJndW1lbnQgdHlwZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzgyNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVk L0FQSS9Db2NvYS9XS1JlbW90ZU9iamVjdENvZGVyLm1tOgorICAgICAgICAoZW5jb2RlSW52b2Nh dGlvbik6IFN1cHBvcnQgZW5jb2RpbmcgY2hhciB2YWx1ZXMuCisKIDIwMTQtMDEtMjggIFJ5dWFu IENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVp bGQgZml4IG9uIHRoZSBjbWFrZSBiYXNlZCBwb3J0IGFmdGVyIHIxNjI5ODEKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmplY3RDb2Rlci5tbSBi L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmplY3RDb2Rlci5tbQpp bmRleCA2YmZmNGM3Li45NDI5ZTQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQv QVBJL0NvY29hL1dLUmVtb3RlT2JqZWN0Q29kZXIubW0KKysrIGIvU291cmNlL1dlYktpdDIvU2hh cmVkL0FQSS9Db2NvYS9XS1JlbW90ZU9iamVjdENvZGVyLm1tCkBAIC0xNDYsNiArMTQ2LDE1IEBA IHN0YXRpYyB2b2lkIGVuY29kZUludm9jYXRpb24oV0tSZW1vdGVPYmplY3RFbmNvZGVyICplbmNv ZGVyLCBOU0ludm9jYXRpb24gKmludm9jCiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQog CisgICAgICAgIC8vIGNoYXIKKyAgICAgICAgY2FzZSAnYyc6IHsKKyAgICAgICAgICAgIGNoYXIg dmFsdWU7CisgICAgICAgICAgICBbaW52b2NhdGlvbiBnZXRBcmd1bWVudDomdmFsdWUgYXRJbmRl eDppXTsKKworICAgICAgICAgICAgZW5jb2RlVG9PYmplY3RTdHJlYW0oZW5jb2RlciwgQCh2YWx1 ZSkpOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KKwogICAgICAgICAvLyBib29sCiAg ICAgICAgIGNhc2UgJ0InOiB7CiAgICAgICAgICAgICBCT09MIHZhbHVlOwo= 222551 2014-01-28 20:31:33 -0800 2014-01-28 21:09:32 -0800 revised patch 127824-2.patch text/plain 1900 ian ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiNDRiNzU2Li5mOGE5YjBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTQtMDEtMjggIElhbiBIZW5kZXJzb24gIDxpYW5oQGFwcGxlLmNvbT4KKworICAgICAg ICBXS1JlbW90ZU9iamVjdENvZGVyIHNob3VsZCBzdXBwb3J0IG1vcmUgYXJndW1lbnQgdHlwZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzgyNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVk L0FQSS9Db2NvYS9XS1JlbW90ZU9iamVjdENvZGVyLm1tOgorICAgICAgICAoZW5jb2RlSW52b2Nh dGlvbik6IFN1cHBvcnQgZW5jb2RpbmcgY2hhciB2YWx1ZXMuCisgICAgICAgIChkZWNvZGVJbnZv Y2F0aW9uQXJndW1lbnRzKTogU3VwcG9ydCBkZWNvZGluZyBjaGFyIHZhbHVlcy4KKwogMjAxNC0w MS0yOCAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZCBidWlsZCBmaXggb24gdGhlIGNtYWtlIGJhc2VkIHBvcnQgYWZ0ZXIgcjE2Mjk4MQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9Db2NvYS9XS1JlbW90ZU9iamVj dENvZGVyLm1tIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9Db2NvYS9XS1JlbW90ZU9iamVj dENvZGVyLm1tCmluZGV4IDZiZmY0YzcuLjk1NzI1ZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1NoYXJlZC9BUEkvQ29jb2EvV0tSZW1vdGVPYmplY3RDb2Rlci5tbQorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvQVBJL0NvY29hL1dLUmVtb3RlT2JqZWN0Q29kZXIubW0KQEAgLTE0Niw2 ICsxNDYsMTUgQEAgc3RhdGljIHZvaWQgZW5jb2RlSW52b2NhdGlvbihXS1JlbW90ZU9iamVjdEVu Y29kZXIgKmVuY29kZXIsIE5TSW52b2NhdGlvbiAqaW52b2MKICAgICAgICAgICAgIGJyZWFrOwog ICAgICAgICB9CiAKKyAgICAgICAgLy8gY2hhcgorICAgICAgICBjYXNlICdjJzogeworICAgICAg ICAgICAgY2hhciB2YWx1ZTsKKyAgICAgICAgICAgIFtpbnZvY2F0aW9uIGdldEFyZ3VtZW50OiZ2 YWx1ZSBhdEluZGV4OmldOworCisgICAgICAgICAgICBlbmNvZGVUb09iamVjdFN0cmVhbShlbmNv ZGVyLCBAKHZhbHVlKSk7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgfQorCiAgICAgICAg IC8vIGJvb2wKICAgICAgICAgY2FzZSAnQic6IHsKICAgICAgICAgICAgIEJPT0wgdmFsdWU7CkBA IC00MDMsNiArNDEyLDEzIEBAIHN0YXRpYyB2b2lkIGRlY29kZUludm9jYXRpb25Bcmd1bWVudHMo V0tSZW1vdGVPYmplY3REZWNvZGVyICpkZWNvZGVyLCBOU0ludm9jYXRpCiAgICAgICAgICAgICBi cmVhazsKICAgICAgICAgfQogCisgICAgICAgIC8vIGNoYXIKKyAgICAgICAgY2FzZSAnYyc6IHsK KyAgICAgICAgICAgIGNoYXIgdmFsdWUgPSBbZGVjb2RlT2JqZWN0RnJvbU9iamVjdFN0cmVhbShk ZWNvZGVyLCBbTlNTZXQgc2V0V2l0aE9iamVjdDpbTlNOdW1iZXIgY2xhc3NdXSkgY2hhclZhbHVl XTsKKyAgICAgICAgICAgIFtpbnZvY2F0aW9uIHNldEFyZ3VtZW50OiZ2YWx1ZSBhdEluZGV4Omld OworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KKwogICAgICAgICAvLyBib29sCiAgICAg ICAgIGNhc2UgJ0InOiB7CiAgICAgICAgICAgICBib29sIHZhbHVlID0gW2RlY29kZU9iamVjdEZy b21PYmplY3RTdHJlYW0oZGVjb2RlciwgW05TU2V0IHNldFdpdGhPYmplY3Q6W05TTnVtYmVyIGNs YXNzXV0pIGJvb2xWYWx1ZV07Cg==